[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kadircet added a comment. thanks, LG in general, just a couple polishing touches Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:146 + // + // Returns true if the insertion into IDs took place. + bool insert(llvm::DenseSet , FileID ID, const SourceManager ,

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389118. linjamaki added a comment. Retry push changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2341-2342 + +Default propagations defined by `GenericTaintChecker`: +``atoi``, ``atol``, ``atoll``, ``fgetc``, ``fgetln``, ``fgets``, ``fscanf``, ``sscanf``, ``getc``, ``getc_unlocked``, ``getdelim``,

[clang] 1cb3cfd - [clang-format] [NFC] build clang-format with -Wall

Author: mydeveloperday Date: 2021-11-23T10:43:27Z New Revision: 1cb3cfd932a0f26e5bfc5d944f63239242fa8ec3 URL: https://github.com/llvm/llvm-project/commit/1cb3cfd932a0f26e5bfc5d944f63239242fa8ec3 DIFF: https://github.com/llvm/llvm-project/commit/1cb3cfd932a0f26e5bfc5d944f63239242fa8ec3.diff

[PATCH] D113844: [clang-format] [NFC] build clang-format with -Wall

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cb3cfd932a0: [clang-format] [NFC] build clang-format with -Wall (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113844/new/

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389131. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files:

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. The following 2 commits caused files in clang-format to no longer be

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp updated this revision to Diff 389157. carlosgalvezp added a comment. Fix numbering of variables. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/ https://reviews.llvm.org/D114427 Files: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp

[PATCH] D114082: [WIP] Normalize String Attributes

serge-sans-paille added a comment. This diff is indeed very large. I reworked it in https://reviews.llvm.org/D114394 to capture the essence of it, on which we could then rebase this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114082/new/

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik created this revision. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC has a `__builtin_bswap128` which is used for `std::byteswap()`. Clang should also add this builtin. Repository: rG LLVM Github Monorepo

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 389101. void added a comment. WIP: Move register selection to a platform-generic place. Not ready for review just yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

sammccall added a comment. The ReferencedFiles is designed to make add() as cheap as possible, and do any per-file logic after folding the fileIDs together. This keeps that loop tighter and also isolates the complexity of the symbol vs file logic. Any reason we can't do that here? Repository:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 389112. linjamaki added a comment. Combine options with append(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki marked 4 inline comments as done. linjamaki added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder marked 13 inline comments as done. tbaeder added inline comments. Comment at: clang/test/Driver/plugin-driver-args.cpp:11 +// Dashes cannot be part of the plugin name here +// RUN: %clang -fplugin=%llvmshlibdir/CallSuperAttr%pluginext

[PATCH] D114424: [Diagnostic] Clarify -Winfinite-recursion message

hkmatsumoto created this revision. hkmatsumoto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114424 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 updated this revision to Diff 389134. gamesh411 added a comment. fix indentation warning make inline code formatting look better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113251/new/ https://reviews.llvm.org/D113251 Files:

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The google-readability-casting check is meant to be on par with cpplint's

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:252 } - return std::move(Result.Files); + // Post-filtering attributes the locations from non self-contained headers to + // their parents while the information about respective

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

balazske updated this revision to Diff 389111. balazske added a comment. Applied lint reformattings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.llvm.org/D113118 Files: clang/lib/AST/ASTStructuralEquivalence.cpp

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

Anastasia added a comment. Could you please clarify the interface to SPIRV-LLVM-Translator tool, specifically: - Does clang lookup the path to the translator or assume any default path? - Is there any diagnostic provided if the translator not installed/found? - How does clang synchronize with

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114256/new/ https://reviews.llvm.org/D114256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 389114. linjamaki marked 2 inline comments as done. linjamaki added a comment. Update a driver test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110622/new/ https://reviews.llvm.org/D110622 Files:

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider created this revision. glider added reviewers: melver, vitalybuka. glider requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For ASan this will effectively serve as a synonym for __attribute__((no_sanitize("address"))) Repository:

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev added a comment. In D114370#3148143 , @sammccall wrote: > The ReferencedFiles is designed to make add() as cheap as possible, and do > any per-file logic after folding the fileIDs together. > This keeps that loop tighter and also isolates the

[PATCH] D114394: Compile-time computation of string attribute hashes

JonChesterfield added inline comments. Comment at: llvm/include/llvm/IR/Attributes.h:79 + bool operator<(AttributeKey const ) const { +return strcmp(value_, other.value_) < 0; + } Could order by size first here, then strncmp on equal sizes Repository:

[PATCH] D113251: [analyzer][doc] Add user documenation for taint analysis

gamesh411 updated this revision to Diff 389117. gamesh411 marked 15 inline comments as done. gamesh411 added a comment. tidy up based on comments from whispy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113251/new/

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder updated this revision to Diff 389121. tbaeder marked an inline comment as done. tbaeder added a comment. Addressed review comments and fixed the tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 Files:

[clang] e7cb328 - [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

Author: mydeveloperday Date: 2021-11-23T10:36:06Z New Revision: e7cb3283c8032d89e81b3958b0fd73064ed5e839 URL: https://github.com/llvm/llvm-project/commit/e7cb3283c8032d89e81b3958b0fd73064ed5e839 DIFF: https://github.com/llvm/llvm-project/commit/e7cb3283c8032d89e81b3958b0fd73064ed5e839.diff

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7cb3283c803: [clang-format] [PR52527] can join * with /* to form an outside of comment error… (authored by MyDeveloperDay). Changed prior to commit:

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp updated this revision to Diff 389159. carlosgalvezp added a comment. Fix numbering in variables. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/ https://reviews.llvm.org/D114427 Files: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114408: Fold a lot of ffixed_x if judgments

jrtc27 requested changes to this revision. jrtc27 added a comment. This revision now requires changes to proceed. This has clearly not been tested whatsoever, it’s totally broken, the preprocessor does not work like that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113917: Add infrastructure to support matcher names.

hokein added a comment. The approach looks fine in general, just some nits when reading through the patch. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:152 + } +MAKE_MATCHER_NAME_FROM_TYPE(TemplateArgument)

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay updated this revision to Diff 389139. MyDeveloperDay added a comment. Fix infinite loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114151/new/ https://reviews.llvm.org/D114151 Files: clang/docs/ReleaseNotes.rst clang/lib/Format/FormatToken.h

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389166. sgatev added a comment. Remove unnecessary constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files:

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong updated this revision to Diff 389198. martong marked 6 inline comments as done. martong added a comment. - Return explicitly with UndefinedVal - Unify test cases (return 0 -> return) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Thanks, looks much better now. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir there is no `fmodule-format=obj` here, why are we failing here?

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

martong added a comment. What happens if this checker runs on a forward declared class? struct Foo; I'd expect the pack/alignment info is missing also in that case. Comment at: clang-tools-extra/clang-tidy/altera/StructPackAlignCheck.cpp:54 + // Ignore invalid decls to

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. I am not sure why you are pinging this review often?! Maybe chat with people who gave you feedback before directly?! Myself I wasted so much time because of D107799 that I am very reluctant to enable

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 389183. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files:

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:262 + ID != SM.getMainFileID() && FE && + !isSelfContainedHeader(PP, ID, FE);) { + ID = SM.getFileID(SM.getIncludeLoc(ID)); kbobyrev wrote: > sammccall

[clang] e13246a - [HIP] Add HIP scope atomic operations

Author: Yaxun (Sam) Liu Date: 2021-11-23T10:13:37-05:00 New Revision: e13246a2ec3dfc13838d43099ca9111c780d2c5e URL: https://github.com/llvm/llvm-project/commit/e13246a2ec3dfc13838d43099ca9111c780d2c5e DIFF:

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added a comment. In D103317#3127318 , @steakhal wrote: > To me at least, the patch looks good. > Please post some comparative measurements to demonstrate it won't introduce > runtime regression. Sure! F20586670: stats.html

[clang] aa9b90c - Fix warning due to default switch label

Author: Yaxun (Sam) Liu Date: 2021-11-23T10:52:51-05:00 New Revision: aa9b90ca441d09969cab158f1db6341de3c1 URL: https://github.com/llvm/llvm-project/commit/aa9b90ca441d09969cab158f1db6341de3c1 DIFF:

[PATCH] D113118: [clang][AST] Check context of record in structural equivalence.

martong accepted this revision. martong added a comment. Still LGTM! Let's land it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113118/new/ https://reviews.llvm.org/D113118 ___ cfe-commits mailing

[PATCH] D114446: [clang] Fix wrong -Wunused-local-typedef warning if use is a dependent qialified identifier

krisb created this revision. krisb added reviewers: thakis, rtrieu, rsmith. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attempt to fix Tom Smeding's example from https://bugs.llvm.org/show_bug.cgi?id=24883. Given the case like

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Actually, it breaks on all Debian. Could you please revert it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list

[clang] fd759d4 - Revert "The _Float16 type is supported on x86 systems with SSE2 enabled."

Author: Zahira Ammarguellat Date: 2021-11-23T08:00:57-05:00 New Revision: fd759d42c9f84d16efa99a59620cbb3e6836fed4 URL: https://github.com/llvm/llvm-project/commit/fd759d42c9f84d16efa99a59620cbb3e6836fed4 DIFF:

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille updated this revision to Diff 389187. serge-sans-paille added a comment. Remove static Dict and replace it by a dict attached to LLVMContext. Some early benchmarks, on the SQLite amalgamation, through ` valgrind --tool=callgrind ./bin/clang -c -o/dev/null sqlite3.c`

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

flx accepted this revision. flx added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:228-232 +void PositiveOperatorCallConstValueParam(const Container* C)

[PATCH] D113925: [HIP] Add HIP scope atomic operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe13246a2ec3d: [HIP] Add HIP scope atomic operations (authored by yaxunl). Changed prior to commit:

[clang] 12887a2 - [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

Author: Gabor Marton Date: 2021-11-23T16:38:01+01:00 New Revision: 12887a202404471ddf77f9fae658700573cbebe8 URL: https://github.com/llvm/llvm-project/commit/12887a202404471ddf77f9fae658700573cbebe8 DIFF: https://github.com/llvm/llvm-project/commit/12887a202404471ddf77f9fae658700573cbebe8.diff

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12887a202404: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN (authored by martong). Repository: rG LLVM Github Monorepo

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added a comment. In D103317#3148868 , @martong wrote: > In D103317#3127318 , @steakhal > wrote: > >> To me at least, the patch looks good. >> Please post some comparative measurements to demonstrate it

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Full log: https://llvm-jenkins.debian.net/view/Debian%20sid/job/llvm-toolchain-binaries/architecture=amd64,distribution=unstable,label=amd64/104/consoleFull CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet updated this revision to Diff 389184. courbet added a comment. Canonicalize more types and add more container tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114249/new/ https://reviews.llvm.org/D114249 Files:

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen created this revision. steffenlarsen added reviewers: erichkeane, aaron.ballman, Tyker, Naghasan. Herald added a subscriber: jdoerfert. steffenlarsen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These changes make the

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet updated this revision to Diff 389197. courbet added a comment. add container exclusion tests for operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114249/new/ https://reviews.llvm.org/D114249 Files:

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1144 + : (SVal)SVB.makeIntVal(*Const); + return SVal(); +} steakhal wrote: > Let's be explicit about it. Good

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added inline comments. Comment at: clang/test/Analysis/svalbuilder-simplify-compound-svals.cpp:32 + clang_analyzer_eval(x + y * z == 0); // expected-warning{{TRUE}} + clang_analyzer_eval(y * z == 0); // expected-warning{{TRUE}} + clang_analyzer_eval(x == 0);

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

sylvestre.ledru added a comment. Maybe add it to the release notes too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 389189. sgatev marked an inline comment as done. sgatev added a comment. Add a note about asserting the requirements of the CFG object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389196. Jake-Egan added a comment. Thanks for the review. I updated the patch to use lit.cfg.py to filter tests that use obj options. For tests that don't use the option or has an individual folder, I changed them to UNSUPPORTED instead of XFAIL.

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1105 - // FIXME: Add support for SymExprs. return nullptr; martong wrote: > steakhal wrote: > > Where did you address this FIXME? > I didn't, but this `FIXME`

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. As mentioned in https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b#commitcomment-60741407 This change is breaking build of compiler-rt on Ubuntu bionic and others on amd64:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong marked 2 inline comments as done. martong added a comment. I'm attaching the coverage of the new test file for the related change: 375 : // Constraints may have changed since the creation of a bound SVal. Check if 376 : // the values can be simplified

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong updated this revision to Diff 389186. martong marked an inline comment as done. martong added a comment. - Add new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113753/new/ https://reviews.llvm.org/D113753 Files:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113753/new/ https://reviews.llvm.org/D113753

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1105 - // FIXME: Add support for SymExprs. return nullptr; steakhal wrote: > Where did you address this FIXME? I

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

zahiraam added a comment. In D114099#3148631 , @sylvestre.ledru wrote: > Actually, it breaks on all Debian. > Could you please revert it? Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. In D110216#3139129 , @lkail wrote: > Hi we found regression in our internal tests. It compiles with clang-13.0.0 > https://godbolt.org/z/3abGrcf7o and gcc https://godbolt.org/z/K9oj3Grs1, but > fails with clang-trunk

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov added a comment. Fix pushed to https://reviews.llvm.org/D114207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 ___ cfe-commits mailing list

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:262 + ID != SM.getMainFileID() && FE && + !isSelfContainedHeader(PP, ID, FE);) { + ID = SM.getFileID(SM.getIncludeLoc(ID)); sammccall wrote: > it seems

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

kamaub added a comment. Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots with this changeset https://lab.llvm.org/buildbot/#/builders/93/builds/6031 https://lab.llvm.org/buildbot/#/builders/100/builds/10836 https://lab.llvm.org/buildbot/#/builders/52/builds/12719

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added a comment. In D113451#3148815 , @kamaub wrote: > Test case `clang/test/CodeGen/ppc-mm-malloc.c` fails on powerpc BE buildbots > with this changeset > https://lab.llvm.org/buildbot/#/builders/93/builds/6031 >

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

martong added a comment. I'm attaching the coverage of the new test file for the related change: 375 : // Constraints may have changed since the creation of a bound SVal. Check if 376 : // the values can be simplified based on those new constraints. 377

[PATCH] D114418: [clang][ASTImporter] Update lookup table correctly at deduction guides.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:6081 + // FunctionTemplateDecl objects are created, but in different order. In this + // way DeclContext of these template parameters may change relative to the + // "from" context. Because these

[clang] b472bd8 - [NFC] Let Microsoft mangler accept GlobalDecl

Author: Yaxun (Sam) Liu Date: 2021-11-23T10:59:26-05:00 New Revision: b472bd855ed85691d0d03ef1808c82b780d23721 URL: https://github.com/llvm/llvm-project/commit/b472bd855ed85691d0d03ef1808c82b780d23721 DIFF:

[PATCH] D113490: [NFC] Let Microsoft mangler accept GlobalDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGb472bd855ed8: [NFC] Let Microsoft mangler accept GlobalDecl (authored by yaxunl). Herald added a project:

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3149389 , @lebedev.ri wrote: > Were you able to actually reproduce the problem that lead to revert of > D107799 , or is this based on blind guesses? The patch will fix the

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3128840 , @rsmith wrote: > I also wonder whether we should accept `decltype(auto)(x)` as an extension, > but we can discuss that separately. Implemented. To produce a reference rather than a temporary, I had to

[PATCH] D114481: [NFC][AIX]Disable precompiled module file tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The PCH reader looks for `__clangast` section in the precompiled module file, which is not present in the file on AIX, and we don't support writing

[PATCH] D114483: Add support for sycl_special_class attribute

zahiraam created this revision. zahiraam added reviewers: bader, Naghasan, keryell, Fznamznon, aaron.ballman, erichkeane. Herald added subscribers: jdoerfert, Anastasia, ebevhan, yaxunl. zahiraam requested review of this revision. Herald added a project: clang. Special classes such as accessor,

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389334. sheldonneuberger-sc added a comment. - revert whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files:

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

stevewan created this revision. Herald added a subscriber: yaxunl. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX doesn't support GPU. There is no point testing HIP on it. Repository: rG LLVM Github Monorepo

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc added a comment. Made suggested changes, ready for another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 ___ cfe-commits mailing

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

rjmccall added a comment. In D108479#3149228 , @samitolvanen wrote: > I worked around this for now by explicitly allowing > `__builtin_function_start` in `CheckLValueConstantExpression`, but this seems > terribly hacky. What would be the correct way

[PATCH] D108479: [Clang] Add __builtin_addressof_nocfi

samitolvanen planned changes to this revision. samitolvanen added a comment. In D108479#3149297 , @rjmccall wrote: > In D108479#3149228 , @samitolvanen > wrote: > >> I worked around this for now by explicitly

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3148690 , @sylvestre.ledru wrote: > I am not sure why you are pinging this review often?! Maybe chat with people > who gave you feedback before directly?! https://llvm.org/docs/CodeReview.html "If it is not urgent,

[PATCH] D114394: Compile-time computation of string attribute hashes

rnk added subscribers: aeubanks, rnk. rnk added a comment. I think @aeubanks might be a good reviewer for this. I like the performance wins here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114394/new/ https://reviews.llvm.org/D114394 ___

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added a comment. In D114317#3149504 , @salman-javed-nz wrote: > What would you say are the key differences between this patch differ and > previous attempts, e.g. https://reviews.llvm.org/D72566? How does this patch > address the

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

martong edited reviewers, added: steakhal; removed: vsavchenko. martong added a comment. vsavchenko is inactive, presumably he is no longer working with CSA Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

lichray added a comment. In D113393#3128835 , @rsmith wrote: > It looks like we'll need some additional work on disambiguation to handle > cases like: > > struct A { int n; } a; > void f() { auto()->n = 0; } > > I think that's valid, but right now

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

lebedev.ri added a comment. Thank you for looking into it! In D114317#3149693 , @carlosgalvezp wrote: > In D114317#3149504 , > @salman-javed-nz wrote: > >> What would you say are the key differences between

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389333. sheldonneuberger-sc added a comment. - inline test helper for readability - fix indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058

[PATCH] D113491: [HIP] Fix device stub name for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG38211bbab1d9: [HIP] Fix device stub name for Windows (authored by yaxunl). Herald added a project: clang.

  1   2   >