[PATCH] D114615: [NFC][clang]Increase the number of driver diagnostics

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Please ignore the clang-format suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114615/new/ https://reviews.llvm.org/D114615

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Still looks great. Comment at: clang/test/Analysis/svalbuilder-simplify-compound-svals.cpp:75 + if (b * b == 1) +; // no-crash (assertion should not be

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added a comment. In D114427#3158405 , @Quuxplusone wrote: > Marking "accepted" for the record; but my checkmark means merely "I'm not > intending to block this," not "I claim the authority to say you //should// > land this." :) Thanks!

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidCStyleCastsCheck.cpp:170 + : getDestTypeString(SM, getLangOpts(), + dyn_cast(CastExpr)); Quuxplusone wrote: > IMO, this repeated

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp updated this revision to Diff 390380. carlosgalvezp marked 6 inline comments as done. carlosgalvezp added a comment. Moved conditionals inside function body. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/ https://reviews.llvm.org/D114427 Files:

[PATCH] D114696: [clang-format] regressed default behavior for operator parentheses

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14126-14127 + // FIXME these tests regressed behaviour. + // verifyFormat("T A::operator() ();", Space); + // verifyFormat("X A::operator++ (T);", Space); verifyFormat("auto lambda = [] () {

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with a few small nits. It'd be nice to update the patch summary with more information about why the option is needed. Comment at:

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1325 setOperationAction(ISD::MLOAD, VT, Custom); + setOperationAction(ISD::INSERT_SUBVECTOR, VT, Custom); } Can you extract this into its own patch

[PATCH] D113837: Sema: Let InitListExpr have dependent type instead of 'void'

aaronpuchert added a comment. Ping @rsmith. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113837/new/ https://reviews.llvm.org/D113837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

crayroud added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14165 + SpaceFuncDecl.SpaceBeforeParens = FormatStyle::SBPO_Custom; + SpaceFuncDecl.SpaceBeforeParensOptions.AfterFunctionDeclarationName = true; + MyDeveloperDay wrote: > are

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. In D114080#3158368 , @Fznamznon wrote: > In D114080#3158323 , @erichkeane > wrote: > >> I note that this is missing a test, otherwise I don't see any issues with it >> from my end. >

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 390377. gandhi21299 added a comment. - replaced integers with memory order macros in SemaCUDA/atomic-ops.cu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon updated this revision to Diff 390376. Fznamznon added a comment. An attempt to fix review page Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 Files:

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau created this revision. MattDevereau added reviewers: bsmith, peterwaller-arm, DavidTruby, paulwalker-arm. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett, mgorny. Herald added a reviewer: efriedma. MattDevereau requested review of this revision. Herald added

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. RKSimon wrote: > aaron.ballman wrote: > > jhenderson wrote: > > > I think the

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

Quuxplusone accepted this revision. Quuxplusone added a comment. Marking "accepted" for the record; but my checkmark means merely "I'm not intending to block this," not "I claim the authority to say you //should// land this." :) Comment at:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. > Have you checked whether there are any bots in the lab that will need to be > updated? I did find a number of bots that I think need addressing, I am intending to privately email the owners but I haven't done that yet - @rnk maintains the sanitizer-windows and

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon added a comment. In D114080#3158323 , @erichkeane wrote: > I note that this is missing a test, otherwise I don't see any issues with it > from my end. There is a test SemaSYCL/zero-length-arrays.cpp. For some reason after I updated this

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:342 + auto w = new int(x); +} Quuxplusone wrote: > salman-javed-nz wrote: > > carlosgalvezp wrote: > > > carlosgalvezp wrote: > > > >

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

yaxunl added inline comments. Comment at: clang/test/SemaCUDA/atomic-ops.cu:69-74 + flag = __hip_atomic_compare_exchange_weak(ptr, 0, 0, 0, 0, __HIP_MEMORY_SCOPE_SYSTEM); // expected-warning {{null passed to a callee that requires a non-null argument}} + flag =

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

carlosgalvezp updated this revision to Diff 390352. carlosgalvezp added a comment. Added Widget test case (reusing the S2 struct instead of adding a new struct Widget) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114427/new/ https://reviews.llvm.org/D114427 Files:

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

erichkeane added a comment. I note that this is missing a test, otherwise I don't see any issues with it from my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong added a comment. In D114619#3155363 , @steakhal wrote: > I see. Simplification is always good. Let's measure and compare the runtime > characteristics before moving forward. Here they are. Seems like the runtime and memory consumption are

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2226 + // + // Empirical measurements show that if we relax assumption G then the + // runtime does not grow noticeably. This is most probably because the

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong updated this revision to Diff 390349. martong marked 4 inline comments as done. martong added a comment. - Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114619/new/ https://reviews.llvm.org/D114619 Files:

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon marked an inline comment as not done. Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaSYCL.cpp:68-75 +bool ErrorFound = false; +if (isZeroSizedArray(*this, TypeToCheck)) { + SYCLDiagIfDeviceCode(UsedAt, diag::err_sycl_zero_array_size); +

[PATCH] D114080: [SYCL] Diagnose uses of zero length arrays

Fznamznon updated this revision to Diff 390346. Fznamznon marked an inline comment as done. Fznamznon added a comment. Apply suggestion from @bader Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114080/new/ https://reviews.llvm.org/D114080 Files:

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong marked an inline comment as done. martong added inline comments. Comment at: clang/test/Analysis/svalbuilder-simplify-compound-svals.cpp:75 + if (b * b == 1) +; // no-crash (assertion should not be violated) + } steakhal wrote: > I guess,

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong updated this revision to Diff 390343. martong marked an inline comment as done. martong added a comment. - Update a test case - Rebase to the parent patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103317/new/

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

erichkeane added a comment. In D105169#3130355 , @hyeongyukim wrote: > In D105169#3115814 , @erichkeane > wrote: > >> Either this or D108453 (which were >> committed

[PATCH] D51650: Implement target_clones multiversioning

erichkeane added a comment. Relanded: fc53eb69c26cdd7efa6b629c187d04326f0448ca Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650

[clang] fc53eb6 - Reapply 'Implement target_clones multiversioning'

Author: Erich Keane Date: 2021-11-29T06:30:01-08:00 New Revision: fc53eb69c26cdd7efa6b629c187d04326f0448ca URL: https://github.com/llvm/llvm-project/commit/fc53eb69c26cdd7efa6b629c187d04326f0448ca DIFF: https://github.com/llvm/llvm-project/commit/fc53eb69c26cdd7efa6b629c187d04326f0448ca.diff

[PATCH] D108643: Introduce _BitInt, deprecate _ExtInt

aaron.ballman added a comment. In D108643#3140927 , @aaron.ballman wrote: > In D108643#3093323 , @aaron.ballman > wrote: > >> In D108643#3106438 , >> @aaron.ballman

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

stuij updated this revision to Diff 390340. stuij added a comment. reuploading after rebase to resolve patch apply failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112431/new/ https://reviews.llvm.org/D112431 Files:

[PATCH] D114484: [NFC][AIX]Disable unsupported hip test on AIX

Jake-Egan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114484/new/ https://reviews.llvm.org/D114484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

Orlando added a comment. Driver flag change seems ok but would appreciate another pair of eyes checking it makes sense. Everything else (test change omissions, new test, default flag settings) LGTM. Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:29 #include

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

jmorse updated this revision to Diff 390003. jmorse added a comment. (Don't test for cc1 flag that's being deleted) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114631/new/ https://reviews.llvm.org/D114631 Files: clang/include/clang/Driver/Options.td

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. @Meinersbur Please rebase on main. The function "getPreheader()" was moved into OMPIRBuilder.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114413/new/ https://reviews.llvm.org/D114413

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

jmorse created this revision. jmorse added reviewers: StephenTozer, Orlando, TWeaver, djtodoro. Herald added subscribers: dang, pengfei, hiraditya. jmorse requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch makes

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne removed projects: libc++, libunwind. ldionne removed reviewers: libunwind, libc++, ldionne. ldionne added a comment. Herald added projects: libc++, libunwind. Herald added a reviewer: libc++. Herald added a reviewer: libunwind. Removing from the runtimes review queue -- please ping me

[PATCH] D114696: [clang-format] regressed default behavior for operator parentheses

This revision was automatically updated to reflect the committed changes. Closed by commit rG814aabae3775: [clang-format] regressed default behavior for operator parentheses (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 814aaba - [clang-format] regressed default behavior for operator parentheses

Author: mydeveloperday Date: 2021-11-29T14:27:16Z New Revision: 814aabae37757d21d96e22608ccb98e91c1f3a06 URL: https://github.com/llvm/llvm-project/commit/814aabae37757d21d96e22608ccb98e91c1f3a06 DIFF: https://github.com/llvm/llvm-project/commit/814aabae37757d21d96e22608ccb98e91c1f3a06.diff

[PATCH] D113709: Don't consider `LinkageSpec` when calculating DeclContext `Encloses`

This revision was automatically updated to reflect the committed changes. Closed by commit rG90010c2e1d60: Dont consider LinkageSpec when calculating DeclContext Encloses (authored by erichkeane). Herald added a project: clang. Changed prior to commit:

[clang] 90010c2 - Don't consider 'LinkageSpec' when calculating DeclContext 'Encloses'

Author: Erich Keane Date: 2021-11-29T06:08:16-08:00 New Revision: 90010c2e1d60c6a9a4a0b30a113d4dae2b7214eb URL: https://github.com/llvm/llvm-project/commit/90010c2e1d60c6a9a4a0b30a113d4dae2b7214eb DIFF: https://github.com/llvm/llvm-project/commit/90010c2e1d60c6a9a4a0b30a113d4dae2b7214eb.diff

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

stuij updated this revision to Diff 390333. stuij added a comment. uploading after rebase as per reviewer request (no changes in the patch itself) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112430/new/ https://reviews.llvm.org/D112430 Files:

[PATCH] D114706: [analyzer] Fix sensitive argument logic in GenericTaintChecker

gamesh411 created this revision. gamesh411 added reviewers: steakhal, Szelethus, NoQ. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. gamesh411 requested review of this revision. Herald added a

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:342 + auto w = new int(x); +} salman-javed-nz wrote: > carlosgalvezp wrote: > > carlosgalvezp wrote: > > > Quuxplusone wrote: > > > > What

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

saudi abandoned this revision. saudi added a comment. I understand, making `clang-cl -Wall` behave differently than `/Wall' is indeed confusing. We'll take different steps for setting up the warnings in our Build System. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112422: [clang][ARM] emit PACBTI-M feature defines

stuij updated this revision to Diff 390320. stuij added a comment. obeying clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112422/new/ https://reviews.llvm.org/D112422 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

gribozavr2 added inline comments. Comment at: clang/docs/DataFlowAnalysisIntro.md:24 +* [Introduction to Dataflow Analysis](https://www.youtube.com/watch?v=OROXJ9-wUQE) +* [Introduction to abstract interpretation](http://www.cs.tau.ac.il/~msagiv/courses/asv/absint-1.pdf).

[PATCH] D114703: [AArch64] Use Feature for A53 Erratum 835769 Fix

lenary created this revision. lenary added a reviewer: ostannard. Herald added subscribers: hiraditya, kristof.beyls. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. When this pass was originally implemented, the fix pass was

[PATCH] D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl()

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:599-603 + const SourceLocation Loc = [](Decl *D) -> SourceLocation { +const Stmt *Body = D->getBody(); +SourceLocation SL = Body ? Body->getBeginLoc() : D->getLocation();

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390316. stuij added a comment. minor clang-format conformance changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files:

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

stuij updated this revision to Diff 390314. stuij marked 2 inline comments as done. stuij added a comment. addressed review comment and clang-format suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112420/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

aaron.ballman added a comment. Have you checked whether there are any bots in the lab that will need to be updated? Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM ..

[clang-tools-extra] d96f92f - fix typos in comments

Author: Zhuo Zhang Date: 2021-11-29T14:06:33+01:00 New Revision: d96f92ff16edab72cf78811673f02371f07a5a70 URL: https://github.com/llvm/llvm-project/commit/d96f92ff16edab72cf78811673f02371f07a5a70 DIFF: https://github.com/llvm/llvm-project/commit/d96f92ff16edab72cf78811673f02371f07a5a70.diff

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 390309. futogergely added a comment. x64 debian failed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp

[PATCH] D114696: [clang-format] regressed default behavior for operator parentheses

MyDeveloperDay added a comment. @crayroud I'm going to commit this change to get past the regression, but we can continue to discuss here how you'd like to proceed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114696/new/

[PATCH] D114696: [clang-format] regressed default behavior for operator parentheses

curdeius accepted this revision. curdeius added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114696/new/ https://reviews.llvm.org/D114696 ___ cfe-commits mailing list

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

davrec accepted this revision. davrec added a comment. This revision is now accepted and ready to land. Looks great, thanks for identifying the need and banging this out so quickly. Hope you had some time to enjoy the holiday with your family! Dave Comment at:

[PATCH] D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl()

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:599-603 + const SourceLocation Loc = [](Decl *D) -> SourceLocation { +const Stmt *Body = D->getBody(); +SourceLocation SL = Body ? Body->getBeginLoc() :

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390298. kbobyrev added a comment. Slightly improve docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files: clang-tools-extra/clangd/index/dex/Trigram.cpp

[PATCH] D113995: [clangd] Dex Trigrams: Improve query trigram generation

kbobyrev updated this revision to Diff 390297. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113995/new/ https://reviews.llvm.org/D113995 Files:

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider added a comment. Vitaly, Evgenii, can one of you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 ___ cfe-commits mailing list

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

steakhal resigned from this revision. steakhal added a comment. I've already reviewed this change offline, thus I resign. For me this looks great, I'm eager to hear your opinions! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added a comment. @tra: what should be done about the unit test that checks whether CUDA SDK 8.0 specifically has been found? Apparently you are taking care of the buildbot configuration performing those tests. And how should we proceed in general, what can I do next? Thanks.

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

salman-javed-nz added a comment. I think the primary goal is satisfied - in all cases the cast is identified and a warning is generated. For the `Widget&` case, a warning is generated but no fixit is offered, but that isn't any worse than the existing C-style cast fixits. It does sound like a

[PATCH] D114696: [clang-format] regressed default behavior for operator parentheses

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, crayroud, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. D110833: [clang-format] Refactor SpaceBeforeParens to add options

[clang] af37d4b - [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl()

Author: Balazs Benics Date: 2021-11-29T10:39:36+01:00 New Revision: af37d4b6fee8990d5b029796681b59e0d0390c28 URL: https://github.com/llvm/llvm-project/commit/af37d4b6fee8990d5b029796681b59e0d0390c28 DIFF: https://github.com/llvm/llvm-project/commit/af37d4b6fee8990d5b029796681b59e0d0390c28.diff

[PATCH] D114441: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf37d4b6fee8: [analyzer][NFC] Refactor AnalysisConsumer::getModeForDecl() (authored by steakhal). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390283. RKSimon added a comment. rebase and add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D114427: [clang-tidy] Warn on functional C-style casts

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/google-readability-casting.cpp:342 + auto w = new int(x); +} carlosgalvezp wrote: > carlosgalvezp wrote: > > Quuxplusone wrote: > > > What about > > > ``` > > >

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3161-3169 +if (Line.MightBeFunctionDecl && (Left.is(TT_FunctionDeclarationName) || + Right.is(TT_OverloadedOperatorLParen))) { + if

[PATCH] D114105: [clang-tidy] Ignore narrowing conversions in case of bitfields

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8120a771143: [clang-tidy] Ignore narrowing conversions in case of bitfields (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D114105?vs=389711=390275#toc Repository: rG

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1d0673aeeec: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges

This revision was automatically updated to reflect the committed changes. Closed by commit rG0540485436c4: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG0685e83534ef: Fix cppcoreguidelines-virtual-base-class-destructor in macros (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a8120a7 - [clang-tidy] Ignore narrowing conversions in case of bitfields

Author: Balazs Benics Date: 2021-11-29T09:56:43+01:00 New Revision: a8120a771143c15480b508c19a14c0c85a36378c URL: https://github.com/llvm/llvm-project/commit/a8120a771143c15480b508c19a14c0c85a36378c DIFF: https://github.com/llvm/llvm-project/commit/a8120a771143c15480b508c19a14c0c85a36378c.diff

[clang-tools-extra] e1d0673 - [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

Author: Balazs Benics Date: 2021-11-29T09:56:43+01:00 New Revision: e1d0673aeeece138d4865385a24a86f6954dff72 URL: https://github.com/llvm/llvm-project/commit/e1d0673aeeece138d4865385a24a86f6954dff72 DIFF: https://github.com/llvm/llvm-project/commit/e1d0673aeeece138d4865385a24a86f6954dff72.diff

[clang-tools-extra] 0540485 - [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges

Author: Balazs Benics Date: 2021-11-29T09:56:43+01:00 New Revision: 0540485436c4dd225e6a40e6db1240f096d145d3 URL: https://github.com/llvm/llvm-project/commit/0540485436c4dd225e6a40e6db1240f096d145d3 DIFF: https://github.com/llvm/llvm-project/commit/0540485436c4dd225e6a40e6db1240f096d145d3.diff

[clang-tools-extra] 0685e83 - Fix cppcoreguidelines-virtual-base-class-destructor in macros

Author: Balazs Benics Date: 2021-11-29T09:56:43+01:00 New Revision: 0685e83534ef8917f277b394da2927cabff8129f URL: https://github.com/llvm/llvm-project/commit/0685e83534ef8917f277b394da2927cabff8129f DIFF: https://github.com/llvm/llvm-project/commit/0685e83534ef8917f277b394da2927cabff8129f.diff

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 390270. futogergely retitled this revision from "[clang-tidy] CERT MSC24-C Obsolescent Functions check" to "[clang-tidy] Add cert-msc24-c checker.". futogergely edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D114667: [clangd] Add fixes for clang "include " diagnostics

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks, this is nice low-hanging fruit. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:830 + if (!ReplacementFixes.empty()) { +

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

MyDeveloperDay added a comment. I'm looking at a bug (sorry can't log it as we don't seem to have a working bug tracker!) that causes a regression on `operator new(` and `operator delete(` which I believe I've tracked to this change v12 ~foo() { ::operator delete(bar); } ::operator

[PATCH] D114162: [X86][clang] Enable floating-point type for -mno-x87 option on 32-bits

asavonic accepted this revision. asavonic added a comment. This revision is now accepted and ready to land. LGTM. We can also remove all code related to HasFPReturn, it is no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114162/new/

<    1   2