[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely updated this revision to Diff 391604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91000/new/ https://reviews.llvm.org/D91000 Files: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp clang-tools-extra/clang-tidy/cert/CMakeLists.txt

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. So far, what I've found is that in some cases, DIEnumerator::get returns the same node for similar enumerator values in different enums that happen to have the same name and value (even if their bitwidth differs), but sometimes not. For example, in one compilation I

[clang] 4f94c02 - [Clang] Mutate bulitin names under IEEE128 on PPC64

Author: Qiu Chaofan Date: 2021-12-03T17:50:18+08:00 New Revision: 4f94c02616025ace168899b6fbdc8c3ba240062b URL: https://github.com/llvm/llvm-project/commit/4f94c02616025ace168899b6fbdc8c3ba240062b DIFF: https://github.com/llvm/llvm-project/commit/4f94c02616025ace168899b6fbdc8c3ba240062b.diff

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f94c0261602: [Clang] Mutate bulitin names under IEEE128 on PPC64 (authored by qiucf). Changed prior to commit:

[clang] b9adaa1 - [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

Author: Qiu Chaofan Date: 2021-12-03T18:07:34+08:00 New Revision: b9adaa1782db727df08b8138e12c1e60964885d3 URL: https://github.com/llvm/llvm-project/commit/b9adaa1782db727df08b8138e12c1e60964885d3 DIFF: https://github.com/llvm/llvm-project/commit/b9adaa1782db727df08b8138e12c1e60964885d3.diff

[PATCH] D114937: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9adaa1782db: [PowerPC] [Clang] Fix alignment adjustment of single-elemented float128 (authored by qiucf). Changed prior to commit:

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

simon_tatham added a comment. I don't think so, I'm afraid. If you look at the definition of `MacroInfo::tokens_begin()` in `clang/include/clang/Lex/MacroInfo.h`, you see that it doesn't return a raw `Token *`: it returns a C++ iterator object. using tokens_iterator =

[PATCH] D25844: [Sema][ObjC] Warn about implicitly autoreleasing indirect parameters that are captured by blocks

Cy-4AH added a comment. Hello! What compiler do when call doStuff: NSString * __strong fillMe; NSString * __autoreleasing autorelesingFillMe = fillMe; doStuff(); fillMe = autoreleasingFillMe; Why it's not making the same thing in doStuff body? Compiler generated code for yours example

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray updated this revision to Diff 391602. lichray added a comment. Restore deleted comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115031/new/ https://reviews.llvm.org/D115031 Files: clang/lib/AST/APValue.cpp Index:

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:372 QualType resultTy) { NonLoc InputLHS = lhs; NonLoc InputRHS = rhs; martong wrote: > steakhal wrote: > > @martong, you

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. This is an alternative to D114957 that does not update the API of the OpenCL builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115032/new/ https://reviews.llvm.org/D115032

[PATCH] D114957: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad added a comment. In D114957#3167700 , @arsenm wrote: > I think this macro is purely terrible and should not be added (and at least > should be all caps?). If we can't just hard break users, I would rather just > leave the builtin signatures broken

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen updated this revision to Diff 391588. steffenlarsen edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114439/new/ https://reviews.llvm.org/D114439 Files: clang/include/clang/Basic/Attr.td

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391595. MattDevereau added a comment. updated SVEMAP2 types added overloadable intrinsics updated BUILTIN function signatures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files:

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked an inline comment as done. futogergely added a comment. In D91000#3161296 , @whisperity wrote: > Should/does this work in C++ mode for `std::whatever`? Right now the checker finds the functions in the global namespace only. The

[PATCH] D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping

linjamaki added a comment. Thanks, @Anastasia. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108621/new/ https://reviews.llvm.org/D108621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray created this revision. lichray requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. C++20 NTTP (non-type template parameter) prints `MyType<{{116, 104, 105, 115}}>` when the code is as simple as `MyType<"this">`. Of course, due to the

[PATCH] D114116: [clang][ARM] relax -mtp=cp15 for non-thumb cases

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114116/new/ https://reviews.llvm.org/D114116

[PATCH] D115032: [AMDGPU] Change llvm.amdgcn.image.bvh.intersect.ray to take vec3 args

foad created this revision. foad added reviewers: arsenm, rampitec, yaxunl, critson, b-sumner. Herald added subscribers: kerbowa, hiraditya, t-tye, Anastasia, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. foad requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added a comment. Thank you both for the reviews! Consensus seems to be having support for pack expansion at argument level for now and let more complicated logic be added when there is an actual need. I have applied these changes as I understood them and have added/adjusted the

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou added a comment. In D115014#3169400 , @simon_tatham wrote: > I don't think so, I'm afraid. If you look at the definition of > `MacroInfo::tokens_begin()` in `clang/include/clang/Lex/MacroInfo.h`, you see > that it doesn't return a raw

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

simon_tatham added a comment. Ah, now I see what you mean – I didn't look far enough! I don't know this code well (in fact I'm not sure why you picked me as a reviewer), but off the top of my head: the question is not just whether `tokens_iterator` happens to be the same thing as `const Token

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

futogergely marked an inline comment as done. futogergely added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ObsolescentFunctionsCheck.cpp:48 + // Matching functions with safe replacements in annex K. + auto FunctionNamesWithAnnexKReplacementMatcher =

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. The patch is ready to land. @Anastasia, @bader, could you commit this patch to the LLVM for us? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818

[PATCH] D115014: [clang] RFC: NFC: simplify macro tokens assignment

zhouyizhou added a comment. In D115014#3169444 , @simon_tatham wrote: > Ah, now I see what you mean – I didn't look far enough! > > I don't know this code well (in fact I'm not sure why you picked me as a > reviewer), but off the top of my head: the

[PATCH] D91000: [clang-tidy] Add cert-msc24-c checker.

steakhal added a comment. L129 and L135 are uncovered by tests. The rest of the lines are covered by tests, according to `lcov`. The checker produced in total 15 reports on these 18 projects:

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. Reduced testcase: enum FrameIID { nsBox_id, nsIFrame_id, nsHTMLFramesetBlankFrame_id, nsHTMLFramesetBorderFrame_id, }; enum class ClassID : unsigned char { nsBox_id, nsIFrame_id, nsHTMLFramesetBlankFrame_id,

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

MattDevereau updated this revision to Diff 391616. MattDevereau added a comment. run clang format to fix test macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/ https://reviews.llvm.org/D114713 Files:

[PATCH] D115015: CodeGen: Strip exception specifications from function types in CFI type names.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115015/new/ https://reviews.llvm.org/D115015 ___

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &, I'm not happy with introducing new (hacky)

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

simoll created this revision. simoll added reviewers: kaz7, MaskRay, phosek. simoll requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before, the CLANG_DEFAULT_LINKER cmake option was a global override for the linker that shall be used on

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patch fixes issues for -fgpu-rdc for Windows MSVC toolchain: Fix COFF specific section flags and remove section types in llvm-mc input file for Windows. Escape fatbin path in llvm-mc input

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

rnk added a comment. In D102090#3169439 , @ebrevnov wrote: > While -Bsymbolic-funtions brings nice performance improvements it also > changes symbol resolution order. That means we effectively disabled > preemption for functions and all references

[clang] f627956 - [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

Author: Alexey Bataev Date: 2021-12-03T07:01:00-08:00 New Revision: f6279562dae456f6c58d5f7484ba4bae5c2071fa URL: https://github.com/llvm/llvm-project/commit/f6279562dae456f6c58d5f7484ba4bae5c2071fa DIFF: https://github.com/llvm/llvm-project/commit/f6279562dae456f6c58d5f7484ba4bae5c2071fa.diff

[PATCH] D114546: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6279562dae4: [OPENMP]Fix PR52117: Crash caused by target region inside of task construct. (authored by ABataev). Repository: rG LLVM Github

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske updated this revision to Diff 391640. balazske marked 2 inline comments as done. balazske added a comment. Applied the text changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114602/new/ https://reviews.llvm.org/D114602 Files:

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1cefe91d40ae: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception… (authored by balazske). Repository: rG LLVM Github

[clang-tools-extra] 1cefe91 - [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

Author: Balázs Kéri Date: 2021-12-03T16:53:08+01:00 New Revision: 1cefe91d40aef043ec949c6ddb053b47b4d5b8e6 URL: https://github.com/llvm/llvm-project/commit/1cefe91d40aef043ec949c6ddb053b47b4d5b8e6 DIFF: https://github.com/llvm/llvm-project/commit/1cefe91d40aef043ec949c6ddb053b47b4d5b8e6.diff

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch avoids unnecessarily copying `mmap`-ed memory into

<    1   2