[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

linjamaki updated this revision to Diff 392664. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110549/new/ https://reviews.llvm.org/D110549 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. Hi, just giving a progress update. This is just a early heads-up - no action needed from you at this stage. I have a rough prototype that seems promising. The big-O/time complexity is no longer dependent on the number of headers being included and the number of

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 0a54c32 - Add note about inlining dllimport functions to the attribute docs

Author: Hans Wennborg Date: 2021-12-08T11:15:39+01:00 New Revision: 0a54c325beff37c57991e88799c213534c1fa6a9 URL: https://github.com/llvm/llvm-project/commit/0a54c325beff37c57991e88799c213534c1fa6a9 DIFF: https://github.com/llvm/llvm-project/commit/0a54c325beff37c57991e88799c213534c1fa6a9.diff

[PATCH] D115252: Add note about inlining dllimport functions to the attribute docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a54c325beff: Add note about inlining dllimport functions to the attribute docs (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki added a comment. Cherry-picking should work now, @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 ___ cfe-commits mailing list

[PATCH] D115249: Clang-Tidy implicit bool conversion check use upercase suffixes

kili updated this revision to Diff 392678. kili added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115249/new/ https://reviews.llvm.org/D115249 Files:

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:126 + bool HandleComment(Preprocessor , SourceRange Range) override { +if (!isInsideMainFile(Range.getBegin(), SM) || Range.getBegin().isMacroID()) + return false; we're

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

linjamaki updated this revision to Diff 392662. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki updated this revision to Diff 392675. linjamaki added a comment. - Add comments to clarify the limitation of the `--offload` option to one target. - Add test for multiple `--offload` option instances. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal added a comment. Sorry for my late response, I'm busy with other things right now. I plan to come back to this in a couple of weeks. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:52 static bool areEquivalentNameSpecifier(const

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392688. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve almost all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files:

[PATCH] D114006: [analyzer][NFC] Enable access to CodeGenOptions from analyzer's instances

ASDenysPetrov updated this revision to Diff 392666. ASDenysPetrov added a comment. Fixed unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114006/new/ https://reviews.llvm.org/D114006 Files: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:2589 + llvm::Regex RawStringRegex("R\"([A-Za-z]*)\\("); + SmallVector RawStringMatches; A raw

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Requesting changes so that appears correctly in the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay added a comment. `So, you missed the digits and the characters: _{}[]#<>%:;.?*+-/^&|~!=,'.` The standard is nuts sometimes... let me add that madness in ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki updated this revision to Diff 392665. linjamaki added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu updated this revision to Diff 392669. ChuanqiXu added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115219/new/ https://reviews.llvm.org/D115219 Files: llvm/docs/Coroutines.rst llvm/lib/Transforms/Coroutines/CoroSplit.cpp

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: llvm/docs/Coroutines.rst:1395 +|| Landingpad | mark coroutine as done | mark coroutine done |

[clang] 96b92d5 - [NFC] Only attach a declaration to global module fragment if it appears in a module

Author: Chuanqi Xu Date: 2021-12-08T17:16:31+08:00 New Revision: 96b92d5b3ec43be18146a346b65cc82766cf8b3a URL: https://github.com/llvm/llvm-project/commit/96b92d5b3ec43be18146a346b65cc82766cf8b3a DIFF: https://github.com/llvm/llvm-project/commit/96b92d5b3ec43be18146a346b65cc82766cf8b3a.diff

[clang] e6d0b85 - [ARM][libunwind] add PACBTI-M support for libunwind

Author: Ties Stuij Date: 2021-12-08T09:44:45Z New Revision: e6d0b851f854849240bc1f02901b0dbb3be84388 URL: https://github.com/llvm/llvm-project/commit/e6d0b851f854849240bc1f02901b0dbb3be84388 DIFF: https://github.com/llvm/llvm-project/commit/e6d0b851f854849240bc1f02901b0dbb3be84388.diff LOG:

[PATCH] D112430: [ARM][libunwind] add PACBTI-M support for libunwind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d0b851f854: [ARM][libunwind] add PACBTI-M support for libunwind (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2605-2607 + if (!CharSequence.empty()) { +RawStringTermination = ")" + CharSequence + "\""; + } curdeius wrote: > Since `CharSequence` is empty, you might want to

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > How about pointers/references in

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

ChuanqiXu added a comment. In D115222#3177269 , @rjmccall wrote: > Like a lot of the switched-resume lowering, this intrinsic is extremely tied > to C++ semantics. If C++ doesn't actually allow the optimization anymore, > then I completely agree that

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay updated this revision to Diff 392674. MyDeveloperDay added a comment. Allow for option Raw String CharSequences CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168 Files: clang/lib/Format/Format.cpp

[PATCH] D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP

linjamaki added a comment. Thanks for the feedback. The `--offload` is meant to support multiple targets but right now it is restricted to one at most. The limitation comes from the HIPActionBuilder and CudaActionBuilderBase which currently expects a single target triple and toolchain for all

[clang-tools-extra] 5d3b895 - Don't offer partial fix-its for `modernize-pass-by-value`

Author: Adrian Vogelsgesang Date: 2021-12-08T13:31:30-05:00 New Revision: 5d3b8956e83484ff7234dda5e939abbdc9bd2c88 URL: https://github.com/llvm/llvm-project/commit/5d3b8956e83484ff7234dda5e939abbdc9bd2c88 DIFF:

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 392830. mbenfield added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 Files: clang/include/clang/Basic/Attr.td

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield added a comment. @aaron.ballman Look to you like this is ready to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 ___ cfe-commits mailing list

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:48 + << std::declval())> +std::ostream <<(std::ostream , + const DataflowAnalysisState ) { This would also

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov updated this revision to Diff 392821. ASDenysPetrov added a comment. Improved dynamic type recognition. Provided `-fstrict-aliasing` compiler flag dependency. Still has issues with some cases (see it at the bottom of the test file). WIP. CHANGES SINCE LAST ACTION

[PATCH] D113638: [xray] Add support for hexagon architecture

kparzysz accepted this revision. kparzysz added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113638/new/ https://reviews.llvm.org/D113638

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2116 + + // __builtin_reduce_xor restricts the element type to vector of integers type + // only. nit: the element type will be restricted to `int`, so maybe say something like `only

[PATCH] D115386: AST: Avoid using SmallVector::set_size() in UnresolvedSet

dexonsmith created this revision. dexonsmith added a reviewer: dblaikie. dexonsmith requested review of this revision. Herald added a project: clang. Update UnresolvedSet to use (and expose) `SmallVector::truncate()` instead of `SmallVector::set_size()`. The latter is going to made private in a

[PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, except I'd prefer the `#include`s be changed separately since that cleanup seems unrelated to this change. Comment at:

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043

[PATCH] D115118: [clang-tidy] Assume that `noexcept` functions won't throw anything in `bugprone-exception-escape` check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:201-202 + case EST_BasicNoexcept: + case EST_DependentNoexcept: // Let's be optimistic here (necessary e.g. + // for variant

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392828. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Sema/darwin-tls.c clang/test/Sema/tls.c

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir updated this revision to Diff 392840. schittir added a subscriber: mikerice. schittir added a comment. Add test case Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/ https://reviews.llvm.org/D115320 Files: clang/lib/CodeGen/CGStmt.cpp

[PATCH] D115320: Avoid setting tbaa information on return type of call to inline assember

schittir added a comment. In D115320#3178682 , @jeroen.dobbelaere wrote: > Do you have a testcase ? Thank you for the review. Please take a look at the new diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115320/new/

[PATCH] D115222: [Coroutines] Remove unused coroutine builtin/intrinsics llvm.coro.param (NFC-ish)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, that's fine, I have no objection to removing it. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115222/new/

[PATCH] D115219: [C++20] [Coroutines] Mark coroutine done if unhandled_exception throws

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor suggestion in the docs, but otherwise LGTM. Comment at: llvm/docs/Coroutines.rst:1382 +The `coro.end` intrinsic in the normal path wouldn't do this since the

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 created this revision. logan-5 added a reviewer: aaron.ballman. logan-5 added a project: clang. Herald added subscribers: abrachet, ctetreau, dexonsmith, martong. logan-5 requested review of this revision. Herald added a subscriber: cfe-commits. Returning `OS.str()` is guaranteed to copy

[PATCH] D115378: OpenMP: Avoid using SmallVector::set_size()

dexonsmith created this revision. dexonsmith added a reviewer: Meinersbur. Herald added subscribers: guansong, hiraditya, yaxunl. dexonsmith requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. Update

[PATCH] D115379: ASTMatchers: Avoid using SmallVector::set_size()

dexonsmith created this revision. dexonsmith added reviewers: njames93, aaron.ballman. dexonsmith requested review of this revision. Herald added a project: clang. Update `variadicMatcherDescriptor` to assert on reserved capacity and to call `emplace_back()` instead of calling `set_size()` and

Re: RFC: proposing to relax standardization requirements for Clang extensions

On Tue, 7 Dec 2021 at 13:22, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > tl;dr: our Clang "get involved" page implies that proposed extensions > to Clang must also be proposed to a standards committee > (https://clang.llvm.org/get_involved.html#criteria). This is a good >

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

aaron.ballman added a comment. In D112648#3165302 , @avogelsgesang wrote: > @aaron.ballman can you please commit this on my behalf? I don't have commit > access OMG, I'm sorry for missing this note! Yes, I'm happy to commit on your behalf. What name

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

avogelsgesang added a comment. > What name and email address would you like me to use for patch attribution? Adrian Vogelsgesang, avogelsges...@salesforce.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112648/new/

[PATCH] D115149: [analyzer][solver] Fix assertion on (NonLoc, Op, Loc) expressions

ASDenysPetrov added a comment. It seems like your test file passes even before your patch. I've just checked it. My last pull from the baseline was on Nov 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115149/new/

[PATCH] D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the fix and your patience with getting it landed! I've commit on your behalf in 5d3b8956e83484ff7234dda5e939abbdc9bd2c88 Repository: rG LLVM

[PATCH] D111100: enable plugins for clang-tidy

vtjnash updated this revision to Diff 392835. vtjnash added a comment. fix cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D00/new/ https://reviews.llvm.org/D00 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.txt

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

kpyzhov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392865. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

aaron.ballman added a comment. In D115106#3172949 , @simon.giesecke wrote: > Thanks a lot for addressing this issue! I am just trying it on our codebase. > >> The problem actually has nothing to do with the out-of-line definition being >> inline; the

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

aaron.ballman added reviewers: aaron.ballman, whisperity, alexfh, malcolm.parsons. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. Adding some additional reviewers. At a high level, I think this is a reasonable direction to go, but I wonder if this should be hidden behind a

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392696. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address the last comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files:

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392715. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp llvm/include/llvm/ADT/Triple.h Index:

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the new functionality, I've committed on your behalf in 8680f951c21e675a110e79c9b8dc59bb94290b01 Comment at:

[PATCH] D115337: [X86][clang] Put the update of HasLongDouble into TargetInfo::adjust

pengfei created this revision. pengfei added reviewers: asavonic, erichkeane, nickdesaulniers, andrew.w.kaylor. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We found a problem that `-mlong-double-64` doesn't work with `-mno-x87`

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); HazardyKnusperkeks wrote: > curdeius wrote: > >

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel created this revision. ymandel added reviewers: gribozavr2, sgatev, xazax.hun. Herald added subscribers: rnkovacs, mgorny. ymandel requested review of this revision. Herald added a project: clang. Adds a general-purpose framework to support testing of dataflow analyses. Repository: rG

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 392703. MyDeveloperDay added a comment. Add some more unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files: clang/lib/Format/FormatToken.cpp clang/lib/Format/FormatToken.h

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 updated this revision to Diff 392717. jansvoboda11 added a comment. Rebase on top of D115331 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 Files:

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > curdeius wrote: > > How

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall marked an inline comment as done. sammccall added a comment. Thanks Dave! A last ping in case @rsmith has opinions here as clang owner. Otherwise I'd probably land this in a week or so. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2106 +

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392731. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Sema/darwin-tls.c clang/test/Sema/tls.c

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-exception-escape.cpp:291-293 +struct super_throws { + super_throws() noexcept(false) { throw 42; } +}; I think this needs additional test coverage. Dynamic

[PATCH] D115254: Use VersionTuple for parsing versions in Triple

jamesfarrell added a comment. In D115254#3177960 , @MaskRay wrote: > commit 219672b8dd06c4765185fa3161c98437d49b4a1b > says > `Revert "Revert "...""` > > For such commits, it is

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &,

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

aaron.ballman added a comment. In D112881#3160590 , @paulaltin wrote: >> LGTM, with a few small nits. It'd be nice to update the patch summary with >> more information about why the option is needed. > > Thanks @aaron.ballman. I've made the changes to

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 updated this revision to Diff 392745. jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 Files:

[PATCH] D112923: [clang][deps] Reset some benign codegen options

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b6c08379b43: [clang][deps] Reset some benign codegen options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112923/new/

[clang] 5b6c083 - [clang][deps] Reset some benign codegen options

Author: Jan Svoboda Date: 2021-12-08T11:53:50+01:00 New Revision: 5b6c08379b437cb22fcd63707b94df1ede23d9db URL: https://github.com/llvm/llvm-project/commit/5b6c08379b437cb22fcd63707b94df1ede23d9db DIFF: https://github.com/llvm/llvm-project/commit/5b6c08379b437cb22fcd63707b94df1ede23d9db.diff

[clang] 9ae5810 - [HIPSPV] Convert HIP kernels to SPIR-V kernels

Author: Henry Linjamäki Date: 2021-12-08T12:18:15+03:00 New Revision: 9ae5810b53c2e096d7442ba8af3f00ebc3d301b0 URL: https://github.com/llvm/llvm-project/commit/9ae5810b53c2e096d7442ba8af3f00ebc3d301b0 DIFF:

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae5810b53c2: [HIPSPV] Convert HIP kernels to SPIR-V kernels (authored by linjamaki, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: shafik. Herald added a reviewer: rupprecht. Herald added a reviewer:

Re: TCE target nonconforming definition of long long and intmax_t

On Wed, Dec 8, 2021 at 2:20 AM Pekka Jääskeläinen wrote: > > Hi Aaron, > > Indeed the 32b TCE target is not fully compliant in this aspect; > its 64b emulation support is not complete, therefore we advertise > only these 32b limits. We have an in-progress 64b target where the > limits are 64b,

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { steffenlarsen wrote: > erichkeane wrote: > > So I was thinking

[PATCH] D115337: [X86][clang] Put the update of HasLongDouble into TargetInfo::adjust

erichkeane added a comment. @craig.topper is the only one I know who can keep all of this straight, so perhaps he's willing to give a more in depth review? Comment at: clang/include/clang/Basic/TargetInfo.h:207 bool HasLongDouble; + bool Has80BitLongDouble; bool

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { erichkeane wrote: > So I was thinking about this overnight...

[PATCH] D115332: [clang][deps] Use lock_guard instead of unique_lock

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes uses of `std::unique_lock` to `std::lock_guard`. The

[PATCH] D87201: [clang-format] Add a option for the position of Java static import

bc-lee added a comment. Thanks for the review. Since I don't have commit access, so I want someone else to apply this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87201/new/ https://reviews.llvm.org/D87201

[clang] 8680f95 - Add __builtin_elementwise_ceil

Author: Jun Zhang Date: 2021-12-08T08:29:33-05:00 New Revision: 8680f951c21e675a110e79c9b8dc59bb94290b01 URL: https://github.com/llvm/llvm-project/commit/8680f951c21e675a110e79c9b8dc59bb94290b01 DIFF: https://github.com/llvm/llvm-project/commit/8680f951c21e675a110e79c9b8dc59bb94290b01.diff

[clang] ca70b80 - Removing some unused parameters from this test; NFC

Author: Aaron Ballman Date: 2021-12-08T08:35:07-05:00 New Revision: ca70b807ae655b3ff2378de7abfb9796cbf5d0b7 URL: https://github.com/llvm/llvm-project/commit/ca70b807ae655b3ff2378de7abfb9796cbf5d0b7 DIFF: https://github.com/llvm/llvm-project/commit/ca70b807ae655b3ff2378de7abfb9796cbf5d0b7.diff

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kbobyrev updated this revision to Diff 392753. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114072/new/ https://reviews.llvm.org/D114072 Files:

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. Herald added a subscriber: hiraditya. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The minimizing and

[clang-tools-extra] 2676759 - [clangd] Add fixes for clang "include " diagnostics

Author: Sam McCall Date: 2021-12-08T16:16:53+01:00 New Revision: 2676759bf22e45def4d37da74f09261b26a98d21 URL: https://github.com/llvm/llvm-project/commit/2676759bf22e45def4d37da74f09261b26a98d21 DIFF: https://github.com/llvm/llvm-project/commit/2676759bf22e45def4d37da74f09261b26a98d21.diff

[PATCH] D114667: [clangd] Add fixes for clang "include " diagnostics

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG2676759bf22e: [clangd] Add fixes for clang include foo.h diagnostics (authored by sammccall). Changed prior to commit:

[PATCH] D115250: switched to emulated TLV on macOS before 10.7

catap updated this revision to Diff 392755. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 Files: clang/lib/Basic/Targets/OSTargets.h clang/lib/CodeGen/ItaniumCXXABI.cpp clang/test/Sema/darwin-tls.c clang/test/Sema/tls.c

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

aaron.ballman added a comment. Mostly just nits from me. At a high level, I think this is good, but if someone else wanted to double-check the changes to the matcher statements themselves, that'd be good. Comment at:

[PATCH] D114713: [AArch64][SVE][NEON] Add NEON-SVE-Bridge intrinsics

peterwaller-arm accepted this revision. peterwaller-arm added a comment. This revision is now accepted and ready to land. LGTM once D115259 has landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114713/new/

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1194 SourceLocation Loc, - Sema::ConditionKind CK, +

[PATCH] D113752: [Parse] Use empty RecoveryExpr when if/while/do/switch conditions fail to parse

sammccall updated this revision to Diff 392776. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113752/new/ https://reviews.llvm.org/D113752 Files:

[PATCH] D114667: [clangd] Add fixes for clang "include " diagnostics

sammccall marked 4 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:495 + if (auto Edit = Inserter->insert(Name)) +return {Fix{llvm::formatv("Include {0}", Name).str(), {std::move(*Edit)}}}; + return {};

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

sammccall added a comment. Do either of you have thoughts on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107275/new/ https://reviews.llvm.org/D107275 ___ cfe-commits mailing list

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev updated this revision to Diff 392772. sgatev marked 8 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115235/new/ https://reviews.llvm.org/D115235 Files:

[PATCH] D115345: [clangd] Suppress IncludeCleaner warnings for headers behind pragma keep

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp:414 + auto = AST.getIncludeStructure(); + EXPECT_THAT(getUnused(AST,

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >