[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { erichkeane wrote: > steffenlarsen wrote: > > erichkeane

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

melver added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3436 case Builtin::BI__builtin_alloca_with_align: { Value *Size = EmitScalarExpr(E->getArg(0)); glider wrote: > For the sake of completeness, shall we also implement an

[PATCH] D115442: [clangd] Provide documentation as MarkupContent in signaturehelp

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This unifies the behaviour we

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 393168. glider added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 Files: clang/docs/AddressSanitizer.rst

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 393185. eopXD added a comment. Rebase now since the preceeding patches are accepted. This patch is ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:50-51 + + /// Minimize contents of the file. + static void minimize(CachedFileSystemEntry );

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 393174. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215 Files: clang/test/Driver/riscv-arch.c

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

MyDeveloperDay updated this revision to Diff 393188. MyDeveloperDay added a comment. Add a suitable amount of C++ madness, (to the limit of what I could coax the regex to accept) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/ https://reviews.llvm.org/D115168 Files:

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

yaxunl added a comment. In D115283#3181128 , @JonChesterfield wrote: > Not exactly that. The weak symbol isn't the function name, as that gets > renamed or inlined. We discussed this before. As code object ABI use runtime metadata to represent

[PATCH] D107275: [Sema] a[x] has type T when a has type T* or T[], even when T is dependent

kadircet added a comment. Sorry for leaving this without any replies, I think the summary you have is already of our offline discussion. Let me raise my final concerns, if you think we're covered for those and others don't chime in this week I suppose we can consider this as good to go. ---

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

yaxunl added a comment. In D115283#3181109 , @kpyzhov wrote: > In D115283#3180836 , @yaxunl wrote: > >> If we only need to check whether `__ockl_hostcall_internal` exists in the >> final module in LLVM codegen

[clang] ab28cb1 - Revert "[xray] add support for hexagon"

Author: Brian Cain Date: 2021-12-09T07:30:40-08:00 New Revision: ab28cb1c5c4dc7181fae3d47f0601982996739db URL: https://github.com/llvm/llvm-project/commit/ab28cb1c5c4dc7181fae3d47f0601982996739db DIFF: https://github.com/llvm/llvm-project/commit/ab28cb1c5c4dc7181fae3d47f0601982996739db.diff

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 updated this revision to Diff 393162. jansvoboda11 added a comment. Prevent potential data races by wrapping access to `Entry.getPPSkippedRangeMapping()` in `if (Entry.isMinimized())`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 393181. eopXD added a comment. One last rebase before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c

[PATCH] D115442: [clangd] Provide documentation as MarkupContent in signaturehelp

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. MarkupContent was introduced in 3.12 in 2018. We could continue to support older clients by rendering plaintext as string instead of the MarkupContent struct but it doesn't seem worth

[PATCH] D115452: Prevent abseil-cleanup-ctad check from stomping on surrounding context

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115452/new/ https://reviews.llvm.org/D115452

[clang-tools-extra] a1968d5 - Prevent abseil-cleanup-ctad check from stomping on surrounding context

Author: CJ Johnson Date: 2021-12-09T17:41:12Z New Revision: a1968d5341d7b1ec7889955f230d0375548d165b URL: https://github.com/llvm/llvm-project/commit/a1968d5341d7b1ec7889955f230d0375548d165b DIFF: https://github.com/llvm/llvm-project/commit/a1968d5341d7b1ec7889955f230d0375548d165b.diff LOG:

[PATCH] D115452: Prevent abseil-cleanup-ctad check from stomping on surrounding context

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa1968d5341d7: Prevent abseil-cleanup-ctad check from stomping on surrounding context (authored by CJ-Johnson, committed by ymandel). Repository:

[PATCH] D114995: clang-tidy: improve the 'modernize-use-default-member-init'

malcolm.parsons added a comment. In D114995#3180475 , @aaron.ballman wrote: > was there a reason we didn't cover that case originally or was it an > oversight/left for future work? It was left for future work - by only considering the initializer list

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 added a comment. In D115346#3181198 , @dexonsmith wrote: > This looks really nice. > > One problem is that it's subtle to confirm whether it's thread-safe. The > local cache access parts of CachedFileSystemEntry lock-free, but the >

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 393187. glider added a comment. Fix a windows test failure: https://buildkite.com/llvm-project/premerge-checks/builds/69318#0b873cc6-bf07-482a-ac37-e960566ac8a3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115452: Prevent abseil-cleanup-ctad check from stomping on surrounding context

CJ-Johnson created this revision. CJ-Johnson added a reviewer: ymandel. Herald added a subscriber: carlosgalvezp. CJ-Johnson requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This change applies two fixes to the

[PATCH] D115438: [lldb] Remove unused lldb.cpp

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115438/new/ https://reviews.llvm.org/D115438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115442: [clangd] Provide documentation as MarkupContent in signaturehelp

kadircet added a comment. Also some related discussions in https://github.com/clangd/clangd/issues/945 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115442/new/ https://reviews.llvm.org/D115442 ___

[PATCH] D115153: clang/AMDGPU: Don't set implicit arg attribute to default size

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115153/new/ https://reviews.llvm.org/D115153 ___

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. Release build: Before this patch: text data bssdec hex 115471733 7987112 443760 123902605 7629a8d ./bin/clang After this patch: text data bssdec hex 117568981 7996376 443760

[clang] 4c7de4f - Thread safety analysis: Remove unused variable. NFC.

Author: Benjamin Kramer Date: 2021-12-09T18:57:43+01:00 New Revision: 4c7de4fbda03f38514c4aebed34dc2bbfb7e62a5 URL: https://github.com/llvm/llvm-project/commit/4c7de4fbda03f38514c4aebed34dc2bbfb7e62a5 DIFF:

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai added a comment. In D111617#3175167 , @craig.topper wrote: > In D111617#3060377 , @HsiangKai > wrote: > >> Although it reduces the header size, this patch will increase the binary >> size of clang.

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

craig.topper added a comment. Doesn’t icc also emit code into main to change the FPCW precision control field? Is making long double 80 bits useful if you don’t increase the precision in hardware? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

JonChesterfield added a comment. In D115283#3182879 , @yaxunl wrote: > In D115283#3181128 , > @JonChesterfield wrote: > >> Not exactly that. The weak symbol isn't the function name, as that gets >> renamed or

[PATCH] D115438: [lldb] Remove unused lldb.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf4f60507fd: [lldb] Remove unused lldb.cpp (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115438/new/

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Meinersbur added a comment. ping? @erichkeane Since you are pushing for upgrade the gcc/clang requirement as well, would you take care of that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 created this revision. momo5502 added reviewers: rnk, eugenis. momo5502 added a project: clang. momo5502 requested review of this revision. Herald added a subscriber: cfe-commits. TLS initializers, for example constructors of thread-local variables, don't necessarily get called. If for

[clang] 5882283 - [clang][deps] Use lock_guard instead of unique_lock

Author: Jan Svoboda Date: 2021-12-09T10:42:50+01:00 New Revision: 58822837cd53cdbe9c1b878c705b288f17a52f98 URL: https://github.com/llvm/llvm-project/commit/58822837cd53cdbe9c1b878c705b288f17a52f98 DIFF: https://github.com/llvm/llvm-project/commit/58822837cd53cdbe9c1b878c705b288f17a52f98.diff

[PATCH] D115332: [clang][deps] Use lock_guard instead of unique_lock

This revision was automatically updated to reflect the committed changes. Closed by commit rG58822837cd53: [clang][deps] Use lock_guard instead of unique_lock (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115332/new/

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

simon.giesecke added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6017 +/// cxxMethodDecl(isStatic()) matches A::foo() but not A::bar() +AST_MATCHER(CXXMethodDecl, isStatic) { return Node.isStatic(); } + aaron.ballman wrote: > I

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

skan added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-functions.c:42 __asm mov eax, k; - // CHECK: movl_k, %eax + // CHECK: movlk, %eax __asm mov eax, kptr; This change is strange here. Others looks good to me. Repository:

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

melver created this revision. melver added reviewers: jfb, pcc, glider. melver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `-ftrivial-auto-var-init=` is enabled, allocas unconditionally receive auto-initialization since [1]. In

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

glider added a comment. In D115440#3182585 , @melver wrote: > For completeness, also provide __builtin_alloca_with_align_uninitialized(). Please make sure to update the patch description. (You may have done already, but arc doesn't pull them

[clang] d0262c2 - [llvm] Add null-termination capability to SmallVectorMemoryBuffer

Author: Jan Svoboda Date: 2021-12-09T11:32:13+01:00 New Revision: d0262c2394f46bb7da2a75529413d625c70908e5 URL: https://github.com/llvm/llvm-project/commit/d0262c2394f46bb7da2a75529413d625c70908e5 DIFF: https://github.com/llvm/llvm-project/commit/d0262c2394f46bb7da2a75529413d625c70908e5.diff

[clang] 13a351e - [clang][deps] Use MemoryBuffer in minimizing FS

Author: Jan Svoboda Date: 2021-12-09T11:32:13+01:00 New Revision: 13a351e862ba3f443b31fac57863625a5c43e43b URL: https://github.com/llvm/llvm-project/commit/13a351e862ba3f443b31fac57863625a5c43e43b DIFF: https://github.com/llvm/llvm-project/commit/13a351e862ba3f443b31fac57863625a5c43e43b.diff

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Kindly ping. @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113237: [RISCV] Support I extension version 2.1

asb added a comment. In D113237#3172492 , @achieveartificialintelligence wrote: > In D113237#3124232 , @luismarques > wrote: > >> In D113237#3124188 , @luismarques >>

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

glider added a comment. I second this proposal. https://reviews.llvm.org/D60548 suggests to handle this case using a pragma, but the required change seems to be more intrusive. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3436 case Builtin::BI__builtin_alloca_with_align:

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe07195bb1f: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bfe0719 - [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

Author: Ties Stuij Date: 2021-12-09T13:37:52Z New Revision: bfe07195bb1f517b2809107098b91767ad8c9460 URL: https://github.com/llvm/llvm-project/commit/bfe07195bb1f517b2809107098b91767ad8c9460 DIFF: https://github.com/llvm/llvm-project/commit/bfe07195bb1f517b2809107098b91767ad8c9460.diff LOG:

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jyknight added a comment. This change seems like it's done in the wrong layer -- why do we add a special-case in Clang to emit "={r11},{r11}", instead of fixing LLVM to not break when given the previously-output "={r11},0"? Furthermore, since earlyclobber was exempted from this change, doesn't

Re: RFC: proposing to relax standardization requirements for Clang extensions

On Wed, Dec 8, 2021 at 3:48 PM Richard Smith wrote: > > On Tue, 7 Dec 2021 at 13:22, Aaron Ballman via cfe-commits > wrote: >> >> tl;dr: our Clang "get involved" page implies that proposed extensions >> to Clang must also be proposed to a standards committee >>

[PATCH] D115106: [clang-tidy] Fix `readability-static-accessed-through-instance` false negative for static methods

simon.giesecke added a comment. In D115106#3180439 , @aaron.ballman wrote: > In D115106#3172949 , > @simon.giesecke wrote: > >> Thanks a lot for addressing this issue! I am just trying it on our codebase. >>

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a73a1ac57f0: [clang-format] PR48916 PointerAlignment not working when using C++20 init… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2a73a1a - [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

Author: mydeveloperday Date: 2021-12-09T10:37:02Z New Revision: 2a73a1ac57f0b7f95d3e75ef8f3dafb174ef5ccc URL: https://github.com/llvm/llvm-project/commit/2a73a1ac57f0b7f95d3e75ef8f3dafb174ef5ccc DIFF: https://github.com/llvm/llvm-project/commit/2a73a1ac57f0b7f95d3e75ef8f3dafb174ef5ccc.diff

[clang-tools-extra] 5321900 - [clang][clangd] Desugar array type.

Author: lh123 Date: 2021-12-09T20:12:48+08:00 New Revision: 53219009aaebd2c26028c1df05550183a94c489c URL: https://github.com/llvm/llvm-project/commit/53219009aaebd2c26028c1df05550183a94c489c DIFF: https://github.com/llvm/llvm-project/commit/53219009aaebd2c26028c1df05550183a94c489c.diff LOG:

[PATCH] D115107: [clang][clangd] Desugar array type.

This revision was automatically updated to reflect the committed changes. Closed by commit rG53219009aaeb: [clang][clangd] Desugar array type. (authored by lh123). Changed prior to commit: https://reviews.llvm.org/D115107?vs=391884=393110#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113638: [xray] Add support for hexagon architecture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG543a9ad7c460: [xray] add support for hexagon (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 543a9ad - [xray] add support for hexagon

Author: Brian Cain Date: 2021-12-09T05:47:53-08:00 New Revision: 543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45 URL: https://github.com/llvm/llvm-project/commit/543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45 DIFF: https://github.com/llvm/llvm-project/commit/543a9ad7c460bb8d641b1b7c67bbc032c9bfdb45.diff

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

steffenlarsen added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { erichkeane wrote: > steffenlarsen wrote: > > erichkeane

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. Can you check the following example by applying this patch on fir-dev? program main integer :: i, N = 10 real :: x = 0 !$omp do schedule(static, 2) do i = 3, N x = x + i end do !$omp end do print *, x end Test running result:

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. I think it would be better to resent this when it is more complete. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 ___

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

melver updated this revision to Diff 393122. melver marked an inline comment as done. melver added a comment. For completeness, also provide __builtin_alloca_with_align_uninitialized(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115440/new/

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev updated this revision to Diff 393156. sgatev added a comment. Declare transferBlock in the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115235/new/ https://reviews.llvm.org/D115235 Files:

[PATCH] D113254: [clang] Fix a misadjusted path style comparison in a unittest

This revision was automatically updated to reflect the committed changes. Closed by commit rG120d44d1a00b: [clang] Fix a misadjusted path style comparison in a unittest (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 120d44d - [clang] Fix a misadjusted path style comparison in a unittest

Author: Martin Storsjö Date: 2021-12-09T11:47:43+02:00 New Revision: 120d44d1a00b12b79057420eb1d89277522348b1 URL: https://github.com/llvm/llvm-project/commit/120d44d1a00b12b79057420eb1d89277522348b1 DIFF:

[PATCH] D115331: [llvm] Add null-termination capability to SmallVectorMemoryBuffer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0262c2394f4: [llvm] Add null-termination capability to SmallVectorMemoryBuffer (authored by jansvoboda11). Changed prior to commit:

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

This revision was automatically updated to reflect the committed changes. Closed by commit rG13a351e862ba: [clang][deps] Use MemoryBuffer in minimizing FS (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/

[PATCH] D115438: [lldb] Remove unused lldb.cpp

hokein created this revision. hokein added a reviewer: labath. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb.cpp is unused after https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1

[PATCH] D114718: [analyzer] Implement a new checker for Strict Aliasing Rule.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StrictAliasingChecker.cpp:113 + QualType getOriginalType(CheckerContext , SVal V, QualType T) const { +assert(V.getAs() && "Location shall be a Loc."); +V =

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks good to me, and mirrors something I implemented in our downstream a few years ago. Please don't submit for another day or two to give others a chance to review.

[PATCH] D113254: [clang] Fix a misadjusted path style comparison in a unittest

mstorsjo added a comment. Yeah I guess I should have just committed this as trivial. Anyway, it doesn't seem to have had any notable impact on anything - luckily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113254/new/

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 393096. stuij added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D115250: switch to emulated TLV on macOS before 10.7

catap added a comment. I have a green light from build and this changes are ready for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115250/new/ https://reviews.llvm.org/D115250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { steffenlarsen wrote: > erichkeane wrote: > > steffenlarsen

[PATCH] D114439: [Annotation] Allow parameter pack expansions in annotate attribute

erichkeane added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:447 Actions.CorrectDelayedTyposInExpr(ParseAssignmentExpression())); + +if (Tok.is(tok::ellipsis)) { steffenlarsen wrote: > erichkeane wrote: > > steffenlarsen

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115225/new/ https://reviews.llvm.org/D115225 ___

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei created this revision. pengfei added reviewers: rnk, andrew.w.kaylor, erichkeane, craig.topper. Herald added a subscriber: hiraditya. pengfei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. MSVC currently doesn't

[PATCH] D115442: [clangd] Provide documentation as MarkupContent in signaturehelp

kadircet added a comment. I am thinking about a follow-up which will actually change `formatDocumentation` to return a `Markup::Document` instead to make sure we will have a single way of representing documents throughout features in future. But that's also what we store in the index, hence

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

junaire updated this revision to Diff 393142. junaire added a comment. Fix wrong code logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D115235: [clang][dataflow] Implement a basic algorithm for dataflow analysis

sgatev marked 4 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:31 +/// states of its predecessor basic blocks. +TypeErasedDataflowAnalysisState computeBlockInputState( +std::vector> ,

[PATCH] D112431: [ARM][clang] Define feature test macro for the PACBTI-M extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGe32b818db187: [ARM][clang] Define feature test macro for the PACBTI-M extension (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e32b818 - [ARM][clang] Define feature test macro for the PACBTI-M extension

Author: Ties Stuij Date: 2021-12-09T10:39:06Z New Revision: e32b818db187a6519ee5eba47e8d7dae1d58a723 URL: https://github.com/llvm/llvm-project/commit/e32b818db187a6519ee5eba47e8d7dae1d58a723 DIFF: https://github.com/llvm/llvm-project/commit/e32b818db187a6519ee5eba47e8d7dae1d58a723.diff LOG:

[PATCH] D115225: [X86][MS-InlineAsm] Make the constraint *m to be simple place holder

pengfei added inline comments. Comment at: clang/test/CodeGen/ms-inline-asm-functions.c:42 __asm mov eax, k; - // CHECK: movl_k, %eax + // CHECK: movlk, %eax __asm mov eax, kptr; skan wrote: > This change is strange here. Others looks good to me.

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

jeroen.dobbelaere added a comment. When I try out the example on llvm-13, I get a 'omnipotent char' tbaa description. That should be ok in general. When I replace the 'float _Complex' with 'double', I do get the 'double' tbaa. That might be a better example for the testcase ? CHANGES SINCE

[PATCH] D115346: [clang][deps] Squash caches for original and minimized files

jansvoboda11 updated this revision to Diff 393159. jansvoboda11 added a comment. Introduce `EntryRef`, handle delayed minimization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115346/new/ https://reviews.llvm.org/D115346 Files:

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

vitalybuka added a comment. > I still don't see a need for them to be updated in lock step, especially for > Visual Studio which tends to be quite different from other toolchains, but I > can see the use of the bumps occurring within the same release version of > llvm if its feasible. It's

[PATCH] D115283: [AMDGPU] Set "amdgpu_hostcall" module flag if an AMDGPU function has calls to device lib functions that use hostcalls.

dfukalov added inline comments. Comment at: clang/test/CodeGenHIP/amdgpu_hostcall.cpp:2-6 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -DFN_HOSTCALL \ +// RUN: -o - %s | FileCheck --enable-var-scope %s + +// RUN: %clang_cc1 -triple

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 393278. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel updated this revision to Diff 393221. ymandel marked 2 inline comments as done. ymandel added a comment. rebasing onto latest version of parent patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 393226. mbenfield added a comment. Remove late parsing. Switch dyn_cast to cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 Files:

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

momo5502 updated this revision to Diff 393247. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115456/new/ https://reviews.llvm.org/D115456 Files: clang/lib/CodeGen/MicrosoftCXXABI.cpp clang/test/CodeGenCXX/ms-thread_local.cpp Index: clang/test/CodeGenCXX/ms-thread_local.cpp

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

logan-5 updated this revision to Diff 393262. logan-5 added a comment. Removed `.flush()`es. Seems like this might be able to land without https://reviews.llvm.org/D115421? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115374/new/

[PATCH] D115440: Provide __builtin_alloca*_uninitialized variants

melver abandoned this revision. melver added a comment. GCC devs say that initializing explicit alloca() is a bug, because they aren't "automatic storage": https://lkml.kernel.org/r/20211209201616.gu...@gate.crashing.org .. which is also the reason why GCC's behaviour differs here at the

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel updated this revision to Diff 393218. ymandel added a comment. responding to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files:

[PATCH] D114564: Fix the use of -fno-approx-func along with -Ofast or -ffast-math

masoud.ataei added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2760 case options::OPT_fno_honor_nans: HonorNaNs = false;break; case options::OPT_fapprox_func: ApproxFunc = true;break; case

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:145 + if ((!ReceivingCallExpr || + ReceivingCallExpr->getDirectCallee()->isTemplateInstantiation()) && + (!ReceivingConstructExpr ||

[PATCH] D115379: ASTMatchers: Avoid using SmallVector::set_size()

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115379/new/ https://reviews.llvm.org/D115379

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith added a comment. Returning from https://reviews.llvm.org/D115421, it looks like that `raw_string_ostream` has unbuffered by default since 65b13610a5226b84889b923bae884ba395ad084d . Seems like all the new

[PATCH] D115374: [NFC][clang] Return std::strings built from raw_string_ostreams more efficiently

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D115374#3183776 , @logan-5 wrote: > Removed `.flush()`es. Seems like this might be able to land without >

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

ymandel marked 2 inline comments as done. ymandel added a comment. Thanks for the great comments and the fast response time! Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:134 + +transferBlock( +BlockStates, *Block, Env, Analysis,

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/SortIncludesTest.cpp:1162 + "test.cxx", 0)); +} + You should add a `#undef X`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115168/new/

[PATCH] D115386: AST: Avoid using SmallVector::set_size() in UnresolvedSet

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good. Comment at: clang/lib/Sema/SemaLookup.cpp:623 - Decls.set_size(N); + Decls.truncate(N); dexonsmith wrote: > Two things to confirm

[PATCH] D115168: [clang-format] [PR49298] Sort includes pass will sort inside raw strings

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2590 + llvm::Regex RawStringRegex( + "R\"([A-Za-z0-9_{}#<>%:;.?*+/^&\\$|~!=,'\\-]*)\\("); + SmallVector RawStringMatches; MyDeveloperDay wrote: > curdeius wrote: > > I'm picky but you

  1   2   >