[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 394353. Anastasia added a comment. Addressed review comments from Sven: - Improved docs and code comments; - Simplified tests; - Added warning in a group. - Aligned with translator PRs after merge. Note, that this change now references documentation from

[PATCH] D113622: [wip] [analyzer] support ignoring use-after-free checking with reference_counted attribute

chrisdangelo updated this revision to Diff 394374. chrisdangelo added a comment. Herald added a subscriber: jdoerfert. This change adds support for reference_counted attribute in pragma-attribute-supported-attributes-list. This change edits comments describing function signatures for

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

aaron.ballman added a comment. Thanks for the fix for this -- I think the changes look like they're correct, but the test coverage needs a bit of work. Comment at: clang/lib/Sema/SemaDecl.cpp:9191 << FixItHint::CreateInsertion(InsertLoc, "<>"); +

[clang] 09a704c - [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO.

Author: Mingming Liu Date: 2021-12-14T20:18:04Z New Revision: 09a704c5efba2c07af5b457bf3afc5eb746f22c2 URL: https://github.com/llvm/llvm-project/commit/09a704c5efba2c07af5b457bf3afc5eb746f22c2 DIFF: https://github.com/llvm/llvm-project/commit/09a704c5efba2c07af5b457bf3afc5eb746f22c2.diff LOG:

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09a704c5efba: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO. (authored by luna). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394351. ychen added a comment. - Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115751/new/ https://reviews.llvm.org/D115751 ___ cfe-commits mailing list

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl added a comment. In D115661#3192983 , @estewart08 wrote: > In D115661#3190477 , @yaxunl wrote: > >> This may cause perf regressions for HIP. > > Do you have a test that would show such a regression?

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true;

[PATCH] D115685: [NFC] Fix typos in release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd106a89172: [NFC] Fix typos in release notes. (authored by STL_MSFT). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8bd106a - [NFC] Fix typos in release notes.

Author: Stephan T. Lavavej Date: 2021-12-14T14:19:42-08:00 New Revision: 8bd106a891726f6542c9364ff4041764a62aa2b7 URL: https://github.com/llvm/llvm-project/commit/8bd106a891726f6542c9364ff4041764a62aa2b7 DIFF:

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

yaxunl added a comment. In D115661#3193157 , @arsenm wrote: > In D115661#3193152 , @yaxunl wrote: > >> In D115661#3192983 , @estewart08 >> wrote: >> >>> In

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

jbcoe added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true; I

[PATCH] D115661: [clang][amdgpu] - Choose when to promote VarDecl to address space 4.

arsenm added a comment. In D115661#3193431 , @yaxunl wrote: > What about situations of a derived pointer to the global variable? For example > > const int a[100] ; > > foo([50]); > > If we put a in addr space 4, it is easy to deduce [50] is

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3192840 , @dblaikie wrote: > Thanks for the data - looks good to me. Maybe include some of that data > (summary of total binary size change/total debug info size change - and if > you could include the flags (was this

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

owenpan added a reviewer: owenpan. owenpan added a comment. Can you add a test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769 ___ cfe-commits mailing

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394461. luna added a comment. Simplify filecheck by re-using one prefix to test the unreachable bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648 Files:

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:16 + +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1 + I think it can be shared with the equivalent checks in

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna marked an inline comment as done. luna added a comment. thanks for the inputs! Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:16 + +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1 +

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114394: Compile-time computation of string attribute hashes

rnk added a comment. That's interesting, somehow clang spends 1% of its time for sqlite3 in attribute lookup. I wonder how we ended up doing so much string-based attribute lookup. These were not really ever intended to be used for anything semantically interesting for the middle end, they were

[clang-tools-extra] 6917f87 - [clangd] Cleanup unneeded use of shared_ptr. NFC

Author: Sam McCall Date: 2021-12-15T02:13:50+01:00 New Revision: 6917f87b3c7c3ea927f8834302a5e9c82fc40a9b URL: https://github.com/llvm/llvm-project/commit/6917f87b3c7c3ea927f8834302a5e9c82fc40a9b DIFF: https://github.com/llvm/llvm-project/commit/6917f87b3c7c3ea927f8834302a5e9c82fc40a9b.diff

[clang] 4706a29 - Avoid setting tbaa on the store of return type of call to inline assembler.

Author: Sindhu Chittireddy Date: 2021-12-14T17:40:33-08:00 New Revision: 4706a297fb9ebe6af91ee2c92e5eb196dc2785f7 URL: https://github.com/llvm/llvm-project/commit/4706a297fb9ebe6af91ee2c92e5eb196dc2785f7 DIFF:

[PATCH] D115320: Avoid setting tbaa information on store of return type of call to inline assember

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4706a297fb9e: Avoid setting tbaa on the store of return type of call to inline assembler. (authored by schittir). Repository: rG LLVM Github

[clang] b45ad73 - [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

Author: Nico Weber Date: 2021-12-14T21:44:56-05:00 New Revision: b45ad7363c306e17422401f318cc243cb9fd99d4 URL: https://github.com/llvm/llvm-project/commit/b45ad7363c306e17422401f318cc243cb9fd99d4 DIFF: https://github.com/llvm/llvm-project/commit/b45ad7363c306e17422401f318cc243cb9fd99d4.diff

[PATCH] D115751: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb45ad7363c30: [clang] Use usual lit pattern for CLANG_DEFAULT_PIE_ON_LINUX and LLVM_WITH_Z3 (authored by thakis). Herald added a project: clang.

Re: [PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

On Tue, Dec 14, 2021 at 6:17 PM Richard Smith - zygoloid via Phabricator < revi...@reviews.llvm.org> wrote: > rsmith added inline comments. > > > > Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 > +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > >

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

starsid planned changes to this revision. starsid added a comment. Thanks. I missed that in the comment thread. Will send back for review once ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53608/new/ https://reviews.llvm.org/D53608

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: llvm/test/tools/llvm-diff/callbr.ll:28-29 entry: - callbr void asm sideeffect "", "X,X,~{dirflag},~{fpsr},~{flags}"(i8* blockaddress(@foo, %t_no), i8* blockaddress(@foo,

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

Andrew-William-Smith created this revision. Andrew-William-Smith added reviewers: MyDeveloperDay, HazardyKnusperkeks, jbcoe. Andrew-William-Smith edited the summary of this revision. Andrew-William-Smith added a project: clang-format. Andrew-William-Smith retitled this revision from

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

rsmith added inline comments. Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml +// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394429. luna marked 2 inline comments as done. luna added a comment. Change test IR by removing irrelevant lines and using one prefix per FileCheck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with one more test simplification below. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:11 +; RUN: llvm-dis -o - %t-main.bc.0 | FileCheck

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:11 +; RUN: llvm-dis -o - %t-main.bc.0 | FileCheck %s --check-prefix=ENABLESPLITFLAG +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}} mustBeUnreachable: 1

[PATCH] D115778: [docs] Give the reason why the support for coroutine is partial

ChuanqiXu created this revision. ChuanqiXu added reviewers: aaron.ballman, jyknight. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. See https://lists.llvm.org/pipermail/cfe-dev/2021-December/069608.html. We couldn't mark

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394443. luna marked an inline comment as done. luna added a comment. Simplify test by sharing one pattern across two filecheck lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 added a comment. In D115561#3189179 , @jdoerfert wrote: > All good but parser tests needed. Since we directly emit an error in Sema, I'm not sure if we can do the same thing as `clang/test/OpenMP/atomic_ast_print.cpp` because we can

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2007 +if (FormatTok->is(tok::l_brace)) { + if (Style.isCSharp() && Style.BraceWrapping.AfterFunction == true) { +FormatTok->MustBreakBefore = true;

[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC

nickdesaulniers updated this revision to Diff 394403. nickdesaulniers added a comment. - rebase onto D115688 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115410/new/ https://reviews.llvm.org/D115410 Files:

[PATCH] D115471: [clang] number labels in asm goto strings after tied inputs

nickdesaulniers updated this revision to Diff 394415. nickdesaulniers added a comment. - rebase onto D115688 +D115410 +D115311 , add notes to clang/docs/LanguageExtensions.rst Repository:

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna added a comment. thanks for review! Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:64 +; Check that EnableSplitLTOUnit is off, and check the content of summary information. +; RUN: llvm-dis -o - %t3.o | FileCheck %s

[PATCH] D115692: [docs] Mark the support for coroutine as unreleased

ChuanqiXu added a comment. According to https://lists.llvm.org/pipermail/cfe-dev/2021-December/069607.html, it might be the time to mark it as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115692/new/ https://reviews.llvm.org/D115692

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:11 +; RUN: llvm-dis -o - %t-main.bc.0 | FileCheck %s --check-prefix=ENABLESPLITFLAG +; ENABLESPLITFLAG: gv: (name: "_ZN4BaseD0Ev", {{.*}}, funcFlags: ({{.*}}

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna marked an inline comment as done. luna added a comment. thanks for review! Also in the previous reply, I forgot to mention I removed the the line `assert ((VTP.FuncVI) && "VTP.FuncVI must be nullptr` after finding existing references doesn't guarantee that [1], and

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 added a comment. In D115561#3190243 , @mikerice wrote: > Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp > for the new clause or the flang build will fail. > > CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare)

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:230 +// RUN: | FileCheck --check-prefix=CHECK-V-MINVLEN %s +// CHECK-V-MINVLEN: __riscv_v_min_vlen 128 frasercrmck wrote: > Are we able to test non-default values of

[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. In D115409#3190589 , @jyknight wrote: > OK, I do think that special case definitely needs to be deleted. It's > assuming that the block args are in a particular place in the

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

tejohnson added inline comments. Comment at: llvm/test/ThinLTO/X86/devirt_after_filtering_unreachable.ll:64 +; Check that EnableSplitLTOUnit is off, and check the content of summary information. +; RUN: llvm-dis -o - %t3.o | FileCheck %s --check-prefix=NOENABLESPLITFLAG +;

[PATCH] D115311: [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

nickdesaulniers updated this revision to Diff 394406. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - rebase onto D115688 + D115410 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115648: [LTO] Ignore unreachable virtual functions in WPD in thin LTO

luna updated this revision to Diff 394435. luna added a comment. Simplify test by using non-DAG prefix (for one pattern), and avoid capturing values since they are not used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394454. eopXD marked 3 inline comments as done. eopXD added a comment. Rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

linjamaki added a comment. Thanks, @tra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110618/new/ https://reviews.llvm.org/D110618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

pengfei added a comment. > GCC doesn't align fp80 long double to 16 bytes on i686, so I see no reason > for LLVM to do it. Is there some other compiler that you need ABI > compatibility with? Yes. ICC aligns long double to 16 bytes on 32bit Windows. (I mentioned it in the summary :). In

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 394471. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp

<    1   2