[PATCH] D114706: [analyzer] Fix sensitive argument logic in GenericTaintChecker

martong added a comment. > The semantics of taint sinks is that if ANY of the arguments is tainted, a > warning should be emmitted. Before this change, if there were multiple > arguments that are sensitive, and if the first arg is not tainted, but any of > the noninitial are tainted, a warning is

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

andmis added a comment. The current behavior when `ColumnLimit: 0` and `JavaScriptWrapImports: false` formats this: import {aaa} from "abc"; import {aaa, bbb, ccc} from "def"; import {aaa, bbb} from "defghi"; import {aaa, long, ccc,} from "ghi"; import { aaa,

[PATCH] D116059: [Clang][CFG] check children statements of asm goto

nathanchance added a comment. The two false positive warnings in the kernel are fixed with this patch and there were no new warnings introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116059/new/ https://reviews.llvm.org/D116059

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 marked 2 inline comments as done. zero9178 added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:4345 + return; } } Quuxplusone wrote: > It seems like this code is overdue for a "compare these two corrections" > //predicate//.

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 updated this revision to Diff 398151. zero9178 added a comment. Utilize operator< of std::pair to simplify the comparison A LOT, simplify using llvm::find_if and add additional test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116775/new/

[PATCH] D113676: [clang][lex] Fix search path usage remark with modules

jansvoboda11 updated this revision to Diff 398146. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113676/new/ https://reviews.llvm.org/D113676 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

asoffer added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCodeBuilders.cpp:73 + cxxRecordDecl(hasAnyName("::std::unique_ptr", "::std::shared_ptr")); + const auto QuacksLikeASmartPointer = cxxRecordDecl( +

[clang-tools-extra] e56a9c9 - Remove redundant return statements (NFC)

Author: Kazu Hirata Date: 2022-01-07T07:42:35-08:00 New Revision: e56a9c9b5b83923b8ed7b21994e6f9f11166aae0 URL: https://github.com/llvm/llvm-project/commit/e56a9c9b5b83923b8ed7b21994e6f9f11166aae0 DIFF: https://github.com/llvm/llvm-project/commit/e56a9c9b5b83923b8ed7b21994e6f9f11166aae0.diff

[PATCH] D116509: [Builtins] Add missing the macro 'y' description in comments

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM, thanks! Nit: perhaps make the commit message a little bit clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116509/new/

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/Format/FormatTest.cpp:23171 + verifyFormat("struct Z : X {};", Style); + verifyFormat("template struct X {};", Style); +}

[PATCH] D115429: [Clang] Implement the rest of __builtin_elementwise_* functions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2ed9f3f44d0: [Clang] Implement the rest of __builtin_elementwise_* functions. (authored by junaire, committed by fhahn). Repository: rG LLVM

[clang] b2ed9f3 - [Clang] Implement the rest of __builtin_elementwise_* functions.

Author: Jun Zhang Date: 2022-01-07T15:11:36Z New Revision: b2ed9f3f44d084bf2aae0af1b84f76a68a7c477b URL: https://github.com/llvm/llvm-project/commit/b2ed9f3f44d084bf2aae0af1b84f76a68a7c477b DIFF: https://github.com/llvm/llvm-project/commit/b2ed9f3f44d084bf2aae0af1b84f76a68a7c477b.diff LOG:

[PATCH] D116750: [clang][lex] Keep search directory indices up-to-date

jansvoboda11 updated this revision to Diff 398135. jansvoboda11 added a comment. Use pointers instead of indices to identify `DirectoryLookup` objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116750/new/ https://reviews.llvm.org/D116750

[clang] 4681ae9 - [clang-format] Use range-for loops. NFC.

Author: Marek Kurdej Date: 2022-01-07T16:06:11+01:00 New Revision: 4681ae9353ed89d28a95f4d07e8050f8772ae724 URL: https://github.com/llvm/llvm-project/commit/4681ae9353ed89d28a95f4d07e8050f8772ae724 DIFF: https://github.com/llvm/llvm-project/commit/4681ae9353ed89d28a95f4d07e8050f8772ae724.diff

[PATCH] D116764: [clang][OpenMP5.1] Initial parsing/sema for 'indirect' clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang/lib/Parse/ParseOpenMP.cpp:1844 + if (!IsDeviceTypeClause && !IsIndirectClause && + DTCI.Kind == OMPD_begin_declare_target) {

[PATCH] D116755: Revert "[CodeGen] Mark fma as const for Android"

alxu added a comment. I don't have commit access; can someone commit this for me? Please use author "Alex Xu (Hello71) ". Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116755/new/ https://reviews.llvm.org/D116755

[PATCH] D116337: [clang] set __NO_MATH_ERRNO__ if -fno-math-errno

alxu added a comment. I don't have commit access; can someone commit this for me? Please use author "Alex Xu (Hello71) ". Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116337/new/ https://reviews.llvm.org/D116337 ___ cfe-commits

[PATCH] D116721: [Tooling] When transferring compile commands between files, always use '--'

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116721/new/ https://reviews.llvm.org/D116721

[PATCH] D116792: [AST] lookup in parent DeclContext for transparent DeclContext

erichkeane added a comment. I had to do something similar for this at one point: https://github.com/llvm/llvm-project/commit/90010c2e1d60c6a9a4a0b30a113d4dae2b7214eb I seem to remember hitting this assert, and from my end, I think I decided even calling 'lookup' with the linkage spec to be a

[PATCH] D116806: [clang-format] Ensure we can correctly parse lambda in the template argument list

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, JohelEGP. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/46505 The presence of a lambda in an

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei updated this revision to Diff 398123. pengfei added a comment. Structure the layout spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 Files: clang/lib/Basic/Targets/X86.h

[PATCH] D116699: [clangd] Polish clangd/inlayHints and expose them by default.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG7c19fdd59939: [clangd] Polish clangd/inlayHints and expose them by default. (authored by sammccall). Changed prior to commit:

[clang-tools-extra] 7c19fdd - [clangd] Polish clangd/inlayHints and expose them by default.

Author: Sam McCall Date: 2022-01-07T15:12:43+01:00 New Revision: 7c19fdd59939249c23384f0900d49aab4a5f0695 URL: https://github.com/llvm/llvm-project/commit/7c19fdd59939249c23384f0900d49aab4a5f0695 DIFF: https://github.com/llvm/llvm-project/commit/7c19fdd59939249c23384f0900d49aab4a5f0695.diff

[PATCH] D116699: [clangd] Polish clangd/inlayHints and expose them by default.

sammccall marked 5 inline comments as done. sammccall added a comment. In D116699#3227203 , @kadircet wrote: > thanks this LGTM just a couple nits. > my biggest concern is old endpoint will vanish all of a sudden and it might > create some confusion,

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 398115. simoll added a comment. Rebased onto vector conditionals changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: clang/docs/LanguageExtensions.rst

[PATCH] D116750: [clang][lex] Keep search directory indices up-to-date

jansvoboda11 added a comment. Yeah, in some cases, we'd be just replacing the index-based indirection with address-based indirection (e.g. when working with `SearchDirToHSEntry`). However, most existing `HeaderSearch` algorithms already work with the index and use that to get the

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG thank you! Keeping/removing the getRParenLoc() accessor is up to you, I see arguments both ways. Comment at: clang/include/clang/AST/TypeLoc.h:2001 +// FIXME: add

[PATCH] D116774: AST: Move __va_list tag to the top level on ARM architectures.

jrtc27 added a comment. The fact that va_list is in the std namespace does leak out into __builtin_dump_struct, possibly the odd other place, and of course to AST consumers. I think it'd make sense to keep ASTContext as putting it in the std namespace for C++ (like it does for Arm, and used

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. Ah, in that case it makes sense as-is. I just assumed they lived in the same library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 added a comment. In D116751#3227243 , @ahoppen wrote: > I just want to make sure that we don’t accidentally introduce a new > instantiation of a `Module` that doesn’t go through `makeModule` in the > future. I understand that, but I'm not

[PATCH] D116750: [clang][lex] Keep search directory indices up-to-date

ahoppen added a comment. I would prefer to use `std::shared_ptr` instead of `unsigned`. IIUC we already basically have a level of indirection because if we want to get the `DirectoryLookup`, we need to find it by its index in `SearchDirs`. And updating the indices just seems like a hack to me

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

ahoppen added a comment. I just want to make sure that we don’t accidentally introduce a new instantiation of a `Module` that doesn’t go through `makeModule` in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116751/new/

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. Reverted for the moment in rG3aec4b3d348d69e6c1ead7cba54677b855293983 while we fix the windows tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/

[PATCH] D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants

aaron.ballman added a comment. In D116386#3226174 , @LegalizeAdulthood wrote: > Aaron, I think your comments are useful and I would be inclined to agree with > you if I > was the original author of this check. Sorry, I hope I didn't give the

[clang] 3aec4b3 - Revert "Unaligned Access Warning Added"

Author: Archibald Elliott Date: 2022-01-07T13:07:30Z New Revision: 3aec4b3d348d69e6c1ead7cba54677b855293983 URL: https://github.com/llvm/llvm-project/commit/3aec4b3d348d69e6c1ead7cba54677b855293983 DIFF: https://github.com/llvm/llvm-project/commit/3aec4b3d348d69e6c1ead7cba54677b855293983.diff

[PATCH] D116699: [clangd] Polish clangd/inlayHints and expose them by default.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks this LGTM just a couple nits. my biggest concern is old endpoint will vanish all of a sudden and it might create some confusion, especially for editors that turn on inlayhints

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

sammccall added a comment. In D116793#3227175 , @hokein wrote: >> (BTW the parsing part of this is probably adjacent to a fix for >> https://github.com/clangd/clangd/issues/121, AutoType also doesn't have >> enough locations for decltype(auto). But

[PATCH] D116750: [clang][lex] Keep search directory indices up-to-date

jansvoboda11 added a comment. In D116750#3227143 , @ahoppen wrote: > Adjusting the indices seem pretty fragile to me. Any reason why you wanted to > stick with indices as keys instead of switching to something else like I > suggested here

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

jansvoboda11 added a comment. In D116751#3227142 , @ahoppen wrote: > I suppose the idea is that all `Module` creations should go through > `makeModule`, right? In that case I think we should either > > - make the `Module` constructor private and

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

hokein added a comment. > (BTW the parsing part of this is probably adjacent to a fix for > https://github.com/clangd/clangd/issues/121, AutoType also doesn't have > enough locations for decltype(auto). But definitely not something to touch in > this patch) Yeah, that is my next step, this is

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

hokein updated this revision to Diff 398101. hokein added a comment. don't expose LParen loc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116793/new/ https://reviews.llvm.org/D116793 Files: clang-tools-extra/clangd/Selection.cpp

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

thakis added a comment. Thanks for the patch! 1. When committing code, please add "Differential Revision: https://reviews.llvm.org/D116221; as last line to your commit description, to link the commit to the review. See `git log` for many examples. 2. This breaks tests on Windows, see e.g.

[PATCH] D116750: [clang][lex] Keep search directory indices up-to-date

ahoppen added a comment. Adjusting the indices seem pretty fragile to me. Any reason why you wanted to stick with indices as keys instead of switching to something else like I suggested here ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116751: [clang][lex] NFC: Extract module creation into function

ahoppen added a comment. I suppose the idea is that all `Module` creations should go through `makeModule`, right? In that case I think we should either - make the `Module` constructor private and `ModuleMap` a friend of `Module` - or at least add a doc comment to the `Module` constructor that

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

hans added a comment. Cool! I'd suggesting adding a note to llvm/docs/ReleaseNotes.rst at the same time :-) Comment at: clang/include/clang/Basic/CodeGenOptions.def:142 +CODEGENOPT(HotPatch, 1, 0) ///< Supports the Microsoft /HOTPATCH flag and would +

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

owenpan added a comment. Moving the handling of empty record blocks might be NFC? Maybe option 4 for now and the refactoring in another patch? Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:288 +// Try to merge a control statement block with left brace unwrapped.

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks added a comment. In D115060#3224176 , @owenpan wrote: >> But I suspect it is the Assignment of the `PreviousLine` since this is not >> existent every time. > > Yep! > >> So I see the following solutions: >> >> 1. Only name `NextLine`,

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. This caused some driver test failures. They have been fixed in https://reviews.llvm.org/rG11c67e5a4e99f51ec66c9781710f81955cfd5e24 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221

[clang] 11c67e5 - [clang][driver] Don't pass -Wunaligned-access to cc1as

Author: Archibald Elliott Date: 2022-01-07T10:45:26Z New Revision: 11c67e5a4e99f51ec66c9781710f81955cfd5e24 URL: https://github.com/llvm/llvm-project/commit/11c67e5a4e99f51ec66c9781710f81955cfd5e24 DIFF: https://github.com/llvm/llvm-project/commit/11c67e5a4e99f51ec66c9781710f81955cfd5e24.diff

[clang] 359b4e6 - [clang-format] Use prefix increment and decrement. NFC.

Author: Marek Kurdej Date: 2022-01-07T11:19:53+01:00 New Revision: 359b4e6cdb7ae60c51e33ce71443843b71cb643d URL: https://github.com/llvm/llvm-project/commit/359b4e6cdb7ae60c51e33ce71443843b71cb643d DIFF: https://github.com/llvm/llvm-project/commit/359b4e6cdb7ae60c51e33ce71443843b71cb643d.diff

[PATCH] D116085: [clang-tidy] Performance improvements for NOLINTBEGIN/END blocks

salman-javed-nz updated this revision to Diff 398087. salman-javed-nz added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116085/new/ https://reviews.llvm.org/D116085 Files: clang-tools-extra/clang-tidy/CMakeLists.txt

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

MTC added subscribers: flx, MTC. MTC added a comment. FYI: I'm from Bytedance Inc , @Sockke, and I are fixing the AutoFix bugs recently, most of them will lead to the compilation error. For this bug, fixing the override virtual methods but missing the pure

[clang] 2cd2600 - Unaligned Access Warning Added

Author: Mubashar Ahmad Date: 2022-01-07T09:54:20Z New Revision: 2cd2600abaf3c604889b77ab408fdf89d7a21c48 URL: https://github.com/llvm/llvm-project/commit/2cd2600abaf3c604889b77ab408fdf89d7a21c48 DIFF: https://github.com/llvm/llvm-project/commit/2cd2600abaf3c604889b77ab408fdf89d7a21c48.diff

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. In D115942#3226146 , @rnk wrote: > Yeah, let's try to reach some resolution on that. The things are different. We don't support f80 type on Windows 32 bits previously. It means we don't have the burden to upgrade, since there's

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

MyDeveloperDay added a comment. > applies just as well to the proposal of force-wrapping at >= 2 imports Absolutely.. but it justifies that this option has got to the point that its no longer one thing or the other based on our personal subjective opinions... now we need to break down what we

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

salman-javed-nz added a comment. In D116378#3226780 , @carlosgalvezp wrote: > By the way, the similar problem exists in Clang compiler. I have written in > cfe-dev , > Discourse >

[clang] c033f0d - [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

Author: Egor Zhdan Date: 2022-01-07T10:41:45+01:00 New Revision: c033f0d9b1c7816b0488a939475d48a100e4dcab URL: https://github.com/llvm/llvm-project/commit/c033f0d9b1c7816b0488a939475d48a100e4dcab DIFF: https://github.com/llvm/llvm-project/commit/c033f0d9b1c7816b0488a939475d48a100e4dcab.diff

[PATCH] D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc033f0d9b1c7: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument (authored by egorzhdan, committed by jansvoboda11).

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei added a comment. In D115942#3226101 , @craig.topper wrote: > Does this have the same autoupgrade issues as @efriedma raised in > https://reviews.llvm.org/D86310 No. The differences are that i128 can be generated by front end while f80 cannot

[PATCH] D116793: [AST] Add more source information for DecltypeTypeLoc.

sammccall added a comment. Thank you for digging into this! (BTW the parsing part of this is probably adjacent to a fix for https://github.com/clangd/clangd/issues/121, AutoType also doesn't have enough locations for `decltype(auto)`. But definitely not something to touch in this patch)

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/MoveConstArgCheck.cpp:161 + // Generate notes for an invocation with an rvalue reference parameter. + const auto *ReceivingCallExpr = dyn_cast(ReceivingExpr); + const auto

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke updated this revision to Diff 398077. Sockke marked an inline comment as done. Sockke added a comment. Add some checks for `null` and comments for codes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 Files:

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:435-454 +bool UnwrappedLineParser::precededByCommentOrPPDirective() const { + const size_t size = Lines.size(); + if (size > 0 && Lines[size - 1].InPPDirective) +return true; +#if 1 +

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

MTC added a comment. This patch has become very complicated now. I summarized this patch and give a figure to illustrate what we have reached. And @Sockke please add some comments to explain the complex part or other means to make this patch more readable. F21496057: D107450.svg

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

This revision was automatically updated to reflect the committed changes. Closed by commit rG91b9e6729c11: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks… (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D116767?vs=397987=398074#toc

[clang] 91b9e67 - [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

Author: Marek Kurdej Date: 2022-01-07T10:06:49+01:00 New Revision: 91b9e6729c11cce8cf5fea727c6cb81ab8ab5ba4 URL: https://github.com/llvm/llvm-project/commit/91b9e6729c11cce8cf5fea727c6cb81ab8ab5ba4 DIFF: https://github.com/llvm/llvm-project/commit/91b9e6729c11cce8cf5fea727c6cb81ab8ab5ba4.diff

[PATCH] D116795: [clang-format] Use range-for loops. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f355fe95f6: [clang-format] Use range-for loops. NFC. (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D116795?vs=398060=398071#toc Repository: rG LLVM Github Monorepo

[clang] 01f355f - [clang-format] Use range-for loops. NFC.

Author: Marek Kurdej Date: 2022-01-07T10:01:09+01:00 New Revision: 01f355fe95f6b45db8bb239239b7ed978e094a13 URL: https://github.com/llvm/llvm-project/commit/01f355fe95f6b45db8bb239239b7ed978e094a13 DIFF: https://github.com/llvm/llvm-project/commit/01f355fe95f6b45db8bb239239b7ed978e094a13.diff

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528 // for them (the one we know is missing are lambdas). -if (Style.BraceWrapping.AfterFunction) +if ((Style.Language == FormatStyle::LK_Java) && +

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528 // for them (the one we know is missing are lambdas). -if (Style.BraceWrapping.AfterFunction) +if ((Style.Language == FormatStyle::LK_Java) && +

[PATCH] D116795: [clang-format] Use range-for loops. NFC.

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/AffectedRangeManager.cpp:66 return true; } return false; Remove braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

curdeius added a comment. Thanks for the reviews! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528 // for them (the one we know is missing are lambdas). -if (Style.BraceWrapping.AfterFunction) +if ((Style.Language == FormatStyle::LK_Java) && +

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I agree performance of this if is unlikely to be a game changer performance wise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116318/new/ https://reviews.llvm.org/D116318

[PATCH] D116795: [clang-format] Use range-for loops. NFC.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM so much easier to read!! Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116795/new/

[PATCH] D116318: [clang-format][NFC] Fix a bug in getPreviousToken() in the parser

owenpan added a comment. In D116318#3212351 , @curdeius wrote: > I'm in the same position as @hazardyknusperkeks. > If you need something to simplify the code you can add a helper > `getPreviousTokenOrNull` or something like that in your patch. > But we

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116767/new/ https://reviews.llvm.org/D116767 ___ cfe-commits mailing list

[PATCH] D116795: [clang-format] Use range-for loops. NFC.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116795 Files:

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5475 + if (IndexVT.getVectorElementType() == MVT::i64 && XLenVT == MVT::i32) { +report_fatal_error("The V extension does not support EEW=64 for index " craig.topper

[PATCH] D116767: [clang-format] Fix `BraceWrapping: AfterFunction` affecting synchronized blocks in Java.

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM except for the nits. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1528 // for them (the one we know is missing are lambdas). -if

<    1   2