[PATCH] D117292: [Driver] Pass the flag -dI to cc1 invocation

qichaogu created this revision. qichaogu added a reviewer: cfe-commits. qichaogu requested review of this revision. Hook up the flag -dI in the driver to pass it to cc1 invocation. https://reviews.llvm.org/D117292 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D117294: [clangd] Better handling `\n` in the synthesized diagnostic message.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The newline-eof fix was rendered as

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder created this revision. tbaeder added reviewers: rsmith, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As part of P1766R1 , allow

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, rsmith. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Namely __builtin_alloca __builtin_alloca_with_align

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius updated this revision to Diff 399946. curdeius added a comment. Rebase to fix Windows CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117142/new/ https://reviews.llvm.org/D117142 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**RemoveBracesLLVM** (``Boolean``) :versionbadge:`clang-format 14` + Remove optional braces of control

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda created this revision. kda added a reviewer: vitalybuka. Herald added a subscriber: dang. kda requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Enable noundef analysis (-enable-noundef-analysis) via the

[PATCH] D116736: [Clang] Add __builtin_reduce_or and __builtin_reduce_and

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. In D116736#3242623 , @junaire wrote: >> @junaire did you already get commit access or should I commit this change on >> your behalf? > > Yeah, I

[PATCH] D117289: [clang-format] Fix namespace end comments fixer with anonymous namespaces.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG717cd16e85fa: [clang-format] Fix namespace end comments fixer with anonymous namespaces. (authored by curdeius). Repository: rG LLVM Github

[clang] 717cd16 - [clang-format] Fix namespace end comments fixer with anonymous namespaces.

Author: Marek Kurdej Date: 2022-01-14T11:41:14+01:00 New Revision: 717cd16e85faa6498cf6c46838241b0e7ddaaaba URL: https://github.com/llvm/llvm-project/commit/717cd16e85faa6498cf6c46838241b0e7ddaaaba DIFF: https://github.com/llvm/llvm-project/commit/717cd16e85faa6498cf6c46838241b0e7ddaaaba.diff

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

curdeius updated this revision to Diff 399945. curdeius added a comment. Minor clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117142/new/ https://reviews.llvm.org/D117142 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**RemoveBracesLLVM** (``Boolean``) :versionbadge:`clang-format 14` + Remove optional braces of control statements (``if``, ``else``, ``for``, curdeius wrote: > owenpan

[PATCH] D107450: [clang-tidy] Fix wrong FixIt in performance-move-const-arg

Sockke added a comment. Friendly ping. @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda updated this revision to Diff 399937. kda added a comment. add missing files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/ https://reviews.llvm.org/D117293 Files: clang/include/clang/Driver/Options.td

[PATCH] D117295: [clang][sema] Allow unnamed decls in C++20 module export{} blocks

tbaeder added a comment. Reading this again, it sounds like this is not expected to happen for C++20; I was using https://clang.llvm.org/cxx_status.html#cxx20 as guidance here. Repository: rG LLVM Github

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

owenpan added a comment. @MyDeveloperDay @curdeius I will land this patch if you have no more comments. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 ___ cfe-commits mailing list

[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

Sockke added a comment. Friendly ping. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116439/new/ https://reviews.llvm.org/D116439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue

Sockke added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NonConstParameterCheck.cpp:86-99 + // Data passed by nonconst reference should not be made const. + unsigned ArgNr = 0U; + if (const auto *CD = CE->getConstructor()) { +for

[PATCH] D117294: [clangd] Better handling `\n` in the synthesized diagnostic message.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:635 + if (Code == "\n") { +OS << "\\n"; +return; or "newline"? Repository: rG

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

hyeongyukim added a comment. @nathanchance Hi, I analyzed all four warnings. Warning #1: can be handled by x86-backend. filled issue #53118 Warning #2: bug in the kernel, fixed in the next version. Warning #3: same reason with #2 Warning #4:

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

MyDeveloperDay updated this revision to Diff 399922. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Make suggested improvements Add additional test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117197/new/ https://reviews.llvm.org/D117197

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius commandeered this revision. curdeius edited reviewers, added: aybassiouny; removed: curdeius. curdeius added a comment. This bug is not present in clang-format 13 (nor master), but was there in v12. I'll commandeer this revision to keep the regression tests. CHANGES SINCE LAST ACTION

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

This revision was automatically updated to reflect the committed changes. Closed by commit rGbba729af3ef8: [clang-check] Adjust argument adjusters for clang-check to strip options… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bba729a - [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

Author: Sam McCall Date: 2022-01-14T10:05:47+01:00 New Revision: bba729af3ef803c35c082417f89a1ac89462e22b URL: https://github.com/llvm/llvm-project/commit/bba729af3ef803c35c082417f89a1ac89462e22b DIFF: https://github.com/llvm/llvm-project/commit/bba729af3ef803c35c082417f89a1ac89462e22b.diff

[PATCH] D116329: [clang-check] Adjust argument adjusters for clang-check to strip options blocking the static analyzer

OikawaKirie added a comment. It seems that it is not committed on my behalf. Maybe you have forgotten to add me as the author? Sad : ( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116329/new/ https://reviews.llvm.org/D116329

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda updated this revision to Diff 399917. kda marked an inline comment as done. kda added a comment. rename file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116633/new/ https://reviews.llvm.org/D116633 Files:

[PATCH] D117289: [clang-format] Fix namespace end comments fixer with anonymous namespaces.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, a strange trailing comment was produced: namespace out {

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

tbaeder updated this revision to Diff 399925. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116595/new/ https://reviews.llvm.org/D116595 Files: clang/lib/Sema/SemaModule.cpp clang/test/Modules/cxx20-export-import.cpp Index: clang/test/Modules/cxx20-export-import.cpp

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng commandeered this revision. kito-cheng edited reviewers, added: HsiangKai; removed: kito-cheng. kito-cheng added a comment. @HsiangKai hand over this revision to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

curdeius updated this revision to Diff 399926. curdeius added a comment. Keep tests only. Clean up. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https://reviews.llvm.org/D99031 Files: clang/unittests/Format/FormatTest.cpp

[clang] a0458b5 - Add -fsanitize-address-param-retval to clang.

Author: Kevin Athey Date: 2022-01-14T00:41:28-08:00 New Revision: a0458b531cfc52fc1a93002f125b61842f6b30f7 URL: https://github.com/llvm/llvm-project/commit/a0458b531cfc52fc1a93002f125b61842f6b30f7 DIFF: https://github.com/llvm/llvm-project/commit/a0458b531cfc52fc1a93002f125b61842f6b30f7.diff

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa0458b531cfc: Add -fsanitize-address-param-retval to clang. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116750: [clang][lex] Keep references to `DirectoryLookup` objects up-to-date

jansvoboda11 reopened this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. I'll need to figure out how to efficiently replace the pointer arithmetic performed by `Preprocessor::LookupFile`, or go back to my first solution: keeping `std::vector` and

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3522 + if ((Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier()) || + (Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && + Right.is(TT_JsTypeOperator))

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:362 + MemorySanitizerOptions{TrackOrigins, Recover, CompileKernel, + CGOpts.SanitizeMemoryParamRetval != 0})); vitalybuka wrote: > we use implicit cast

[PATCH] D117289: [clang-format] Fix namespace end comments fixer with anonymous namespaces.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117289/new/ https://reviews.llvm.org/D117289

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117142/new/ https://reviews.llvm.org/D117142

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

tbaeder added inline comments. Comment at: clang/test/Modules/cxx20-export-import.cpp:1-2 + +// RUN: %clang_cc1 -std=c++20 -fmodules -fmodules-cache-path=%t -fimplicit-module-maps -I%S/Inputs -stdlib=libc++ -verify %s +export import dummy; // expected-error {{export declaration

[libunwind] 6e52bfe - Revert "[cmake] Use `GNUInstallDirs` to support custom installation dirs."

Author: John Ericson Date: 2022-01-15T07:35:02Z New Revision: 6e52bfe09d3ab3ae6c43c079d06ebeb7bb241dec URL: https://github.com/llvm/llvm-project/commit/6e52bfe09d3ab3ae6c43c079d06ebeb7bb241dec DIFF: https://github.com/llvm/llvm-project/commit/6e52bfe09d3ab3ae6c43c079d06ebeb7bb241dec.diff LOG:

[PATCH] D117388: [Driver][FreeBSD] -r: imply -nostdlib like GCC

MaskRay created this revision. MaskRay added a reviewer: dim. Herald added a subscriber: emaste. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D116843 . Repository: rG LLVM Github

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 400253. Ericson2314 added a comment. Try again, with more `include(GNUInstallDirs)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Found two more `include(GNUInstallDirs)` I should include which will hopefully fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Sorry about that. I think the issue was just one more `include(GNUInstallDirs)` for compiler-rt for the standalone build, but I am going to bed so just reverted for now to try again later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3522 + if ((Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier()) || + (Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && + Right.is(TT_JsTypeOperator))

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added inline comments. Comment at: clang/test/Driver/fsanitize-memory-param-retval.c:8-9 + +// RUN: %clang -target aarch64-linux-gnu -fsyntax-only %s -fsanitize=memory -fsanitize-memory-param-retval -c -### 2>&1 | FileCheck --check-prefix=11 %s +// 11:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3244233 , @aaron.ballman wrote: > The changes look good aside from the precommit CI failing. Can you > investigate? Absolutely, I'm already giving a look at it! :) Repository: rG LLVM Github Monorepo

[clang] 3d5b9fb - [OpenMP] Fix problems with the declare variant append_args clause

Author: Mike Rice Date: 2022-01-14T11:09:27-08:00 New Revision: 3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580 URL: https://github.com/llvm/llvm-project/commit/3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580 DIFF: https://github.com/llvm/llvm-project/commit/3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580.diff

[PATCH] D117172: [OpenMP] Fix problems with the declare variant append_args clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d5b9fb3e3cd: [OpenMP] Fix problems with the declare variant append_args clause (authored by mikerice). Herald added a project: clang. Herald added

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 400102. rmaz added a comment. Update VirtualFileSystemTest to validate relative root paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files:

[PATCH] D116174: [clang] support relative roots to vfs overlays

benlangmuir added a comment. Make sure the test failure gets fixed, but otherwise LGTM. > x64 debian > LLVM-Unit.Support/_/SupportTests::VFSFromYAMLTest.RelativePaths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. @rjmccall @pengfei @andrew.w.kaylor review please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400111. eopXD added a comment. Rebase to latest main. Resolve test case conflicts due to Zvamo removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[clang] 6ea3d9e - [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

Author: Marek Kurdej Date: 2022-01-14T21:47:16+01:00 New Revision: 6ea3d9efc53641d930e9176916ff09ca6f73aef2 URL: https://github.com/llvm/llvm-project/commit/6ea3d9efc53641d930e9176916ff09ca6f73aef2 DIFF: https://github.com/llvm/llvm-project/commit/6ea3d9efc53641d930e9176916ff09ca6f73aef2.diff

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea3d9efc536: [clang-format] Fix CompactNamespaces corner case when… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. In D117293#3244668 , @kda wrote: > In D117293#3243735 , @vitalybuka > wrote: > >> Nice! >> This completes the work found in: >> >> It's too late for this set of patches, but

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

bmahjour added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/PowerPC/optimal-epilog-vectorization.ll:273-276 -; VF-TWO-CHECK-DAG: [[LOOPID_MV]] = distinct !{[[LOOPID_MV]], [[LOOPID_DISABLE_VECT:!.*]]} -; VF-TWO-CHECK-DAG: [[LOOPID_EV]] = distinct

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:90 void VisitDeclStmt(const DeclStmt *S) { -// FIXME: Add support for group decls, e.g: `int a, b;` -if (S->isSingleDecl()) { - if (const auto *D =

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a subscriber: nickdesaulniers. nathanchance added a comment. In D105169#3242949 , @hyeongyukim wrote: > @nathanchance Hi, I analyzed all four warnings. Thanks a lot for doing this! > Warning #1: can be handled by x86-backend. filled

[clang] 6cacd42 - Document several clang-supported builtins

Author: serge-sans-paille Date: 2022-01-14T22:03:56+01:00 New Revision: 6cacd420a1d72bca7809e6b516fb1e18ac6056c8 URL: https://github.com/llvm/llvm-project/commit/6cacd420a1d72bca7809e6b516fb1e18ac6056c8 DIFF:

[PATCH] D117296: Document several clang-supported builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cacd420a1d7: Document several clang-supported builtins (authored by serge-sans-paille). Changed prior to commit:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. The warning would be correct if the compiler could actually tell the parameter is unused, but at the moment it cannot, as far as I know. I stumbled upon this thing myself, and there are a few ways to silence the warning: -removing names -marking every

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D114235#3243429 , @mboehme wrote: > Thanks for the feedback! And no worries about the delay -- I know you've got > a lot on your

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think the test behavior is pretty mysterious and there's likely some other bug happening, but this is incremental progress and definitely fixes an issue, so LGTM!

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman created this revision. arphaman added reviewers: ravikandhadai, egorzhdan, aaron.ballman, rsmith. Herald added subscribers: ributzka, kristof.beyls, mgorny. arphaman requested review of this revision. Recently we observed high memory pressure caused by clang during some parallel builds.

[PATCH] D117296: Document several clang-supported builtins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit with duplicate punctuation. Comment at: clang/docs/LanguageExtensions.rst:2653 +data is going to be reused a lot once in cache.

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. In D117293#3243772 , @vitalybuka wrote: > Just noticed, -enable-noundef-analysis is missing tests undef > llvm/llvm-project/clang/test/Driver/ > Can you add few near maybe before >

[PATCH] D117296: Document several clang-supported builtins

aaron.ballman added a comment. Thanks for this new documentation! I'm by no means an expert in these builtins, so I had some questions on places we might want to expand things a bit more. Comment at: clang/docs/LanguageExtensions.rst:2183 +n *

[PATCH] D117309: [clang] NFC: Remove unused `DirectoryLookup`

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117309/new/ https://reviews.llvm.org/D117309

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:290-292 +// Do not warn on naked functions. +[[gnu::naked]] int nakedFunction(int a, float b, const char *c) { ; } +__attribute__((naked)) void nakedFunction(int

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3242274 , @fdwr wrote: >> I think no one just had thought about it. :) > > @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm > squeaking on behalf of a few stackoverflowers 

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

bmahjour added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/PowerPC/optimal-epilog-vectorization.ll:273-276 -; VF-TWO-CHECK-DAG: [[LOOPID_MV]] = distinct !{[[LOOPID_MV]], [[LOOPID_DISABLE_VECT:!.*]]} -; VF-TWO-CHECK-DAG: [[LOOPID_EV]] = distinct

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman added a comment. CI still seems unhappy: Failed Tests (1): Clang :: Sema/warn-unused-parameters.c Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:290-292 +// Do not warn on naked functions. +[[gnu::naked]] int

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

erichkeane added a comment. Right, yeah, so there are a couple of problems with AttributedType. First, it gets lost almost as soon as you get out of SemaType about 90% of the time. Anything that does some level of canonicalization ends up losing it, so the AttributedType information is lost

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. @Fznamznon @bader @Naghasan reviews please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[clang] 2bcba21 - [CPU-Dispatch] Make sure Dispatch names get updated if previously mangled

Author: Erich Keane Date: 2022-01-14T10:45:55-08:00 New Revision: 2bcba21c8ba95de866ed6333fa5cd29d5d232afe URL: https://github.com/llvm/llvm-project/commit/2bcba21c8ba95de866ed6333fa5cd29d5d232afe DIFF: https://github.com/llvm/llvm-project/commit/2bcba21c8ba95de866ed6333fa5cd29d5d232afe.diff

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 400078. MuAlphaOmegaEpsilon added a comment. Fix failing test by updating clang/test/Sema/warn-unused-parameters.c expected warnings amount Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7af11989be21: [clang-format] Fix short functions being considered as inline inside an… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7af1198 - [clang-format] Fix short functions being considered as inline inside an indented namespace.

Author: Marek Kurdej Date: 2022-01-14T21:57:02+01:00 New Revision: 7af11989be21df00ad6a510a831ea2425e48fa90 URL: https://github.com/llvm/llvm-project/commit/7af11989be21df00ad6a510a831ea2425e48fa90 DIFF: https://github.com/llvm/llvm-project/commit/7af11989be21df00ad6a510a831ea2425e48fa90.diff

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/CommentLexer.cpp:278 + +again: + size_t End = aaronpuchert wrote: > gribozavr2 wrote: > > I'd suggest refactoring to

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman added a comment. The changes look good aside from the precommit CI failing. Can you investigate? Comment at: clang/test/Sema/warn-unused-parameters.c:27-29 // CHECK-everything: 6 warnings generated // CHECK-everything-error: 5 errors generated //

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille updated this revision to Diff 400080. serge-sans-paille marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117296/new/ https://reviews.llvm.org/D117296 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda added a comment. In D117293#3243735 , @vitalybuka wrote: > Nice! > >>> This completes the work found in: > > It's too late for this set of patches, but phabricator supports "Depends on" > comments (I guess only of the first patch upload), and

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, amyk, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds the fix for undef virtual register reading failure when trap

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a comment. In D111400#3172097 , @cor3ntin wrote: > Regression compared to the status quo: > This code no longer warns (as noted by Hubert above) > > auto f = [](bool b) { > if (b) return 42; > static int x = 0; > return

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM go for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400098. eopXD marked 8 inline comments as done. eopXD added a comment. Address comments. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187 +def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen", "ExtZvl::Zvl64b", + "'Zvl' (Minimum Vector Length) 64", +

[PATCH] D116186: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC)

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice simplification, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116186/new/ https://reviews.llvm.org/D116186

[PATCH] D117312: [clang][lex] NFC: Simplify calls to `LookupFile`

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117312/new/ https://reviews.llvm.org/D117312

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

efriedma added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/PowerPC/optimal-epilog-vectorization.ll:273-276 -; VF-TWO-CHECK-DAG: [[LOOPID_MV]] = distinct !{[[LOOPID_MV]], [[LOOPID_DISABLE_VECT:!.*]]} -; VF-TWO-CHECK-DAG: [[LOOPID_EV]] = distinct

[PATCH] D117098: [RISCV] update zfh and zfhmin extention to v1.0

craig.topper added a comment. A new test `inline-asm-zfh-constraint-f.ll` was added today that needs it's RUN line updated. Comment at: clang/test/Preprocessor/riscv-target-features.c:231 // RUN: %clang -target riscv32-unknown-linux-gnu -menable-experimental-extensions \

[clang] f63a805 - Revert "[X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC"

Author: Phoebe Wang Date: 2022-01-15T10:54:38+08:00 New Revision: f63a805a4e9924002a9533b335ab29a8b5c7a9ac URL: https://github.com/llvm/llvm-project/commit/f63a805a4e9924002a9533b335ab29a8b5c7a9ac DIFF: https://github.com/llvm/llvm-project/commit/f63a805a4e9924002a9533b335ab29a8b5c7a9ac.diff

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400238. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch changes the visiblity of variables

[clang] 533fbae - [clang-format] Add experimental option to remove LLVM braces

Author: Owen Pan Date: 2022-01-14T15:10:17-08:00 New Revision: 533fbae8d8d87fb151f852b5273e6e1626321567 URL: https://github.com/llvm/llvm-project/commit/533fbae8d8d87fb151f852b5273e6e1626321567 DIFF: https://github.com/llvm/llvm-project/commit/533fbae8d8d87fb151f852b5273e6e1626321567.diff

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. To clarify: LGTM as-is, I don't expect any changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/ https://reviews.llvm.org/D117293 ___ cfe-commits mailing list

[PATCH] D117098: [RISCV] update zfh and zfhmin extention to v1.0

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117098/new/ https://reviews.llvm.org/D117098

  1   2   >