[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3978 for (StringRef F : ReqFeatures) { -if (TI.hasFeature(F)) - continue; - -// If the feature is 64bit, alter the string so it will print better in -// the diagnostic. -if (F

[PATCH] D115031: [AST] Print NTTP args as string-literals when possible

lichray marked an inline comment as done. lichray added a comment. Restricted the ellipsis only to diagnosis. Type comparison now shows full initializers, which could be made smarter next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

eopXD updated this revision to Diff 402192. eopXD added a comment. Rebase. Resolve conflict due to addition of zbkc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860 Files:

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan updated this revision to Diff 402184. jacquesguan added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D117854: [RISCV] Decouple Zve* extensions and the V extension.

jacquesguan updated this revision to Diff 402188. jacquesguan added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117854/new/ https://reviews.llvm.org/D117854 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

RKSimon added a comment. In D117881#3263152 , @pengfei wrote: > What's the difference between `__builtin_reduce_and` and generating a > `Intrinsic::vector_reduce_and` in code? If this is just a simplification, why > can't be applied to `add` too?

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee updated this revision to Diff 402201. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D117924 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-sanitizer-ld.c

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Patryk27 updated this revision to Diff 402203. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114611/new/ https://reviews.llvm.org/D114611 Files:

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

pengfei accepted this revision. pengfei added a comment. I see. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117881/new/ https://reviews.llvm.org/D117881 ___ cfe-commits mailing list

[PATCH] D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 402199. zinovy.nis added a comment. - Remove unused include. - Update release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files:

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. new nits but basically I think this looks like it might handle this ok? LGTM We need to run this across a large code base to check Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:106 + bool

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

MyDeveloperDay added a comment. maybe slightly related https://github.com/llvm/llvm-project/issues/53183 in that this is also impacted by the 5 character `TT_FunctionLikeOrFreestandingMacro` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117520/new/ https://reviews.llvm.org/D117520

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Patryk27 added inline comments. Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1261 +if (!DstIsKill) { + buildMI(MBB, MBBI, AVR::POPWRd).addDef(Dst.getReg()); +} I'm not sure if that's correct, but the previous approach: ``` buildMI(MBB,

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 402206. xbolva00 added a comment. Added testcase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/mm_malloc.c Index:

[PATCH] D117091: [Clang] Add attributes alloc_size and alloc_align to mm_malloc

xbolva00 updated this revision to Diff 402207. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117091/new/ https://reviews.llvm.org/D117091 Files: clang/lib/Headers/mm_malloc.h clang/test/Headers/mm_malloc.c Index: clang/test/Headers/mm_malloc.c

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Patryk27 updated this revision to Diff 402213. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114611/new/ https://reviews.llvm.org/D114611 Files: clang/docs/tools/clang-formatted-files.txt llvm/lib/Target/AVR/AVR.h

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood updated this revision to Diff 402284. LegalizeAdulthood added a comment. Clarify ninja build example CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index:

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 402234. Ericson2314 added a comment. Trim down, now that many parts have been landed already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files:

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

pkubaj created this revision. pkubaj added reviewers: adalava, nemanjai. Herald added subscribers: shchenz, kbarton, krytarowski. pkubaj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 created this revision. Ericson2314 added reviewers: compnerd, phosek, beanz, sterni. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox,

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood updated this revision to Diff 402283. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index:

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cf15af2daa9: [RISCV] Remove experimental prefix from rvv-related extensions. (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/

[PATCH] D117939: [clang-tidy] Add more documentation about check development

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:232 + +If your check applies only to specific dialect of C or C++, you will +want to override the method ``isLanguageVersionSupported`` to reflect that.

[PATCH] D117977: WIP: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, compnerd, phosek. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox,

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood updated this revision to Diff 402237. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readability-duplicate-include.h:1 +#if !defined(READABILITY_DUPLICATE_INCLUDE_H) +#define READABILITY_DUPLICATE_INCLUDE_H

[PATCH] D117520: [clang-format] Fix SeparateDefinitionBlocks issues

ksyx marked 2 inline comments as done. ksyx added a comment. In D117520#3263403 , @MyDeveloperDay wrote: > maybe slightly related https://github.com/llvm/llvm-project/issues/53183 in > that this is also impacted by the 5 character >

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added a comment. @xazax.hun ping re merging this to `main`. Would be amazing to get this in still in time for clang 14. In case it makes merging easier for you, there is a copy of this commit on

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood marked 7 inline comments as done. LegalizeAdulthood added a comment. In D117939#3263180 , @Eugene.Zelenko wrote: > It's also make sense to mention `isLanguageVersionSupported`. Good idea. CHANGES SINCE LAST ACTION

[PATCH] D117860: [RISCV] Remove experimental prefix from rvv-related extensions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117860/new/ https://reviews.llvm.org/D117860

[clang] b846795 - [docs] [clang] Small documentation change for compilation databases

Author: Dave Date: 2022-01-22T17:30:34-08:00 New Revision: b8467952404c3598c9c901332607eb1886e1721c URL: https://github.com/llvm/llvm-project/commit/b8467952404c3598c9c901332607eb1886e1721c DIFF: https://github.com/llvm/llvm-project/commit/b8467952404c3598c9c901332607eb1886e1721c.diff LOG:

[PATCH] D116882: [docs] [clang] Small documentation change for compilation databases

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8467952404c: [docs] [clang] Small documentation change for compilation databases (authored by croepha, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood updated this revision to Diff 402238. LegalizeAdulthood added a comment. Update from review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117939/new/ https://reviews.llvm.org/D117939 Files: clang-tools-extra/docs/clang-tidy/Contributing.rst Index:

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

eopXD added a comment. In D117913#3263493 , @khchen wrote: > why the new test filename extension is `.c.c`? Thanks for the reminder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117913/new/

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

xbolva00 created this revision. xbolva00 added reviewers: leonardchan, aeubanks. Herald added subscribers: ormris, hiraditya. xbolva00 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Problem: Migration to new PM broke

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. In D7982#3263790 , @carlosgalvezp wrote: > Great patch, thanks!! Can you mark the patch as accepted in phabricator? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982

[PATCH] D117939: [clang-tidy] Add more documentation about check development

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:232 + +If your check applies only to specific versions of the C++ standard, you will +want to override the method ``isLanguageVersionSupported`` to reflect that.

[clang] 37d1d02 - [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

Author: Phoebe Wang Date: 2022-01-23T09:58:46+08:00 New Revision: 37d1d02200b9472082304c191f396f0489d00e05 URL: https://github.com/llvm/llvm-project/commit/37d1d02200b9472082304c191f396f0489d00e05 DIFF: https://github.com/llvm/llvm-project/commit/37d1d02200b9472082304c191f396f0489d00e05.diff

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37d1d02200b9: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match… (authored by pengfei). Repository: rG LLVM Github

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. Great patch, thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D7982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117965: [AlwaysInliner] Enable call site inlining to make flatten attribute working again (PR53360)

xbolva00 added inline comments. Comment at: llvm/lib/Transforms/IPO/AlwaysInliner.cpp:95 - // Remember to try and delete this function afterward. This both avoids - // re-walking the rest of the module and avoids dealing with any iterator - // invalidation

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added a comment. Thank you for your feedback! I could combine the riscv32 and 64 cpp files with some xlen conditions if that will work better, but that might take a bit of a hit in terms of readability (do I explain both sleds in the comments preceding the implementation). I have

[PATCH] D117929: [XRay] Add support for RISCV

jrtc27 added a comment. In D117929#3263462 , @ashwin98 wrote: > Thank you for your feedback! I could combine the riscv32 and 64 cpp files > with some xlen conditions if that will work better, but that might take a bit > of a hit in terms of readability

[clang-tools-extra] 7c16647 - [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

Author: John Ericson Date: 2022-01-22T20:57:21Z New Revision: 7c16647c3676587391f6bb80ec87d9621ca9472f URL: https://github.com/llvm/llvm-project/commit/7c16647c3676587391f6bb80ec87d9621ca9472f DIFF: https://github.com/llvm/llvm-project/commit/7c16647c3676587391f6bb80ec87d9621ca9472f.diff LOG:

[PATCH] D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c16647c3676: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation… (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D117939: [clang-tidy] Add more documentation about check development

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:295 +Reference `_ to understand +the relationship between the different matcher funtions. + Should

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

carlosgalvezp added a comment. In D7982#3263920 , @LegalizeAdulthood wrote: > In D7982#3263790 , @carlosgalvezp > wrote: > >> Great patch, thanks!! > > Can you mark the patch as accepted in phabricator? > Thanks I

[PATCH] D117913: [Clang][RISCV] Guard vmulh, vsmul correctly

khchen added a comment. why the new test filename extension is `.c.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117913/new/ https://reviews.llvm.org/D117913 ___ cfe-commits mailing list

[PATCH] D99484: [clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Alright, this is the last bit (except for D101070 which evidently caused the issues), looking good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/