[PATCH] D119296: KCFI sanitizer

samitolvanen created this revision. Herald added subscribers: dexonsmith, dang, jdoerfert, cryptoad. Herald added a reviewer: aaron.ballman. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The KCFI sanitizer, enabled with

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659 Target.getNewAlign(), getContext().getTypeSize(allocType))); allocationAlign = std::max( allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign)); }

[clang] deaf22b - [X86] Implement -fzero-call-used-regs option

Author: Bill Wendling Date: 2022-02-08T17:42:54-08:00 New Revision: deaf22bc0e306bc44c70d2503e9364b5ed312c49 URL: https://github.com/llvm/llvm-project/commit/deaf22bc0e306bc44c70d2503e9364b5ed312c49 DIFF: https://github.com/llvm/llvm-project/commit/deaf22bc0e306bc44c70d2503e9364b5ed312c49.diff

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdeaf22bc0e30: [X86] Implement -fzero-call-used-regs option (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:1658-1659 Target.getNewAlign(), getContext().getTypeSize(allocType))); allocationAlign = std::max( allocationAlign, getContext().toCharUnitsFromBits(AllocatorAlign)); }

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD, Is XLenRI correct for

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

MaskRay added inline comments. Comment at: clang/lib/Driver/Job.cpp:304 +void Command::setRedirectFiles(std::vector> Redirects) { + RedirectFiles = Redirects; Comment at: clang/lib/Driver/Job.cpp:370 +

[clang] d379ec9 - [AArch64] ACLE feature macro for Armv8.8-A MOPS

Author: tyb0807 Date: 2022-02-08T21:07:49Z New Revision: d379ec99085e33ace51740f2b93bda5e5c72326f URL: https://github.com/llvm/llvm-project/commit/d379ec99085e33ace51740f2b93bda5e5c72326f DIFF: https://github.com/llvm/llvm-project/commit/d379ec99085e33ace51740f2b93bda5e5c72326f.diff LOG:

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd379ec99085e: [AArch64] ACLE feature macro for Armv8.8-A MOPS (authored by tyb0807). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. @mehdi_amini Just to unblock users, I've posted https://reviews.llvm.org/D119277 which fixes the issue originally raised by @krzysz00 I'm also working on a more long term solution in https://reviews.llvm.org/D119049 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119289: [Clang] Add lowering for _C complex arithmetic to complex intrinsics.

jcranmer-intel created this revision. Herald added subscribers: dexonsmith, dang, pengfei. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a new guard flag, -fuse-complex-intrinsics, that is defaulted to on for the

[PATCH] D118199: [AArch64] ACLE feature macro for Armv8.8-A MOPS

tyb0807 reopened this revision. tyb0807 added a comment. This revision is now accepted and ready to land. Reverted due to buildbots failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118199/new/ https://reviews.llvm.org/D118199

[PATCH] D119301: [AArch64][ARM] add -Wunaligned-access only for clang

ychen created this revision. ychen added reviewers: mubashar_, lenary, pbarrio. Herald added a subscriber: kristof.beyls. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] f05a63f - [clang] Properly cache member pointer LLVM types

Author: Arthur Eubanks Date: 2022-02-08T13:22:24-08:00 New Revision: f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 URL: https://github.com/llvm/llvm-project/commit/f05a63f9a09bdacab6a98683c5a4fc3f1f2a9149 DIFF:

[PATCH] D119215: [clang] Properly cache member pointer LLVM types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf05a63f9a09b: [clang] Properly cache member pointer LLVM types (authored by aeubanks). Changed prior to commit:

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5419 + typedef typeof(f1) * __attribute__((kcfi_unchecked) unchecked_t; + ((unchecked_t)p2)(); // unchecked + `p2` is already unchecked. Would it be more demonstrative to

[PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4667 + + SmallVector Expr; + AppendAddressSpaceXDeref(AddressSpace, Expr); aprantl wrote: > 13 seems to be unnecessarily high. Shouldn't 1 be enough for the expected > single

[clang] dc8f4e1 - [cxx_status] Add a couple of Feb 2022 library papers that need compiler support.

Author: Richard Smith Date: 2022-02-08T17:25:52-08:00 New Revision: dc8f4e118d92982ff5f6316fe7d541d120ebabd1 URL: https://github.com/llvm/llvm-project/commit/dc8f4e118d92982ff5f6316fe7d541d120ebabd1 DIFF: https://github.com/llvm/llvm-project/commit/dc8f4e118d92982ff5f6316fe7d541d120ebabd1.diff

[clang] f16cc5d - [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

Author: Arthur Eubanks Date: 2022-02-08T13:22:43-08:00 New Revision: f16cc5df2288ef4637de29cd878627967b0fee3b URL: https://github.com/llvm/llvm-project/commit/f16cc5df2288ef4637de29cd878627967b0fee3b DIFF:

[PATCH] D118977: [NVPTX] Add more FMA intriniscs/builtins

tra added inline comments. Comment at: llvm/lib/Target/NVPTX/NVPTXIntrinsics.td:937 +class FMA_TUPLE Preds = [hasPTX70, hasSM80]> { + string Variant = V; I think the default should be the most useful/common and the least surprising value. I'd argue that in

[clang] 6ba68a5 - [clang][Driver] Use a VersionTuple for darwin linker version checks.

Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: 6ba68a5fc34271c85f438217f50e165cb0158c04 URL: https://github.com/llvm/llvm-project/commit/6ba68a5fc34271c85f438217f50e165cb0158c04 DIFF:

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai updated this revision to Diff 406977. vsapsai added a comment. Herald added a project: clang. Rebase and address clang-format comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118525/new/ https://reviews.llvm.org/D118525 Files:

[clang] ca9f0ec - [clang] Document objc_unsafeClaimAutoreleasedReturnValue.

Author: Ahmed Bougacha Date: 2022-02-08T14:30:39-08:00 New Revision: ca9f0ec1a30b899ce9df3d2173aa9a295b510509 URL: https://github.com/llvm/llvm-project/commit/ca9f0ec1a30b899ce9df3d2173aa9a295b510509 DIFF:

[PATCH] D119299: [NFC] clang-format one function.

eugenis created this revision. eugenis added reviewers: kda, vitalybuka. eugenis requested review of this revision. Herald added a project: clang. fix code formatting Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119299 Files: clang/lib/CodeGen/CGClass.cpp Index:

[PATCH] D119296: KCFI sanitizer

pcc added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3168 + -1); + llvm::Value *Test = Builder.CreateICmpEQ(Builder.CreateLoad(HashPtr), Hash); + llvm::BasicBlock *ContBB = createBasicBlock("kcfi.cont"); We considered a scheme like this

[clang] 8440ec6 - [docs] Document -ffinite-math-only, -fhonor-{infinities,infinites,nans}

Author: Jon Roelofs Date: 2022-02-08T18:10:17-08:00 New Revision: 8440ec66f4f0f2e4f49061262648809345952bf7 URL: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7 DIFF: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7.diff

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

mehdi_amini added a comment. (The discussion seems to be happening in two places: https://github.com/llvm/llvm-project/issues/53475 ) You can break downstream users, the relationship inside the monorepo is different as far as I know: I believe we will have to live with revert like the one

[PATCH] D118936: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address-field-padding.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cc5df2288: [test] Remove -fno-experimental-new-pass-manager -O1 from sanitize-address… (authored by aeubanks). Repository: rG LLVM Github

[clang] cfe7f69 - [RISCV][NFC] Refactor RISCVISAInfo.

Author: Zakk Chen Date: 2022-02-08T18:37:43-08:00 New Revision: cfe7f690367b9d2903f099162f0bcbbfd18c7610 URL: https://github.com/llvm/llvm-project/commit/cfe7f690367b9d2903f099162f0bcbbfd18c7610 DIFF: https://github.com/llvm/llvm-project/commit/cfe7f690367b9d2903f099162f0bcbbfd18c7610.diff

[PATCH] D119250: [RISCV][NFC] Refactor RISCVISAInfo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe7f690367b: [RISCV][NFC] Refactor RISCVISAInfo. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119299: [NFC] clang-format one function.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I don't think you need approval for that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119299/new/ https://reviews.llvm.org/D119299

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen marked an inline comment as done. ychen added inline comments. Comment at: llvm/lib/CodeGen/JMCInstrumenter.cpp:180 + "JMC instrument more than once?"); + FunctionCallee Fn = + M.getOrInsertFunction(CheckFunctionName, getCheckFunctionType(Ctx));

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:595 +continue; + XorOp = X86::PXORrr; +} else if (X86::VR256RegClass.contains(Reg)) { nickdesaulniers wrote: > void wrote: > > nickdesaulniers wrote: > > > Is there

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 406924. void added a comment. Move register clearning to after the "pop"s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/Basic/Attr.td

[PATCH] D119271: CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign

xbolva00 added inline comments. Comment at: clang/test/CodeGen/alloc-align-attr.c:14 // CHECK-NEXT:[[CASTED_ALIGN:%.*]] = zext i32 [[TMP0]] to i64 // CHECK-NEXT:call void @llvm.assume(i1 true) [ "align"(i32* [[CALL]], i64 [[CASTED_ALIGN]]) ] // CHECK-NEXT:

[PATCH] D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LG, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119231/new/ https://reviews.llvm.org/D119231

[PATCH] D118428: [clang-cl] Support the /JMC flag

ychen updated this revision to Diff 406927. ychen marked an inline comment as done. ychen added a comment. - address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118428/new/ https://reviews.llvm.org/D118428 Files:

[clang] f2c2e92 - Fix a typo (occured => occurred)

Author: Sylvestre Ledru Date: 2022-02-08T21:35:26+01:00 New Revision: f2c2e924e73a76562b7cc6d8fd96df5b177eaf18 URL: https://github.com/llvm/llvm-project/commit/f2c2e924e73a76562b7cc6d8fd96df5b177eaf18 DIFF:

[PATCH] D119257: Revert "Re-land [LLD] Remove global state in lldCommon"

aganea added a comment. All things considered I think in the short term it is better to aim for small patches/fixes that can be transplanted to `release/14.x` if need be. I've posted D119277 for the issue you were seeing @krzysz00, but I am still planning on

<    1   2   3