[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

cor3ntin added a comment. In D119651#3317346 , @erichkeane wrote: > I'm pretty sure @cor3ntin just messed with this quite a bit, so I'd like to > hear his thoughts on this. But this generally looks right on first blush. Probably not as much as you

[PATCH] D119646: [clang] Allow consteval functions in default arguments

cor3ntin added a comment. There is also https://reviews.llvm.org/D74130 which tries to address the same issue in a very different way. I don't really understand the different approaches yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers added a comment. In D119601#3317317 , @NoQ wrote: >> steakhal performed systems testing across a large set of open source >> projects. > > I'm curious if any findings there caused you to make changes in the patch. If > so it'd be great to

[clang] 4b43209 - [clang][sema] Use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-02-13T13:14:05Z New Revision: 4b432096839e719ec0b78cd0299e7950a59dce0b URL: https://github.com/llvm/llvm-project/commit/4b432096839e719ec0b78cd0299e7950a59dce0b DIFF: https://github.com/llvm/llvm-project/commit/4b432096839e719ec0b78cd0299e7950a59dce0b.diff

[PATCH] D119481: run-clang-tidy: Fix infinite loop on windows

salman-javed-nz added a comment. Just a drive-by comment to say, thank you for taking the time to make this fix. It's a bug I've triggered many times. Great to see it being resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119481/new/

[PATCH] D119599: Add option to align compound assignments like `+=`

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// sstwcw wrote: > HazardyKnusperkeks wrote: > > sstwcw wrote: > > > HazardyKnusperkeks wrote: > > > > curdeius wrote: > > > >

[PATCH] D119646: [clang] Allow consteval functions in default arguments

Izaron added a comment. In D119646#3317473 , @cor3ntin wrote: > There is also https://reviews.llvm.org/D74130 which tries to address the same > issue in a very different way. > I don't really understand the different approaches yet. Thanks! I spent

[PATCH] D119648: [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8415-8417 + verifyFormat("if (int *p, *q; p != q) {\n p = p->next;\n}", Style); + verifyFormat("/*comment*/ if (int *p, *q; p != q) {\n p = p->next;\n}", + Style);

[PATCH] D119648: [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

HazardyKnusperkeks added a comment. In D119648#3317212 , @owenpan wrote: > Does any C++ standard support init statements in `while` loops? I actually thought there was. But that was a mistake. :) Comment at:

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers added a comment. Thanks for the comments. I'll address and revert back soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601 ___ cfe-commits mailing

[PATCH] D119650: [clang-format] Handle PointerAlignment in `if` statements with initializers (C++17) the same way as in `for` loops.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:32 +static bool startsWithStatementWithInitializer(const AnnotatedLine ) { + return Line.startsWith(tok::kw_for) || Line.startsWith(tok::kw_if); +} Here a switch? I'm

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked an inline comment as done. tbaeder added a comment. In D119525#3314383 , @aaron.ballman wrote: > Can you also add a release note for the change? Would this go in the "libclang" section in `clang/docs/ReleaseNotes.rst`? Or somewhere

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added a comment. I need a response here. :) @Quuxplusone are the names okay for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 ___ cfe-commits mailing list

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

Izaron added a comment. > Should we maybe always treat `PotentiallyEvaluated` as `ConstantEvaluated` in > constant evaluated contexts? could that work ? Indeed, within this patch we can prevent similars bugs to appear. I researched other places where a new context is pushed, and haven't find

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, balazske. Herald added a reviewer: shafik. v.g.vassilev requested review of this revision. In case where we have removed all declarations for a given declaration name entry we should remove the whole StoredDeclsMap entry.

[clang] 09559bc - Avoid a vulgarism. NFC.

Author: Marek Kurdej Date: 2022-02-13T22:01:06+01:00 New Revision: 09559bc59a718e597725c7d9747350e9c649fd0e URL: https://github.com/llvm/llvm-project/commit/09559bc59a718e597725c7d9747350e9c649fd0e DIFF: https://github.com/llvm/llvm-project/commit/09559bc59a718e597725c7d9747350e9c649fd0e.diff

[PATCH] D119664: Check for the overloadable attribute in all the appropriate syntactic locations

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (I didn't know `can_overload_4` was a valid place to put a C attribute) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119664/new/

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cjdb added a comment. Thanks for working on this! I'm overall very happy, but I don't see a test case for a unary `move` originating from another namespace. Comment at: clang/lib/Sema/SemaExpr.cpp:6422 +static void DiagnosedUnqualifiedCallsToStdFunctions(Sema , CallExpr

[PATCH] D119649: [clang-format] Correctly format loops and `if` statements even if preceded with comments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cb944597907: [clang-format] Correctly format loops and `if` statements even if preceded with… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9cb9445 - [clang-format] Correctly format loops and `if` statements even if preceded with comments.

Author: Marek Kurdej Date: 2022-02-13T21:22:17+01:00 New Revision: 9cb944597907458ce9c2f6bd0ecc9723b674b77f URL: https://github.com/llvm/llvm-project/commit/9cb944597907458ce9c2f6bd0ecc9723b674b77f DIFF: https://github.com/llvm/llvm-project/commit/9cb944597907458ce9c2f6bd0ecc9723b674b77f.diff

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf planned changes to this revision. qiucf added a comment. This breaks existing smm/tmm tests, will update/clean-up them before this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407

[PATCH] D119648: [clang-format] Fix PointerAlignment within lambdas in a multi-variable declaration statement.

curdeius updated this revision to Diff 408289. curdeius marked an inline comment as done. curdeius added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119648/new/ https://reviews.llvm.org/D119648 Files:

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth

vabridgers added a comment. I explored some test cases, and the rabbit hole gets deeper :) Continuing to explore. Best Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119601/new/ https://reviews.llvm.org/D119601

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:157 + /// a &= 2; + /// bbb = 2; + /// HazardyKnusperkeks wrote: > sstwcw wrote: > > HazardyKnusperkeks wrote: > > > sstwcw wrote: > > > > HazardyKnusperkeks wrote: > > > > >

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a diagnostic when an unqualified call is resolved to std::move or std::forward. This follows some C++ committee discussions where some

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. There may be some things worth considering here: - libc++ own tests and build is affected, I have not addressed these yet. - other standard libs are affected but because they are considered system headers, no warning is emitted I think this is a worth while first

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 added a comment. In D117929#3314355 , @ashwin98 wrote: > In D117929#3299751 , @dberris wrote: > >> In D117929#3276843 , @ashwin98 >> wrote: >> >>> Fixed another

[PATCH] D119625: Fix integer underflow bug when aligning code in clang-format

sstwcw abandoned this revision. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16854 + // that things still get aligned. + Alignment.ColumnLimit = 20; EXPECT_EQ("inta(int x,\n" HazardyKnusperkeks wrote: > I disagree.

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16872 + // that things still get aligned. + Alignment.ColumnLimit = 20; EXPECT_EQ("inta(int x,\n" sstwcw wrote: > curdeius wrote:

[PATCH] D119682: [clang-format][docs] Fix incorrect 'clang-format 13' configuration options markers

kuzkry created this revision. kuzkry added a reviewer: MyDeveloperDay. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Note: Option 'IndentRequiresClause' was previously known as 'IndentRequires' but the version marker should still

[PATCH] D119680: [clang-format] Fix SpacesInLineCommentPrefix deleting tokens.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/53799. Repository: rG

[PATCH] D119680: [clang-format] Fix SpacesInLineCommentPrefix deleting tokens.

curdeius added a comment. I thought about using signed ints for Minimum and Maximum in the style, but then, we won't be able to use `-1` for Maximum the same way as now and signed int makes no sense for Minimum... Comment at: clang/lib/Format/BreakableToken.cpp:799-800 +

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis requested changes to this revision. thakis added a comment. This revision now requires changes to proceed. (also marking as "request changes" for the Optional change we need) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/

[PATCH] D118070: Make lld-link work in a non-MSVC shell

thakis reopened this revision. thakis added a comment. This revision is now accepted and ready to land. (reopening for fixing things + relanding) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118070/new/ https://reviews.llvm.org/D118070

[clang] 25282bd - [clang-format] Handle PointerAlignment in `if` and `switch` statements with initializers (C++17) the same way as in `for` loops.

Author: Marek Kurdej Date: 2022-02-13T21:36:58+01:00 New Revision: 25282bd6c4bf54a21c0f8dbf00db6e70922c02fa URL: https://github.com/llvm/llvm-project/commit/25282bd6c4bf54a21c0f8dbf00db6e70922c02fa DIFF: https://github.com/llvm/llvm-project/commit/25282bd6c4bf54a21c0f8dbf00db6e70922c02fa.diff

[PATCH] D119650: [clang-format] Handle PointerAlignment in `if` and `switch` statements with initializers (C++17) the same way as in `for` loops.

This revision was automatically updated to reflect the committed changes. curdeius marked 2 inline comments as done. Closed by commit rG25282bd6c4bf: [clang-format] Handle PointerAlignment in `if` and `switch` statements with… (authored by curdeius). Changed prior to commit:

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

joerg added a comment. I'm ambivalent about this change. To me, it falls into the category of "stop passing random ld options to the compiler driver". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119655/new/ https://reviews.llvm.org/D119655

[PATCH] D119599: Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 408295. sstwcw edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4812 +def warn_unqualified_call_to_std_function : Warning< + "unqualified call to %0">, InGroup>; + This should probably be named `-Wunqualified-std-move` resp.

[PATCH] D119664: Check for the overloadable attribute in all the appropriate syntactic locations

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, cor3ntin, rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. When forming the function type from a declarator, we look for an overloadable attribute before issuing a diagnostic in

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119541/new/ https://reviews.llvm.org/D119541

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 408310. achieveartificialintelligence added a comment. Ping & Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files:

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu updated this revision to Diff 408317. ChuanqiXu added a comment. Handle named module explicitly for better readability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 Files: clang/lib/Serialization/ASTWriterDecl.cpp

[PATCH] D119686: [RISCV] Add the passthru operand for vadc/vsbc/vmerge/vfmerge IR intrinsics.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu added inline comments. Comment at: clang/test/CXX/modules-ts/basic/basic.def.odr/p4/module.cpp:5 // CHECK-DAG: @extern_var_exported = external {{(dso_local )?}}global -// CHECK-DAG: @inline_var_exported = linkonce_odr {{(dso_local )?}}global +// CHECK-DAG:

[clang] 7f51a9e - [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

Author: eopXD Date: 2022-02-13T21:05:06-08:00 New Revision: 7f51a9e2730e32eec45ff2e91b3d7bae897893e4 URL: https://github.com/llvm/llvm-project/commit/7f51a9e2730e32eec45ff2e91b3d7bae897893e4 DIFF: https://github.com/llvm/llvm-project/commit/7f51a9e2730e32eec45ff2e91b3d7bae897893e4.diff LOG:

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f51a9e2730e: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:80 +// Zknd extension +TARGET_BUILTIN(__builtin_riscv_aes32dsi, "ZiZiZiUc", "nc", "zknd") +TARGET_BUILTIN(__builtin_riscv_aes32dsmi, "ZiZiZiUc", "nc", "zknd") Uc -> IUc

[PATCH] D119409: [C++20] [Modules] Remain variable's definition in module interface

ChuanqiXu updated this revision to Diff 408315. ChuanqiXu added a comment. Update test about inline variable in module CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 Files: clang/lib/Serialization/ASTWriterDecl.cpp

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 408319. achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3e19ba3 - [X86][MS] Add 80bit long double support for Windows

Author: Phoebe Wang Date: 2022-02-14T13:32:29+08:00 New Revision: 3e19ba36fca9fa0b6aba0de2767f26dfd463cb5a URL: https://github.com/llvm/llvm-project/commit/3e19ba36fca9fa0b6aba0de2767f26dfd463cb5a DIFF: https://github.com/llvm/llvm-project/commit/3e19ba36fca9fa0b6aba0de2767f26dfd463cb5a.diff

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e19ba36fca9: [X86][MS] Add 80bit long double support for Windows (authored by pengfei). Changed prior to commit:

[PATCH] D117929: [XRay] Add support for RISCV

dberris added a comment. In D117929#3317813 , @ashwin98 wrote: > In D117929#3314355 , @ashwin98 > wrote: > >> On including RISCV64 to the check, I see new issues while reading the >> instrumentation map. How do

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

eopXD added a comment. Kindly reverse ping. May you land this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119210/new/ https://reviews.llvm.org/D119210 ___ cfe-commits mailing list

[clang] bfb4c0c - [RISCV] Recover the implication between Zve* extensions and the V extension.

Author: jacquesguan Date: 2022-02-14T15:52:07+08:00 New Revision: bfb4c0c37078aa5ce251752d99310ccb05e1296a URL: https://github.com/llvm/llvm-project/commit/bfb4c0c37078aa5ce251752d99310ccb05e1296a DIFF: https://github.com/llvm/llvm-project/commit/bfb4c0c37078aa5ce251752d99310ccb05e1296a.diff

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfb4c0c37078: [RISCV] Recover the implication between Zve* extensions and the V extension. (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

jacquesguan added a comment. In D119210#3318348 , @eopXD wrote: > Kindly reverse ping. > May you land this change? OK, right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119210/new/

[PATCH] D119680: [clang-format] Fix SpacesInLineCommentPrefix deleting tokens.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Never would have thought about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119680/new/

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder updated this revision to Diff 408341. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119221/new/ https://reviews.llvm.org/D119221 Files: clang/lib/Lex/Lexer.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Lexer/utf8-char-literal.cpp Index:

[PATCH] D119655: [Driver][NetBSD] -r: imply -nostdlib like GCC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D119655#3318003 , @joerg wrote: > I'm ambivalent about this change. To me, it falls into the category of "stop > passing random ld options to

[clang] 83028ad - [clang][AST][ASTImporter] Set record to complete during import of its members.

Author: Balázs Kéri Date: 2022-02-14T08:27:44+01:00 New Revision: 83028ad934d60b024b5b0272cb68523232715dab URL: https://github.com/llvm/llvm-project/commit/83028ad934d60b024b5b0272cb68523232715dab DIFF: https://github.com/llvm/llvm-project/commit/83028ad934d60b024b5b0272cb68523232715dab.diff

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG83028ad934d6: [clang][AST][ASTImporter] Set record to complete during import of its members. (authored by balazske).

[PATCH] D119210: [RISCV] Recover the implication between Zve* extensions and the V extension.

eopXD added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119210/new/ https://reviews.llvm.org/D119210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org