[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, LegalizeAdulthood. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Create a PrettyStackTraceEvent

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 abandoned this revision. njames93 added a comment. I have decided to move this behaviour into the ast matcher directly, I feel in the long term, that should be a better home for this functionality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. I've reused the test cases from the old clang-tidy implementation of this, however this should eventually be moved into ASTMatchers tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org

[clang] a54b56e - Fix Wdocumentation unknown parameter warning

Author: Simon Pilgrim Date: 2022-02-19T13:06:09Z New Revision: a54b56ecf2e7c35e0bb3e61585a2c27c252069c8 URL: https://github.com/llvm/llvm-project/commit/a54b56ecf2e7c35e0bb3e61585a2c27c252069c8 DIFF: https://github.com/llvm/llvm-project/commit/a54b56ecf2e7c35e0bb3e61585a2c27c252069c8.diff LOG:

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

kimgr added a comment. First sanity check: applying this patch on my branch causes no test failures either in the `tools/clang/unittests/Tooling/ToolingTests` or `ninja check-clang-semacxx`. Hopefully I can think this through more deeply soon. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro added inline comments. Comment at: clang/test/Driver/solaris-ld-sanitizer.c:6 +/// Check sparc-sun-solaris2.11, 32bit +// RUN: %clang %s -### 2>&1 \ +// RUN: --target=sparc-sun-solaris2.11 \ MaskRay wrote: > The first line is now shorter. You can move --ta

[PATCH] D119829: [Driver] Support Solaris/amd64 GetTls

ro updated this revision to Diff 410083. ro added a comment. Testcase formatting improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119829/new/ https://reviews.llvm.org/D119829 Files: clang/lib/Driver/ToolChains/Solaris.cpp clang/test

[PATCH] D119927: [Clang] [P2025] More exhaustive tests for NRVO

Quuxplusone added inline comments. Comment at: clang/test/CodeGenCXX/nrvo.cpp:1537 + } + return x; // FIXME: NRVO could happen if B == false, but doesn't +} Quuxplusone wrote: > Nit: `s/if/when/` Serendipitously, I just ran into almost this exact scenario in D1

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. I now realize that the type check isn't correct for the platforms which pass arguments to the resolver. Unfortunate that the glibc wiki doesn't mention this (as far as I can tell)... I thought that the bitcast-to-"expected"-type should shield from that error, but may

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny created this revision. SimplyDanny added a reviewer: alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. SimplyDanny requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang-tools-extra. This is a fix for #53737. In additi

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

njames93 added inline comments. Comment at: .clang-tidy:1-10 +Checks: | + -* + clang-diagnostic-* + llvm-* + misc-* + -misc-unused-parameters + -misc-non-private-member-variables-in-classes This change doesn't belong in this patch. Commen

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

lattner added a comment. Thank you so much Carlos, I hope they can come to see the value of having first class support for this in LLVM/Clang. I really appreciate you pushing for this, -Chris CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D119095: [clang] Fix redundant functional cast in ConstantExpr

kimgr added a comment. I can also confirm that `main` and my branch (containing https://reviews.llvm.org/D119477 and https://reviews.llvm.org/D119476) both assert on the same line: $ cat bug-53244.cc struct A { consteval A() {} A(const A&) = delete; consteval void

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos created this revision. penagos requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120188 Files: clang/lib/Format/BreakableToken.cpp clang/unittests/Format/FormatTest

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 added a comment. Could one of you review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D117973: [cmake] Support custom package install paths

Ericson2314 added a comment. Could one of you review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117973/new/ https://reviews.llvm.org/D117973 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818-822 const auto AllowsSpaceChange = -SpacesInPrefix != 0 || -(!NoSpaceBeforeFirstCommentChar() || - (FirstNonSpace == '}' && FirstLineSpaceCha

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

HazardyKnusperkeks added a comment. Thanks for working on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120188/new/ https://reviews.llvm.org/D120188 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny updated this revision to Diff 410102. SimplyDanny added a comment. Update according to comments in review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120187/new/ https://reviews.llvm.org/D120187 Files: clang-tools-extra/clang-tidy/

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny marked 2 inline comments as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:100 + EXPECT_TRUE(!!Options); + EXPECT_EQ("-*,misc-*\nllvm-*\n-clang-*,\ngoogle-*\n", *Options->Checks); +} -

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

SimplyDanny marked an inline comment as done. SimplyDanny added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:100 + EXPECT_TRUE(!!Options); + EXPECT_EQ("-*,misc-*\nllvm-*\n-clang-*,\ngoogle-*\n", *Options->Checks); +} -

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

curdeius added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818 const auto FirstNonSpace = Lines[i][IndentPrefix.size()]; const auto AllowsSpaceChange = +(!LineTok || !switchesFormatting(*LineTok)) && curdeius wro

[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

njames93 added a comment. Was there any real use case for making this polymorphic, The overhead for a virtual function call seems a little unnecessary IMO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113422/new/ https://reviews.llvm.org/D113422

[PATCH] D120196: [clang-tidy][NFC] Remove Tristate from CachedGlobList

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, whisperity, salman-javed-nz. Herald added subscribers: rnkovacs, xazax.hun. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The tristate i

[clang] fa0f90b - [HIP] Support linking archive of bundled bitcode

Author: Yaxun (Sam) Liu Date: 2022-02-19T18:37:44-05:00 New Revision: fa0f90bc55ed536e1488648255278ce9029cfa59 URL: https://github.com/llvm/llvm-project/commit/fa0f90bc55ed536e1488648255278ce9029cfa59 DIFF: https://github.com/llvm/llvm-project/commit/fa0f90bc55ed536e1488648255278ce9029cfa59.dif

[PATCH] D120070: [HIP] Support linking archive of bundled bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa0f90bc55ed: [HIP] Support linking archive of bundled bitcode (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Mon

[PATCH] D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations

njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:100 + EXPECT_TRUE(!!Options); + EXPECT_EQ("-*,misc-*\nllvm-*\n-clang-*,\ngoogle-*\n", *Options->Checks); +} SimplyDanny wrote: > SimplyDanny wrote: > > n

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos updated this revision to Diff 410115. penagos added a comment. - Split AllowsSpaceChange conditional over multiple variables to enhance readability. - Remove unnecessary column limit from unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos marked 3 inline comments as done. penagos added inline comments. Comment at: clang/lib/Format/BreakableToken.cpp:818-822 const auto AllowsSpaceChange = -SpacesInPrefix != 0 || -(!NoSpaceBeforeFirstCommentChar() || - (FirstNonSp

[PATCH] D120188: Fix extraneous whitespace addition in line comments on clang-format directives

penagos marked an inline comment as done. penagos added a comment. In D120188#674 , @HazardyKnusperkeks wrote: > Thanks for working on it. Happy to help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D119562: Provide fine control of color in run-clang-tidy

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:240-249 + color_group = parser.add_mutually_exclusive_group() + color_group.add_argument('-use-color', action='store_true', dest='use_color', + help='Use co

[PATCH] D119562: Provide fine control of color in run-clang-tidy

njames93 added a comment. Why have you removed execute perms form the scripts, can you add them back please `$ chmod +x run-clang-tidy.py'` Unless you are using windows in which case you will have to manually edit the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds Sema support for `

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410124. tianshilei1992 added a comment. reorg code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/lib/Sema/SemaOpenMP.cpp Index: clang/lib/Sem

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog updated this revision to Diff 410132. kesyog added a comment. Use argument style more consistent with clang-tidy & LLVM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119562/new/ https://reviews.llvm.org/D119562 Files: clang-tools-extra/cl

[PATCH] D119562: Provide fine control of color in run-clang-tidy

kesyog marked an inline comment as done. kesyog added a comment. Thanks for the suggestions. I removed `-no-use-color` and modified `-use-color` to follow the behavior of LLVM's CLI parser. I also fixed the (very unintentional) file mode change. Repository: rG LLVM Github Monorepo CHANGES S