[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 marked an inline comment as done. kovdan01 added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG mehdi_amini wrote: > This is a

[PATCH] D121549: Define ABI breaking class members correctly

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 ___ cfe-commits mailing list

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rG9e0fc6768378: [clang][dataflow] Model the behavior of various optional members (authored by sgatev).

[clang] 9e0fc67 - [clang][dataflow] Model the behavior of various optional members

Author: Stanislav Gatev Date: 2022-03-14T06:50:14Z New Revision: 9e0fc67683781fe4bd9bc4085084faec1126b41b URL: https://github.com/llvm/llvm-project/commit/9e0fc67683781fe4bd9bc4085084faec1126b41b DIFF: https://github.com/llvm/llvm-project/commit/9e0fc67683781fe4bd9bc4085084faec1126b41b.diff

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(); +if (auto *Val = dyn_cast_or_null( xazax.hun wrote: > Could you elaborate on when would this happen? I'd expect the traversal to

[PATCH] D121578: [RISCV][NFC] Add tests to address invalid arch dependencies.

khchen created this revision. khchen added reviewers: craig.topper, kito-cheng. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev updated this revision to Diff 415021. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121455/new/ https://reviews.llvm.org/D121455 Files:

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 415022. kovdan01 added a comment. Keep private headers untouched CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: llvm/include/llvm/CodeGen/GlobalISel/GISelWorkList.h

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ https://reviews.llvm.org/D121576 ___ cfe-commits mailing list

[PATCH] D121427: [lit] add lit_config.substitute to interpolate lit_config.params

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This patch is definitely an improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121427/new/ https://reviews.llvm.org/D121427

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. In D88905#3375676 , @aaron.ballman wrote: > In D88905#3362347 , @kaz7 wrote: > >> At the beginning, this implementation extends `vector_type` attribute which >> is GCC's attribute. So,

[PATCH] D121592: [clangd] Expose include cleaner interface in clangd

serge-sans-paille created this revision. serge-sans-paille added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

egorzhdan updated this revision to Diff 415069. egorzhdan added a comment. Rename a lambda to improve readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Please fix the clang format issue as well. Other than that and a nit, this LGTM. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1587 + // The `minus`

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. Much better, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 ___ cfe-commits mailing

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman added a comment. In D121283#3375806 , @egorzhdan wrote: > In D121283#3373560 , @aaron.ballman > wrote: > >> why do we support multiple attribute *specifiers* in the same pragma? I >> would not

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415079. simoll added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h

[clang] 8cba721 - Implement literal suffixes for _BitInt

Author: Aaron Ballman Date: 2022-03-14T09:24:19-04:00 New Revision: 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 URL: https://github.com/llvm/llvm-project/commit/8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 DIFF: https://github.com/llvm/llvm-project/commit/8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8.diff

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra accepted this revision. amilendra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon,

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:35 +// TODO: Vector mask registers +// Depend on https://reviews.llvm.org/D88905 +// BUILTIN(__builtin_ve_vl_vst_vssml, "vV256dLUiv*V256bUi", "n") Why leave dead code

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich to look at this WIP for early feedback as he's recently been looking at template instantiation guts rather deeply, but I added some questions. Comment at:

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca2f1938f96: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6ca2f19 - [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

Author: Egor Zhdan Date: 2022-03-14T12:47:30Z New Revision: 6ca2f1938f96a71abdecdd96508f48e4d20a5694 URL: https://github.com/llvm/llvm-project/commit/6ca2f1938f96a71abdecdd96508f48e4d20a5694 DIFF: https://github.com/llvm/llvm-project/commit/6ca2f1938f96a71abdecdd96508f48e4d20a5694.diff LOG:

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242 +#if 0 +BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n") +BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n") Could you comment at the top of this file

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. erichkeane marked an inline comment as done. Closed by commit rGdc152659b452: Have cpu-specific variants set tune-cpu as an optimization hint (authored by erichkeane).

[clang] dc15265 - Have cpu-specific variants set 'tune-cpu' as an optimization hint

Author: Erich Keane Date: 2022-03-14T06:14:30-07:00 New Revision: dc152659b4527cc2e5f75cc33f36df67c7d5db26 URL: https://github.com/llvm/llvm-project/commit/dc152659b4527cc2e5f75cc33f36df67c7d5db26 DIFF: https://github.com/llvm/llvm-project/commit/dc152659b4527cc2e5f75cc33f36df67c7d5db26.diff

[PATCH] D121599: [AST] Better recovery on an expression refers to an invalid decl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Prior to the patch, we didn't build a DeclRefExpr if the Decl being referred to is invalid, because many clang downstream AST

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou added a comment. In D121498#3379222 , @erichkeane wrote: > This seems reasonable to me, but can you please add a lit test and fix the > format of the code in your commit message? Thank you for reviewing the patch for me ;-) I am a

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:615 +TEST_F(TokenAnnotatorTest, UnderstandsObjCBlock) { + auto Tokens = annotate("int (^)() = ^ ()\n" I hope the name is appropriate, I don't know shit about

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added a comment. In D88905#3378933 , @simoll wrote: > In D88905#3375676 , @aaron.ballman > wrote: > >> In D88905#3362347 , @kaz7 wrote: >> >>> At the

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

erichkeane added a comment. This seems reasonable to me, but can you please add a lit test and fix the format of the code in your commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 (LLVM bits) and 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

kaz7 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242 +#if 0 +BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n") +BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n") simoll wrote: > Could you comment at the top

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121586/new/ https://reviews.llvm.org/D121586 ___

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415041. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address Hubert's feedback - Add a diagnostic during constant evaluation when evaluating the declaration of a variable with non-automatic storage duration - Add more tests -

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 415049. kovdan01 marked an inline comment as done. kovdan01 removed projects: MLIR, clang. kovdan01 added a comment. Fix formatting problems found on pre-merge checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/

[clang] 2d8e907 - [clang-format][NFC] Rename Left to OpeningParen...

Author: Björn Schäpers Date: 2022-03-14T12:44:45+01:00 New Revision: 2d8e907016ef323ed1a9e2e70c558eb9c3568b06 URL: https://github.com/llvm/llvm-project/commit/2d8e907016ef323ed1a9e2e70c558eb9c3568b06 DIFF:

[clang] acd17a2 - [clang-format] Fix crash on invalid requires expression

Author: Björn Schäpers Date: 2022-03-14T12:44:46+01:00 New Revision: acd17a2be81a33abf4350e31ae1747dcb0f12332 URL: https://github.com/llvm/llvm-project/commit/acd17a2be81a33abf4350e31ae1747dcb0f12332 DIFF:

[clang] b7494a1 - [clang-format][NFC] Left renamed to OpeningBrace...

Author: Björn Schäpers Date: 2022-03-14T12:44:47+01:00 New Revision: b7494a1d72c16a4d1f9cc8d4b3eba36934c35664 URL: https://github.com/llvm/llvm-project/commit/b7494a1d72c16a4d1f9cc8d4b3eba36934c35664 DIFF:

[clang] 35abbf1 - [clang-format] Fix crash on asm block with label

Author: Björn Schäpers Date: 2022-03-14T12:44:48+01:00 New Revision: 35abbf166d4ad13e4a89095307bb6e4b2e96e0b3 URL: https://github.com/llvm/llvm-project/commit/35abbf166d4ad13e4a89095307bb6e4b2e96e0b3 DIFF:

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan updated this revision to Diff 415031. owenpan added a comment. Reset the `Spaces` of the closing brace only if it can be unwrapped. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ https://reviews.llvm.org/D121576 Files: clang/lib/Format/WhitespaceManager.cpp

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm wondering if the presence of the comment would impact the CellCount, I might go back and add some more unit tests for the "non rectangular" change I made. So this fixes the "}" going up onto the comment line, but not

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

serge-sans-paille created this revision. serge-sans-paille added reviewers: kbobyrev, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay,

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch, please address the comment before submitting. Comment at: clang/lib/Sema/SemaChecking.cpp:1946-1953 +auto ArgArrayConversion = [&](unsigned Arg)

[clang] 2507e0a - [clang-format] Clean up UnwrappedLineParser::parseRecord. NFC.

Author: Marek Kurdej Date: 2022-03-14T11:59:52+01:00 New Revision: 2507e0a257991fd46bd847c8fa0964bc70891add URL: https://github.com/llvm/llvm-project/commit/2507e0a257991fd46bd847c8fa0964bc70891add DIFF: https://github.com/llvm/llvm-project/commit/2507e0a257991fd46bd847c8fa0964bc70891add.diff

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains created this revision. Herald added a subscriber: dang. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. These command-line flags are alternates

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the -fdirectives-only option is used together with -E, the

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow an invocation like clang -fmodule-header bar.h (which will be a C++

[PATCH] D121558: [clang-format][NFC] Left renamed to OpeningBrace...

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7494a1d72c1: [clang-format][NFC] Left renamed to OpeningBrace... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121559: [clang-format] Fix crash on asm block with label

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35abbf166d4a: [clang-format] Fix crash on asm block with label (authored by HazardyKnusperkeks). Changed prior to commit:

[PATCH] D121557: [clang-format][NFC] Rename Left to OpeningParen...

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d8e907016ef: [clang-format][NFC] Rename Left to OpeningParen... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121557/new/

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

This revision was automatically updated to reflect the committed changes. Closed by commit rGacd17a2be81a: [clang-format] Fix crash on invalid requires expression (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(); +if (auto *Val = dyn_cast_or_null( sgatev wrote: > xazax.hun wrote: > > Could you elaborate on when would this happen? I'd

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(); +if (auto *Val = dyn_cast_or_null( xazax.hun wrote: > sgatev wrote: > > xazax.hun wrote: > > > Could you elaborate on when would

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:42 - /// Current lattice element. + ASTContext LatticeT This shouldn't be needed, since we now pass the `MatchFinder::MatchResult` in `Action`, which

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

kaz7 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:35 +// TODO: Vector mask registers +// Depend on https://reviews.llvm.org/D88905 +// BUILTIN(__builtin_ve_vl_vst_vssml, "vV256dLUiv*V256bUi", "n") xbolva00 wrote: > Why leave

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(); +if (auto *Val = dyn_cast_or_null( sgatev wrote: > xazax.hun wrote: > > sgatev wrote: > > >

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a comment. Ping, all green here, I just had to mess with the test regex a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 ___ cfe-commits

[PATCH] D121549: Define ABI breaking class members correctly

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a717e9d - [AttrDocs] try to fix build

Author: Dávid Bolvanský Date: 2022-03-14T22:19:55+01:00 New Revision: a717e9d47e64682bf45e6a998d11d76f47454f12 URL: https://github.com/llvm/llvm-project/commit/a717e9d47e64682bf45e6a998d11d76f47454f12 DIFF:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 retitled this revision from "CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign" to "clang: emit allocalign to LLVM for alloc_align attributes". durin42 edited the summary of this revision. durin42 updated this revision to Diff 415230. Herald added a project: All.

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415153. simoll marked an inline comment as done. simoll added a comment. Simplify following comments. Thx :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files:

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10244-10245 + // This operation may not be performed on boolean vectors. + if (!AllowBoolOperation && (isBoolOrExtVectorBoolType(LHSType) && +

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. Comment based on @rsmith and EWG reflector feedback as to where this should be checked. Comment at: clang/test/SemaTemplate/concepts.cpp:63 template concept C = true; - template requires C typename U> struct X {}; // expected-error {{requires

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:118 +/// function will be 2. +int countOptionalWrappers(const ASTContext , QualType Type) { + if (!IsOptionalType(Type)) Nit: some of these

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

royjacobson created this revision. royjacobson added a reviewer: erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See: https://github.com/llvm/llvm-project/issues/54379 I tried to see if

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

dexonsmith added a comment. I'm not a big fan of moving to the recursive call. Creating a separate `StringMap` for each iteration seems awfully wasteful. I'd prefer fixing the iterative algorithm so that it's correct and easy to verify. This can be done with a stack that points at the stable

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121206/new/ https://reviews.llvm.org/D121206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 407c721 - [Support] Change zlib::compress to return void

Author: Fangrui Song Date: 2022-03-14T11:38:04-07:00 New Revision: 407c721ceb93863b2cb3851a6aa7686f31657e6b URL: https://github.com/llvm/llvm-project/commit/407c721ceb93863b2cb3851a6aa7686f31657e6b DIFF: https://github.com/llvm/llvm-project/commit/407c721ceb93863b2cb3851a6aa7686f31657e6b.diff

[PATCH] D121512: [Support] Change zlib::compress to return void

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG407c721ceb93: [Support] Change zlib::compress to return void (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:146 + std::vector> + Actions; Nit: looks like we need to repeat the action type. Should we restore the using above? Repository: rG LLVM Github

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Might be worth adding a release note for it (does this close any bugs in the bug database? If so, it'd be worth mentioning those in the commit message and release note).

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

shafik added a comment. Can you add a test to `ASTImpoterTest.cpp` that checks that we import the `LambdaDependencyKind` correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

jyknight added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

erichkeane added a comment. This seems acceptable to me. Though, I wonder if `getTemplateArgumentBindingsText` should produce the leading space, that way we could just pass the result of it directly, rather than have to create a SmallString everywhere. WDYT? Comment at:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D121628: Only run this test for x86 registed targets.

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121628 Files:

[PATCH] D121629: clang: also check alloc_alignment claims in return

lebedev.ri added a reviewer: lebedev.ri. lebedev.ri added a comment. Please can you pose the next patch itself? I suspect that propagation should simply not be done when sanitizer is enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch refactors `EmitPPCBuiltinExpr` in `CGBuiltin.cpp` to remove

[clang] 003c0b9 - [Clang] always_inline statement attribute

Author: Dávid Bolvanský Date: 2022-03-14T21:45:31+01:00 New Revision: 003c0b9307bc52605fc93c599dfe36849839ded5 URL: https://github.com/llvm/llvm-project/commit/003c0b9307bc52605fc93c599dfe36849839ded5 DIFF:

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415240. cor3ntin added a comment. clamg-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added a reviewer: lebedev.ri. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64*

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf63e9d4cacc: [clang][dataflow] Add support for nested composite bool expressions (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121627: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock

hkmatsumoto created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. hkmatsumoto requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, we only check alloc_alignment claims in the caller. I'm about to add some extra logic that threads

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10244-10245 + // This operation may not be performed on boolean vectors. + if (!AllowBoolOperation && (isBoolOrExtVectorBoolType(LHSType) && +

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev updated this revision to Diff 415178. sgatev marked 2 inline comments as done. sgatev added a comment. Add a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121602/new/ https://reviews.llvm.org/D121602 Files:

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added inline comments. Comment at: clang/test/SemaTemplate/concepts.cpp:63 template concept C = true; - template requires C typename U> struct X {}; // expected-error {{requires 'class'}} expected-error 0+{{}} + template requires C typename U> struct X {};

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3379225 , @aaron.ballman wrote: > As a thought experiment, would it make sense to lift the restriction on the > number of attributes allowed in a pragma, but not allow multiple attribute > specifiers? I think

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 415199. egorzhdan added a comment. - Only allow one attribute syntax style per directive - Adjust documentation - Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/

[PATCH] D121512: [Support] Change zlib::compress to return void

ikudrin added inline comments. Comment at: llvm/lib/ObjCopy/ELF/ELFObject.cpp:568 DebugCompressionType CompressionType, Error ) : SectionBase(Sec), CompressionType(CompressionType),

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. In D121629#3380175 , @lebedev.ri wrote: > Please can you pose the next patch itself? > I suspect that propagation should simply not be done when sanitizer is > enabled. I'm working on the next patch. Sadly we can't omit

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:923 + void initializeLocal(ASTContext , SourceLocation loc) {} + + QualType getInnerType() const { return getTypePtr()->getWrappedType(); } yonghong-song wrote: > aaron.ballman

  1   2   3   >