[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin added a comment. I will probably land that soon if there are no further issue According to my notes, i then need to - Cleanup `clang/test/SemaCXX/constant-expression-cxx14.cpp` (remove -Werror, #ifdef) - Add braces in `CheckConstexprFunctionStmt` - We may still miss a compatibility

[PATCH] D122224: Allow -Wno-gnu to silence GNU extensions related to pointer arithmetic

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. TIL about `Extension<>` and `-verify=`. Thanks @aaron.ballman ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal marked an inline comment as done. steakhal added a comment. Now it should be much smaller. Sorry for not doing this in the first place. Comment at: clang/utils/TableGen/ClangSACheckersEmitter.cpp:90-91 + + return

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoChecker.cpp:68-71 + if (ErrnoLoc) { +ErrnoRegion = ErrnoLoc->getAsRegion(); +assert(ErrnoRegion && "The 'errno' location should be a memory region."); + } NoQ wrote: >

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG683e83c56f98: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 683e83c - [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

Author: Corentin Jabot Date: 2022-03-22T19:51:19+01:00 New Revision: 683e83c56f98df6fe42d506a04dda44309ca758f URL: https://github.com/llvm/llvm-project/commit/683e83c56f98df6fe42d506a04dda44309ca758f DIFF:

[clang] 8f05736 - [Clang][NFC] Add braces to help readability

Author: Corentin Jabot Date: 2022-03-22T20:12:20+01:00 New Revision: 8f057362a87f1b3c6072c1d0c4d66867ded99669 URL: https://github.com/llvm/llvm-project/commit/8f057362a87f1b3c6072c1d0c4d66867ded99669 DIFF:

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. Just a formality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756

[PATCH] D122255: Meta directive runtime support

jdoerfert added subscribers: ggeorgakoudis, mikerice, cchen. jdoerfert added a comment. This contains a lot of unrelated changes, leftover comments, etc. As you clean up the code, please also include tests. Clang format the patch, go over the new code and make sure you follow the coding style.

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

zixuw added a comment. LGTM. Need to rebase. Do you think `ProductName` should be a general property of `APISerializer` or something specific to the `SymbolGraphSerializer`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi added a comment. Sorry, I flagged this as "accepted", but I'm not sure I am allowed to do that... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

MaskRay added a comment. > Previously, omitting unnecessary DWARF unwinds was only done for watchOS, I have looked at compact unwind descriptors in 2020-11 to write https://maskray.me/blog/2020-11-08-stack-unwinding#compact-unwind-descriptors I vaguely remember there is a place where DWARF

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:66-67 - if (T.isWatchABI()) -OmitDwarfIfHaveCompactUnwind = true; @MaskRay > I vaguely remember there is a place where DWARF unwind info is enabled for > all but few environments

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">; mgehre-amd wrote: >

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

aaron.ballman added a comment. In D111400#3400011 , @hubert.reinterpretcast wrote: > Confirming LGTM with minor comments. > > In D111400#3399929 , @cor3ntin > wrote: > >> - We may still miss a compatibility

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal updated this revision to Diff 417344. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121387/new/ https://reviews.llvm.org/D121387 Files: clang/test/Analysis/diagnostics/Inputs/expected-sarif/sarif-multi-diagnostic-test.c.sarif clang/utils/TableGen/ClangSACheckersEmitter.cpp

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417361. zixuw marked 3 inline comments as done. zixuw added a comment. Address review issues: - Documenting the responsibility of keeping StringRefs alive for APISet - Remove unnecessary `static` for helper functions in an anonymous namespace Repository:

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

devin.jeanpierre added a comment. Please revert it, I don't have easy access to a Windows machine at work so am struggling with the reproduction instructions. This has failed twice, and this time with a one month delay! Is there any way to run and confirm all tests pass before I try to merge

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. abidmalikwaterloo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang,

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2694-2697 +if (!Matches[i].empty()) { + res = Matches[i]; + break; +} Comment at:

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG89f6b26f1beb: [clang][extract-api] Refactor ExtractAPI and improve docs (authored by zixuw). Changed prior to commit: https://reviews.llvm.org/D122160?vs=417365=417383#toc Repository: rG LLVM Github

[clang] 89f6b26 - [clang][extract-api] Refactor ExtractAPI and improve docs

Author: Zixu Wang Date: 2022-03-22T13:21:57-07:00 New Revision: 89f6b26f1beb2c1344f5cfeb34e405128544c76b URL: https://github.com/llvm/llvm-project/commit/89f6b26f1beb2c1344f5cfeb34e405128544c76b DIFF: https://github.com/llvm/llvm-project/commit/89f6b26f1beb2c1344f5cfeb34e405128544c76b.diff

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 created this revision. int3 added reviewers: davide, kledzik, lhames. Herald added subscribers: StephenFan, cmtice, hiraditya, kristof.beyls, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a project: All. int3 requested review of this

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417328. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - add comments, remove test requirement on 64b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers added a comment. In D122189#3399836 , @DavidSpickett wrote: > Can you post a bit of the header diff before/after? I think I know what it > looks like but just to be sure. Before: #define __noswap_splat_lane_f16(__p0,__p1) __extension__

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt; increase max _BitInt size

mgehre-amd marked 3 inline comments as done. mgehre-amd added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8422 +def err_int_to_float_bit_int_max_size : Error< + "cannot convert '_BitInt' operands of more than %0 bits to floating point">;

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122249 Files:

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam updated this revision to Diff 417356. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122155/new/ https://reviews.llvm.org/D122155 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin added a comment. @hubert.reinterpretcast @aaron.ballman @erichkeane Thanks a lot for the review. I'm working on making PRs for the further changes we agreed to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +"results of

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 417379. kwk added a comment. - Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/lib/Format/Format.cpp

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:33 + : alias(Alias), loc(Loc) {} + inline IdentifierInfo *getAlias() const { return alias; } inline SourceLocation

[clang] 23d60ce - [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td.

Author: Zakk Chen Date: 2022-03-22T09:58:43-07:00 New Revision: 23d60ce164db48cfaff84967e86dd052801bf73a URL: https://github.com/llvm/llvm-project/commit/23d60ce164db48cfaff84967e86dd052801bf73a DIFF: https://github.com/llvm/llvm-project/commit/23d60ce164db48cfaff84967e86dd052801bf73a.diff

[PATCH] D120870: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23d60ce164db: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td. (authored by khchen). Herald added subscribers: s, StephenFan,

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

urnathan added a comment. In D122119#3398823 , @iains wrote: > > With the change here we now get: > cannot export redeclaration 'f' here since the previous declaration has > internal linkage > cannot export redeclaration 'S' here since the previous

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

cor3ntin updated this revision to Diff 417341. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

dblaikie added a comment. In D119409#3398483 , @ChuanqiXu wrote: > In D119409#3396690 , @dblaikie > wrote: > >> Not even necessarily then - if you have code like protobufs (large amounts >> of autogenerated

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417387. junfd added a comment. Check the mixing -fsplit-machine-functions and -fno-split-machine-functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files:

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added a comment. Does anyone implement/take care of the "otherwise" clause? If I am correct, OpenMP 5.2 supports otherwise instead of the default for meta directive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120573/new/

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121525/new/ https://reviews.llvm.org/D121525

[clang] 2cedaee - [OpenMP] Initial parsing/sema for the 'omp parallel loop' construct

Author: Mike Rice Date: 2022-03-22T13:55:47-07:00 New Revision: 2cedaee6f7387b39f7a534883050d66fd78e15a4 URL: https://github.com/llvm/llvm-project/commit/2cedaee6f7387b39f7a534883050d66fd78e15a4 DIFF: https://github.com/llvm/llvm-project/commit/2cedaee6f7387b39f7a534883050d66fd78e15a4.diff

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

urnathan added a comment. yeah, gcc's preprocessor has peeking code to deal with this (more generally than modules) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

urnathan added a comment. In D122119#3398949 , @ChuanqiXu wrote: > > The first feeling I saw the change is that not every C++ programmer knows > about linkage. OK, it depends on the environment really and every one might > has their own opinion.

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

cor3ntin updated this revision to Diff 417376. cor3ntin added a comment. - fix formatting - use cxx2b in the test as per aaron request. This doesn't really matter as this part of the test file is only executed in c++2b mode though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk marked 2 inline comments as done. kwk added a comment. @HazardyKnusperkeks I've addressed your comments and did an early return together with `llvm_unreachable()` which is used in the `clang/lib/Format` in other places as well. I hope this is to your liking. There's no longer an `assert`.

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417386. hubert.reinterpretcast marked 2 inline comments as done. hubert.reinterpretcast added a comment. - Address review comments: Use default member init in WeakInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

andrew.w.kaylor added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has not effect when numeric " +

[PATCH] D122224: Allow -Wno-gnu to silence GNU extensions related to pointer arithmetic

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've landed in c3fe8ddd8385832fde9f16a261908afbaf9878a4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoChecker.cpp:47-49 + mutable bool ErrnoInitialized = false; + mutable Optional ErrnoLoc; + mutable const MemRegion *ErrnoRegion = nullptr; steakhal wrote: > One should not define

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:492 +Diag(Loc, + diag::warn_eval_method_setting_via_pragma_in_value_unsafe_context); FpPragmaStack.Act(Loc, PSK_Set, StringRef(), NewFPFeatures); Not sure if I should repeat

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2725 +def warn_cxx20_compat_constexpr_var : Warning< + "definition of a %select{static variable|thread_local variable|variable of non-literal type}1 " "in a constexpr

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

xbolva00 added a comment. >> the remaining changes are code formatting Please remove code formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248

[PATCH] D122261: [Clang][NFC] Some `const` for `IdentifierInfo *`s feeding `DeclarationName`

hubert.reinterpretcast created this revision. hubert.reinterpretcast added a reviewer: aaron.ballman. Herald added a project: All. hubert.reinterpretcast requested review of this revision. Herald added a project: clang. `DeclarationName` already takes `const IdentifierInfo *`. Propagate the

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz updated this revision to Diff 417331. adamcz added a comment. Reverted to previous version + new test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121824/new/ https://reviews.llvm.org/D121824 Files: clang/lib/Sema/TreeTransform.h

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

adamcz added a comment. In D121824#3399208 , @sammccall wrote: > I reduced something very similar recently as > https://github.com/clangd/clangd/issues/1073 > > This patch does not fix it, but looks closely related, want to take a look? Very similar.

[clang] c3fe8dd - Allow -Wno-gnu to silence GNU extensions related to pointer arithmetic

Author: Aaron Ballman Date: 2022-03-22T13:15:13-04:00 New Revision: c3fe8ddd8385832fde9f16a261908afbaf9878a4 URL: https://github.com/llvm/llvm-project/commit/c3fe8ddd8385832fde9f16a261908afbaf9878a4 DIFF: https://github.com/llvm/llvm-project/commit/c3fe8ddd8385832fde9f16a261908afbaf9878a4.diff

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

NoQ added a comment. Looks like the API was used incorrectly 50% of the time anyway :) I have one nit but other than that looks good. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2570 + State, TotalSize.castAs(), +

[PATCH] D111400: [Clang][C++2b] P2242R3: Non-literal variables [...] in constexpr

hubert.reinterpretcast added a comment. Confirming LGTM with minor comments. In D111400#3399929 , @cor3ntin wrote: > - We may still miss a compatibility warning for non-literal in c++23 mode? My understanding is that Aaron and I both want the warning

[PATCH] D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error

steakhal created this revision. steakhal added reviewers: martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revision.

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuw updated this revision to Diff 417365. zixuw added a comment. Address review issue: remove unnecessary `copyString` overload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 Files:

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121812/new/ https://reviews.llvm.org/D121812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121525: [clang][deps] Create lit substitution for deps-to-rsp

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121525/new/ https://reviews.llvm.org/D121525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122255: Meta directive runtime support

jdoerfert added a comment. In D122255#3400636 , @abidmalikwaterloo wrote: > Is it okay if I can put comments on the patch? Not sure what you mean but feel free. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. looks resonable, 1 nit. Comment at: clang/lib/Driver/Driver.cpp:2453 // Disambiguate headers that are meant to be header units from those -// intended

[PATCH] D122243: [analyzer][NFC] Introduce the checker package separator character

steakhal created this revision. steakhal added reviewers: martong, Szelethus. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review of this revision.

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/inconsistent-export-template.cpp:1-11 +// RUN: %clang_cc1 -std=c++20 %s -S -emit-llvm -triple %itanium_abi_triple -disable-llvm-passes -o - | FileCheck %s + +export module m; +export template +void f() { +} +

[PATCH] D122119: [C++20][Modules] Adjust handling of exports of namespaces and using-decls.

dblaikie added a comment. SOrry, I don't have much context here - the more informative (module/internal linkage) diagnostic does seem better to me than saying "is not exported", even if it's a bit esoteric for some users. We do have other diagnostics that mention linkage, I'm sure (because

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

dexonsmith accepted this revision. dexonsmith added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 ___ cfe-commits mailing list

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

aaron.ballman added a comment. In D119017#3400347 , @devin.jeanpierre wrote: > Please revert it, I don't have easy access to a Windows machine at work so am > struggling with the reproduction instructions. Thanks for letting us know! @Manna -- I'll

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman added a comment. FWIW, I plan to land this sometime tomorrow (Mar 23) unless there are additional review comments before then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https://reviews.llvm.org/D122029 ___

[PATCH] D121812: [clang][deps] NFC: De-duplicate clang-cl tests

saudi accepted this revision. saudi added a comment. This revision is now accepted and ready to land. It is indeed much cleaner this way`, thanks! The tests are not anymore the same for `clang-cl` as for `clang`, but I agree what needs testing is the clang-cl specific behaviors, not having the

[PATCH] D122255: Meta directive runtime support

abidmalikwaterloo added a comment. Is it okay if I can put comments on the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122255/new/ https://reviews.llvm.org/D122255 ___ cfe-commits mailing list

[PATCH] D122202: [clang][extract-api] Add struct support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:375 + case APIRecord::RK_StructField: +Kind["identifier"] = AddLangPrefix("struct.field"); +Kind["displayName"] = "Struct Field"; "property" instead of

[PATCH] D117391: [AST] Ignore implicit nodes in CastExpr::getConversionFunction

kimgr closed this revision. kimgr added a comment. Herald added a project: All. Now that D119477 has landed, this suggested change is obsolete. Closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117391/new/

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:62 +return false; + return LHS.getAlias()->getName() == RHS.getAlias()->getName(); +}

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added a comment. Just a side note, I often get this on your changes: Unhandled Exception ("Exception") Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file . Comment at:

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:33 + : alias(Alias), loc(Loc) {} + inline IdentifierInfo *getAlias() const { return alias; } inline SourceLocation getLocation() const { return loc; }

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers updated this revision to Diff 417450. vabridgers added a comment. remove assert that was commented out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122277/new/ https://reviews.llvm.org/D122277 Files:

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417458. junfd added a comment. Apply clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[clang] 818e72d - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-22T18:39:16-07:00 New Revision: 818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db URL: https://github.com/llvm/llvm-project/commit/818e72d1b09bc5fc3b7a2c9f90b981a9c0d2a5db DIFF:

[PATCH] D122199: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in TargetInfo.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG818e72d1b09b: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121359: [AVR] Add more devices

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6edfe45a6312: [AVR] Add more devices (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai updated this revision to Diff 417468. vsapsai added a comment. Fix bug with anonymous enum constant lookup in C++. Turns out the lookup was broken by using `ObjCInterfaceDecl` as a semantic decl context for anonymous enums. Fixing that fixed the lookup. Also added in tests checking

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

jyknight added a comment. Given that this is an error `error: functions cannot be declared in an anonymous struct` (thus you can assume that function declarations inside a struct imply that the struct MUST have a linkage name) struct { static int foo(); }; then I don't think there's

[PATCH] D120134: [analyzer] refactor makeIntValWithPtrWidth, remove getZeroWithPtrWidth (NFC)

vabridgers updated this revision to Diff 417415. vabridgers added a comment. update per @NoQ's latest comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120134/new/ https://reviews.llvm.org/D120134 Files:

[PATCH] D122202: [clang][extract-api] Add struct support

zixuw updated this revision to Diff 417430. zixuw added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/ https://reviews.llvm.org/D122202 Files: clang/include/clang/ExtractAPI/API.h

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417443. hubert.reinterpretcast added a comment. - Address review comments: Add release notes, expand comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121927/new/

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D120397#3399808 , @aaron.ballman wrote: > Can you also add a release note that explains we've fixed the crash? My thought is to edit a release note standalone. Since there are

[PATCH] D121824: [clang] Do not crash on arrow operator on dependent type.

sammccall added a comment. Oops, forgot conclusion: Thanks for incorporating my testcase, and the patch LGTM in its current form (most of the alternatives discussed also sound OK). I'll leave to Haojian to stamp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122265: [Clang][NFC] Cleanup dcl.constexpr/p3 tests

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Check for warnings instead of using -Werror, to avoid masking the type of diagnostic emitted - use different -verify

[PATCH] D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check

This revision was automatically updated to reflect the committed changes. fwolff marked an inline comment as done. Closed by commit rG07675b0b38e9: [clang-tidy] Fix false positives in `misc-redundant-expression` check (authored by fwolff). Changed prior to commit:

[clang-tools-extra] 07675b0 - [clang-tidy] Fix false positives in `misc-redundant-expression` check

Author: Fabian Wolff Date: 2022-03-23T00:32:45+01:00 New Revision: 07675b0b38e930c2c582122ac93efcdf7859a772 URL: https://github.com/llvm/llvm-project/commit/07675b0b38e930c2c582122ac93efcdf7859a772 DIFF: https://github.com/llvm/llvm-project/commit/07675b0b38e930c2c582122ac93efcdf7859a772.diff

[PATCH] D122277: [analyzer] Fix crash in RangedConstraintManager.cpp

vabridgers created this revision. vabridgers added reviewers: martong, NoQ. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

fwolff created this revision. fwolff added reviewers: rsmith, cor3ntin, mizvekov. fwolff added a project: clang. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes #50794 .

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a subscriber: urnathan. ChuanqiXu added a comment. In D119409#3400287 , @dblaikie wrote: > In D119409#3398483 , @ChuanqiXu > wrote: > >> In D119409#3396690

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

MaskRay added a comment. Herald added a subscriber: StephenFan. This may need a test in `clang/test/Misc/cc1as-*`. Can you add to the description what the `clang -cc1as` usage looks like? Comment at: clang/tools/driver/cc1as_main.cpp:217 +llvm::Triple TVT(A->getValue());

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

abidmalikwaterloo added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1793 +void CodeGenFunction::EmitOMPMetaDirective(const OMPMetaDirective ) { + llvm::BasicBlock *AfterBlock = + createBasicBlock("omp.meta.user.condition.after"); Why

  1   2   3   >