[clang-tools-extra] cc7ed0c - [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

Author: Balázs Kéri Date: 2022-04-07T09:38:58+02:00 New Revision: cc7ed0caaca58bb38c789dcf2e0aade5f68f1e02 URL: https://github.com/llvm/llvm-project/commit/cc7ed0caaca58bb38c789dcf2e0aade5f68f1e02 DIFF: https://github.com/llvm/llvm-project/commit/cc7ed0caaca58bb38c789dcf2e0aade5f68f1e02.diff

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc7ed0caaca5: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D118370?vs=416435=421112#toc

[PATCH] D123286: Patch for : omp nothing

koops created this revision. koops added reviewers: dreachem, soumitra, cchen, jdoerfert. Herald added a project: All. koops requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Patch to support "#pragma omp nothing"

[PATCH] D123122: [OpaquePtr][Clang] Add CLANG_ENABLE_OPAQUE_POINTERS cmake option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5390606aa963: [OpaquePtr][Clang] Add CLANG_ENABLE_OPAQUE_POINTERS cmake option (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D123211: [flang][driver] Add support for generating LLVM bytecode files

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. In D123211#3433059 , @awarzynski wrote: > Thanks for taking a look Diana! > >> Why not use the BackendAction for this? > > This action only requires

[clang] 5479174 - [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

Author: Balázs Kéri Date: 2022-04-07T11:07:15+02:00 New Revision: 5479174071ec7d4692959bbdc15b5bb79e268e00 URL: https://github.com/llvm/llvm-project/commit/5479174071ec7d4692959bbdc15b5bb79e268e00 DIFF: https://github.com/llvm/llvm-project/commit/5479174071ec7d4692959bbdc15b5bb79e268e00.diff

[PATCH] D122528: [clang][ASTImporter] Not using consumeError at failed import of in-class initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5479174071ec: [clang][ASTImporter] Not using consumeError at failed import of in-class… (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D122528?vs=418395=421132#toc

[clang-tools-extra] be572e1 - [clangd] NFC: Fix doc typos

Author: Kirill Bobyrev Date: 2022-04-07T12:56:56+02:00 New Revision: be572e1e1d297039129b0c4ff2deffd817e42f30 URL: https://github.com/llvm/llvm-project/commit/be572e1e1d297039129b0c4ff2deffd817e42f30 DIFF:

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. In D116203#3434761 , @rjmccall wrote: > In D116203#3434515 , @cjdb wrote: > >> In D116203#3431612 , @rjmccall >> wrote: >> >>> In

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

cor3ntin added a comment. In D123298#3435770 , @aaron.ballman wrote: > Changes LGTM, I also don't think we should hit these limits. Perhaps we > should add some assertions to the ctor and the setter functions just to be > sure though? If we are going

[PATCH] D123297: [flang][driver] Add support for -mmlir

rovka added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rovka wrote: > Is this the most llvm-ish option we have? I'm concerned

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 421122. manas added a comment. Fix comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files:

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 421134. manas added a comment. Format constant-folding.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files:

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang updated this revision to Diff 421143. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123148/new/ https://reviews.llvm.org/D123148 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

kuzkry added a comment. Hi, I've got yet another one. Luckily, nothing wrong with clang-format 10, all were fine. This one was the only option incorrectly marked as clang-format 9. Note, AllowShortIfStatementsOnASingleLine was introduced by 1b750edda14879a16ce782b3ade3af599bfbb717

[PATCH] D123297: [flang][driver] Add support for -mmlir

rovka added a comment. I don't know the command line library that well, so I have this curiosity: what happens if LLVM and MLIR have 2 different options with the same name? Do we get a compile time error? Or is there a risk that someone might -mllvm -XYZ and it would end up in MLIR's XYZ

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

aaron.ballman added a comment. In D123298#3435796 , @cor3ntin wrote: > In D123298#3435770 , @aaron.ballman > wrote: > >> Changes LGTM, I also don't think we should hit these limits. Perhaps we >> should add

[PATCH] D122008: [flang][driver] Add support for generating executables

rovka added a comment. Just for the record, I'd like to speak in favor of option 2 - merge the patch now, but put the functionality behind a flag. This sounds like a good compromise to me. I think if we choose an inconspicuous name like -fexperimentail-test-driver-integration-with-cmake (or

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2113-2117 if (CanonicalType->isRecordType()) { - TmpRes = dumpRecord(CGF, CanonicalType, FieldPtr, Align, Func, Lvl + 1); + TmpRes = dumpRecord(CGF, CanonicalType, FieldLV, Align, Func, Lvl

[PATCH] D123299: [clang-format][docs] Fix incorrect 'clang-format 9' option marker

kuzkry created this revision. kuzkry added reviewers: MyDeveloperDay, HazardyKnusperkeks. kuzkry added a project: clang-format. Herald added a project: All. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Introduced by 23a5090c6

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 421159. mboehme added a comment. Add documentation and a unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/include/clang/Basic/Attr.td

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Changes LGTM, I also don't think we should hit these limits. Perhaps we should add some assertions to the ctor and the setter functions just to be sure though? Repository: rG

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I'm not an expert in CMake, but the changes look reasonable from what I do know. The current bot failures all look to be unrelated to the changes in this patch as best I can

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman added a comment. In D122808#3435821 , @antoniofrighetto wrote: > Awesome, thank you for reviewing this! PS: I do not have commit access, feel > free to close it, if you say. Ah, thank you for letting me know you don't have commit access.

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto updated this revision to Diff 42. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 Files: clang/include/clang/AST/DeclarationName.h llvm/include/llvm/ADT/STLExtras.h llvm/unittests/ADT/STLExtrasTest.cpp Index:

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski created this revision. awarzynski added a reviewer: rovka. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett added reviewers: amilendra, tmatheson. DavidSpickett added a comment. The background here is that I want to automate what I did in https://reviews.llvm.org/D121999 and thought I could do that by passing 0xf...f to getExtensionFeatures. I thought there might be some reason to not

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 421103. balazske added a comment. Removed a left comment and improved another comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files:

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

kuzkry added a subscriber: owenpan. kuzkry added a comment. @owenpan, thank you for delivery. > You just could ask for push rights, especially if you want to change > something more in the future. I will request it then. Hopefully I get accepted as apparently they check for a good "record of

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

hans added a comment. In D123070#3430207 , @ekieri wrote: > @hans , thanks, that is a valid concern. I was asked to add closing comments > on an earlier patch though, and I find them particularly useful (when > accurate...) in this file, which does not

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

dang created this revision. dang added reviewers: zixuw, ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123295 Files:

[PATCH] D119544: Deferred Concept Instantiation Implementation

ChuanqiXu added a comment. I've read the whole patch. It looks good to me roughly except some style issues and the 2 places you marked as ` Attn Reviewers`. Let's try to fix them one by one. Comment at: clang/lib/Sema/SemaTemplate.cpp:4705 CheckConstraintSatisfaction(

[clang] 82d0f7b - [Clang] Remove redundant -no-opaque-pointers flag in test (NFC)

Author: Nikita Popov Date: 2022-04-07T13:53:37+02:00 New Revision: 82d0f7bdb5b542118f54aa03fac52e7a8f776123 URL: https://github.com/llvm/llvm-project/commit/82d0f7bdb5b542118f54aa03fac52e7a8f776123 DIFF: https://github.com/llvm/llvm-project/commit/82d0f7bdb5b542118f54aa03fac52e7a8f776123.diff

[clang] 5390606 - [OpaquePtr][Clang] Add CLANG_ENABLE_OPAQUE_POINTERS cmake option

Author: Nikita Popov Date: 2022-04-07T10:14:56+02:00 New Revision: 5390606aa963a7b415da65aa8120efbbafd30401 URL: https://github.com/llvm/llvm-project/commit/5390606aa963a7b415da65aa8120efbbafd30401 DIFF: https://github.com/llvm/llvm-project/commit/5390606aa963a7b415da65aa8120efbbafd30401.diff

[clang] b16a3b4 - [Clang] Add -no-opaque-pointers to more tests (NFC)

Author: Nikita Popov Date: 2022-04-07T12:53:29+02:00 New Revision: b16a3b4f3bbd6f9f1f8d3a1525804dd5754c0adf URL: https://github.com/llvm/llvm-project/commit/b16a3b4f3bbd6f9f1f8d3a1525804dd5754c0adf DIFF: https://github.com/llvm/llvm-project/commit/b16a3b4f3bbd6f9f1f8d3a1525804dd5754c0adf.diff

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the new interface and fixes! (Current Precommit CI failures look unrelated to me.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added inline comments. Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:994 + enum A { Zero = 0, One = 1 }; + enum B { IntMax = INT_MAX, ULongLongMax = ULLONG_MAX }; + enum class C : unsigned { Two = 2 }; aaron.ballman wrote: > It looks like

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet created this revision. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[clang-tools-extra] 817df79 - [clang-tidy] Silence unused variable warning in release builds. NFCI.

Author: Benjamin Kramer Date: 2022-04-07T11:00:28+02:00 New Revision: 817df7999a71a5dbda0025b75612b54160fb5f9c URL: https://github.com/llvm/llvm-project/commit/817df7999a71a5dbda0025b75612b54160fb5f9c DIFF:

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

dang accepted this revision. dang added a comment. LGTM thanks for spotting this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123259/new/ https://reviews.llvm.org/D123259 ___ cfe-commits mailing list

[PATCH] D123115: [OpaquePtrs][Clang] Add -no-opaque-pointers to tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG532dc62b9075: [OpaquePtrs][Clang] Add -no-opaque-pointers to tests (NFC) (authored by nikic). Herald added a project: clang. Herald added a

[PATCH] D120989: Support debug info for alias variable

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1ea0191a420: [clang][DebugInfo] Support debug info for alias variable (authored by kavitha-natarajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b1ea019 - [clang][DebugInfo] Support debug info for alias variable

Author: Kavitha Natarajan Date: 2022-04-07T17:15:40+05:30 New Revision: b1ea0191a42074341847d767609f66a26b6d5a41 URL: https://github.com/llvm/llvm-project/commit/b1ea0191a42074341847d767609f66a26b6d5a41 DIFF:

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Looks like this causes a relocation failure on this buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/7311 ld.lld: error: relocation R_MIPS_64 cannot be used against local symbol; recompile with -fPIC >>> defined in

[PATCH] D123296: [llvm][AArch64] Generate getExtensionFeatures from the list of extensions

DavidSpickett created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This takes the AARCH64_ARCH_EXT_NAME in

[PATCH] D123298: [NFC] [AST] Reduce the size of TemplateParmPosition

ChuanqiXu created this revision. ChuanqiXu added reviewers: erichkeane, aaron.ballman, cor3ntin. ChuanqiXu added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. I found

[PATCH] D122808: [clang] Fix warnings when `-Wdeprecated-enum-enum-conversion` is enabled

antoniofrighetto added a comment. Awesome, thank you for reviewing this! PS: I do not have commit access, feel free to close it, if you say. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122808/new/ https://reviews.llvm.org/D122808 ___

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 added a comment. Herald added a project: All. @Quuxplusone I can commit this patch on behalf of @fanfuqiang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://reviews.llvm.org/D92956

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik created this revision. shafik added reviewers: aprantl, dblaikie, probinson. Herald added a project: All. shafik requested review of this revision. D70524 added support for auto return types for C++ member functions. I was implementing support on the LLDB

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a comment. I think this is reasonable, but could you add a testcase? Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1684 + +if (AT->isDeduced() && ThisPtr->getPointeeCXXRecordDecl()->isLambda()) +

[PATCH] D123308: Handle a subtle hole in inline builtin handling

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the quick fix! Comment at: clang/lib/CodeGen/CGExpr.cpp:4968-4969 // name to make it clear it's not the actual builtin. -if

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15627 +Value *Y = +Builder.CreateAnd(EmitScalarExpr(E->getArg(1)), Builder.CreateNot(Op3)); return Builder.CreateOr(X, Y); nemanjai wrote: > Nit: I understand that we

[PATCH] D123297: [flang][driver] Add support for -mmlir

mehdi_amini added a comment. `-mmlir` is fine with me, but note that MLIR has much less global options than LLVM: you will only get access to context and passmanager options and not individual passes flags. That's not a criticism :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao updated this revision to Diff 421305. rZhBoYao added a comment. Handling of eagerly parsed deleted or defaulted function must happen AFTER `D.complete(Res);`. A nice looking diff: https://github.com/poyaoc97/llvm-project/commit/dc37a262582f6a2d8143c6f1f586dc657b4b5311 CHANGES SINCE

[PATCH] D97121: [clang-tidy] Add a Standalone diagnostics mode to clang-tidy

njames93 updated this revision to Diff 421310. njames93 added a comment. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97121/new/ https://reviews.llvm.org/D97121 Files:

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar added inline comments. Comment at: clang/docs/HLSLSupport.rst:190 +* RTTI +* Exceptions +* Multiple inheritance How about goto and labels? Irreducible control flow? Are infinite loops valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

This revision was automatically updated to reflect the committed changes. Closed by commit rG101559225189: [clang][extract-api][NFC] Use dedicated API to check for macro equality (authored by dang). Changed prior to commit: https://reviews.llvm.org/D123295?vs=421147=421290#toc Repository:

[clang] 50de659 - [clang] Use -triple, not -target for %clang_cc1

Author: Alex Brachet Date: 2022-04-07T18:19:54Z New Revision: 50de659adcc19c4c197ba5e9a7719325af7151ee URL: https://github.com/llvm/llvm-project/commit/50de659adcc19c4c197ba5e9a7719325af7151ee DIFF: https://github.com/llvm/llvm-project/commit/50de659adcc19c4c197ba5e9a7719325af7151ee.diff LOG:

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123278: [Clang] [Docs] Add HLSLSupport page

kuhar added a comment. Looks good to me overall, I just left some local comments. Please take my writing suggestions with a pinch of salt, English is my second language. Comment at: clang/docs/HLSLSupport.rst:13 +describes the high level goals of the project, the guiding

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123295/new/ https://reviews.llvm.org/D123295 ___

[PATCH] D92956: Fix range-loop-analysis checks for trivial copyability

gandhi21299 added a comment. Perhaps, a description could be added to this patch before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92956/new/ https://reviews.llvm.org/D92956 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. In D116203#3435729 , @aaron.ballman wrote: > In D116203#3434761 , @rjmccall > wrote: > >> In D116203#3434515 , @cjdb wrote: >> >>> In

[PATCH] D122008: [flang][driver] Add support for generating executables

rouson added a comment. I also very much like the second option. I think it prevents a naive user from stumbling into treacherous territory. Also, as someone who is funded to write tests for flang, making it easier to build executables would expand the options for testing. Currently, we're

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421279. quinnp marked an inline comment as done. quinnp added a comment. Fixing some testcases that broke due to re-ordering IR in my last update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/

[clang] 3329dae - [clang] Fix macos build broken after D120989

Author: Alex Brachet Date: 2022-04-07T18:17:29Z New Revision: 3329dae5cb8a8c91c518dd87c09e88c4fad507bd URL: https://github.com/llvm/llvm-project/commit/3329dae5cb8a8c91c518dd87c09e88c4fad507bd DIFF: https://github.com/llvm/llvm-project/commit/3329dae5cb8a8c91c518dd87c09e88c4fad507bd.diff LOG:

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", I'd prefer not to use `dyn_cast` as

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked an inline comment as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D,

[clang] aebe5fc - [clang][extract-api] Process only APIs declared in inputs

Author: Daniel Grumberg Date: 2022-04-07T17:49:05+01:00 New Revision: aebe5fc6e7d8ab99f3796067d430752552932d28 URL: https://github.com/llvm/llvm-project/commit/aebe5fc6e7d8ab99f3796067d430752552932d28 DIFF:

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaebe5fc6e7d8: [clang][extract-api] Process only APIs declared in inputs (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. The ScudoCUnitTest-mips64el-Test failure looks like a mips64el specific issue. FAILED: lib/scudo/standalone/tests/ScudoCUnitTest-mips64el-Test cd /b/sanitizer-x86_64-linux-qemu/build/llvm_build2_debug_mips64el_qemu/lib/scudo/standalone/tests &&

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. Here are my remarks. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1415-1416 + + Range CoarseLHS = fillGaps(LHS); + Range CoarseRHS = fillGaps(RHS); + Avoid filling the gaps, because it's completely

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman added a comment. In D116203#3436572 , @cjdb wrote: > Having `__remove_cv` do more than it's advertised to do doesn't sound like a > great idea to me. Both libc++ >

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4048aad85a84: [clang][ExtractAPI] Fix declaration fragments for ObjC methods (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES

[clang] 4048aad - [clang][ExtractAPI] Fix declaration fragments for ObjC methods

Author: Zixu Wang Date: 2022-04-07T10:22:41-07:00 New Revision: 4048aad85a843d2b15cb8e60b2ea37f148b7b770 URL: https://github.com/llvm/llvm-project/commit/4048aad85a843d2b15cb8e60b2ea37f148b7b770 DIFF: https://github.com/llvm/llvm-project/commit/4048aad85a843d2b15cb8e60b2ea37f148b7b770.diff

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments. Comment at: clang/test/CodeGen/PowerPC/atomic-alignment.c:1-12 // RUN: %clang_cc1 -verify -triple

[PATCH] D123308: Handle a subtle hole in inline builtin handling

nickdesaulniers added a comment. Also, for the initial lines of commit messages, please try to make them less ambiguous about which parts of the project they touch. For example `[Clang][Fortify] drop inline decls when redeclared` is more descriptive should this get bucketed with other commits

[PATCH] D122008: [flang][driver] Add support for generating executables

tschuett added a comment. In my example, they even promised that the flag will removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 ___ cfe-commits mailing

[clang] b4ac849 - [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

Author: Pavel Samolysov Date: 2022-04-07T10:38:46-07:00 New Revision: b4ac84901e9b88429e5e51dc0b4a17b8d3e37708 URL: https://github.com/llvm/llvm-project/commit/b4ac84901e9b88429e5e51dc0b4a17b8d3e37708 DIFF:

[PATCH] D123026: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4ac84901e9b: [clang][NFC] Extract EmitAssemblyHelper::shouldEmitRegularLTOSummary (authored by psamolysov-intel, committed by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp updated this revision to Diff 421286. quinnp added a comment. Rebasing with main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121637/new/ https://reviews.llvm.org/D121637 Files: clang/lib/CodeGen/CGBuiltin.cpp

[clang] 1015592 - [clang][extract-api][NFC] Use dedicated API to check for macro equality

Author: Daniel Grumberg Date: 2022-04-07T19:08:17+01:00 New Revision: 101559225189e63b7f6236fb944501b1e6b74a87 URL: https://github.com/llvm/llvm-project/commit/101559225189e63b7f6236fb944501b1e6b74a87 DIFF:

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked 3 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D,

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

dhruvachak added a comment. In D102107#3434733 , @ggeorgakoudis wrote: > In D102107#3417452 , @dhruvachak > wrote: > >> I added https://github.com/llvm/llvm-project/issues/54654 documenting what I >> found

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. (@probinson as someone I've disagreed with about this before) Personally I think there's limited value in expressing 'auto' in DWARF at all - we could omit function declarations if the return type is not known (undeduced auto) and wouldn't lose much - basically

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 421270. jhuber6 added a comment. Make `-foffload-new-driver` imply GPU-RDC mode, it won't work otherwise. Also adjust tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120272/new/

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a comment. > Are there cases where we emit debug info and we don't have the deduced type? I don't think that would happen for a lambda. https://dwarfstd.org/ShowIssue.php?issue=131217.1 specifically calls out method declarations without definitions, which makes sense to me.

[PATCH] D120989: Support debug info for alias variable

thakis added a comment. This breaks tests on mac: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8817534773179515649/+/u/package_clang/stdout?format=raw Script: -- : 'RUN: at line 1'; /opt/s/w/ir/cache/builder/src/third_party/llvm-bootstrap/bin/clang -cc1

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added a comment. In D123297#3436867 , @mehdi_amini wrote: > `-mmlir` is fine with me, but note that MLIR has much less global options > than LLVM: you will only get access to context and passmanager options and > not individual passes

[clang] da1fc3a - [Driver][NFC] Simplify handling of flags in Options.td

Author: Emil Kieri Date: 2022-04-07T20:38:51+02:00 New Revision: da1fc3ae955da47dc43d8d2e8f4d5a52deac7cf9 URL: https://github.com/llvm/llvm-project/commit/da1fc3ae955da47dc43d8d2e8f4d5a52deac7cf9 DIFF: https://github.com/llvm/llvm-project/commit/da1fc3ae955da47dc43d8d2e8f4d5a52deac7cf9.diff

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

rZhBoYao marked 2 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Parse/Parser.cpp:1306 + bool Delete = + Tok.is(tok::equal) && NextToken().is(tok::kw_delete) ? true : false; Decl *Res = Actions.ActOnStartOfFunctionDef(getCurScope(), D,

[PATCH] D123070: [Driver][NFC] Simplify handling of flags in Options.td

This revision was automatically updated to reflect the committed changes. Closed by commit rGda1fc3ae955d: [Driver][NFC] Simplify handling of flags in Options.td (authored by ekieri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123070/new/

[PATCH] D122981: [Clang] Diagnose incomplete return/param types only when function is not deleted

erichkeane added a comment. This definitely looks like it is 'nicer' than before, a few smaller/nit-ish comments. Additionally, Phab made a REAL mess of the diff, if you could give a quick summary of what changes were actually made (vs things that were moved slightly and causing massive

[PATCH] D123297: [flang][driver] Add support for -mmlir

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} rriddle wrote: > awarzynski wrote: > > awarzynski wrote: > > > rovka

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

shafik added a comment. I did some experiments where I did not restrict this to lambdas case and I could not come up with a test case where we emit debug info and do not have the deduced type. Are there cases where we emit debug info and we don't have the deduced type? If not what do we gain

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

MaskRay added inline comments. Comment at: clang/test/Driver/cuda-openmp-driver.cu:10 +// CHECK: "nvptx64-nvidia-cuda" - "clang", inputs: ["[[INPUT:.+]]"], output: "[[PTX_SM_35:.+]]" +// CHECK: "nvptx64-nvidia-cuda" - "NVPTX::Assembler", inputs: ["[[PTX_SM_35]]"], output:

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

MaskRay added inline comments. Comment at: clang/test/Driver/cuda-openmp-driver.cu:1 +// REQUIRES: clang-driver +// REQUIRES: x86-registered-target clang-driver is unneeded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. In preparation for allowing other

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Neat! I think you've broken the FilesToTokenCache by moving it into the loop, so I'd expect further wins from fixing that. (If you don't see any, something seems wrong: syntax::tokenize

[PATCH] D118927: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0fcbb37838a: [clang-tidy] Fix invalid fix-it for cppcoreguidelines-prefer-member-initializer (authored by njames93). Herald added a project: All. Changed prior to commit:

  1   2   >