[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

erichkeane added a comment. Herald added a subscriber: StephenFan. Note the error I found with this: https://github.com/llvm/llvm-project/issues/55038 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:534 + /// Returns true if implicit int is supported at all. + bool implicitIntEnabled() const { return !CPlusPlus && !C2x; } + erichkeane wrote: > This name seems inverse of

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. In D123300#3467615 , @yurai007 wrote: > Just one more thing regarding this: > > In D123300#3467165 , @yurai007 > wrote: > >> Hi, unfortunately for some reason it doesn't play well with

[PATCH] D124239: [analyzer] Fix ValistChecker false-positive involving symbolic pointers

steakhal updated this revision to Diff 424478. steakhal added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124239/new/ https://reviews.llvm.org/D124239 Files: clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp

[PATCH] D124262: compile commands header to source heuristic lower-cases filenames before inferring file types

ishaangandhi created this revision. ishaangandhi added reviewers: nridge, sammccall. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. ishaangandhi requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang.

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. Just one more thing regarding this: In D123300#3467165 , @yurai007 wrote: > Hi, unfortunately for some reason it doesn't play well with coroutines HALO. > There is regression seen on Gor's Nishanov classical code snippet: >

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 424470. steakhal added a comment. Added two new RUN lines, demonstrating the behavior of `support-symbolic-integer-casts={true,false}`. Also refined the match string to be less fuzzy. It helps to grasp the difference between the expectations. CHANGES

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

StailGot created this revision. StailGot added a project: clang-format. Herald added a project: All. StailGot requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for https://github.com/llvm/llvm-project/issues/47624 Used token for

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

erichkeane added a comment. Some quick comments... I didn't even bother opening the tests besides checking on functionality, so hopefully those are ok too :D Comment at: clang/docs/ReleaseNotes.rst:169 + As of C2x, support for implicit int has been removed, and the warning

[PATCH] D124132: Thread safety analysis: Don't pass capability kind where not needed (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124132/new/ https://reviews.llvm.org/D124132

[PATCH] D123300: [Clang] Enable opaque pointers by default

markus added a comment. In D123300#3467309 , @nikic wrote: > Sounds reasonable in general -- though isn't this a pre-existing problem > you'd see if you simply had multiple loads from the same global (without any > GEP)? Looking at the current

[PATCH] D86351: WIP: llvm-buildozer

aganea added inline comments. Comment at: llvm/lib/Analysis/MemorySSA.cpp:89 #ifdef EXPENSIVE_CHECKS -bool llvm::VerifyMemorySSA = true; +LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true; #else arsenm wrote: > Do command line flags like this really need to

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

erichkeane added a comment. I generally just question the usefulness of this. Despite its shortcomings, the 'dump struct' has the capability of runtime introspection into a type, whereas this seems to require that the user 'know' a significant amount about the type that they are introspecting

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), +

[clang] 4c4ff00 - [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

Author: Iain Sandoe Date: 2022-04-22T14:14:19+01:00 New Revision: 4c4ff004a2702b9b7538efd569bb621a5efac8f3 URL: https://github.com/llvm/llvm-project/commit/4c4ff004a2702b9b7538efd569bb621a5efac8f3 DIFF: https://github.com/llvm/llvm-project/commit/4c4ff004a2702b9b7538efd569bb621a5efac8f3.diff

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. The issue is in `clang/lib/Driver/ToolChains/Cuda.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/ https://reviews.llvm.org/D124253

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

martong added a comment. I'd like to have a guarantee that if `Opts.ShouldSupportSymbolicIntegerCasts` is set to `true` then the `SymboCast` is produced both for the scoped and the unscoped enums. Could you please have an additional lit test for that? At some point we'd like to make

[PATCH] D124256: [OpenCL] Add cl_khr_subgroup_rotate builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtins for the new OpenCL

[PATCH] D124255: [libc++] Make check_assertion.h use setjmp/longjmp instead of fork

john.brawn created this revision. john.brawn added reviewers: ldionne, Mordante, michaelplatings. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Currently

[PATCH] D124199: [randstruct] Check final randomized layout ordering

DavidSpickett added a comment. We (Linaro) also got the same failure: https://lab.llvm.org/buildbot/#/builders/186/builds/5626 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), + std::move(E.second)); +TrigramDocs.clear(); sammccall wrote: > the move

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 added a comment. In D124253#3467375 , @jhuber6 wrote: > Is this really the cause? `nvptx::assemble` should call `createOutputFile` > which makes a temp file to output to that is added to `TempFiles`. Hmm, that's interesting. After adding

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

jhuber6 added a comment. Is this really the cause? `nvptx::assemble` should call `createOutputFile` which makes a temp file to output to that is added to `TempFiles`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124253/new/

[PATCH] D124253: [Clang][OpenMP] Fix the issue that one temp cubin file is not removed after compilation

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

This revision was automatically updated to reflect the committed changes. Closed by commit rGf69328049e9e: [cc1as] Add support for emitting the build version load command for -darwin… (authored by bc-lee, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f693280 - [cc1as] Add support for emitting the build version load command for -darwin-target-variant

Author: Byoungchan Lee Date: 2022-04-22T08:38:07-04:00 New Revision: f69328049e9e7fde7a314de785c76c1b93e069b2 URL: https://github.com/llvm/llvm-project/commit/f69328049e9e7fde7a314de785c76c1b93e069b2 DIFF:

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 updated this revision to Diff 424449. jhuber6 added a comment. Moving some stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124220/new/ https://reviews.llvm.org/D124220 Files: clang/include/clang/Driver/Options.td

[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

thakis added a comment. Thanks! Comment at: clang/test/Misc/cc1as-darwin-target-variant-triple.s:2 +// Run cc1as using darwin-target-variant-triple +// RUN: %clang -cc1as -triple x86_64-apple-macos10.9 -darwin-target-variant-triple x86_64-apple-ios13.1-macabi -filetype obj %s

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG864752cfeba4: [AST] QualifiedTemplateName::getTemplateDecl cleanup. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 864752c - [AST] QualifiedTemplateName::getTemplateDecl cleanup.

Author: Haojian Wu Date: 2022-04-22T14:28:48+02:00 New Revision: 864752cfeba445652b6ee0e040da366894a86c88 URL: https://github.com/llvm/llvm-project/commit/864752cfeba445652b6ee0e040da366894a86c88 DIFF: https://github.com/llvm/llvm-project/commit/864752cfeba445652b6ee0e040da366894a86c88.diff

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

hokein updated this revision to Diff 424446. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124238/new/ https://reviews.llvm.org/D124238 Files:

[PATCH] D124199: [randstruct] Check final randomized layout ordering

thakis added a comment. Reverted in 8dbc6b560055ff5068ff45b550482ba62c36b5a5 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124199/new/ https://reviews.llvm.org/D124199

[clang] 8dbc6b5 - Revert "[randstruct] Check final randomized layout ordering"

Author: Nico Weber Date: 2022-04-22T08:27:32-04:00 New Revision: 8dbc6b560055ff5068ff45b550482ba62c36b5a5 URL: https://github.com/llvm/llvm-project/commit/8dbc6b560055ff5068ff45b550482ba62c36b5a5 DIFF: https://github.com/llvm/llvm-project/commit/8dbc6b560055ff5068ff45b550482ba62c36b5a5.diff

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the cleanup here! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124033/new/ https://reviews.llvm.org/D124033

[PATCH] D124128: Thread safety analysis: Store CapabilityExprs in ScopedLockableFactEntry (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a question (if we can't use `emplace_back()` the code is still fine). Comment at: clang/lib/Analysis/ThreadSafety.cpp:911-919 +

[PATCH] D124127: Thread safety analysis: Pack CapabilityExpr using PointerIntPair (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124127/new/ https://reviews.llvm.org/D124127

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. In D123300#3467278 , @markus wrote: > We have run into a slight performance degrading issue with our downstream > target. The situation is that we relay on the "consthoist" pass with option > "-consthoist-gep=1" to factor out the

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall updated this revision to Diff 424443. sammccall added a comment. Don't hardcode 5 dependence bits in abbreviaions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124250/new/ https://reviews.llvm.org/D124250 Files:

[PATCH] D123300: [Clang] Enable opaque pointers by default

markus added a comment. We have run into a slight performance degrading issue with our downstream target. The situation is that we relay on the "consthoist" pass with option "-consthoist-gep=1" to factor out the common parts of GEP expresseions to reduce the number of symbol references. For

[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When exprs are written

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

hans accepted this revision. hans added inline comments. Comment at: clang/docs/ReleaseNotes.rst:175 - Remove anonymous tag locations. - Beautify dump format, add indent for nested struct and struct members. +- Previously disabled sanitizer options now enabled by default

[PATCH] D123300: [Clang] Enable opaque pointers by default

yurai007 added a comment. Hi, unfortunately for some reason it doesn't play well with coroutines HALO. There is regression seen on Gor's Nishanov classical code snippet: https://godbolt.org/z/PKMxqq4Gr I'm checking IR to find out more. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb09ba4262076: Bug 51277: [DWARF] DW_AT_alignment incorrect when (authored by MaggieYi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b09ba42 - Bug 51277: [DWARF] DW_AT_alignment incorrect when

Author: Ying Yi Date: 2022-04-22T12:15:00+01:00 New Revision: b09ba42620768c0092b20cf526a30b14752a5dc9 URL: https://github.com/llvm/llvm-project/commit/b09ba42620768c0092b20cf526a30b14752a5dc9 DIFF: https://github.com/llvm/llvm-project/commit/b09ba42620768c0092b20cf526a30b14752a5dc9.diff LOG:

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, martong, steakhal, balazske, vsavchenko. zukatsinadze added a project: clang. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware,

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ItaniumMangle.cpp:2206 switch (TN.getKind()) { case TemplateName::QualifiedTemplate: +TD = TN.getAsQualifiedTemplateName()

[PATCH] D124242: [Frontend] shrink in-memory PCH buffers to fit

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After building a PCH, the vector capacity is on average ~1/3 unused. If we're

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), + std::move(E.second)); +TrigramDocs.clear(); the move here does nothing,

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-struct-align.cpp:11 +} __attribute__((aligned(1))); +struct MyType mt; + dblaikie wrote: > You can drop the "struct" here and from other references to these types (in > mt1/mt2 and the

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi updated this revision to Diff 424420. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124006/new/ https://reviews.llvm.org/D124006 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-struct-align.cpp Index:

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet updated this revision to Diff 424417. kadircet added a comment. Get rid of shrink_to_fit as PostingList representation doesn't really make a copy of the vector, but rather build a new representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D124239: [analyzer] Fix ValistChecker false-positive involving symbolic pointers

steakhal created this revision. steakhal added reviewers: NoQ, martong, xazax.hun, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this

[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This is a followup cleanup of 1234b1c6d8113d50beef5801be607ad1d502b2f7

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

DavidSpickett abandoned this revision. DavidSpickett added a comment. People are leaning toward fixes on the buildkite side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new/ https://reviews.llvm.org/D123601

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c6a14649843: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}… (authored by iains). Herald added a subscriber: MaskRay.

[clang] 5c6a146 - [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

Author: Iain Sandoe Date: 2022-04-22T09:24:29+01:00 New Revision: 5c6a14649843ccd2c50ed9e2fcacaa8ebd820ae8 URL: https://github.com/llvm/llvm-project/commit/5c6a14649843ccd2c50ed9e2fcacaa8ebd820ae8 DIFF: https://github.com/llvm/llvm-project/commit/5c6a14649843ccd2c50ed9e2fcacaa8ebd820ae8.diff

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

sammccall marked an inline comment as done. sammccall added a subscriber: hliao. sammccall added a comment. In D123668#3466376 , @maryammo wrote: > It seems it breaks the following builds: > https://lab.llvm.org/buildbot/#/builders/121/builds/18618 >

[PATCH] D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

steffenlarsen added a comment. In D100394#3466316 , @nirvedhmeshram wrote: > Hello, I was interested in using `llvm.nvvm.cp.async.cg.shared.global.8` and > `llvm.nvvm.cp.async.cg.shared.global.4` and was wondering if there is some > fundamental reason

[PATCH] D124215: [clang-format][NFC] Use isComment() in setCommentLineLevels()

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Thanks for the clean up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124215/new/ https://reviews.llvm.org/D124215

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. In D123874#3454723 , @MaskRay wrote: >> Add support to clang (-Wa,-generate-unused-section-symbols={yes|no}) and >> llvm-mc. > > > >>

[clang] 036aeac - [Testing] Fix the shared build. NFC.

Author: Michael Liao Date: 2022-04-22T02:46:54-04:00 New Revision: 036aeac36c00f4390e861118f536150b366beaaf URL: https://github.com/llvm/llvm-project/commit/036aeac36c00f4390e861118f536150b366beaaf DIFF: https://github.com/llvm/llvm-project/commit/036aeac36c00f4390e861118f536150b366beaaf.diff

[clang] 7898c79 - Fix test for c7ee0b8bda8b32a800bc01e9151b364446a6e1b1

Author: Brad Smith Date: 2022-04-22T02:27:10-04:00 New Revision: 7898c79b742f0dda6ec47b572f727fcd6d8ff54a URL: https://github.com/llvm/llvm-project/commit/7898c79b742f0dda6ec47b572f727fcd6d8ff54a DIFF: https://github.com/llvm/llvm-project/commit/7898c79b742f0dda6ec47b572f727fcd6d8ff54a.diff

[PATCH] D124199: [randstruct] Check final randomized layout ordering

MaskRay added a comment. In D124199#3466653 , @void wrote: > Maskray? I think this is likely the failure I saw when I tried fix forward in 46b2a463bdef1bd1d80abee869b09f95ca5a4fc2 .

Re: [PATCH] D124199: [randstruct] Check final randomized layout ordering

Maskray? On Thu, Apr 21, 2022 at 8:00 PM Nico Weber via Phabricator < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > Looks like this breaks tests on windows: > http://45.33.8.238/win/56771/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > >

[clang] c7ee0b8 - [Clang] Fix the guaranteed alignment of memory returned by malloc/new on OpenBSD

Author: Mark Kettenis Date: 2022-04-22T02:03:55-04:00 New Revision: c7ee0b8bda8b32a800bc01e9151b364446a6e1b1 URL: https://github.com/llvm/llvm-project/commit/c7ee0b8bda8b32a800bc01e9151b364446a6e1b1 DIFF: https://github.com/llvm/llvm-project/commit/c7ee0b8bda8b32a800bc01e9151b364446a6e1b1.diff

<    1   2