[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

sammccall added a comment. > With this priority, the thread is > confined to efficiency cores only, which makes background indexing take > forever (How) does this interact with battery vs mains power on laptops? It seems like there's a common scenario where: - the user is on a relatively slow

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. @krasimir could you please test this patch on your side? I've reopened it and tested it with the following file that contains both `//` and `/* ... */` trailing comments on include lines followed by `foo` and alike. The includes use `<...>` and `"..."` notation to locate

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 426702. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/Sema.h

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 426701. kwk added a comment. Address trailing comments on include lines by ignoring slashes in characters that lead up to the match groups. ^[\t\ ]*[@#][\t\ ]*(import|include)([^"/]*("[^"]+")|[^]+>)|[\t/\ ]*([^;]+;))

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong updated this revision to Diff 426700. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new/ https://reviews.llvm.org/D124701 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/no-builtin-2.c Index:

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Thank you for working on this! Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1023-1024 +// Typoed directive warnings +def TypoedDirective : DiagGroup<"typoed-directive">; +

[clang] 50b51b1 - Fix a typo in an OpenMP test

Author: Aaron Ballman Date: 2022-05-03T10:01:46-04:00 New Revision: 50b51b1860acbfb775d5e2eee3310e25c635d667 URL: https://github.com/llvm/llvm-project/commit/50b51b1860acbfb775d5e2eee3310e25c635d667 DIFF: https://github.com/llvm/llvm-project/commit/50b51b1860acbfb775d5e2eee3310e25c635d667.diff

[clang] 50c959b - Add explicit OpenMP 5.0 case for version macros; NFC

Author: Aaron Ballman Date: 2022-05-03T10:01:47-04:00 New Revision: 50c959b4fa4288127026a6a908c9a6d74b6f5d11 URL: https://github.com/llvm/llvm-project/commit/50c959b4fa4288127026a6a908c9a6d74b6f5d11 DIFF: https://github.com/llvm/llvm-project/commit/50c959b4fa4288127026a6a908c9a6d74b6f5d11.diff

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D124715#3484058 , @stefanhaller wrote: > Fix documentation of ThreadPriority::Low (was: Background), and move it up > from >

[PATCH] D124432: Fix issues with using clangd with C++ modules

kuganv updated this revision to Diff 426690. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124432/new/ https://reviews.llvm.org/D124432 Files: clang-tools-extra/clangd/test/modules-options-compatablity-test/A.h clang-tools-extra/clangd/test/modules-options-compatablity-test/B.h

[clang-tools-extra] 860eabb - Revert "[pseudo] Implement the GLR parsing algorithm."

Author: Haojian Wu Date: 2022-05-03T15:54:10+02:00 New Revision: 860eabb3953a104b2b85398c705cd32e33d86689 URL: https://github.com/llvm/llvm-project/commit/860eabb3953a104b2b85398c705cd32e33d86689 DIFF: https://github.com/llvm/llvm-project/commit/860eabb3953a104b2b85398c705cd32e33d86689.diff

[PATCH] D121150: [pseudo] Implement the GLR parsing algorithm.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeac22d0754f7: [pseudo] Implement the GLR parsing algorithm. (authored by sammccall, committed by hokein). Repository: rG LLVM Github Monorepo

[clang-tools-extra] eac22d0 - [pseudo] Implement the GLR parsing algorithm.

Author: Sam McCall Date: 2022-05-03T15:42:07+02:00 New Revision: eac22d0754f70df10ea0eb6f59cbd1ef012ab5a4 URL: https://github.com/llvm/llvm-project/commit/eac22d0754f70df10ea0eb6f59cbd1ef012ab5a4 DIFF: https://github.com/llvm/llvm-project/commit/eac22d0754f70df10ea0eb6f59cbd1ef012ab5a4.diff

[PATCH] D121150: [pseudo] Implement the GLR parsing algorithm.

hokein updated this revision to Diff 426680. hokein retitled this revision from "[pseudo] Implement the GLR parsing algorithm. " to "[pseudo] Implement the GLR parsing algorithm.". hokein added a comment. fix a dangling reference of the source text in clang-pseudo. Repository: rG LLVM

[PATCH] D121150: [pseudo] Implement the GLR parsing algorithm.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:143 +// parsing process (glrShift, or glrReduce). +using NewHeadCallback = +std::function nit: this is always used synchronously, so llvm::function_ref? we have a `captureNewHeads`

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein updated this revision to Diff 426679. hokein marked 6 inline comments as done. hokein added a comment. address remaining comments: - return GSS::node in the NewHeadCallback, rather the fields of GSS::Node; - remove the unncessary NewHeadResult structure in unittest; Repository: rG

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski updated this revision to Diff 426678. awarzynski marked 2 inline comments as done. awarzynski added a comment. Add an assert, make some editorial changes in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124667/new/

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski marked 8 inline comments as done. awarzynski added a comment. Thanks for the review @rovka! Comment at: flang/lib/Frontend/FrontendActions.cpp:86 + + // ... otherwise, generate an MLIR module from the input Fortran source bool res = RunPrescan() && RunParse() &&

[PATCH] D97625: fix check-clang-tools tests that fail due to Windows CRLF line endings

thakis added a comment. > So I went ahead and just fixed this in > ac5f7be6a8688955a282becf00eebc542238a86b > . As far as we can tell, this broke clang-move/move-used-helper-decls.cpp on our windows bot. D124563

[PATCH] D124091: [clang][AArch64][SVE] Implement conditional operator for SVE vectors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bc29d14273b: [clang][AArch64][SVE] Implement conditional operator for SVE vectors (authored by DavidTruby). Changed prior to commit:

[clang] 8bc29d1 - [clang][AArch64][SVE] Implement conditional operator for SVE vectors

Author: David Truby Date: 2022-05-03T13:10:32Z New Revision: 8bc29d14273b05b05d5a56e34c07948dc2c770d3 URL: https://github.com/llvm/llvm-project/commit/8bc29d14273b05b05d5a56e34c07948dc2c770d3 DIFF: https://github.com/llvm/llvm-project/commit/8bc29d14273b05b05d5a56e34c07948dc2c770d3.diff LOG:

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2442 + +This builtin does not return a value. + rsmith wrote: > erichkeane wrote: > > I don't know if anyone would be using this value, but I wonder if there is > > value to making

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8470-8473 +def err_expected_struct_pointer_argument : Error< + "expected pointer to struct as %ordinal0 argument to %1, found %2">; +def err_expected_callable_argument : Error< +

[PATCH] D124807: [clang][dataflow] Avoid assert for invalid cast to BoolValue

ymandel added a comment. Thanks for the patch! Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1155 +// FIXME: Remove this test once it provides no additional test coverage. +TEST_F(FlowConditionTest, DoesNotAssertForImplicitCastToBool)

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

RosieSumpter created this revision. RosieSumpter added reviewers: sdesmalen, paulwalker-arm. Herald added subscribers: ctetreau, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. RosieSumpter requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added a comment. Assuming no further comments from reviewers, I plan to land this sometime tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124258/new/ https://reviews.llvm.org/D124258 ___ cfe-commits mailing list

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: dcoughlin. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. frederic-tingaud-sonarsource requested

[PATCH] D124827: [pseudo] Simplify the forest dump, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb18abde8ada1: [pseudo] Simplify the forest dump, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124827/new/

[clang-tools-extra] b18abde - [pseudo] Simplify the forest dump, NFC.

Author: Haojian Wu Date: 2022-05-03T14:14:57+02:00 New Revision: b18abde8ada122408724d2a1722aa2f75e9a87ce URL: https://github.com/llvm/llvm-project/commit/b18abde8ada122408724d2a1722aa2f75e9a87ce DIFF: https://github.com/llvm/llvm-project/commit/b18abde8ada122408724d2a1722aa2f75e9a87ce.diff

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:6766-6767 +def enable_16bit_types : DXCFlag<"enable-16bit-types">, Alias, + HelpText<"Enable 16bit types and disable min precision types." + "Available in HLSL 2018 and shader

[PATCH] D122663: Mark identifier prefixes as substitutable

hvdijk added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:6031 +bool CXXNameMangler::mangleSubstitution(NestedNameSpecifier *NNS) { + NNS = Context.getASTContext().getCanonicalNestedNameSpecifier(NNS); + return mangleSubstitution(reinterpret_cast(NNS));

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf7cd664f3fd: [analyzer] Check for std::__addressof for inner pointer checker (authored by alishuja, committed by steakhal). Repository: rG LLVM

[clang] cf7cd66 - [analyzer] Check for std::__addressof for inner pointer checker

Author: Ali Shuja Siddiqui Date: 2022-05-03T14:05:19+02:00 New Revision: cf7cd664f3fd212c0f1e4a83fd2fe96902569d20 URL: https://github.com/llvm/llvm-project/commit/cf7cd664f3fd212c0f1e4a83fd2fe96902569d20 DIFF:

[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:682 +/// Current name mangling is for device name in host compilation. +bool MangleDeviceNameInHostCompilation = false; + } CUDANameMangleCtx;

[PATCH] D124842: [NFC][CUDA][HIP] rework mangling number for aux target

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. CUDA/HIP needs to mangle for aux target. When mangling for aux target, the mangler should use mangling number for aux

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

steakhal added a comment. I think I don't have anything left. Let's see the numbers. Comment at: clang/test/Analysis/sink-infeasible.c:37-48 + /* The BASELINE passes these checks ('wrning' is used to avoid lit to match) + // The parent state is already infeasible, look at

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz added a comment. Thanks for your help! I will work on testing in calendar week 21. Comment at: llvm/lib/CodeGen/WinEHPrepare.cpp:966 -if (FuncletBundleOperand == FuncletPad) +if (!FuncletPad || FuncletBundleOperand == FuncletPad)

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

alishuja accepted this revision. alishuja added a comment. @steakhal yes please go ahead, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109467/new/ https://reviews.llvm.org/D109467 ___

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || + !isIntegralConstant(*Current)) { aaron.ballman wrote:

[PATCH] D122663: Mark identifier prefixes as substitutable

urnathan added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:6031 +bool CXXNameMangler::mangleSubstitution(NestedNameSpecifier *NNS) { + NNS = Context.getASTContext().getCanonicalNestedNameSpecifier(NNS); + return mangleSubstitution(reinterpret_cast(NNS));

[PATCH] D124694: [randstruct] Move initializer check to be more effective

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D124694#3486547 , @void wrote: > In D124694#3485585 , @aaron.ballman > wrote: > >>

[clang] 1fc208d - Fix Clang sphinx build

Author: Aaron Ballman Date: 2022-05-03T07:14:12-04:00 New Revision: 1fc208d40012103f81279ab85949a91f8188e7a1 URL: https://github.com/llvm/llvm-project/commit/1fc208d40012103f81279ab85949a91f8188e7a1 DIFF: https://github.com/llvm/llvm-project/commit/1fc208d40012103f81279ab85949a91f8188e7a1.diff

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks really good, great job on the signatures & tests. There are a few different ways to formulate the signatures of glrParse/glrReduce, and some possible optimizations, but I

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong added a comment. In D124674#3482765 , @steakhal wrote: > Finally, we have this! Thanks for the review. > Can we have this https://godbolt.org/z/oferc6P5Y in addition to the one you > proposed? > I find it more readable. Sure, I find it also

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ConstraintManager.cpp:51 +ProgramStateRef StFalse = assume(State, Cond, false); +if (!StFalse) { // both infeasible + ProgramStateRef Infeasible = State->cloneAsInfeasible();

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

martong updated this revision to Diff 426635. martong marked 6 inline comments as done. martong added a comment. - Update according to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124674/new/ https://reviews.llvm.org/D124674

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

kristof.beyls added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:752 +#undef CASE + } +} Just a drive-by comment: I'm wondering if SVE registers should also be listed here? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

void created this revision. void added reviewers: nickdesaulniers, danielkiss, MaskRay. Herald added subscribers: StephenFan, pengfei, hiraditya, kristof.beyls. Herald added a project: All. void requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 426622. philipp.tomsich marked 4 inline comments as done. philipp.tomsich added a comment. Rebased to main. The earlier base-regression was a precommitted test-case that caused SimpleLoopUnswitch tests (not related to these changes) to fail.

[PATCH] D109467: [analyzer] check for std::__addressof for inner pointer checker

steakhal added a comment. @alishuja, Shall I submit this patch with `--author="Ali Shuja Siddiqui "` (thus on your behalf) ? The LLVM DeveloperPolicy mandates me for asking permission. Repository: rG LLVM Github Monorepo

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGad47114ad850: In MSVC compatibility mode, friend function declarations behave as function… (authored by frederic-tingaud-sonarsource, committed by mantognini). Repository: rG LLVM Github Monorepo

[clang] ad47114 - In MSVC compatibility mode, friend function declarations behave as function declarations

Author: Fred Tingaud Date: 2022-05-03T11:31:50+02:00 New Revision: ad47114ad8500c78046161d492ac13a8e3e610eb URL: https://github.com/llvm/llvm-project/commit/ad47114ad8500c78046161d492ac13a8e3e610eb DIFF: https://github.com/llvm/llvm-project/commit/ad47114ad8500c78046161d492ac13a8e3e610eb.diff

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rG68ee5ec07d4a: [Analyzer] Fix assumptions about const field with member-initializer (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 68ee5ec - [Analyzer] Fix assumptions about const field with member-initializer

Author: Marco Antognini Date: 2022-05-03T11:27:45+02:00 New Revision: 68ee5ec07d4a169baf287acad9ad7fa85d764a22 URL: https://github.com/llvm/llvm-project/commit/68ee5ec07d4a169baf287acad9ad7fa85d764a22 DIFF:

[clang] c819dce - [clang-format] Add a regression test for aligning macros with keywords.

Author: Marek Kurdej Date: 2022-05-03T11:09:38+02:00 New Revision: c819dce2d304817ae7f47628067092f4353a148e URL: https://github.com/llvm/llvm-project/commit/c819dce2d304817ae7f47628067092f4353a148e DIFF: https://github.com/llvm/llvm-project/commit/c819dce2d304817ae7f47628067092f4353a148e.diff

[PATCH] D124831: [pseudo] Use a real language option in the parser.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124831

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka added a comment. I think I confused myself yesterday, it does make sense to add -fno-integrated-as for this. Could we add a test for it independent of save-temps? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/

[PATCH] D124827: [pseudo] Simplify the forest dump, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The code was written to handle nullable grammar, and we disallow nullable

[PATCH] D120495: [clang][dataflow] Add transfer functions for structured bindings

sgatev added inline comments. Herald added a project: All. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:80 +/// +/// FIXME: Consider adding support for structured bindings to the CFG builder. +class DecompositionVisitor : public ConstStmtVisitor {

[PATCH] D124719: [docs] PCH usage documentation update

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6112f490cfe: [docs] PCH usage documentation update (authored by ivanmurashko). Changed prior to commit:

[clang] f6112f4 - [docs] PCH usage documentation update

Author: Ivan Murashko Date: 2022-05-03T08:26:13+01:00 New Revision: f6112f490cfeed05b42ae33cc994292000aee0da URL: https://github.com/llvm/llvm-project/commit/f6112f490cfeed05b42ae33cc994292000aee0da DIFF: https://github.com/llvm/llvm-project/commit/f6112f490cfeed05b42ae33cc994292000aee0da.diff

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

steakhal added a comment. In D124621#3487507 , @mantognini wrote: > Thanks for digging in the past. I confirm I didn't see any regression in > existing tests, so I'll land it. Go for it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124719: [docs] PCH usage documentation update

ivanmurashko updated this revision to Diff 426588. ivanmurashko added a comment. Some clarifications for the direct include example were added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124719/new/ https://reviews.llvm.org/D124719 Files:

[PATCH] D124621: [Analyzer] Fix assumptions about const field with member-initializer

mantognini added a comment. In D124621#3486004 , @r.stahl wrote: > I can confirm the issue with my patch, so this piece of code needs to be > removed. > > As long as the following test still succeeds, this looks good to me. Back > then, the analyzer

[PATCH] D124611: [RISCV][Clang] add more tests for clang driver. (NFC)

khchen updated this revision to Diff 426587. khchen added a comment. Add zve64* tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124611/new/ https://reviews.llvm.org/D124611 Files: clang/test/Driver/riscv-arch.c Index:

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-symbolizer/data-location.yaml:46 +## symbolized correctly. In future (if D123534 gets merged), this can be updated +## to include a check that llvm-symbolize can also symbolize constant strings, +## like `const

[PATCH] D124774: [clang][ASTImporter][NFC]: Address a fixme in ASTImporterSharedState.h

balazske added a comment. A better title: "Move clang::ImportError into own header and rename it (NFC)." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___

[PATCH] D124774: [clang][ASTImporter][NFC]: Address a fixme in ASTImporterSharedState.h

balazske added a comment. The `ASTImporterLookupTable` was not dependent on the `ImportError` so the header should not be included in that file. It is better in **ASTImporterSharedState.h**. Alternative solution is to add class `ASTImportError` into **ASTImporterSharedState.h** (no new header

<    1   2