[PATCH] D124909: Fix issues with using clangd with C++ modules

kuganv added a comment. Thanks a lot for the detailed. comment. Yes, you are right in that we are using build system (buck) to build the modules and provide as part of the CDB. This is fairly cheap when we hit the buck cache that is also shared by others. You are right in that the PCM format

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11663 X = BO->getLHS(); - D = BO->getRHS(); + D = BO->getRHS()->IgnoreImpCasts(); tianshilei1992 wrote: > tianshilei1992 wrote: > > ABataev wrote: > > > Why do we need to use

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427036. awarzynski added a comment. Fix typos as per comments from @rovka, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files:

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski marked 4 inline comments as done. awarzynski added inline comments. Comment at: flang/test/Driver/fno-integrated-as.f90:18 +! DEFAULT-LABEL: "-fc1" +! DEFAULT-SAME: "-o" "fno-integrated-as.o" "{{.*}}fno-integrated-as.f90" rovka wrote: > Nit (here and

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

rmaz updated this revision to Diff 427065. rmaz added a comment. fix windows paths attempt #2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124874/new/ https://reviews.llvm.org/D124874 Files: clang/include/clang/Driver/Options.td

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 427082. njames93 added a comment. Reimplement matchers as an ASTVisitor instead. This massively simplifies the tracking of nested cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

steplong added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5219 +// function. +else if (!CGF.CurFn->getAttributes().hasFnAttr(AttributeNoBuiltin)) return CGCallee::forBuiltin(builtinID, FD); hans wrote: > What if CurFn has the

[clang] 726d7b0 - [Sema] Simplify CheckConstraintSatisfaction. NFC

Author: Ilya Biryukov Date: 2022-05-04T15:53:07Z New Revision: 726d7b07fcde58c61743c45723c9b614911fe084 URL: https://github.com/llvm/llvm-project/commit/726d7b07fcde58c61743c45723c9b614911fe084 DIFF: https://github.com/llvm/llvm-project/commit/726d7b07fcde58c61743c45723c9b614911fe084.diff

[PATCH] D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG726d7b07fcde: [Sema] Simplify CheckConstraintSatisfaction. NFC (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

ymandel updated this revision to Diff 427029. ymandel added a comment. remove stray newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 Files:

[PATCH] D124938: [clang] serialize SUBMODULE_TOPHEADER relative to BaseDirectory

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff changes the serialization of the `SUBMODULE_TOPHEADER` entry in module files to be serialized relative to the module's

[PATCH] D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:335 + auto Satisfaction = + std::make_unique(Template, TemplateArgs); if (::CheckConstraintSatisfaction(*this, Template, ConstraintExprs, ilya-biryukov wrote: > sammccall

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

ymandel added a comment. The code looks good, but what is the intended application? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124943/new/ https://reviews.llvm.org/D124943 ___ cfe-commits mailing

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw updated this revision to Diff 427061. zixuw added a comment. Herald added a subscriber: arphaman. Update test case to use cc1 instead of driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831

[PATCH] D124674: [analyzer] Indicate if a parent state is infeasible

NoQ added a comment. Yes, we've discussed this before, and I'm very much in favor of this change. This is assertion removal, and the assertion has been really useful back in the day, but the assertion doesn't seem to be realistic to maintain with all the new logic in the constraint solver

[clang] 5f841c7 - [NFC] Remove unfinished test case

Author: Zixu Wang Date: 2022-05-04T10:40:25-07:00 New Revision: 5f841c71fc2cc77c92f526791cd7a938bcac69aa URL: https://github.com/llvm/llvm-project/commit/5f841c71fc2cc77c92f526791cd7a938bcac69aa DIFF: https://github.com/llvm/llvm-project/commit/5f841c71fc2cc77c92f526791cd7a938bcac69aa.diff

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added a comment. In D124715#3490364 , @stefanhaller wrote: > In D124715#3488447 , @sammccall > wrote: > >> (How) does this interact with battery vs mains power on laptops? >> It seems like there's a

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! In D124666#3490871 , @frederic-tingaud-sonarsource wrote: > By the way, in the current state of the code, there is no risk of such >

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

stevewan added inline comments. Comment at: clang/test/Driver/aix-ld.c:675-676 +// CHECK-LD32-SHARED-EXPORTS-NOT: "{{.*}}llvm-nm" +// CHECK-LD32-SHARED-EXPORTS-NOT: "-X" +// CHECK-LD32-SHARED-EXPORTS-NOT: "32" +// CHECK-LD32-SHARED-EXPORTS: "{{.*}}ld{{(.exe)?}}"

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

ymandel updated this revision to Diff 427126. ymandel added a comment. address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124952/new/ https://reviews.llvm.org/D124952 Files:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added a comment. Just a few nits left. Consider marking 'done' the corresponding boxes. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:211 +// Check if the negation of the RHS is representable: +// * if resultTy is unsigned, then negation is

[PATCH] D124702: [MSVC] Add support for pragma function

steplong added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:3561 << "intrinsic"; return; } hans wrote: > since the above is just a warning, we should probably still call the ActOn.. > method? Hmm, I'm not sure because all the

[PATCH] D124842: [NFC][CUDA][HIP] rework mangling number for aux target

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG62501bc45a2f: [NFC][CUDA][HIP] rework mangling number for aux target (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin marked 8 inline comments as done. DiggerLin added inline comments. Comment at: clang/test/Driver/aix-ld.c:985 +// CHECK-LD64-SHARED-EXPFULL: "-bM:SRE" +// CHECK-LD64-SHARED-EXPFULL: "-bnoentry" +// CHECK-LD64-SHARED-EXPFULL: "-b64" MaskRay

[PATCH] D124868: [clang-format] Fix a bug in AlignConsecutiveAssignments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG342e1c77c360: [clang-format] Fix a bug in AlignConsecutiveAssignments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 342e1c7 - [clang-format] Fix a bug in AlignConsecutiveAssignments

Author: owenca Date: 2022-05-04T12:04:43-07:00 New Revision: 342e1c77c360e745fc6457037e6c1e37b84f2791 URL: https://github.com/llvm/llvm-project/commit/342e1c77c360e745fc6457037e6c1e37b84f2791 DIFF: https://github.com/llvm/llvm-project/commit/342e1c77c360e745fc6457037e6c1e37b84f2791.diff LOG:

[clang] b1a55d0 - Fix a crash on targets where __bf16 isn't supported

Author: Aaron Ballman Date: 2022-05-04T16:45:59-04:00 New Revision: b1a55d0895249a493da5a442e44ee0a846410e88 URL: https://github.com/llvm/llvm-project/commit/b1a55d0895249a493da5a442e44ee0a846410e88 DIFF: https://github.com/llvm/llvm-project/commit/b1a55d0895249a493da5a442e44ee0a846410e88.diff

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

zixuw created this revision. zixuw added reviewers: ributzka, dang, cishida. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reapply the change after fixing sanitizer errors. The original problem was that

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

zixuw updated this revision to Diff 427140. zixuw added a comment. Whitespace change: clang-format removed an empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124964/new/ https://reviews.llvm.org/D124964 Files:

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

rmaz updated this revision to Diff 427034. rmaz added a comment. Use regex for path separators in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124874/new/ https://reviews.llvm.org/D124874 Files: clang/include/clang/Driver/Options.td

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

craig.topper added inline comments. Comment at: clang/lib/Headers/cetintrin.h:48 +#pragma clang diagnostic ignored "-Wuninitialized" unsigned int t; return __builtin_ia32_rdsspd(t); So if CET isn't enabled this intrinsic returns a random value instead of 0

[clang] 62501bc - [NFC][CUDA][HIP] rework mangling number for aux target

Author: Yaxun (Sam) Liu Date: 2022-05-04T13:05:33-04:00 New Revision: 62501bc45a2fb4980725baccf48576cf9b45cd4d URL: https://github.com/llvm/llvm-project/commit/62501bc45a2fb4980725baccf48576cf9b45cd4d DIFF:

[clang] 859d923 - Fix a failing assertion with vector type initialization

Author: Aaron Ballman Date: 2022-05-04T13:25:21-04:00 New Revision: 859d92394812c0e5e650ab337717719b9687e5ce URL: https://github.com/llvm/llvm-project/commit/859d92394812c0e5e650ab337717719b9687e5ce DIFF: https://github.com/llvm/llvm-project/commit/859d92394812c0e5e650ab337717719b9687e5ce.diff

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw added a comment. Accidentally added another test case in my local workspace. Removed in 5f841c71fc2cc77c92f526791cd7a938bcac69aa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 427087. njames93 added a comment. Added release notes. Fix build issues with previous push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/ https://reviews.llvm.org/D124806 Files:

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers added a comment. Thanks for the comments! Per our discussion, I'll create a different test case with a pinned target and add the additional test case to be sure we see expected behavior. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124719: [docs] PCH usage documentation update

tahonermann reopened this revision. tahonermann added a comment. This revision is now accepted and ready to land. Reopening for further discussion or clarification. The changes appear to suggest that a PCH file won't be implicitly used when an explicit include for the corresponding header is

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

curdeius accepted this revision. curdeius added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124956/new/ https://reviews.llvm.org/D124956 ___ cfe-commits mailing list

[PATCH] D124790: [HLSL] Enable half type for hlsl.

beanz added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; aaron.ballman wrote: > python3kgae wrote: >

[PATCH] D104975: Implement P1949

tahonermann added a comment. > I hope at least GCC will not implement this arbitrary restriction on math > symbols. I would argue a partial derivative symbol in C++ has more sense than > a skull emoji. I am quite sure that gcc will also be implementing P1949

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:107 + ASSERT_EQ(Errors.size(), 1U); + // This should match the input;

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 427127. steplong added a comment. Error if pragma function/intrinsic is used inside a function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files:

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

awarzynski updated this revision to Diff 427032. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124667/new/ https://reviews.llvm.org/D124667 Files: clang/include/clang/Driver/Types.h

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

craig.topper added inline comments. Comment at: clang/lib/Headers/cetintrin.h:45 static __inline__ unsigned int __DEFAULT_FN_ATTRS _rdsspd_i32() { +#pragma clang diagnostic push The argument should also be `(void)`. Comment at:

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua added a comment. This allows me to query when an expression is always encountered/executed. Alternatively, if I have a set of interesting expressions, I can note the flow condition at every expression, compute the disjunction of the set of flow conditions, and determine if execution

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { yihanaa wrote: > rsmith wrote: > > rsmith wrote: > > > aaron.ballman wrote: > > > > yihanaa

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

ymandel created this revision. ymandel added a reviewer: gribozavr2. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Messages generated by Transformer rules may have `%` in them,

[PATCH] D124955: [clang-tidy] Make header-guard check a little looser on comment whitespace

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently it

[PATCH] D124687: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to record and use pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi added a comment. In D124687#3486473 , @akyrtzi wrote: > In D124687#3485710 , @tschuett > wrote: > >> Is there overhead in the non dependency scanning mode? > > Good suggestion, I'll do some measurements

[libunwind] 6123e9c - [libunwind] Silence warnings about unused variables. NFC.

Author: Martin Storsjö Date: 2022-05-04T22:55:02+03:00 New Revision: 6123e9c0d03bf1e3f43c3851f4122a7267b33c28 URL: https://github.com/llvm/llvm-project/commit/6123e9c0d03bf1e3f43c3851f4122a7267b33c28 DIFF:

[libunwind] f1f8899 - [libunwind] [CMake] Handle the RelWithDebInfo configuration similarly to Release

Author: Martin Storsjö Date: 2022-05-04T22:55:01+03:00 New Revision: f1f8899a18822ede04d8f90cbdae29d66333d7dc URL: https://github.com/llvm/llvm-project/commit/f1f8899a18822ede04d8f90cbdae29d66333d7dc DIFF:

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

ymandel marked an inline comment as done. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124952/new/ https://reviews.llvm.org/D124952 ___ cfe-commits mailing list

[clang-tools-extra] 9a8d33d - [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

Author: Yitzhak Mandelbaum Date: 2022-05-04T20:56:56Z New Revision: 9a8d33dbd8a851ccb9821d5d1346aa225398cadc URL: https://github.com/llvm/llvm-project/commit/9a8d33dbd8a851ccb9821d5d1346aa225398cadc DIFF: https://github.com/llvm/llvm-project/commit/9a8d33dbd8a851ccb9821d5d1346aa225398cadc.diff

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8d33dbd8a8: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer. (authored by ymandel). Repository: rG LLVM Github

[clang] 94d36fd - Fix a crash on invalid with _Generic expressions

Author: Aaron Ballman Date: 2022-05-04T12:41:56-04:00 New Revision: 94d36fdbd7d2c6eab250f15f65fd20a6447b92eb URL: https://github.com/llvm/llvm-project/commit/94d36fdbd7d2c6eab250f15f65fd20a6447b92eb DIFF: https://github.com/llvm/llvm-project/commit/94d36fdbd7d2c6eab250f15f65fd20a6447b92eb.diff

[PATCH] D123831: [clang][extract-api] Use relative includes

zixuw added a comment. In D123831#3490684 , @dang wrote: > Since this is a new test can we use the approach in > https://reviews.llvm.org/D124634 to check for diagnostics output. I used FileCheck to check the input buffer dump in this test, but I'll

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

vabridgers updated this revision to Diff 427106. vabridgers added a comment. Address comments from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124349/new/ https://reviews.llvm.org/D124349 Files:

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

martong accepted this revision. martong added a comment. Herald added a subscriber: rnkovacs. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124708/new/ https://reviews.llvm.org/D124708 ___

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 427040. steplong added a comment. Changed std::vector to llvm::SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files:

[clang] b6c67c3 - [clang] Track how headers get included generally during lookup time

Author: Cyndy Ishida Date: 2022-05-04T09:52:31-07:00 New Revision: b6c67c3c67893d532fe741c508dfa2ac40fae1ad URL: https://github.com/llvm/llvm-project/commit/b6c67c3c67893d532fe741c508dfa2ac40fae1ad DIFF: https://github.com/llvm/llvm-project/commit/b6c67c3c67893d532fe741c508dfa2ac40fae1ad.diff

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c67c3c6789: [clang] Track how headers get included generally during lookup time (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:433 + + llvm::StringRef getFormatSpecifier(QualType T) { +if (auto *BT = T->getAs()) { rsmith wrote: > yihanaa wrote: > > rsmith wrote: > > > rsmith wrote: > > > > aaron.ballman

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

akyrtzi added a comment. My recommendation is that indexing belongs to 'utility', as @stefanhaller mentioned the user is actively depending on functionality coming from the index. That said, you may want to consider dynamically switching to background if running on laptop with battery, or other

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

sammccall added a comment. OK, so wanting this to be utility makes sense, and maybe/probably it should be the default. I'm still concerned some users will find this a large regression and we won't have a good workaround: - it'll use a lot more battery than before - not everyone will see the

[clang] 2966f0f - Revert "[clang][extract-api] Use relative includes"

Author: Zixu Wang Date: 2022-05-04T12:27:20-07:00 New Revision: 2966f0fa505266735dbc8324b8821b7f0aa901ff URL: https://github.com/llvm/llvm-project/commit/2966f0fa505266735dbc8324b8821b7f0aa901ff DIFF: https://github.com/llvm/llvm-project/commit/2966f0fa505266735dbc8324b8821b7f0aa901ff.diff

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to

[PATCH] D124956: [clang-format] Fix another bug in AlignConsecutiveAssignments

curdeius added a comment. Just one last thought, shouldn't we have a test case close to what was reported in the issue? I.e. with PP directives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124956/new/ https://reviews.llvm.org/D124956

[PATCH] D124932: [clang][dataflow] Track `optional`s' values (i.e. contents) in `optional` model.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds partial

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 427038. njames93 added a comment. Enhanced support for parens, both adding them in when needed as well as removing some un-needed parens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/

[PATCH] D124943: [clang][dataflow] Add flowConditionIsTautology function

li.zhe.hua created this revision. li.zhe.hua added reviewers: ymandel, sgatev, xazax.hun. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] 4c262fe - [clang][extract-api] Use relative includes

Author: Zixu Wang Date: 2022-05-04T10:28:01-07:00 New Revision: 4c262fee08b5383c96857d77eefe80d61c41d2b0 URL: https://github.com/llvm/llvm-project/commit/4c262fee08b5383c96857d77eefe80d61c41d2b0 DIFF: https://github.com/llvm/llvm-project/commit/4c262fee08b5383c96857d77eefe80d61c41d2b0.diff

[PATCH] D123831: [clang][extract-api] Use relative includes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c262fee08b5: [clang][extract-api] Use relative includes (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff changes the serialization of the `ORIGINAL_PCH_DIR` entry in module files to be serialized relative to the module's

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3491782 , @akyrtzi wrote: > That said, you may want to consider dynamically switching to background if > running on laptop with battery, or other heuristics, My take on this is that it would be Apple's

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 427081. shafik removed reviewers: teemperor, jingham, jasonmolenda. shafik added a comment. Herald added a project: All. - Expanded test - applied clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

aaron.ballman added a subscriber: rjmccall. aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { mboehme wrote: > aaron.ballman wrote: > > mboehme wrote: >

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3488447 , @sammccall wrote: > (How) does this interact with battery vs mains power on laptops? > It seems like there's a common scenario where: > > - the user is on a relatively slow laptop, running off battery >

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

balazske added inline comments. Comment at: clang/include/clang/AST/ASTImportError.h:17 + +#include "clang/AST/APValue.h" +#include "llvm/Support/Error.h" This header is probably not needed. Comment at:

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:474 +// the parameter names from the wrapped function +if (Args.size() > FixedParamCount && Args.size() == Params.size()) { + auto ForwardedParams = matchForwardedParams(

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets added inline comments. Comment at: clang/include/clang/AST/ASTImportError.h:22 + +class ImportError : public llvm::ErrorInfo { +public: balazske wrote: > balazske wrote: > > Rename to `ASTImportError`. > The rename to `ASTImportError` is better in a

[PATCH] D124349: [analyzer] Get direct binding for specific punned case

martong added a comment. Can we have a test for this, got idea from here (https://stackoverflow.com/questions/4129961/how-is-the-size-of-a-struct-with-bit-fields-determined-measured) typedef struct { unsigned int a:1; unsigned int x:31; unsigned int c:1;

[PATCH] D124666: In MSVC compatibility mode, handle unqualified templated base class initialization

frederic-tingaud-sonarsource updated this revision to Diff 426944. frederic-tingaud-sonarsource added a comment. Sorry about the confusion, it makes sense. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124666/new/ https://reviews.llvm.org/D124666 Files:

[PATCH] D124909: Fixes following incompatibility issues with c++ modules

kuganv created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kuganv requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. 1. Preamble generated by clangd is

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 marked 4 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp:51 ClangTidyContext *Context) -: NamePrefix(CheckName.str() + "."), CheckOptions(CheckOptions), +: NamePrefix((CheckName +

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

phyBrackets added inline comments. Comment at: clang/include/clang/AST/ASTImporterLookupTable.h:17 +#include "clang/AST/ASTImportError.h" #include "clang/AST/DeclBase.h" // lookup_result balazske wrote: > phyBrackets wrote: > > balazske wrote: > > > This

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

peterwaller-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:752 +#undef CASE + } +} void wrote: > kristof.beyls wrote: > > Just a drive-by comment: I'm wondering if SVE registers should also be > > listed here? > I'm not

[PATCH] D124850: [Sema][SVE2] Move/simplify Sema testing for SVE2 ACLE builtins

sdesmalen added a comment. Thanks for working on this @RosieSumpter! Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2.cpp:1 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -target-feature +bf16 -fallow-half-arguments-and-returns

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1398 + (sequence "W%u", 0, 7))>; +def FPR8_ARG : RegisterClass<"AArch64", [untyped], 8, (trunc FPR8, 7)> { + let Size = 8; Should this

[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:230 + /// + /// Requirements: + /// Why add these as requirements instead of skipping past `ExprWithCleanups` internally, as we currently do for

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header and rename it .

balazske added inline comments. Comment at: clang/include/clang/AST/ASTImportError.h:1 +//===- ASTImporter.h - Import Error while Importing AST ---*- C++ -*-===// +// balazske wrote: > Comment at:

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka added inline comments. Comment at: flang/test/Driver/fno-integrated-as.f90:6 +!-- +! Verify that there _is_ a seperate line with an assembler invocation +! RUN: %flang -c -fno-integrated-as %s -### 2>&1 | FileCheck %s

[PATCH] D123831: [clang][extract-api] Use relative includes

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libunwind] 7167237 - [libunwind][SystemZ] Unwind out of signal handlers

Author: Ulrich Weigand Date: 2022-05-04T10:43:11+02:00 New Revision: 71672375fe91d602699ae2a6d6a88e910ff91b5c URL: https://github.com/llvm/llvm-project/commit/71672375fe91d602699ae2a6d6a88e910ff91b5c DIFF:

[PATCH] D124807: [clang][dataflow] Only skip ExprWithCleanups when visiting terminators

sgatev accepted this revision. sgatev added a comment. Looks great! Thank you! Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1156 +// FIXME: Remove this test once it provides no additional test coverage. +TEST_F(FlowConditionTest,

[PATCH] D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:335 + auto Satisfaction = + std::make_unique(Template, TemplateArgs); if (::CheckConstraintSatisfaction(*this, Template, ConstraintExprs, I also wonder if this could be

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked 3 inline comments as done. mboehme added a comment. In D111548#3483275 , @erichkeane wrote: > I don't really know how useful this ends up being, these attributes (since > they are part of `AttributedType` end up disappearing pretty

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:204 +// subtraction/addition of the negated value. +if (!RHS.isNegative()) { + ConvertedRHS = (resultTy, RHS); steakhal wrote: >

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 426998. steplong added a comment. Removed unnecessary braces (mentioned in the LLVM coding standard) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124702/new/ https://reviews.llvm.org/D124702 Files:

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme marked an inline comment as done. mboehme added a comment. In D111548#3483326 , @xbolva00 wrote: > This patch should not land until we see some real use cases to justify new > hundreds of lines of code. We should more careful and take

  1   2   >