[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

2022-05-08 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 427909. void added a comment. - Support SVE registers. - Initial feature to gather argument registers from the *CallingConv.td files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124836/new/

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

2022-05-08 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj updated this revision to Diff 427910. upsj marked 13 inline comments as done. upsj added a comment. review updates: - Pass ParseForwardingFunctions via ParseOptions - Simplify check for forwarding function - Add test checking diagnostics for make_shared Repository: rG LLVM Github

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

2022-05-08 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b16488129e: [X86] Fix some signedness errors in x86 headers (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

2022-05-08 Thread Kees Cook via Phabricator via cfe-commits
kees planned changes to this revision. kees added a comment. In D125142#3499010 , @brooks wrote: > It would be somewhat helpful as a transition aid if > `-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang` > remained as a no-op

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

2022-05-08 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj updated this revision to Diff 427911. upsj added a comment. update test docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 Files: clang-tools-extra/clangd/ClangdServer.cpp

[clang] f2b1648 - [X86] Fix some signedness errors in x86 headers

2022-05-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-05-08T09:42:58+01:00 New Revision: f2b16488129ef408e89c900f61dc53b1a6699c45 URL: https://github.com/llvm/llvm-project/commit/f2b16488129ef408e89c900f61dc53b1a6699c45 DIFF: https://github.com/llvm/llvm-project/commit/f2b16488129ef408e89c900f61dc53b1a6699c45.diff

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

2022-05-08 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 427913. RKSimon edited the summary of this revision. RKSimon added a comment. Use \code{.operation} ... \endcode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125170/new/ https://reviews.llvm.org/D125170

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

2022-05-08 Thread Kees Cook via Phabricator via cfe-commits
kees updated this revision to Diff 427916. kees added a comment. Report flag as "unused" Adjust flags and tests to have the option warn about being unused now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

2022-05-08 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj updated this revision to Diff 427930. upsj added a comment. attempt to fix the patch issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D124690 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

2022-05-08 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:208 +// If the parameter is part of an expanded pack and not yet resolved +if (/*isExpandedParameter(Param) && */ +ForwardedParams.find(Param) == ForwardedParams.end()) {

[PATCH] D125177: Recognize scope of thread local variables in CFGBuilder

2022-05-08 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125177/new/ https://reviews.llvm.org/D125177

[PATCH] D124147: [clang][cmake] correct grammar and style inconsistency

2022-05-08 Thread Mohammed Keyvanzadeh via Phabricator via cfe-commits
VoltrexMaster updated this revision to Diff 427959. VoltrexMaster added a comment. Rebase and add upstream changes to fix CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124147/new/ https://reviews.llvm.org/D124147 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

2022-05-08 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. Could anybody else have a review or nominate a reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 ___ cfe-commits mailing

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

2022-05-08 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj updated this revision to Diff 427928. upsj added a comment. - add test for emplace-like functions - fix RecursiveASTVisitor early exit - fix handling of skipped parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/

[PATCH] D125177: Recognize scope of thread local variables in CFGBuilder

2022-05-08 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz updated this revision to Diff 427938. kparzysz added a comment. Replace the direct storage class examination with `hasLocalStorage`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125177/new/ https://reviews.llvm.org/D125177 Files:

[PATCH] D125177: Recognize scope of thread local variables in CFGBuilder

2022-05-08 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz updated this revision to Diff 427939. kparzysz added a comment. Use the proper diff file this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125177/new/ https://reviews.llvm.org/D125177 Files: clang/lib/Analysis/CFG.cpp

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-05-08 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked an inline comment as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:99 + + if (!Current->isLiteral() || isStringLiteral(Current->getKind()) || +

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

2022-05-08 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added a comment. OK, so thinking about this review a little more, I propose this: - Take the check as is, but document that the initializing expressions may result in an invalid enum, particularly for C which restricts the

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

2022-05-08 Thread Tobias Ribizel via Phabricator via cfe-commits
upsj added a comment. It seems like except for the caveats I listed before, all the obvious cases seem to work: `make_unique`, `make_shared`, `emplace_back` with exact type matches. One point that still needs some work is if the parameter needs to be converted inside one of the forwarding

[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

2022-05-08 Thread Roy Sundahl via Phabricator via cfe-commits
rsundahl created this revision. rsundahl added reviewers: yln, kubamracek, rjmccall, dcoughlin, delcypher, aralisza, thetruestblue, wrotki. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. rsundahl requested review of this revision. Herald added projects: clang,

[PATCH] D125189: Added parameter names to signature help.

2022-05-08 Thread Visa via Phabricator via cfe-commits
Qwinci created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. Qwinci requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

2022-05-08 Thread Srishti Srivastava via Phabricator via cfe-commits
srishti-pm updated this revision to Diff 427964. srishti-pm added a comment. Fixing a comment typo and enhancing the commit summary even further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files:

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

2022-05-08 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Is there a related change that explains what this setting does? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125170: [Headers][X86] Replace \operation with \code{.operation}

2022-05-08 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125170/new/ https://reviews.llvm.org/D125170

[clang] 6b3a111 - [Headers][X86] Replace \operation with \code{.operation}

2022-05-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-05-08T10:46:26+01:00 New Revision: 6b3a111a2867ce075e70ff1fa1eac2a9e1a4156a URL: https://github.com/llvm/llvm-project/commit/6b3a111a2867ce075e70ff1fa1eac2a9e1a4156a DIFF: https://github.com/llvm/llvm-project/commit/6b3a111a2867ce075e70ff1fa1eac2a9e1a4156a.diff

[PATCH] D125170: [Headers][X86] Replace \operation with \code{.operation}

2022-05-08 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b3a111a2867: [Headers][X86] Replace \operation with \code{.operation} (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 72eb630 - [Headers][X86] Enable basic Wdocumentation testing on X86 headers

2022-05-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-05-08T10:53:28+01:00 New Revision: 72eb630207b812dced21fb820c6d65ecc2978c0a URL: https://github.com/llvm/llvm-project/commit/72eb630207b812dced21fb820c6d65ecc2978c0a DIFF: https://github.com/llvm/llvm-project/commit/72eb630207b812dced21fb820c6d65ecc2978c0a.diff