[PATCH] D125208: [OpenCL] Fix __remove_address_space documentation code example

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Herald added a project: All. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously code example didn't compile

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal created this revision. steakhal added reviewers: aaron.ballman, whisperity, LegalizeAdulthood, alexfh. Herald added subscribers: carlosgalvezp, martong, mgrang, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427999. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp clang/test/Analysis/additive-op-on-sym-int-expr.c Index:

[PATCH] D124919: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme updated this revision to Diff 428016. mboehme edited the summary of this revision. mboehme added a comment. Herald added a subscriber: jdoerfert. - Added warnings for "legacy" type attributes - Added documentation - Fixed TODOs in the code CHANGES SINCE LAST ACTION

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 427998. nridge marked 2 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files:

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal updated this revision to Diff 428000. steakhal added a comment. Fix the RUN line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D125209 Files:

[PATCH] D114611: [AVR] Expand STDWSPQRr & STDSPQRr, approach #2

Patryk27 abandoned this revision. Patryk27 marked 2 inline comments as done. Patryk27 added a comment. Changes in this revision were split into separate revisions, so this one is not needed anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kadircet closed this revision. kadircet added a comment. Landed as rG9fe89a1f0fa6d88aa4786580b89e81dc906fcc52 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125088/new/ https://reviews.llvm.org/D125088

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

peterwaller-arm added inline comments. Comment at: llvm/test/CodeGen/AArch64/zero-call-used-regs.ll:233 + +attributes #0 = { mustprogress nofree norecurse nosync nounwind readnone willreturn uwtable "frame-pointer"="non-leaf" "min-legal-vector-width"="0"

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. I think the issue is related to this loop in `AnalyzeImplicitConversions()`, which iterates over `Expr::children()`, and adds each child to a list of

[PATCH] D125085: [clang-format] Correctly handle SpaceBeforeParens for builtins.

curdeius updated this revision to Diff 428009. curdeius marked an inline comment as done. curdeius added a comment. Address comment: simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125085/new/ https://reviews.llvm.org/D125085 Files:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 428011. tomasz-kaminski-sonarsource added a comment. Firstly, my apologies for the back and forth. My repo was in some strange state, and I wasn't picking up all the changes that got reverted in my patch (this is why the patch was not

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme updated this revision to Diff 428015. mboehme added a comment. Move some tests here that I originally added to https://reviews.llvm.org/D124919. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111548/new/ https://reviews.llvm.org/D111548 Files: clang/docs/ReleaseNotes.rst

[PATCH] D125157: [clang][Driver] Add more tests for riscv

Pretty-box added a comment. In D125157#3500218 , @benshi001 wrote: > Change the title to `[clang][Driver] Add more tests for riscv` done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1476 bool IsImplicit) { -return getSema().BuildResolvedCoawaitExpr(CoawaitLoc, Result, IsImplicit); +// This function rebuilds a coawait-expr given its operator. +

[PATCH] D125169: [clangd] Skip extra round-trip in parsing args in debug builds. NFC

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125169/new/ https://reviews.llvm.org/D125169

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

benshi001 added a comment. Change the title to `[clang][Driver] Add more tests for riscv` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/ https://reviews.llvm.org/D125157 ___ cfe-commits

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427989. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added a comment. In D124658#3499883 , @tomasz-kaminski-sonarsource wrote: > Updated patch to match master after revert. It's still messed up. Please double-check. Comment at:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

uabelho added a comment. Not sure if I'm doing something wrong but I can't apply this patch on current top of tree (a4190037fac0 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/

[PATCH] D125109: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125109/new/ https://reviews.llvm.org/D125109

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke added a comment. Friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

Pretty-box updated this revision to Diff 427986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125157/new/ https://reviews.llvm.org/D125157 Files: clang/test/Driver/riscv-arch.c Index: clang/test/Driver/riscv-arch.c

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added a comment. In D125088#3499649 , @nridge wrote: > Is there a related change that explains what this setting does? Yes: https://reviews.llvm.org/D123488 It seems that I forgot to add the YAML parser logic :( CHANGES SINCE LAST ACTION

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:37-47 +#if __cplusplus == 201703L +# if defined(CHAR8_T) +#if u8'\xff' == '\xff' // expected-warning {{right side of operator converted from negative

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge added a comment. There is one remaining test failure, related to a duplicate diagnostic. I've reduced it to the following: namespace std { template struct coroutine_traits {}; } // end of namespace std struct awaitable { bool await_ready() noexcept; template

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

linjamaki abandoned this revision. linjamaki added a comment. Sounds good to me. I’ll make a new patch when there is a need for it and close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110685/new/ https://reviews.llvm.org/D110685

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 428003. tomasz-kaminski-sonarsource added a comment. Updated and manually validated the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files:

[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

This revision was automatically updated to reflect the committed changes. Closed by commit rG50cd52d93572: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125172: [clangd] Disable predefined macros in tests. NFC

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:44 + // In tests, we don't need predefined macros (__GNUC__, __CHAR_BIT__) etc. + // There

[PATCH] D125085: [clang-format] Correctly handle SpaceBeforeParens for builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85ec8a9ac141: [clang-format] Correctly handle SpaceBeforeParens for builtins. (authored by curdeius). Repository: rG LLVM Github Monorepo

[clang] 85ec8a9 - [clang-format] Correctly handle SpaceBeforeParens for builtins.

Author: Marek Kurdej Date: 2022-05-09T11:42:41+02:00 New Revision: 85ec8a9ac141a1807d907b7514546f531007d87d URL: https://github.com/llvm/llvm-project/commit/85ec8a9ac141a1807d907b7514546f531007d87d DIFF: https://github.com/llvm/llvm-project/commit/85ec8a9ac141a1807d907b7514546f531007d87d.diff

[PATCH] D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching.

kadircet added a comment. Thx, LGTM. I agree that figuring out includes/macros in conditional branches is already best-effort, so I don't think this will result in noticeable regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125179/new/

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427982. tomasz-kaminski-sonarsource added a comment. Updated patch to match master after revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files:

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

sunshaoce added inline comments. Comment at: clang/test/Driver/riscv-arch.c:583 +// RV32-ZHINX-BADVERS: unsupported version number 0.1 for extension 'zhinx' \ No newline at end of file Add a newline here. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125166: [clang-fuzzer] Add a tiny tool to generate a fuzzing dictionary for clang

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-fuzzer/dictionary/CMakeLists.txt:2 +add_clang_executable(clang-fuzzer-dictionary dictionary.c) + nit: remove the extra

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 427993. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp clang/test/Analysis/additive-op-on-sym-int-expr.c Index:

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal reopened this revision. steakhal added a comment. This revision is now accepted and ready to land. When I download the "raw diff" using the `Download Raw Diff` button on this page, then I try to `git apply` it still fails. (error `219: new blank line at EOF.`) Anyway, I managed to

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

peterwaller-arm added a comment. Looking pretty good. A couple of test cases to consider: #include #include svint8_t svi8(svint8_t a) { return a + 256; } int8x16_t nei8(int8x16_t a) { return a + 256; } svint8_t svi8_128(svint8_t a) { return a +

[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaron.ballman accepted this revision. aaron.ballman added a comment. In D124966#3497781 , @aaronpuchert wrote: > In D124966#3497305 , @aaron.ballman > wrote: > >> Do we need to update any documentation from

[PATCH] D125172: [clangd] Disable predefined macros in tests. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rGbf9921adb930: [clangd] Disable predefined macros in tests. NFC (authored by sammccall). Changed prior to commit:

[clang-tools-extra] bf9921a - [clangd] Disable predefined macros in tests. NFC

Author: Sam McCall Date: 2022-05-09T14:44:51+02:00 New Revision: bf9921adb9304b90f21f087c1ea2ef178d9c57dd URL: https://github.com/llvm/llvm-project/commit/bf9921adb9304b90f21f087c1ea2ef178d9c57dd DIFF: https://github.com/llvm/llvm-project/commit/bf9921adb9304b90f21f087c1ea2ef178d9c57dd.diff

[clang-tools-extra] a316a98 - [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC

Author: Sam McCall Date: 2022-05-09T14:53:00+02:00 New Revision: a316a9815a4f4105bb96420e85e93fe5f0033ed0 URL: https://github.com/llvm/llvm-project/commit/a316a9815a4f4105bb96420e85e93fe5f0033ed0 DIFF: https://github.com/llvm/llvm-project/commit/a316a9815a4f4105bb96420e85e93fe5f0033ed0.diff

[PATCH] D125225: [WIP][analyzer] Taint Notes enhancements

gamesh411 created this revision. gamesh411 added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All.

[PATCH] D125224: [CodeComplete] prototype of contextual postfix completions

ilya-biryukov added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:784 + /// When Kind == RK_Pattern, an optional short name for the pattern. + /// Often he pattern combines with a fixit to rewrite surrounding code. + /// NIT:

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

aaron.ballman added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ec1cdcfb49a: [analyzer] Inline operator delete when MayInlineCXXAllocator is set. (authored by frederic-tingaud-sonarsource, committed by

[clang] 1ec1cdc - [analyzer] Inline operator delete when MayInlineCXXAllocator is set.

Author: Fred Tingaud Date: 2022-05-09T15:44:33+02:00 New Revision: 1ec1cdcfb49aed24a634999ab90c4feb48100c3e URL: https://github.com/llvm/llvm-project/commit/1ec1cdcfb49aed24a634999ab90c4feb48100c3e DIFF: https://github.com/llvm/llvm-project/commit/1ec1cdcfb49aed24a634999ab90c4feb48100c3e.diff

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428072. kadircet added a comment. - Add lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ https://reviews.llvm.org/D125228 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. That is definitely not expected. I'm looking into it, but as this is my first time building chromium, I'm taking a bit more time finding my way around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d9e6b5d - [clang] Recognize scope of thread local variables in CFGBuilder

Author: Krzysztof Parzyszek Date: 2022-05-09T07:11:56-07:00 New Revision: d9e6b5df74f54a7cf21a419f737d922040c1ed08 URL: https://github.com/llvm/llvm-project/commit/d9e6b5df74f54a7cf21a419f737d922040c1ed08 DIFF:

[PATCH] D125225: [WIP][analyzer] Taint Notes enhancements

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2363 + for (SymbolRef SubSym : SubSyms) { +if (SymbolData::classof(SubSym)) { + if (auto MaybeTK = TryToLookupTrackingKind(SubSym)) I think this is the superior

[PATCH] D125177: Recognize scope of thread local variables in CFGBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9e6b5df74f5: [clang] Recognize scope of thread local variables in CFGBuilder (authored by kparzysz). Repository: rG LLVM Github Monorepo

[PATCH] D125231: [pseudo] Compile cxx grammar.

hokein added a comment. This is just a prototype, wanting some early feedback before making further progress: - compiling the generated Cxx.cpp is very slow (took minutes, mostly due to the LRTable::Actions); - layering (location of the generated header file) is not super clear; Repository:

[PATCH] D117829: [Clang] Add integer mul reduction builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a92c45e07dc: [Clang] Add integer mul reduction builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 428041. njames93 added a comment. Clean up some code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files:

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 428042. serge-sans-paille added a comment. Match GCC behavior here: some test case were previously accepted while having the opposite behavior. This pacth both fixes the original issue and adopt gcc behavior. CHANGES SINCE LAST ACTION

[clang-tools-extra] bb53eb1 - [clangd] Skip extra round-trip in parsing args in debug builds. NFC

Author: Sam McCall Date: 2022-05-09T14:45:35+02:00 New Revision: bb53eb1ef4369fa7ae13d693eb219665c2cecd24 URL: https://github.com/llvm/llvm-project/commit/bb53eb1ef4369fa7ae13d693eb219665c2cecd24 DIFF: https://github.com/llvm/llvm-project/commit/bb53eb1ef4369fa7ae13d693eb219665c2cecd24.diff

[PATCH] D125169: [clangd] Skip extra round-trip in parsing args in debug builds. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb53eb1ef436: [clangd] Skip extra round-trip in parsing args in debug builds. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D125169?vs=427869=428047#toc Repository:

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. -

[PATCH] D125225: [WIP][analyzer] Taint Notes enhancements

gamesh411 added a comment. @steakhal This is WIP as there is still a stdlib function, that does not pass the test, and I would like to add more complex taint propagation test cases as well. Could you please glance over these commits: [Malloc] Pass down a State and a Pred ExplodedNode in the

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

aaron.ballman added a comment. In D124866#3497439 , @tra wrote: >> CUDA/HIP do not have language spec. > > Well. It's not completely true. CUDA programming guide does serve as the > de-facto spec for CUDA. It's far from perfect, but it does mention >

[clang] 8a92c45 - [Clang] Add integer mul reduction builtin

Author: Simon Pilgrim Date: 2022-05-09T12:12:53+01:00 New Revision: 8a92c45e07dc81c83ca3afda3971d98c512429d4 URL: https://github.com/llvm/llvm-project/commit/8a92c45e07dc81c83ca3afda3971d98c512429d4 DIFF: https://github.com/llvm/llvm-project/commit/8a92c45e07dc81c83ca3afda3971d98c512429d4.diff

[PATCH] D124149: [NFC] follow up code cleanup after D123837

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. sorry for being slow, concentrating on module initialisers! this LGTM (but we can still probably make the visibility code cleaner - perhaps after we get the main functionality installed).

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

urnathan added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1231-1236 +SmallString<128> BaseDir(CWD->getName()); +cleanPathForOutput(Context.getSourceManager().getFileManager(), BaseDir); +BaseDirectory.assign(BaseDir.begin(), BaseDir.end()); +

[PATCH] D125222: [X86] Replace avx512f integer mul reduction builtins with generic builtin

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125222/new/ https://reviews.llvm.org/D125222

[PATCH] D125109: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGa316a9815a4f: [clangd] Rewrite TweakTesting helpers to avoid reparsing the same code. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:769 + // So don't bother generating the long version of the predefines buffer. + // The is going to

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Running on SemaDecl.cpp with the cxx.bnf

[clang-tools-extra] f1a9c4b - [clangd] Skip (most) predefined macros when scanning for preamble patching.

Author: Sam McCall Date: 2022-05-09T15:33:31+02:00 New Revision: f1a9c4b717be9a9a730f837dfd70df69d1daf44f URL: https://github.com/llvm/llvm-project/commit/f1a9c4b717be9a9a730f837dfd70df69d1daf44f DIFF: https://github.com/llvm/llvm-project/commit/f1a9c4b717be9a9a730f837dfd70df69d1daf44f.diff

[PATCH] D125179: [clangd] Skip (most) predefined macros when scanning for preamble patching.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf1a9c4b717be: [clangd] Skip (most) predefined macros when scanning for preamble patching. (authored by sammccall).

[clang] 0195163 - [Frontend] when attaching a preamble, don't generate the long predefines buffer.

Author: Sam McCall Date: 2022-05-09T15:55:32+02:00 New Revision: 0195163dbae962ebb48bcba32b6db85919f07370 URL: https://github.com/llvm/llvm-project/commit/0195163dbae962ebb48bcba32b6db85919f07370 DIFF: https://github.com/llvm/llvm-project/commit/0195163dbae962ebb48bcba32b6db85919f07370.diff

[PATCH] D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0195163dbae9: [Frontend] when attaching a preamble, dont generate the long predefines buffer. (authored by sammccall). Changed prior to commit:

[clang] 882915d - Enum conversion warning when one signed and other unsigned.

Author: Micah Weston Date: 2022-05-09T10:16:19-04:00 New Revision: 882915df61e33f3a2b7f58e52f572717e1c11499 URL: https://github.com/llvm/llvm-project/commit/882915df61e33f3a2b7f58e52f572717e1c11499 DIFF: https://github.com/llvm/llvm-project/commit/882915df61e33f3a2b7f58e52f572717e1c11499.diff

[PATCH] D125226: [pseudo] Add benchmarks for pseudoparser.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! This will be very useful. I think we should have some fixed checked-in examples, but we can add them later. BTW, the fuzzer identifies slow inputs, I have attached one (though it

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added a comment. This change should likely also have some Sema tests demonstrating what happens during constant expression evaluation, or narrowing conversions, etc given that the type may have different behavior. Comment at: clang/lib/Basic/LangOptions.cpp:197

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 428030. tomasz-kaminski-sonarsource added a comment. Applied clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp

[PATCH] D125222: [X86] Replace avx512f integer mul reduction builtins with generic builtin

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. D117829 added the generic

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

urnathan added a comment. Looks good to me, but perhaps leave it a few days for others to comment (my familiarity with this code is low). I do know people want relocatable outputs though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124946/new/

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

steakhal added a comment. This time I've checked this on our test set, and it seems to run without any issues. I'm still waiting for the results of analyzing LLVM, but I think safe to say that this should work. Could you please give this another shoot at this @uabelho?

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

uabelho added a comment. In D124658#3500467 , @steakhal wrote: > [...] > Could you please give this another shoot at this @uabelho? Yes, the case that crashed for me works with the updated patch. Haven't done other testing. CHANGES SINCE LAST

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

tomasz-kaminski-sonarsource updated this revision to Diff 428052. tomasz-kaminski-sonarsource added a comment. Changed variable name and formatting to match coding style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124658/new/ https://reviews.llvm.org/D124658 Files:

[clang] 44ae49e - Thread safety analysis: Handle compound assignment and ->* overloads

Author: Aaron Puchert Date: 2022-05-09T15:35:43+02:00 New Revision: 44ae49e1a72576ca6aa8835b3f72df9605516403 URL: https://github.com/llvm/llvm-project/commit/44ae49e1a72576ca6aa8835b3f72df9605516403 DIFF: https://github.com/llvm/llvm-project/commit/44ae49e1a72576ca6aa8835b3f72df9605516403.diff

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

rmaz added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1231-1236 +SmallString<128> BaseDir(CWD->getName()); +cleanPathForOutput(Context.getSourceManager().getFileManager(), BaseDir); +BaseDirectory.assign(BaseDir.begin(), BaseDir.end()); + }

[PATCH] D125224: [CodeComplete] prototype of contextual postfix completions

sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Demo:

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/line-directive.c:33 # 42 "foo" 2 // expected-error {{invalid line marker flag '2': cannot pop empty include stack}} # 42 "foo" 1 3 // enter # 42 "foo" 2 3 // exit ken-matsui wrote: >

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong updated this revision to Diff 428055. martong marked 8 inline comments as done. martong added a comment. Herald added a reviewer: shafik. - Add explanatory comment to RuntimeDefinition::Foreign field - Changed the return value from bool to void in ctuBifurcate and in inlineCall - Add

[PATCH] D125222: [X86] Replace avx512f integer mul reduction builtins with generic builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec6024d0811b: [X86] Replace avx512f integer mul reduction builtins with generic builtin (authored by RKSimon). Repository: rG LLVM Github

[clang] ec6024d - [X86] Replace avx512f integer mul reduction builtins with generic builtin

Author: Simon Pilgrim Date: 2022-05-09T14:10:28+01:00 New Revision: ec6024d0811b3116e0a29481b01179d5081a3b92 URL: https://github.com/llvm/llvm-project/commit/ec6024d0811b3116e0a29481b01179d5081a3b92 DIFF: https://github.com/llvm/llvm-project/commit/ec6024d0811b3116e0a29481b01179d5081a3b92.diff

[clang] a425cac - "Re-apply 4b6c2cd642 "Deferred Concept Instantiation Implementation""""

Author: Erich Keane Date: 2022-05-09T06:29:47-07:00 New Revision: a425cac31e2e4cee8e14b7b9a99c8ba17c1ebb52 URL: https://github.com/llvm/llvm-project/commit/a425cac31e2e4cee8e14b7b9a99c8ba17c1ebb52 DIFF: https://github.com/llvm/llvm-project/commit/a425cac31e2e4cee8e14b7b9a99c8ba17c1ebb52.diff

[PATCH] D125225: [WIP][analyzer] Taint Notes enhancements

gamesh411 updated this revision to Diff 428070. gamesh411 added a comment. - [BoolAssign] Add taint to the BoolAssignmentChecker - [BugReporter] Transitive interestingness - [Malloc] Pass down a State and a Pred ExplodedNode in the MallocChecker - [BoundV2] ArrayBoundV2 checks if the extent is

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 428069. njames93 added a comment. Tweak fix to not remove parens if it will result in a LogicalOpParentheses warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the fix! I've landed on your behalf in 882915df61e33f3a2b7f58e52f572717e1c11499 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. Seems like this should be added to canonicalization? The "push constants to the right hand side" is there already. I also don't understand the complexity of the implementation, I may need an example to understand why you're recursively operating on the producer ops

[clang-tools-extra] 12cb540 - [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

Author: Nathan James Date: 2022-05-09T12:01:46+01:00 New Revision: 12cb540529e41d12cf27d2e716a384b6692563a8 URL: https://github.com/llvm/llvm-project/commit/12cb540529e41d12cf27d2e716a384b6692563a8 DIFF: https://github.com/llvm/llvm-project/commit/12cb540529e41d12cf27d2e716a384b6692563a8.diff

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

This revision was automatically updated to reflect the committed changes. njames93 marked 4 inline comments as done. Closed by commit rG12cb540529e4: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would… (authored by njames93). Repository: rG LLVM Github Monorepo

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D124500#3499683 , @LegalizeAdulthood wrote: > OK, so thinking about this review a little more, I propose this: > > - Take the check

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

frederic-tingaud-sonarsource updated this revision to Diff 428044. frederic-tingaud-sonarsource added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124845/new/ https://reviews.llvm.org/D124845 Files: clang/include/clang/Analysis/ConstructionContext.h

[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:116 + const bool Foreign = false; // From CTU. + martong wrote: > xazax.hun wrote: > > I feel that we use different terms for the imported

[PATCH] D125231: [pseudo] Compile cxx grammar.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. It compiles the cxx bnf grammar, and

  1   2   3   >