[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. Sorry, it looks like `arcanist` or my PHP runtime was auto updated on my host and has regressed. I need to sort that out first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/

[clang] 4680982 - [dwarf] Emit a DIGlobalVariable for constant strings.

Author: Mitch Phillips Date: 2022-05-16T16:52:16-07:00 New Revision: 4680982b36a84770a1600fc438be8ec090671724 URL: https://github.com/llvm/llvm-project/commit/4680982b36a84770a1600fc438be8ec090671724 DIFF:

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4680982b36a8: [dwarf] Emit a DIGlobalVariable for constant strings. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

njames93 updated this revision to Diff 429907. njames93 added a comment. Extend fix-its to also support removing parens where possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124806/new/ https://reviews.llvm.org/D124806 Files:

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee added a comment. In D125402#3508845 , @aaron.ballman wrote: > Thank you for working on this new diagnostic! We don't typically add new > diagnostics that are off by default unless they're for pedantic diagnostics > or are reasonably expected to

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

iliya-diyachkov added a comment. I'm not an expert in clang, but overall the patch looks good to me. Comment at: clang/docs/UsersManual.rst:3640 +Clang also supports integrated generation of SPIR-V without use of ``llvm-spirv`` +tool as an exerimental feature when

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Sorry for having missed it. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. Done, I'll take a look and resubmit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___ cfe-commits mailing list

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. sorted, will commit soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

paulkirth added a comment. Hi, we're seeing a breakage in Fuchsia's clang CI for x64 windows that I think is related to this patch. https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8813962058917346337/overview We see a test failure in Clang ::

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

paulkirth added a comment. Thanks for the quick response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123534/new/ https://reviews.llvm.org/D123534 ___ cfe-commits mailing list

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui updated this revision to Diff 429877. ken-matsui added a comment. Remove `- < %s` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 Files: clang/lib/Lex/PPDirectives.cpp

[clang] 45e01ce - [clang] Avoid suggesting typoed directives in `.S` files

Author: Ken Matsui Date: 2022-05-16T15:46:59-07:00 New Revision: 45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd URL: https://github.com/llvm/llvm-project/commit/45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd DIFF: https://github.com/llvm/llvm-project/commit/45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd.diff

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45e01ce5fe6a: [clang] Avoid suggesting typoed directives in `.S` files (authored by ken-matsui, committed by nickdesaulniers). Repository: rG

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. pushed 45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. @nickdesaulniers Thank you for your review! I do not have permission to land this patch, so could you please do it on my behalf? Here is my information: Name: `Ken Matsui` Email: `v...@kmatsui.me` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124435: [X86] Always extend the integer parameters in callee

rjmccall added a comment. I'm fine with alternatives on the names. I just don't think we want names that imply that the caller and callee are parallel here, as if there were some sort of requirement that the callee always extends. In those conventions, the callee gets passed 8 or 16

[clang] ed2c321 - Revert "[dwarf] Emit a DIGlobalVariable for constant strings."

Author: Mitch Phillips Date: 2022-05-16T19:07:38-07:00 New Revision: ed2c3218f5badf88cb7897fabf8faa01e8aa2044 URL: https://github.com/llvm/llvm-project/commit/ed2c3218f5badf88cb7897fabf8faa01e8aa2044 DIFF:

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

dblaikie added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp:769-783 +DataExtractor Data(Location.Expr, /*IsLittleEndian=*/true, 8); +uint64_t DataOffset = 0; +uint8_t Operation = Data.getU8(); +if (Operation == dwarf::DW_OP_addr) { +

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG452fac9534c0: [Frontend] [Coroutines] Emit error when we found incompatible allocation (authored by ChuanqiXu). Repository: rG LLVM Github

[clang] 452fac9 - [Frontend] [Coroutines] Emit error when we found incompatible allocation

Author: Chuanqi Xu Date: 2022-05-17T10:36:21+08:00 New Revision: 452fac9534c00290e92819202d445810e33d0444 URL: https://github.com/llvm/llvm-project/commit/452fac9534c00290e92819202d445810e33d0444 DIFF: https://github.com/llvm/llvm-project/commit/452fac9534c00290e92819202d445810e33d0444.diff

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

LegalizeAdulthood marked 2 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-macro-to-enum.c:9 + +// C forbids comma operator in initializing expressions. +#define BAD_OP 1, 2

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

nickdesaulniers added a comment. > I do not have permission to land this patch, so could you please do it on my > behalf? Will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727

[PATCH] D125727: [clang] Avoid suggesting typoed directives in `.S` files

ken-matsui added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125727/new/ https://reviews.llvm.org/D125727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie accepted this revision. dblaikie added a comment. Seems good - if folks find the growth too much, or it creates weird perf issues otherwise, we can discuss that if/when it comes up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added a comment. Gentle pin.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov created this revision. ppluzhnikov added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. ppluzhnikov requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3506745 , @shafik wrote: >> Any update/further details here? > > David, apologies for not getting back to you sooner. The context is D105564 > which I started working on again

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429618. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments: the structure is a bit different but the bug is now actually removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7ff0bf5 - [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

Author: Kito Cheng Date: 2022-05-16T15:13:05+08:00 New Revision: 7ff0bf576b841d5418c0fb1c4b94f16c6205e7d9 URL: https://github.com/llvm/llvm-project/commit/7ff0bf576b841d5418c0fb1c4b94f16c6205e7d9 DIFF: https://github.com/llvm/llvm-project/commit/7ff0bf576b841d5418c0fb1c4b94f16c6205e7d9.diff

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff0bf576b84: [RISCV][NFC] Refactor RISC-V vector intrinsic utils. (authored by kito-cheng). Changed prior to commit: https://reviews.llvm.org/D124730?vs=429184=429620#toc Repository: rG LLVM Github

[PATCH] D125669: Adding support for target in_reduction

RitanyaB created this revision. RitanyaB added reviewers: soumitra, koops, ssquare08, cchen, dreachem. Herald added a project: All. RitanyaB requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects:

[clang-tools-extra] 106e63c - [clangd] NFC: Rename field to be compatible with the function name

Author: Kirill Bobyrev Date: 2022-05-16T10:18:08+02:00 New Revision: 106e63ce47b5b00e376be9eef03a084c71c03f11 URL: https://github.com/llvm/llvm-project/commit/106e63ce47b5b00e376be9eef03a084c71c03f11 DIFF:

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 429630. upsj marked an inline comment as done. upsj added a comment. remove std::forward bodies from diagnostic tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! A few more nits Comment at: clang-tools-extra/clangd/Headers.cpp:151 + // will know that the next inclusion is behind the IWYU pragma. + if

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Another test case that comes to mind is: void f1(int a, int b); void f2(int c, int d); template void foo(Args... args) { if (cond) { f1(args...); } else { f2(args...); } } int main() { foo(1, 2); } I guess in this case it

[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:762 Opts.ResourceDir = ResourceDir; - Opts.BuildDynamicSymbolIndex = EnableIndex; + Opts.BuildDynamicSymbolIndex = true;

[clang-tools-extra] 9902a09 - Add ThreadPriority::Low, and use QoS class Utility on Mac

Author: stk Date: 2022-05-16T10:01:49+02:00 New Revision: 9902a0945d22cd5757b16ebe85fe07059723aa09 URL: https://github.com/llvm/llvm-project/commit/9902a0945d22cd5757b16ebe85fe07059723aa09 DIFF: https://github.com/llvm/llvm-project/commit/9902a0945d22cd5757b16ebe85fe07059723aa09.diff LOG: Add

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

This revision was automatically updated to reflect the committed changes. Closed by commit rG9902a0945d22: Add ThreadPriority::Low, and use QoS class Utility on Mac (authored by stk s...@ableton.com, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

sammccall added a comment. In D124715#3510908 , @stefanhaller wrote: > In D124715#3498846 , @sammccall > wrote: > >> Looks great! I'm happy to land it, will do so on Tuesday unless anyone has >> further

[clang] e57f578 - [clang-format] fix alignment w/o binpacked args

Author: Gregory Fong Date: 2022-05-16T10:25:06+02:00 New Revision: e57f57841fbb0cd1d1dbd3237c2cbe6ce15984dd URL: https://github.com/llvm/llvm-project/commit/e57f57841fbb0cd1d1dbd3237c2cbe6ce15984dd DIFF: https://github.com/llvm/llvm-project/commit/e57f57841fbb0cd1d1dbd3237c2cbe6ce15984dd.diff

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

This revision was automatically updated to reflect the committed changes. Closed by commit rGe57f57841fbb: [clang-format] fix alignment w/o binpacked args (authored by cha5on, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1a65c49 - [pseudo] Support parsing variant target symbols.

Author: Haojian Wu Date: 2022-05-16T10:38:16+02:00 New Revision: 1a65c491be712f89b36af9d828b6ccce02de37db URL: https://github.com/llvm/llvm-project/commit/1a65c491be712f89b36af9d828b6ccce02de37db DIFF: https://github.com/llvm/llvm-project/commit/1a65c491be712f89b36af9d828b6ccce02de37db.diff

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked 2 inline comments as done. Closed by commit rG1a65c491be71: [pseudo] Support parsing variant target symbols. (authored by hokein). Changed prior to

[PATCH] D124435: [X86] Always extend the integer parameters in callee

LiuChen3 added a comment. Thanks, @rjmccall . I'm sorry I don't have much time on this patch recently. I will update it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124435/new/ https://reviews.llvm.org/D124435

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:208 +// If the parameter is part of an expanded pack and not yet resolved +if (/*isExpandedParameter(Param) && */ +ForwardedParams.find(Param) == ForwardedParams.end())

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added a comment. I looked through this patch, and it looks good to me! I will leave the final approval to Sam though. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:416 +// These mocks aren't quite right - we omit shared_ptr for simplicity. +

[PATCH] D125528: [clang-format] Fix PointerAlignment: Right not working with tab indentation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. curdeius marked an inline comment as done. Closed by commit rGe20bc892b6fa: [clang-format] Fix PointerAlignment: Right not working with tab indentation. (authored by

[clang] e20bc89 - [clang-format] Fix PointerAlignment: Right not working with tab indentation.

Author: Marek Kurdej Date: 2022-05-16T09:42:20+02:00 New Revision: e20bc892b6facc56fffc012929157888bb798bed URL: https://github.com/llvm/llvm-project/commit/e20bc892b6facc56fffc012929157888bb798bed DIFF: https://github.com/llvm/llvm-project/commit/e20bc892b6facc56fffc012929157888bb798bed.diff

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein added a comment. This is a revised version of D125231 , based on our discussion. It has a narrow scope: only nonterminals of the grammar are compiled; and it mainly focuses on interfaces; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 40f361a - [clangd] Include Cleaner: ignore headers with IWYU export pragmas

Author: Kirill Bobyrev Date: 2022-05-16T10:13:47+02:00 New Revision: 40f361ace3e9a9c24bd99300216aeabd49ad99bb URL: https://github.com/llvm/llvm-project/commit/40f361ace3e9a9c24bd99300216aeabd49ad99bb DIFF:

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40f361ace3e9: [clangd] Include Cleaner: ignore headers with IWYU export pragmas (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429619. kbobyrev added a comment. Also rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D125604: [FileCheck] Catch missspelled directives.

jhenderson added a comment. Code change looks good to me. Are the TODO cases where the test fails if changing them? Comment at: llvm/test/FileCheck/missspelled-directive.txt:18 + +P4_COUNT-2: foo +CHECK4: error: misspelled directive 'P4_COUNT-2:' What about

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:258 + static inline llvm::SMTExprRef fromUnary(llvm::SMTSolverRef , + ASTContext ,

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong updated this revision to Diff 429633. martong marked 2 inline comments as done. martong added a comment. - Use existing fromUnOp - pass nullptr as FromTy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/

[clang] 5bc469f - [RISCV][NFC] Fix build issue

Author: Kito Cheng Date: 2022-05-16T16:00:23+08:00 New Revision: 5bc469fd96192039bafe4bb9f74c85b37f63212e URL: https://github.com/llvm/llvm-project/commit/5bc469fd96192039bafe4bb9f74c85b37f63212e DIFF: https://github.com/llvm/llvm-project/commit/5bc469fd96192039bafe4bb9f74c85b37f63212e.diff

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev added a comment. In D125604#3514983 , @jhenderson wrote: > Are the TODO cases where the test fails if changing them? Yes, this and where the fix is not perfectly obvious. Comment at:

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. The main idea is to compile the cxx

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:285 + return isa(S) || isa(S) || + isa(S) || isa(S) || + isa(S) || isa(S) || whisperity wrote: > Is CUDA built upon C++-specific features?

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

fhahn accepted this revision. fhahn added a comment. Still LGTM, thanks! The remaining suggestion can be addressed directly before committing the patch. Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:324 + /// Check if the number of runtime checks

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Had a read through this. I'm still digesting it, but the high-level approach seems reasonable to me. Could we add a test case for the recursive scenario that came up during chat: void foo(); template void foo(Head head, Tail... tail) { foo(tail...); }

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429637. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files:

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks, this looks good now! A last few nits here. Would you like me to commit for you? From your patches so far, I think it's appropriate to request commit access

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj added inline comments. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:416 +// These mocks aren't quite right - we omit shared_ptr for simplicity. +// forward is included to show its body is not needed to get the diagnostic. +template T&&

[PATCH] D122126: [LoopVectorize] Don't interleave when the number of runtime checks exceeds the threshold

TiehuZhang added a comment. In D122126#3515070 , @fhahn wrote: > Still LGTM, thanks! The remaining suggestion can be addressed directly before > committing the patch. Thanks, @fhahn! I'll add the precommit test when committing the patch Repository:

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. One more testcase: template void foo(Args...); template void bar(Args... args) { foo(args...); } template void foo(Args... args) { bar(args...); } int main() { foo(1, 2); } Sure, this is a stack overflow at runtime, but there's

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein updated this revision to Diff 429645. hokein added a comment. move the findNonterminal to Grammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125006/new/ https://reviews.llvm.org/D125006 Files:

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 429660. njames93 added a comment. Nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files:

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These symbols are understood to not be used for client API consumption by

[PATCH] D124776: [SPIR-V] Allow setting SPIR-V version via target triple

Anastasia updated this revision to Diff 429678. Anastasia added a comment. Fixed typo in docs CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124776/new/ https://reviews.llvm.org/D124776 Files: llvm/docs/SPIRVUsage.rst llvm/docs/UserGuides.rst llvm/include/llvm/ADT/Triple.h

[PATCH] D125622: [clang-tidy] Reject invalid enum initializers in C files

aaron.ballman added a comment. Note, I'm in C standards committee meetings all week this week, so I expect I won't be doing many reviews this week and I'll be catching up as best I can starting next week. Comment at:

[PATCH] D125535: [clang][NFC] Cleanup some coroutine tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bebbc7cb77: [clang][NFC] Cleanup some coroutine tests (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 80bebbc - [clang][NFC] Cleanup some coroutine tests

Author: Nathan Sidwell Date: 2022-05-16T05:15:12-07:00 New Revision: 80bebbc7cb77979ef9d229450b7ea84e3e9c6a5a URL: https://github.com/llvm/llvm-project/commit/80bebbc7cb77979ef9d229450b7ea84e3e9c6a5a DIFF:

[PATCH] D125555: [clang] Add __has_target_feature

aaron.ballman added a comment. It's not clear to me why existing facilities shouldn't be extended to cover this case rather than coming up with another feature testing macro. There's already plenty of confusion for users to decide between `__has_feature` and `__has_extension`, and now we're

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks added a comment. In D124749#3514224 , @sstwcw wrote: > The two parents of this revision change the same file, so the build bot says > patch does not apply. Does that mean I have to submit the parent patches > with less context?

[PATCH] D125243: [OpenCL] Make -cl-ext a driver option

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3145-3146 + +Note that some targets e.g. SPIR/SPIR-V enable all extensions/features in clang by +default. + svenvh wrote: > Was this meant to go after the command example? true, will fix

[PATCH] D125604: [FileCheck] Catch missspelled directives.

thopre added inline comments. Comment at: llvm/lib/FileCheck/FileCheck.cpp:1774-1781 +static std::pair +FindCheckType(const FileCheckRequest , StringRef Buffer, StringRef Prefix) { + bool Misspelled = false; + auto Res = FindCheckType(Req, Buffer, Prefix, Misspelled); + if

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026

[PATCH] D125318: [analyzer] Add UnarySymExpr

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/unary-sym-expr.c:35 +return; + clang_analyzer_eval(-(x + y) == -3); // expected-warning{{TRUE}} +} martong

[PATCH] D125673: [clangd] Add command-line flag to set background indexing thread priority.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. As pointed out in the previous review section, having a dedicated accept

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

kadircet added a reviewer: kadircet. kadircet added a comment. 66% win sounds great, it would be nice to have some detailed numbers (but this is clearly a huge win, so no need to reperform the experiments if numbers are gone) Comment at:

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

Anastasia created this revision. Anastasia added reviewers: mpaszkowski, iliya-diyachkov, svenvh, linjamaki. Herald added subscribers: ThomasRaoux, ebevhan. Herald added a project: All. Anastasia requested review of this revision. Herald added a subscriber: MaskRay. Following the new flow for

[PATCH] D110685: [HIPSPV][4/4] Add option to use llc to emit SPIR-V

Anastasia added a comment. Actually after some more thinking I have decided to go for a generic flag and I have created the review for it: https://reviews.llvm.org/D125679. Perhaps you can built your functionality on top of it when you get to it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

aaronpuchert added a comment. In D125429#3512642 , @aaronpuchert wrote: > Proposed this in D125580 . Landed this two days ago and no one complained about it so far, so let's hope that solved it. Repository: rG

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 added a comment. So those times were a little unfair as now we don't use ParentMapContext, however the cost of building that is included in the running time for the check. In a use case where you have other enabled checks with do make use of that, the cost for building would be moved

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:839 +void FormatTokenLexer::resizeToken(size_t NewLen) { + resetLexer(SourceMgr.getFileOffset(Lex->getSourceLocation( sstwcw wrote: > HazardyKnusperkeks wrote: > > Can

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong added a comment. In D125547#3515259 , @steakhal wrote: > Something is messed up with the diff. You refer to `fromUnOp()` but it's not > defined anywhere. No. There is no mess up here, the diff is correct. `fromUnOp` had been implemented way

[clang] 9dffab9 - [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

Author: owenca Date: 2022-05-16T02:43:35-07:00 New Revision: 9dffab9d524a05742a765dea27aedc8a7080a402 URL: https://github.com/llvm/llvm-project/commit/9dffab9d524a05742a765dea27aedc8a7080a402 DIFF: https://github.com/llvm/llvm-project/commit/9dffab9d524a05742a765dea27aedc8a7080a402.diff LOG:

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

This revision was automatically updated to reflect the committed changes. Closed by commit rG9dffab9d524a: [clang-format][NFC] Dont call mightFitOnOneLine() unnecessarily (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125673: [clangd] Add command-line flag to set background indexing thread priority.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM. i agree that having this as a config to let users prioritise some sources over others could be useful, but it's too intrusive and unclear how useful that would be in

[PATCH] D125401: [OpenCL] Do not guard vload/store_half builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125401/new/ https://reviews.llvm.org/D125401 ___ cfe-commits mailing

[PATCH] D125682: Add documentHighlight in clangd check for performance measurements.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

steakhal added a comment. Something is messed up with the diff. You refer to `fromUnOp()` but it's not defined anywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/ https://reviews.llvm.org/D125547

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj updated this revision to Diff 429653. upsj marked 4 inline comments as done. upsj added a comment. review updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 Files:

[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

njames93 added a comment. Since latest update speed up gone from 0.87s to 0.04s for SemaCodeComplete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 ___

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/IntegralLiteralExpressionMatcher.cpp:204 + return true; +} + LegalizeAdulthood wrote: > LegalizeAdulthood wrote: > > aaron.ballman wrote: > > > LegalizeAdulthood wrote: > >

[PATCH] D124435: [X86] Always extend the integer parameters in callee

jyknight added a comment. I find the option names you have a bit confusing. I'd like to suggest calling them, instead: caller: Extend a small integer parameter in the caller; callee will assume it has already been extended. callee : Pass a small integer parameter directly in caller, extend in

  1   2   >