[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

rengolin added a comment. In D126451#3541590 , @zixuan-wu wrote: > I don't think it is largely similar to RISCV implementation except for the > code structure and test reuse. And the test result is big different. Sorry, that's what I meant. There are

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:621 +void CodeGenModule::EmitCXXModuleInitFunc(Module *Primary) { + while (!CXXGlobalInits.empty() && !CXXGlobalInits.back()) ChuanqiXu wrote: > iains wrote: > > ChuanqiXu wrote: > > >

[PATCH] D126511: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument

pengfei added a comment. This is also fine to me. I'll rebase on it if @nickdesaulniers accept this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126511/new/ https://reviews.llvm.org/D126511 ___

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei updated this revision to Diff 432511. pengfei marked 5 inline comments as done. pengfei added a comment. Address @MaskRay 's comments. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:257 +} else if (Scope != "none") { + D.Diag(diag::err_invalid_sls_hardening) << Scope << A->getAsString(Args); +} nickdesaulniers wrote: > MaskRay wrote: > > The

[clang] 7df2597 - [Doc][OpenCL] Misc wording improvements for SPIR-V

Author: Anastasia Stulova Date: 2022-05-27T11:13:06+01:00 New Revision: 7df25978ef7882a3d793eecee854ec5d961c02d2 URL: https://github.com/llvm/llvm-project/commit/7df25978ef7882a3d793eecee854ec5d961c02d2 DIFF:

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 432509. steakhal edited the summary of this revision. steakhal added a comment. - Specify exactly that we propose one release deprecation, then removal. - Test the help message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal added a comment. I'm hesitating about landing this. I think I'll mark this flag deprecated instead, to emit a warning when using this flag. So, `clang-15` would emit a warning for this, and `clang-16` and above we can remove this flag completely. WDYT @martong ? Repository: rG LLVM

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. In D126291#3536718 , @kiranchandramohan wrote: > @rovka in case you missed this, the test is failing in windows. Yeah, thanks, I was out of office a bit so I couldn't get to it sooner. I'll give it a try without lld.

[clang] 3988bd1 - [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

Author: Balazs Benics Date: 2022-05-27T11:15:23+02:00 New Revision: 3988bd13988aad72ec979beb2361e8738584926b URL: https://github.com/llvm/llvm-project/commit/3988bd13988aad72ec979beb2361e8738584926b DIFF: https://github.com/llvm/llvm-project/commit/3988bd13988aad72ec979beb2361e8738584926b.diff

[PATCH] D126068: [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3988bd13988a: [llvm][clang][bolt][NFC] Use llvm::less_first()

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

mstorsjo added a comment. Regarding building native tools while cross compiling - for other tools so far, we’ve also had the option to pass an option like `-DLLVM_TABLEGEN=path/to/llvm-tblgen`. If all the needed native tools are provided that way, the build doesn’t need to set up the nested

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf13050eca356: [analyzer][NFCi] Annotate major nonnull returning functions (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D126198?vs=431379=432498#toc Repository: rG LLVM

[clang] f13050e - [analyzer][NFCi] Annotate major nonnull returning functions

Author: Balazs Benics Date: 2022-05-27T11:05:50+02:00 New Revision: f13050eca3564ebccc04ea39eb34a312f063c4e9 URL: https://github.com/llvm/llvm-project/commit/f13050eca3564ebccc04ea39eb34a312f063c4e9 DIFF: https://github.com/llvm/llvm-project/commit/f13050eca3564ebccc04ea39eb34a312f063c4e9.diff

[clang] 6ab69ef - [analyzer][NFC] Rename GREngine->CoreEngine, GRExprEngine->ExprEngine in comments and txt files

Author: Gabor Marton Date: 2022-05-27T11:04:35+02:00 New Revision: 6ab69efe61f2db50d72416a59fafa427249cb91b URL: https://github.com/llvm/llvm-project/commit/6ab69efe61f2db50d72416a59fafa427249cb91b DIFF: https://github.com/llvm/llvm-project/commit/6ab69efe61f2db50d72416a59fafa427249cb91b.diff

[PATCH] D125708: [analyzer][NFC] Remove unused default SVal constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7727d2abece6: [analyzer][NFC] Remove unused default SVal constructors (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125707: [analyzer][NFC] Remove unused friend SVal declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8def22f7be1: [analyzer][NFC] Remove unused friend SVal declarations (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125706: [analyzer][NFC] Use idiomatic classof instead of isKind

This revision was automatically updated to reflect the committed changes. Closed by commit rGe37b287998a7: [analyzer][NFC] Use idiomatic classof instead of isKind (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D125706?vs=429767=432493#toc Repository: rG LLVM

[clang] 7727d2a - [analyzer][NFC] Remove unused default SVal constructors

Author: Balazs Benics Date: 2022-05-27T10:54:25+02:00 New Revision: 7727d2abece6855ec6486ca0600998bfa35882a1 URL: https://github.com/llvm/llvm-project/commit/7727d2abece6855ec6486ca0600998bfa35882a1 DIFF: https://github.com/llvm/llvm-project/commit/7727d2abece6855ec6486ca0600998bfa35882a1.diff

[clang] d8def22 - [analyzer][NFC] Remove unused friend SVal declarations

Author: Balazs Benics Date: 2022-05-27T10:54:25+02:00 New Revision: d8def22f7be120ab159220a9e6d450b26bf50bca URL: https://github.com/llvm/llvm-project/commit/d8def22f7be120ab159220a9e6d450b26bf50bca DIFF: https://github.com/llvm/llvm-project/commit/d8def22f7be120ab159220a9e6d450b26bf50bca.diff

[clang] e37b287 - [analyzer][NFC] Use idiomatic classof instead of isKind

Author: Balazs Benics Date: 2022-05-27T10:54:25+02:00 New Revision: e37b287998a72b028fbcf623f06685ed2b6b48e2 URL: https://github.com/llvm/llvm-project/commit/e37b287998a72b028fbcf623f06685ed2b6b48e2 DIFF: https://github.com/llvm/llvm-project/commit/e37b287998a72b028fbcf623f06685ed2b6b48e2.diff

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes llvm#53545 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126524 Files:

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead added a comment. In D126461#3541577 , @craig.topper wrote: > What if it isn't known to be null at compile time but gets optimized to it. Thanks, I haven't thought it clearly and I just wanted to solve found bugs. :-) I changed it to

[PATCH] D126123: [analyzer][NFC] Use MemRegion::getRegion()'s return value unconditionally

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a666dd37a06: [analyzer][NFC] Use MemRegion::getRegion()s return value unconditionally (authored by steakhal). Repository: rG LLVM Github

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

This revision was automatically updated to reflect the committed changes. Closed by commit rG813acb12972e: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126130/new/

[PATCH] D126129: [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81066603a8b9: [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp (authored by steakhal). Changed prior to commit:

[PATCH] D126128: [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6eab4376432: [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp (authored by steakhal). Changed prior to commit:

[clang] 3a7a465 - [analyzer][docs] Fix typo in checker name

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 3a7a465def4a7faae41467893276910b1faa6152 URL: https://github.com/llvm/llvm-project/commit/3a7a465def4a7faae41467893276910b1faa6152 DIFF: https://github.com/llvm/llvm-project/commit/3a7a465def4a7faae41467893276910b1faa6152.diff

[clang] 3a666dd - [analyzer][NFC] Use MemRegion::getRegion()'s return value unconditionally

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 3a666dd37a06fd5ff74b9e8fea15e31a80398233 URL: https://github.com/llvm/llvm-project/commit/3a666dd37a06fd5ff74b9e8fea15e31a80398233 DIFF: https://github.com/llvm/llvm-project/commit/3a666dd37a06fd5ff74b9e8fea15e31a80398233.diff

[clang] 813acb1 - [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 813acb12972eceabd2b5b06f2c11d3a1f34579bd URL: https://github.com/llvm/llvm-project/commit/813acb12972eceabd2b5b06f2c11d3a1f34579bd DIFF: https://github.com/llvm/llvm-project/commit/813acb12972eceabd2b5b06f2c11d3a1f34579bd.diff

[PATCH] D126125: [analyzer][NFC] Inline ExprEngine::evalMinus

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee8987d585e7: [analyzer][NFC] Inline ExprEngine::evalMinus (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8106660 - [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 81066603a8b91ec3edf59622d153ba40f0b4a169 URL: https://github.com/llvm/llvm-project/commit/81066603a8b91ec3edf59622d153ba40f0b4a169 DIFF: https://github.com/llvm/llvm-project/commit/81066603a8b91ec3edf59622d153ba40f0b4a169.diff

[clang] f6eab43 - [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: f6eab4376432fffe99b6699e6b604a38a8906bfe URL: https://github.com/llvm/llvm-project/commit/f6eab4376432fffe99b6699e6b604a38a8906bfe DIFF: https://github.com/llvm/llvm-project/commit/f6eab4376432fffe99b6699e6b604a38a8906bfe.diff

[PATCH] D126124: [analyzer][NFC] Inline ExprEngine::evalComplement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2d6dea73b5: [analyzer][NFC] Inline ExprEngine::evalComplement (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] ee8987d - [analyzer][NFC] Inline ExprEngine::evalMinus

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: ee8987d585e799ec056da364220e81d97258ddec URL: https://github.com/llvm/llvm-project/commit/ee8987d585e799ec056da364220e81d97258ddec DIFF: https://github.com/llvm/llvm-project/commit/ee8987d585e799ec056da364220e81d97258ddec.diff

[clang] 7a2d6de - [analyzer][NFC] Inline ExprEngine::evalComplement

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 7a2d6dea73b594a42b83ed48bd19bd232c29f2b8 URL: https://github.com/llvm/llvm-project/commit/7a2d6dea73b594a42b83ed48bd19bd232c29f2b8 DIFF: https://github.com/llvm/llvm-project/commit/7a2d6dea73b594a42b83ed48bd19bd232c29f2b8.diff

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. @iains Do you agree to submit this one first? Since all the discussions/questions I see in this page now it not about the patch itself. The patch itself should be good personally I thought. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Prefer https://reviews.llvm.org/D126189 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 ___ cfe-commits mailing list

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan added a comment. In D126365#3536736 , @curdeius wrote: > Would it be possible to add a test please? There are no tests for this script, but I have tested this patch on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 updated this revision to Diff 432478. kpdev42 edited the summary of this revision. kpdev42 added a comment. Well, after some investigation it turned out that: 1. ARMv5 has DMB instruction in the form of mcr p15, #0, , c7, c10, #5 2. There is SWP instruction (deprecated on ARMv6), which

[PATCH] D126522: Create specialization of `-Wgnu-statement-expression` for expressions found in macros.

mwyman updated this revision to Diff 432471. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126522/new/ https://reviews.llvm.org/D126522 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Parse/ParseExpr.cpp

[libunwind] e251fb4 - [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG

Author: Pavel Samolysov Date: 2022-05-27T09:20:57+03:00 New Revision: e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7 URL: https://github.com/llvm/llvm-project/commit/e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7 DIFF:

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432468. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp

[PATCH] D126522: Create specialization of `-Wgnu-statement-expression` for expressions found in macros.

mwyman created this revision. mwyman added reviewers: stephanemoore, hokein, ymandel, dmaclach. mwyman added a project: clang. Herald added a project: All. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. `-Wgnu-statement-expression` currently warns for both

<    1   2