[PATCH] D127859: [clangd] Don't add inlay hints on std::move/forward

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127859/new/ https://reviews.llvm.org/D127859

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Thanks for the update and the additional test cases! Comment at: clang-tools-extra/clangd/AST.cpp:682 + if (const auto *TTPD = + dyn_cast(TemplateParams.back())) { +const auto *TTPT = upsj wrote: > nridge

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

mizvekov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. mizvekov published this revision for review. mizvekov added reviewers: dyung, nikic. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository:

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

mizvekov added a comment. Hi @dyung, can you verify the solution I proposed in https://reviews.llvm.org/D127943 is good for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126308/new/ https://reviews.llvm.org/D126308

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

lei added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7716 +// This returns true if at least one of the types is an altivec vector. +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert((DestTy->isVectorType() || SrcTy->isVectorType()) &&

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

bader added a comment. > The way I understand a bitcast instruction in SPIR-V (`OpBitcast` in > https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_conversion_instructions) > is that it can only apply to pointer types which are distinct from function > types. Note that I believe

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

lei added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7738 +// This returns true if both vectors have the same element type. +bool Sema::areVectorTypesSameElmType(QualType SrcTy, QualType DestTy) { + assert((DestTy->isVectorType() || SrcTy->isVectorType()) &&

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3588651 , @bader wrote: >> The way I understand a bitcast instruction in SPIR-V (`OpBitcast` in >> https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_conversion_instructions) >> is that it can only

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

steakhal added a comment. Sorry for my late reply. It feels like we have some serious obstacles. The `check::PostCall` handler wants to mark some memory region immutable. Currently, the checker creates a new //symbolic// memregion, spawned into the //immutable// memory space. After this it

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3588417 , @ChuanqiXu wrote: > From what I can see, the crash reason would be the mismatch depth and the > setting of MultiLevelTemplateArgumentList. In > `::CheckConstraintSatisfaction`, the depth of

[PATCH] D127961: [OpenCL] Reduce emitting candidate notes for builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. When overload resolution fails, clang

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman added a comment. Btw, precommit CI caught a failure: FAIL: Clang :: CodeGen/hwasan-globals.cpp (4495 of 15547) TEST 'Clang :: CodeGen/hwasan-globals.cpp' FAILED Script: -- : 'RUN: at line 1'; echo "int extra_global;" >

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3586092 , @nikic wrote: > @Anastasia Thanks, that does sound like a legitimate reason to include the > information. I want to double check though, does linking the modules actually > fail if the functions have

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

martong added subscribers: steakhal, NoQ. martong added a comment. @NoQ @steakhal FYI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127923/new/ https://reviews.llvm.org/D127923 ___ cfe-commits mailing

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

steakhal added a comment. Please, consider updating the summary to clearly specify the motivation for making this change. It describes what this patch intends to do, but I'm about the why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127923/new/

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

martong added a comment. > If some checker placed a sink node into some block, the successors of the > sink block was marked unreachable previously. This leads to an unpleasant > situation from the user's point of view since a different bugreport gets > correlated with the FPs caused by the

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added a comment. It looks great. Let me check the test coverage and the generated docs page it everything looks great. Comment at: clang/docs/analyzer/checkers.rst:2538 +may change value of ``errno`` if the call does not fail. +Therefore ``errno`` should only be used

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe35096ae961e: cmake: configure clang lit to use hmaptool from source directly (authored by mizvekov). Repository: rG LLVM Github Monorepo

[clang] e35096a - cmake: configure clang lit to use hmaptool from source directly

Author: Matheus Izvekov Date: 2022-06-16T13:08:50+02:00 New Revision: e35096ae961eb25843f0489847cdb6c1c586ad30 URL: https://github.com/llvm/llvm-project/commit/e35096ae961eb25843f0489847cdb6c1c586ad30 DIFF:

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: hctim wrote: > aaron.ballman wrote: > > Spurious whitespace change? > unfortunately there's no way in my editor to trim trailing

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 437508. upsj marked 4 inline comments as done. upsj added a comment. - remove inlay hints from std::forward in tests - identify recursive variadic calls from template, not post-processing - allow template parameter packs to appear at any place - improve

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:682 + if (const auto *TTPD = + dyn_cast(TemplateParams.back())) { +const auto *TTPT = nridge wrote: > upsj wrote: > > nridge wrote: > > > I don't think there is

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

iliya-diyachkov added a comment. In D127579#3585411 , @Anastasia wrote: > Also is there anything that we don't need from the metadata that are > currently emitted for the use case i.e. for example argument names? This > could reduce the number of

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 437513. balazske added a comment. Use typed state trait. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122150/new/ https://reviews.llvm.org/D122150 Files: clang/docs/ReleaseNotes.rst

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1926 +// f16 %r = llvm.amdgcn.fdot2.f16.f16(v2f16 %a, v2f16 %b, f16 %c, i1 %clamp) +// %r = %a[0] * %b[0] + %a[1] * %b[1] + %c rampitec wrote: > I do not see clamp in the

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

tschuett added a comment. C++ seems to be tied to templates. I wonder if super classes resp. inheritance would make your life easier. You can explicitly define the API and documentation. You could provide default implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added a comment. Awesome! The generated doc section looks great. The test coverage it excellent, but I would recommend adding tests for covering the following lines: - `ErrnoChecker.cpp:99` - `ErrnoModeling.cpp:259` - `ErrnoModeling.cpp:264` There are two other uncovered cases, but

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl updated this revision to Diff 437587. yaxunl added a comment. use compiler-rt as runtime lib by default for --hip-link CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127142/new/ https://reviews.llvm.org/D127142 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao updated this revision to Diff 437593. vangthao added a comment. Update commit message to include the motivation behind the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127923/new/ https://reviews.llvm.org/D127923 Files:

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added a comment. I think it's a good idea. When does `MatchingParen` bind? The value of `PrevToken->MatchingParen` is still NULL in `determineStarAmpUsage` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

steakhal added a comment. In the `describeErrnoCheckState()` the `Errno_MustBeChecked` is uncovered by tests. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:410 +/// Many of the descendant classes use this value. +

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127904/new/ https://reviews.llvm.org/D127904

[PATCH] D127184: [clangd] Add to header map

nridge added a comment. Thanks for taking the time to do a systematic review! In D127184#3577165 , @falbrechtskirchinger wrote: > bits/mofunc_impl.h I see this included from `bits/move_only_function.h`, so I think `` would make sense for it. >

[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay added a comment. I think you are missing a PARSE unit test Comment at: clang/docs/ClangFormatStyleOptions.rst:4261 + **AfterPlacementOperator** (``AfterPlacementOperatorStyle``) :versionbadge:`clang-format 14` +Defines in which cases to put a space

[PATCH] D127943: cmake: configure clang lit to use hmaptool from source directly

dyung accepted this revision. dyung added a comment. This revision is now accepted and ready to land. I tried it on Windows building with both ninja and Visual Studio and both seem to work after your change. LGTM. Thanks for looking into this! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437468. omarahmed edited the summary of this revision. omarahmed added a comment. Add coverage for placement delete expressions and transform bool option to enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, many thanks for this non trivial effort! :) I've left a few nits, feel free to ignore! @mstorsjo , are you also OK with this change? [nit] "This is exactly what we do for

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. Kind ping to reviewers :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 ___ cfe-commits mailing list

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

ChuanqiXu added a comment. From what I can see, the crash reason would be the mismatch depth and the setting of MultiLevelTemplateArgumentList. In `::CheckConstraintSatisfaction`, the depth of `RawCompletionToken ` is 0, while the depth of corresponding MultiLevelTemplateArgumentList is 2. So

[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:3495 +/// \code +///true: false: +///new (buf) T;vs.new(buf) T; should this be `Always/Never`

[clang-tools-extra] e984e1c - [clangd] Don't add inlay hints on std::move/forward

Author: Tobias Ribizel Date: 2022-06-16T12:24:16+02:00 New Revision: e984e1cd6137bb235ca8081b7b35e219c001f86d URL: https://github.com/llvm/llvm-project/commit/e984e1cd6137bb235ca8081b7b35e219c001f86d DIFF:

[PATCH] D127859: [clangd] Don't add inlay hints on std::move/forward

This revision was automatically updated to reflect the committed changes. Closed by commit rGe984e1cd6137: [clangd] Dont add inlay hints on std::move/forward (authored by upsj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127859/new/

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

lenary added a comment. Yes. Please submit a PR or Issue to the ACLE, explaining the use-case (the explanation here is good enough, I think). Once the ACLE changes are merged, then you can proceed with a patch for clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 437471. balazske marked 7 inline comments as done. balazske added a comment. applied review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122150/new/ https://reviews.llvm.org/D122150 Files:

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:93 + EXPECT_EQ(Tokens.size(), 10u) << Tokens; + EXPECT_TOKEN(Tokens[6], tok::star, TT_PointerOrReference); } HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > >

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. In D127270#3584200 , @curdeius wrote: > Does this patch really fix https://github.com/llvm/llvm-project/issues/54703? > If so, please add test for it. Otherwise remove the link from the summary > (and if possible handle it in

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2538-2539 +yet supported by the checker. +The return values for the failure cases are documented in the standard Linux man +pages of the functions. + steakhal wrote: > Maybe place a

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp:73 +REGISTER_TRAIT_WITH_PROGRAMSTATE(ErrnoState, ErrnoCheckState) + You will need this to get it compiled. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, c-rhodes, sdesmalen. Herald added subscribers: ctetreau, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D126891: [clang-tidy] The check should ignore final classes

steakhal added a comment. @aaron.ballman @njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126891/new/ https://reviews.llvm.org/D126891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2313 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp)) + return TT_BinaryOperator; Instead of checking for `r_brace`, maybe it would be possible to

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D126495#3574115 , @LegalizeAdulthood wrote: > In D126495#3571511 , @njames93 > wrote: >

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev added a comment. provide full context of the changes. Comment at: clang/include/clang/AST/OpenMPClause.h:7646 - /// A kind of the 'default' clause. + /// A kind of the 'order' clause. OpenMPOrderClauseKind Kind = OMPC_ORDER_unknown; Commit as

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sdesmalen added a comment. Hi @sagarkulkarni19, this patch will have to wait until the ABI is implemented so that the builtins can be decorated with the attributes. A first patch proposing these attributes is in D127762 . LLVM patches that use these attributes

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

jcranmer-intel added a comment. In D127579#3588607 , @iliya-diyachkov wrote: > I think the return type information can be added in the next version of the > patch, however it should be attached to function declarations (not > definitions as it's done

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash updated this revision to Diff 437552. Joe_Nash marked 3 inline comments as done. Joe_Nash added a comment. added builtin positive tests, removed clamp from intrinsic comments, combined gisel with normal codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

bsmith updated this revision to Diff 437557. bsmith added a comment. - Add info to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437566. ahatanak added a comment. Revert the changes made to SemaCoroutine.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 Files:

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa70b39abffb4: [clang] Dont emit type test/assume for virtual classes that should never… (authored by aeubanks). Repository: rG LLVM Github

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added a comment. Thanks @aaron.ballman for your elaborate review, that was very helpful! I'm still working through some of your suggestions (although some of them weren't entirely clear to me), but I've addressed a number of them already. In D127762#3582753

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille updated this revision to Diff 437582. serge-sans-paille retitled this revision from "[clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays" to "[clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays". serge-sans-paille edited

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

tschuett added a comment. Maybe a line in the Release Notes of LLVM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127976/new/ https://reviews.llvm.org/D127976 ___ cfe-commits mailing list

[PATCH] D127933: [clang] Don't emit IFUNC when targeting Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f6adc451a2: [clang] Dont emit IFUNC when targeting Fuchsia (authored by abrachet). Herald added a project: clang. Herald added a subscriber:

[clang] f4f6adc - [clang] Don't emit IFUNC when targeting Fuchsia

Author: Alex Brachet Date: 2022-06-16T15:38:12Z New Revision: f4f6adc451a2dc901c08c2fdac81ef2cf98a5cc6 URL: https://github.com/llvm/llvm-project/commit/f4f6adc451a2dc901c08c2fdac81ef2cf98a5cc6 DIFF: https://github.com/llvm/llvm-project/commit/f4f6adc451a2dc901c08c2fdac81ef2cf98a5cc6.diff LOG:

[PATCH] D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks

nicovank abandoned this revision. nicovank added a comment. Looks like `registerPPCallbacks` / `Result.Context->getSourceManager()` gives me the information I need. Thank you @gribozavr2 for your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/fpclamptosat_vec.ll:605 +; CHECK-NEXT:.cfi_def_cfa_offset 80 +; CHECK-NEXT:movss %xmm2, {{[-0-9]+}}(%r{{[sb]}}p) # 4-byte Spill +; CHECK-NEXT:movss %xmm1, {{[-0-9]+}}(%r{{[sb]}}p) # 4-byte Spill

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

nemanjai added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15587 + +bool isUnaligned = (BuiltinID == PPC::BI__builtin_altivec_vinsw || +BuiltinID == PPC::BI__builtin_altivec_vinsd) This is strange. You don't need the

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:35 +using NoopDiags = std::tuple<>; + I'm not sure that this is valid style. It's essentially a unit type, which I quite like, but I've never seen this

[clang] a70b39a - [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

Author: Arthur Eubanks Date: 2022-06-16T09:38:14-07:00 New Revision: a70b39abffb42eb85fd2dd7960ec9dc7ae38510c URL: https://github.com/llvm/llvm-project/commit/a70b39abffb42eb85fd2dd7960ec9dc7ae38510c DIFF:

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

steakhal added a comment. In D127874#3588786 , @martong wrote: >> If some checker placed a sink node into some block, the successors of the >> sink block was marked unreachable previously. This leads to an unpleasant >> situation from the user's point

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 437580. sdesmalen marked 10 inline comments as done. sdesmalen added a comment. Addressed bunch of the review comments (though not all yet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112579/new/ https://reviews.llvm.org/D112579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D126224: Add DWARF string debug to clang release notes.

paulkirth added a comment. so do we want to land this? or are there some outstanding issues I'm unaware of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. Yeah, I'll look at landing it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:209 def IsTupleSet: FlagType<0x4>; +def IsSME : FlagType<0x8>; +def IsSMELoadStore: FlagType<0x10>;

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson updated this revision to Diff 437656. royjacobson added a comment. Update the PR to now handle triviality, which turned out to require a different approach. On the bright side it is now easier to see how to implemenet the rest of P0848. Added an AST dump test that checks the

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. In D126495#3588787 , @aaron.ballman wrote: > In D126495#3574115 , > @LegalizeAdulthood wrote: > >> In D126495#3571511 , @njames93 >>

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2291 + // statement. + CodeGenFunction::RunCleanupsScope Cleanups(*this); + Do we need to do anything special when entering the full expressions to make sure that enclosing-block

[PATCH] D127910: [Clang][AArch64] Add SME C intrinsics for load and store

sagarkulkarni19 added a comment. In D127910#3589068 , @sdesmalen wrote: > Hi @sagarkulkarni19, this patch will have to wait until the ABI is > implemented so that the builtins can be decorated with the attributes. A > first patch proposing these

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim added a comment. (thanks for the bump - this one fell off the radar) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 ___ cfe-commits mailing list

[clang] 2d43de1 - [AMDGPU] gfx11 new dot instruction codegen support

Author: Joe Nash Date: 2022-06-16T14:19:34-04:00 New Revision: 2d43de13df03eab0fda1023b22b335b207afc507 URL: https://github.com/llvm/llvm-project/commit/2d43de13df03eab0fda1023b22b335b207afc507 DIFF: https://github.com/llvm/llvm-project/commit/2d43de13df03eab0fda1023b22b335b207afc507.diff

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d43de13df03: [AMDGPU] gfx11 new dot instruction codegen support (authored by Joe_Nash). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] ee28837 - [NFCI] Whitespace in SemaDeclAttr.cpp

Author: Mitch Phillips Date: 2022-06-16T15:10:32-07:00 New Revision: ee28837a1fbd574dbec14b9f09cb4effab6a492a URL: https://github.com/llvm/llvm-project/commit/ee28837a1fbd574dbec14b9f09cb4effab6a492a DIFF:

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

hctim abandoned this revision. hctim added a comment. Herald added a subscriber: Enna1. Integrated slowly and surely as part of the stack leading up to D127911 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. In D113107#3585672 , @zahiraam wrote: > @rjmccall > The comma && ternary cases for EmitPromoted, I am not sure what needs to > happen there? Basically just the same thing that the normal paths do, except you recurse with

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. I had the same failures with and without this change. It looks like these tests are already broken upstream. Without this patch: Unsupported: 15 Passed : 50 Failed : 232 With this patch: Unsupported: 15 Passed : 50 Failed : 232

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

tra added a comment. Playing devil's advocate, I've got to ask -- do we even want to support JIT? JIT brings more trouble than benefits. - substantial start-up time on nontrivial apps. Last time I tried launching a tensorflow app and needed to JIT its kernels, it took about half an hour until

[clang] bb83f8e - [OpenMP] Initial parsing and sema for 'parallel masked' construct

Author: Jennifer Yu Date: 2022-06-16T18:01:15-07:00 New Revision: bb83f8e70bd1d56152f02307adacd718cd67e312 URL: https://github.com/llvm/llvm-project/commit/bb83f8e70bd1d56152f02307adacd718cd67e312 DIFF: https://github.com/llvm/llvm-project/commit/bb83f8e70bd1d56152f02307adacd718cd67e312.diff

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb83f8e70bd1: [OpenMP] Initial parsing and sema for parallel masked construct (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

rnk added a subscriber: aaron.ballman. rnk added a comment. I think Richard had some concerns in the other review that this may not be enough to really guarantee initialization order within the TU. I couldn't say either way, I shouldn't review this code. Conceptually, this change seems small

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. I started to get those errors on D126194 as well, definitely annoying. They both do spooky things with type triviality so maybe this is somehow related? I'm not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124093: [PowerPC] Fixing implicit castings in altivec for -fno-lax-vector-conversions

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat.c:8 // RUN: -D__XL_COMPAT_ALTIVEC__ -target-cpu pwr8 | FileCheck %s -// RUN: %clang_cc1

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 added a comment. In D127901#3590402 , @tra wrote: > Playing devil's advocate, I've got to ask -- do we even want to support JIT? > > JIT brings more trouble than benefits. > > - substantial start-up time on nontrivial apps. Last time I tried

[PATCH] D126224: Add DWARF string debug to clang release notes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG011e0604ebc9: Add DWARF string debug to clang release notes. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 011e060 - Add DWARF string debug to clang release notes.

Author: Mitch Phillips Date: 2022-06-16T14:54:12-07:00 New Revision: 011e0604ebc9d85db3585ebb2f63df465f726417 URL: https://github.com/llvm/llvm-project/commit/011e0604ebc9d85db3585ebb2f63df465f726417 DIFF:

[PATCH] D126224: Add DWARF string debug to clang release notes.

hctim updated this revision to Diff 437717. hctim marked an inline comment as done. hctim added a comment. Change a small amount of wording, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126224/new/ https://reviews.llvm.org/D126224 Files:

[clang] dba2ff5 - fix x86 sanitizer failure due to use of or

Author: Lei Huang Date: 2022-06-16T17:20:31-05:00 New Revision: dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd URL: https://github.com/llvm/llvm-project/commit/dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd DIFF: https://github.com/llvm/llvm-project/commit/dba2ff500d5b29f2d18b93aed5caa5b4ef7c94dd.diff

[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. Looks good to me in general, one general question though. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:773 + // TODO: Make this work unconditionally once Flang is mature enough. + if (!Args.hasArg(options::OPT_flang_experimental_exec)) +

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. The OpenMP tests passed on D127998 (I think just randomly?). I'm going to commit this tomorrow morning so I can revert if needed. Javier, thanks again for the patch and for the patience! Repository: rG LLVM Github Monorepo

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437740. maryammo added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

  1   2   >