[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. https://reviews.llvm.org/D128097 is now submitted. Unfortunately, it didn't fix the compile-time regression entirely (see detailed comments there). I'll do some more investigation to see where the rest of the slowdown is coming from. Repository: rG LLVM Github

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpText<"Pass to the offload linkers or the ones idenfied by -">, + HelpText<"Pass to the offload linkers or the ones

[PATCH] D127448: [wip][pseudo] Implement guard extension.

sammccall added a comment. The ParseLang + CLI library seem clearly separate from everything else, I think this patch should be split. Comments on that part first... Comment at: clang-tools-extra/pseudo/benchmarks/Benchmark.cpp:68 for (auto _ : State) -

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 439356. pratlucas added a comment. Fixing use-after-poison issue detected by ASAN buildbot. When popping LR on thumb it's value is popped into PC and used as a return. The original return instruction gets erased, invalidating the MachineInstr iterator.

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > Documentation path was changed recently.

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3603940 , @iains wrote: > In D128328#3602646 , @iains wrote: > >> In D128328#3601080 , @ChuanqiXu >> wrote: >> >>> It looks like we

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3603967 , @iains wrote: > In D128328#3603953 , @ChuanqiXu > wrote: > >> In D128328#3603945 , @iains wrote: >> >>> In

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski updated this revision to Diff 439285. awarzynski added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 Files: clang/include/clang/Driver/Options.td

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added a comment. In D128328#3604110 , @iains wrote: > In D128328#3603980 , @ChuanqiXu > wrote: > >> > > > Also, **if** [module.private.frag]p2.1 is changed into: > the point by which the

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

yurai007 added a comment. Disclaimer: I'm not front-end guy. After running 7zip benchmark under perf and comparing origin (7acc88be031 ) with fix (0d300da799b0

[PATCH] D127803: Generate the capture for field when the field is used in openmp region with implicit default in the member function.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:1873-1877 +if (auto *PrivateCopy = +isOpenMPFDCaptureDecl(Field, Base.get(), IsArrow, OpLoc, , + /*TemplateKWLoc=*/SourceLocation(), Field, +

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. I'm unfamiliar with -emit-ast. Can you add some background on what this is for? What's CTU? In any case this needs a test. Comment at: clang/include/clang/Driver/Options.td:834 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, -

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2322 +def ArmStreamingCompatible : DeclOrTypeAttr, TargetSpecificAttr { + let Spellings = [Clang<"arm_streaming_compatible">]; aaron.ballman wrote: > sdesmalen wrote: > >

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep added a comment. @xazax.hun After this patch, `SourceLocationsLattice` is still used by `clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp`. I'm currently working on a patch to change the way we write unit tests in that file, after which I'll make a followup

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme added a comment. Marking as {WIP] for the time being because I'm uploading this change for discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128439/new/ https://reviews.llvm.org/D128439

[PATCH] D128352: [clang][dataflow] Use diagnosis API in optional checker

samestep updated this revision to Diff 439373. samestep added a comment. - Merge branch 'diagnose-api' into optional-check-diagnose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128352/new/ https://reviews.llvm.org/D128352 Files:

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep updated this revision to Diff 439374. samestep added a comment. - Merge branch 'optional-check-diagnose' into optional-model-noop-lattice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128356/new/ https://reviews.llvm.org/D128356 Files:

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null

pcwang-thead abandoned this revision. pcwang-thead added a comment. After discussion, we decide to not change anything right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461

[PATCH] D125669: Adding support for target in_reduction

ABataev added a comment. In D125669#3604302 , @RitanyaB wrote: > In D125669#3599134 , @ABataev wrote: > >> What about the description? Shall we still emit ` if(0)`? > > Can you please elaborate for more clarity?

[PATCH] D128256: [Clang][AArch64] Limit arm_locally_streaming to function definitions only.

sdesmalen added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9835-9839 + if (D.isFunctionDefinition()) { +NewFD->setWillHaveBody(); +ProcessDeclAttributes(S, NewFD, D); +NewFD->setWillHaveBody(false); + } else aaron.ballman wrote: >

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 439372. samestep added a comment. - Merge branch 'main' into diagnose-api - Incorporate Gábor's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files:

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. @zahiraam, community requires to enable the `_Float16` support in FE, see https://discourse.llvm.org/t/how-to-build-compiler-rt-for-new-x86-half-float-abi/63366 Is there any blocking issue to land it soon? Otherwise, we can split the changes in `X86.cpp`,

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam updated this revision to Diff 439300. jspam added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157 Files:

[PATCH] D128299: [pseudo] Add a fast-path to GLR reduce when both pop and push are trivial

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:268 + // However in trivial cases (only pop that yields only one push) we can + // bypass all these fancy queues and pop+push directly. This is very common. + auto PopAndPushTrivial = [&]() -> bool

[clang] b6a33ce - [NFC] remove trailing whitespace

Author: Tobias Hieta Date: 2022-06-23T14:04:23+02:00 New Revision: b6a33cec3830b6c9ea35faf35b4a5889c22c6ae9 URL: https://github.com/llvm/llvm-project/commit/b6a33cec3830b6c9ea35faf35b4a5889c22c6ae9 DIFF: https://github.com/llvm/llvm-project/commit/b6a33cec3830b6c9ea35faf35b4a5889c22c6ae9.diff

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

aaron.ballman added a comment. In D112579#3603629 , @fcloutier wrote: > Would it be better if I asked a colleague to finish the review? Typically, you should try to get a LG from the reviewers who have been active on the review in the past (assuming

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi updated this revision to Diff 439369. ishaangandhi added a comment. Use `auto` instead of `Expr` and `llvm::cast` instead of `llvm::dyn_cast`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128402/new/ https://reviews.llvm.org/D128402 Files:

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This check was present before https://reviews.llvm.org/D126061. I eliminated it as part of that patch because it seemed

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. In D128328#3603942 , @ChuanqiXu wrote: > In D128328#3603940 , @iains wrote: > >> In D128328#3602646 , @iains wrote: >> >>> In D128328#3601080

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 439276. cor3ntin added a comment. - Remove explicit load instruction - cleanup extra braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128059/new/ https://reviews.llvm.org/D128059 Files:

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein created this revision. hokein added reviewers: sammccall, ilya-biryukov. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This enables us to use a different underlying token implementation for the syntax Leaf node -- in clang

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 439341. thieta added a comment. Removed unintentional whitespace removal and landed that as a NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files:

[PATCH] D128434: [OpenCL] Remove half scalar vload/vstore builtins

svenvh created this revision. svenvh added reviewers: Anastasia, stuart, azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. These are not

[PATCH] D126613: [Static Analyzer] Structured binding to arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ef628088b54: [analyzer] Structured binding to arrays (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8ef6280 - [analyzer] Structured binding to arrays

Author: isuckatcs Date: 2022-06-23T11:38:21+02:00 New Revision: 8ef628088b54aebd4a8317ce3a0029e3283b3aa0 URL: https://github.com/llvm/llvm-project/commit/8ef628088b54aebd4a8317ce3a0029e3283b3aa0 DIFF: https://github.com/llvm/llvm-project/commit/8ef628088b54aebd4a8317ce3a0029e3283b3aa0.diff

[clang] 6f258c0 - [Clang] Don't test register allocation

Author: Nikita Popov Date: 2022-06-23T12:46:00+02:00 New Revision: 6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f URL: https://github.com/llvm/llvm-project/commit/6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f DIFF: https://github.com/llvm/llvm-project/commit/6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f.diff

[clang] 8999b74 - Revert "[tbaa] Handle base classes in struct tbaa"

Author: Jeroen Dobbelaere Date: 2022-06-23T14:18:49+02:00 New Revision: 8999b745bc4ecae5ac74f5c4d06f40e317ddb12c URL: https://github.com/llvm/llvm-project/commit/8999b745bc4ecae5ac74f5c4d06f40e317ddb12c DIFF:

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. Unfortunately, it looks as if this patch did not fix the compile-time regression entirely. It did so for the particular source file I tested above, but other source files are still slower to compile than before D126061 . For

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

iains added a comment. In D128328#3603953 , @ChuanqiXu wrote: > In D128328#3603945 , @iains wrote: > >> In D128328#3603942 , @ChuanqiXu >> wrote: >> >>> In

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. In D128043#3604037 , @rovka wrote: > I just realized I haven't pestered you enough about testing :) I did feel like I was missing something here, haha! Updates arriving shortly! Repository: rG LLVM Github Monorepo

[clang-tools-extra] e36535f - Fix sphinx build for clang-tools-extra

Author: Aaron Ballman Date: 2022-06-23T07:22:00-04:00 New Revision: e36535f99cd4caa3773089a60eee26ad535a923d URL: https://github.com/llvm/llvm-project/commit/e36535f99cd4caa3773089a60eee26ad535a923d DIFF: https://github.com/llvm/llvm-project/commit/e36535f99cd4caa3773089a60eee26ad535a923d.diff

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

sdesmalen updated this revision to Diff 439330. sdesmalen marked 7 inline comments as done. sdesmalen added a comment. - Limited attribute to GNU spelling __attribute__((...)) - Changed `arm_locally_streaming` attribute to be `DeclOrStmtAttr` because it does not apply to type (only the

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3604048 , @pengfei wrote: > @zahiraam, community requires to enable the `_Float16` support in FE, see > https://discourse.llvm.org/t/how-to-build-compiler-rt-for-new-x86-half-float-abi/63366 > Is there any blocking

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. In D128409#3604460 , @hans wrote: > I'm unfamiliar with -emit-ast. Can you add some background on what this is > for? What's CTU? CTU is cross translation unit. In this case the clang-static-analyzer can do analysis over

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fdfeb0847df: [WebAssembly] Update test to run it in opaque pointers mode (authored by pmatos). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0fdfeb0 - [WebAssembly] Update test to run it in opaque pointers mode

Author: Paulo Matos Date: 2022-06-23T14:16:33+02:00 New Revision: 0fdfeb0847dfbce9d5734f61c9fc16ed6f7dc17e URL: https://github.com/llvm/llvm-project/commit/0fdfeb0847dfbce9d5734f61c9fc16ed6f7dc17e DIFF: https://github.com/llvm/llvm-project/commit/0fdfeb0847dfbce9d5734f61c9fc16ed6f7dc17e.diff

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

hans added a comment. In D128409#3604570 , @thieta wrote: > In D128409#3604460 , @hans wrote: > >> I'm unfamiliar with -emit-ast. Can you add some background on what this is >> for? What's CTU? > > CTU is cross

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

svenvh created this revision. svenvh added reviewers: Anastasia, stuart, azabaznov. svenvh added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. Herald added a project: All. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. These are not

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta created this revision. thieta added reviewers: hans, mstorsjo. Herald added a project: All. thieta requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Also make the output of -emit-ast end up where /Fo or /o points. The same with .plist

[PATCH] D128415: [ARM] Add Support for Cortex-M85 r=MarkMurrayARM,dmgreen,tmatheson

lenary created this revision. lenary added reviewers: MarkMurrayARM, dmgreen, tmatheson. Herald added subscribers: jdoerfert, hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D125669: Adding support for target in_reduction

RitanyaB marked an inline comment as done. RitanyaB added a comment. In D125669#3599134 , @ABataev wrote: > What about the description? Shall we still emit ` if(0)`? Can you please elaborate for more clarity? Comment at:

[clang] cdc59e2 - [tbaa] Handle base classes in struct tbaa

Author: Bruno De Fraine Date: 2022-06-23T13:39:49+02:00 New Revision: cdc59e2202c11a6a5dfd2ec83531523c58eaae45 URL: https://github.com/llvm/llvm-project/commit/cdc59e2202c11a6a5dfd2ec83531523c58eaae45 DIFF:

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdc59e2202c1: [tbaa] Handle base classes in struct tbaa (authored by brunodf, committed by jeroen.dobbelaere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128282: [WebAssembly] Update test to run it in opaque pointers mode

pmatos updated this revision to Diff 439345. pmatos added a comment. Remove extraneous whitespace. Make equal CHECK lines use WEBASSEMBLY: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128282/new/ https://reviews.llvm.org/D128282 Files:

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp:28 +const Expr *RHSExpr = llvm::dyn_cast(RHS); +if (LHSExpr->containsErrors() && RHSExpr->containsErrors()) { + return false; njames93 wrote:

[PATCH] D128379: [clangd] Change the url for clang-tidy check documentation

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:928 +std::tie(Module, Check) = Name.split('-'); +assert(!Module.empty() && !Check.empty()); +

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 439389. dongjunduo added a comment. [Clang] change directory-store to path-store Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Files:

[PATCH] D128439: [Clang][WIP] Don't call distributeTypeAttrsFromDeclarator() on empty list.

nikic added a comment. Not seeing a statistically significant impact from this change: http://llvm-compile-time-tracker.com/compare.php?from=8b6f69a4da5baaf3748798a84dd16a2481b7ca7f=797ba50f5fd88017925fe765427b1f5f136c3310=instructions Maybe it's an improvement at the 0.05% level, but it may

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor changes. Comment at: clang/lib/AST/ASTContext.cpp:1712 + case BuiltinType::Half: +// For HLSL, when not enable native half

[PATCH] D128297: [pseudo] Track heads as GSS nodes, rather than as "pending actions".

sammccall marked 6 inline comments as done. sammccall added a comment. As discussed offline, I'm going to land this patch as other approved optimizations are based on it, and there are no big objections. Please feel free to keep discussing details here and I'll land followups.

[PATCH] D128446: [clang][dataflow] Use annotations for optional diagnostic tests

samestep updated this revision to Diff 439415. samestep added a comment. - Merge branch 'diagnose-api' into diagnose-test-annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128446/new/ https://reviews.llvm.org/D128446 Files:

[PATCH] D128356: [clang][dataflow] Use NoopLattice in optional model

samestep updated this revision to Diff 439414. samestep added a comment. - Merge branch 'optional-check-diagnose' into optional-model-noop-lattice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128356/new/ https://reviews.llvm.org/D128356 Files:

[PATCH] D125669: Adding support for target in_reduction

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125669/new/ https://reviews.llvm.org/D125669 ___ cfe-commits mailing list

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

ishaangandhi added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches Eugene.Zelenko wrote: > Eugene.Zelenko wrote: > > ishaangandhi wrote: > > > ishaangandhi

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:236 +- Fixed a false positive in :doc:`bugprone-branch-clone + ` when the branches ishaangandhi wrote: > Eugene.Zelenko wrote: > > Eugene.Zelenko wrote: > > >

[clang-tools-extra] 2c80b53 - Revert "[pseudo] Track heads as GSS nodes, rather than as "pending actions"."

Author: Sam McCall Date: 2022-06-23T18:16:38+02:00 New Revision: 2c80b5319870b57fbdbb6c9cef9c86c26c65371d URL: https://github.com/llvm/llvm-project/commit/2c80b5319870b57fbdbb6c9cef9c86c26c65371d DIFF: https://github.com/llvm/llvm-project/commit/2c80b5319870b57fbdbb6c9cef9c86c26c65371d.diff

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128333/new/ https://reviews.llvm.org/D128333

[PATCH] D128301: [pseudo] Turn glrReduce into a class, reuse storage across calls.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e610f2cdc1e: [pseudo] Turn glrReduce into a class, reuse storage

[clang-tools-extra] 3e610f2 - [pseudo] Turn glrReduce into a class, reuse storage across calls.

Author: Sam McCall Date: 2022-06-23T19:27:47+02:00 New Revision: 3e610f2cdc1e156c82f5b59c287165e769b24f40 URL: https://github.com/llvm/llvm-project/commit/3e610f2cdc1e156c82f5b59c287165e769b24f40 DIFF: https://github.com/llvm/llvm-project/commit/3e610f2cdc1e156c82f5b59c287165e769b24f40.diff

[PATCH] D128301: [pseudo] Turn glrReduce into a class, reuse storage across calls.

sammccall added a comment. (Going to land this for post-commit review as a dumb mechanical change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128301/new/ https://reviews.llvm.org/D128301 ___

[clang-tools-extra] 7aff663 - [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

Author: Sam McCall Date: 2022-06-23T19:41:11+02:00 New Revision: 7aff663b2a04f6bea0732ed3b11e10466affb2ac URL: https://github.com/llvm/llvm-project/commit/7aff663b2a04f6bea0732ed3b11e10466affb2ac DIFF: https://github.com/llvm/llvm-project/commit/7aff663b2a04f6bea0732ed3b11e10466affb2ac.diff

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG7aff663b2a04: [pseudo] Store reduction sequences by pointer in heaps, instead of by value. (authored by

[PATCH] D128307: [pseudo] Store reduction sequences by pointer in heaps, instead of by value.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:208 + // Underlying storage for sequences pointed to by stored SequenceRefs. + std::deque SequenceStorage; + // We don't actually destroy the

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. I think on balance the right thing to do is probably to add an alternative to `-fexcess-precision`, like `-fexcess-precision=none`. We can default to `-fexcess-precision=standard` and treat `-fexcess-precision=fast` as an alias for `standard` for now.

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128157/new/ https://reviews.llvm.org/D128157

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 439383. pmatos added a comment. Remove conflict marker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D128441: [CUDA] Do not embed a fatbinary when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang.

[PATCH] D128448: [clang][dataflow] Delete SourceLocationsLattice

samestep created this revision. Herald added subscribers: martong, tschuett, mgrang, xazax.hun, mgorny. Herald added a project: All. samestep requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

miyuki added a comment. Hi Martin, I think this patch caused a regression. Clang used to warn about the following code: struct X { [[deprecated]] struct Y {}; }; $ clang -std=c++17 -Wall test.cpp :2:7: warning: attribute 'deprecated' is ignored, place it after "struct" to

[clang] 9ec7e4d - [clang][driver] NFC, test: Make test output order-independent

Author: Jan Svoboda Date: 2022-06-23T17:15:28+02:00 New Revision: 9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc URL: https://github.com/llvm/llvm-project/commit/9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc DIFF: https://github.com/llvm/llvm-project/commit/9ec7e4df57f3716018cc0ef60c5d37c8cf6a7cbc.diff

[PATCH] D125669: Adding support for target in_reduction

ssquare08 added a comment. In D125669#3604452 , @ABataev wrote: > In D125669#3604302 , @RitanyaB > wrote: > >> In D125669#3599134 , @ABataev >> wrote: >> >>> What about

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Diagnosis.h:38 +template +llvm::DenseSet diagnoseCFG( +const ControlFlowContext , This function seems pretty general and not necessarily tied to diagnostics. WDYT

[PATCH] D128157: [clang-tidy] cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam added a comment. @LegalizeAdulthood Not sure what exactly you mean by "fold your changes into `checkers/cppcoreguidelines/virtual-class-destructor.cpp`". The only rebase conflict was in `VirtualClassDestructorCheck.cpp`. Please let me know if there is still something to do. Repository:

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Diagnosis.h:38-42 +llvm::DenseSet diagnoseCFG( +const ControlFlowContext , +std::vector> , +const Environment , TypeErasedDataflowAnalysis , +Diagnosis> Diagnose) {

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs,

[PATCH] D128372: Clang-Tidy Empty Check

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs,

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

LegalizeAdulthood requested changes to this revision. LegalizeAdulthood added a comment. This revision now requires changes to proceed. Clang-Tidy tests and docs have moved to module subdirectories. Please rebase this onto `main:HEAD` and: - fold your changes into the appropriate subdirs,

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Okay, thanks both for your perspective on this. This LGTM as-is and we can handle validation and integration in subsequent patches. Thank you for this, @vaibhav.y! Repository:

[clang-tools-extra] 466eae6 - [pseudo] Store last node popped in the queue, not its parent(s). NFC

Author: Sam McCall Date: 2022-06-23T20:10:20+02:00 New Revision: 466eae6aa3574aea6604d42666f099025718ffa4 URL: https://github.com/llvm/llvm-project/commit/466eae6aa3574aea6604d42666f099025718ffa4 DIFF: https://github.com/llvm/llvm-project/commit/466eae6aa3574aea6604d42666f099025718ffa4.diff

[PATCH] D128411: [syntax] Introduce a BaseToken class.

sammccall added a comment. As discussed offline this has some problems: - putting virtual methods on BaseToken gives it a vtable, which makes it (and syntax::Token) large - being able to use ArrayRef but not ArrayRef is a bit weird - unusual uses of inheritance can be hard to reason about We

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos created this revision. pmatos added reviewers: asb, tlively. Herald added subscribers: mattd, gchakrabarti, asavonic, StephenFan, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a reviewer: aaron.ballman. Herald added a project: All. pmatos requested

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos planned changes to this revision. pmatos added a comment. Draft patch as some tests still fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 ___

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439385. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added a comment. Hi @jamieschmeiser @Whitney , I have changed the approach from directory-store to path-store, so that the user can specify the aim path to store the time trace json file. If "-ftime-trace-path" is not specified, it will follow the default behavior. In addition, I

[PATCH] D128446: [clang][dataflow] Use annotations for optional diagnostic tests

samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:159 +llvm::SmallSet ) { +if (const CallExpr *Call =

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added a comment. In D126864#3598257 , @serge-sans-paille wrote: > @kees does the new version looks good to you? Hi, yes, this is working as expected in my kernel builds. Yay! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/

[PATCH] D128415: [ARM] Add Support for Cortex-M85

dmgreen added inline comments. Comment at: llvm/lib/Target/ARM/ARM.td:1443 +def : ProcessorModel<"cortex-m85", CortexM4Model, [ARMv81mMainline, + FeatureDSP, Please use the CortexM7 schedule - it is

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Diagnosis.h:38-42 +llvm::DenseSet diagnoseCFG( +const ControlFlowContext , +std::vector> , +const Environment , TypeErasedDataflowAnalysis , +Diagnosis> Diagnose) {

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 439435. serge-sans-paille added a comment. Activate `-Warray-parameter` on `-Wmost` but disable it by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNotes.rst

  1   2   3   >