[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

junaire created this revision. junaire added a reviewer: v.g.vassilev. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts 3668d1264e2d246f7e222338b8a5cab18ce1bdab

[clang] 6956840 - Revert "Reland "[NFC] Add a missing test for for clang-repl""

Author: Jun Zhang Date: 2022-07-03T19:42:39+08:00 New Revision: 6956840b5c0029d7f8e043b3c77bb1ffc230e4d5 URL: https://github.com/llvm/llvm-project/commit/6956840b5c0029d7f8e043b3c77bb1ffc230e4d5 DIFF: https://github.com/llvm/llvm-project/commit/6956840b5c0029d7f8e043b3c77bb1ffc230e4d5.diff

[PATCH] D129043: [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands.

fakepaper56 created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta marked an inline comment as done. thieta added a comment. Thanks for the review! I uploaded a new version addressing all (I think) of your feedback and added a release note. The help text is a bit weird since it's using a commonoptionsparser we can't really change the text to add `` as

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains created this revision. Herald added a project: All. iains added reviewers: urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. the other

[PATCH] D128604: [RISCV] Support Zbpbo extension

sunshaoce updated this revision to Diff 441931. sunshaoce added a comment. Rebase on D99158 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files:

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 441930. thieta marked 6 inline comments as done. thieta added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704 Files:

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone updated this revision to Diff 441952. maharmstone added a comment. Rebased patch against current upstream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[PATCH] D128757: [Driver][test] Add -fuse-ld= option tests for NetBSD

fcambus added a comment. In D128757#3616795 , @MaskRay wrote: > I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, > especially for an ELF OS like NetBSD which shares many characteristics with > other ELF OSes. It will be

[clang] f7819ce - [FPEnv] Allow CompoundStmt to keep FP options

Author: Serge Pavlov Date: 2022-07-03T17:06:26+07:00 New Revision: f7819ce166bcc472108cf7c05f86edcf4ee9e6cf URL: https://github.com/llvm/llvm-project/commit/f7819ce166bcc472108cf7c05f86edcf4ee9e6cf DIFF: https://github.com/llvm/llvm-project/commit/f7819ce166bcc472108cf7c05f86edcf4ee9e6cf.diff

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman created this revision. Codesbyusman added reviewers: aaron.ballman, erichkeane, xgupta. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rewording the failing of _Satic_assert to the

[PATCH] D128625: [RISCV][Driver] Fix baremetal `GCCInstallation` paths

arichardson added inline comments. Comment at: clang/lib/Driver/ToolChains/RISCVToolchain.cpp:54 + + // Set alias for "riscv{64|32}-unknown-unknown-elf" + SmallVector TripleAliases; anton-afanasyev wrote: > arichardson wrote: > > This seems like the wrong

[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. Let's move forward and we can remove the XFAIL once https://reviews.llvm.org/D128968 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8679cbc - Reland "[NFC] Add a missing test for for clang-repl"

Author: Jun Zhang Date: 2022-07-03T19:15:59+08:00 New Revision: 8679cbc29fb76195544956fe233060bb7a1a6453 URL: https://github.com/llvm/llvm-project/commit/8679cbc29fb76195544956fe233060bb7a1a6453 DIFF: https://github.com/llvm/llvm-project/commit/8679cbc29fb76195544956fe233060bb7a1a6453.diff

[PATCH] D129042: Reland "[NFC] Add a missing test for for clang-repl"

This revision was automatically updated to reflect the committed changes. Closed by commit rG8679cbc29fb7: Reland [NFC] Add a missing test for for clang-repl (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129042/new/

[PATCH] D129043: [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands.

fakepaper56 updated this revision to Diff 441943. fakepaper56 added a comment. Align output code in riscv_vector_builtin_cg.inc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129043/new/ https://reviews.llvm.org/D129043 Files:

[PATCH] D128750: [c++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

royjacobson requested changes to this revision. royjacobson added a comment. This revision now requires changes to proceed. Thanks for working on this! I like the approach, but two comments: I would like more tests for the different forms of template argument deduction. Some suggestions for

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.9.11

sunshaoce updated this revision to Diff 441925. sunshaoce added a comment. Support for P extension version 0.9.11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c

[clang] b1f0efc - [clang-format] Tweak help text a bit

Author: Nico Weber Date: 2022-07-03T21:54:14+02:00 New Revision: b1f0efc06acc27ea07632452d9cf50eb7cc0c7f1 URL: https://github.com/llvm/llvm-project/commit/b1f0efc06acc27ea07632452d9cf50eb7cc0c7f1 DIFF: https://github.com/llvm/llvm-project/commit/b1f0efc06acc27ea07632452d9cf50eb7cc0c7f1.diff

[PATCH] D128984: [clang-format] Tweak help text a bit

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1f0efc06acc: [clang-format] Tweak help text a bit (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129030: [Driver] Ignore the clang modules validation-related flags if clang modules are not enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93d6fdfc232c: [Driver] Ignore the clang modules validation-related flags if clang modules are… (authored by akyrtzi). Repository: rG LLVM Github

[clang] 93d6fdf - [Driver] Ignore the clang modules validation-related flags if clang modules are not enabled

Author: Argyrios Kyrtzidis Date: 2022-07-03T21:26:15-07:00 New Revision: 93d6fdfc232c59975d52146532693178def5ad16 URL: https://github.com/llvm/llvm-project/commit/93d6fdfc232c59975d52146532693178def5ad16 DIFF:

[PATCH] D129030: [Driver] Ignore the clang modules validation-related flags if clang modules are not enabled

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129030/new/ https://reviews.llvm.org/D129030

[PATCH] D129050: [clang-format] Update documentation

thakis created this revision. thakis added reviewers: MyDeveloperDay, curdeius. Herald added a project: All. thakis requested review of this revision. - Update `clang-format --help` output after b1f0efc06acc . - Update

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Break after a

[PATCH] D129050: [clang-format] Update documentation

thakis added inline comments. Comment at: clang/docs/ClangFormat.rst:233 Script for patch reformatting = (As far as I can tell, we don't have `git clang-format` docs anywhere? But that's for a different patch.) CHANGES SINCE

[PATCH] D129049: [clang] Fix gcc-6 compilation error. (NFC)

sylvestre.ledru added a comment. thanks I will retrigger the CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129049/new/ https://reviews.llvm.org/D129049 ___ cfe-commits mailing list

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

LegalizeAdulthood added a comment. I will submit it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127807/new/ https://reviews.llvm.org/D127807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128807: [clang][transformer] Finish plumbing `Note` all the way to the output.

courbet added a comment. In D128807#3625676 , @ymandel wrote: >> For my particular case, I just need multiple notes per rule. I don't need >> them to be associated to a particular edit (and in that very particular >> case, I don't even need a source

[clang-tools-extra] f7a80c3 - [clang-tidy] Properly forward clang-tidy output when running tests

Author: Nicolas van Kempen Date: 2022-07-03T16:30:17-06:00 New Revision: f7a80c3d08d4821e621fc88d6a2e435291f82dff URL: https://github.com/llvm/llvm-project/commit/f7a80c3d08d4821e621fc88d6a2e435291f82dff DIFF:

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a80c3d08d4: [clang-tidy] Properly forward clang-tidy output when running tests (authored by nicovank, committed by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128981: [C++20][Modules] Implement include translation.

ChuanqiXu added a subscriber: rsmith. ChuanqiXu added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:434 +/// Saw a 'module' identifier. +void handleModule(bool ATLTS) { + // This was the first module identifier and not preceded by any token

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7099 OnePerLine); - verifyFormat("SomeClass::Constructor() :\n" + verifyFormat("SomeClass::Constructor() : // NOLINT\n" "a(aa),

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7136 Style); + verifyFormat("Constructor() : // NOLINT\n" + "() {}", How about very long comments? They don't get split now? Please add a

[clang-tools-extra] a65a3bf - [clang-tidy] Don't treat invalid branches as identical

Author: Ishaan Gandhi Date: 2022-07-03T15:50:33-06:00 New Revision: a65a3bffd31f57243929b0f50abbd90bd626faee URL: https://github.com/llvm/llvm-project/commit/a65a3bffd31f57243929b0f50abbd90bd626faee DIFF: https://github.com/llvm/llvm-project/commit/a65a3bffd31f57243929b0f50abbd90bd626faee.diff

[PATCH] D128402: [clang-tidy] Don't treat invalid branches as identical

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65a3bffd31f: [clang-tidy] Dont treat invalid branches as identical (authored by ishaangandhi, committed by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1343632 - [clang] Fix gcc-6 compilation error. (NFC)

Author: Sunho Kim Date: 2022-07-04T05:33:05+09:00 New Revision: 134363208b9272a967c911f7b56c255a72a6f0a0 URL: https://github.com/llvm/llvm-project/commit/134363208b9272a967c911f7b56c255a72a6f0a0 DIFF: https://github.com/llvm/llvm-project/commit/134363208b9272a967c911f7b56c255a72a6f0a0.diff

[PATCH] D129049: [clang] Fix gcc-6 compilation error. (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG134363208b92: [clang] Fix gcc-6 compilation error. (NFC)

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

ChuanqiXu added inline comments. Comment at: clang/lib/AST/TextNodeDumper.cpp:1723-1725 + if (!D->isInlineSpecified() && D->isInlined()) { +OS << " implicit-inline"; + } Is this necessary to this revision? Comment at:

[PATCH] D129048: Rewording the "static_assert" to static assertion

xgupta added a comment. Three test cases are failing - Please see: https://buildkite.com/llvm-project/premerge-checks/builds/100784#0181c539-bcd1-4d01-a2db-f27a63e2f17e/6-15379 But I think you want to actually modify