[PATCH] D129131: Remove uses of llvm_shutdown

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added a reviewer: bollu. Herald added subscribers: anlunx, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, jvesely,

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm updated this revision to Diff 442253. peterwaller-arm marked an inline comment as done. peterwaller-arm edited the summary of this revision. peterwaller-arm added a comment. - Update commit message: "This affects" -> "The fix affects" Repository: rG LLVM Github Monorepo

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nikic added a comment. @HanKuanChen Thanks for the report! I've landed a fix for this test case in https://github.com/llvm/llvm-project/commit/dc969061c68e62328607d68215ed8b9ef4a1e4b1. This is based on making SimplifyCFG behave more like JumpThreading, which does not have an infinite loop for

[PATCH] D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowAnalysisContext.cpp:61 + auto CanonicalPointeeType = + PointeeType.isNull() ? PointeeType :

[PATCH] D129061: [Lex] Diagnose macro in command lines

aaron.ballman added a reviewer: serge-sans-paille. aaron.ballman added a comment. Thank you for looking into this! I think we may need to figure out something better for handling macros defined by the driver, because otherwise we're going to get a bunch of false positives from this. For

[PATCH] D128820: [ConstExpr] Don't create div/rem expressions

nikic added inline comments. Comment at: llvm/lib/IR/Constants.cpp:2368-2379 +bool ConstantExpr::isDesirableBinOp(unsigned Opcode) { + assert(Instruction::isBinaryOp(Opcode) && "Argument must be binop opcode"); + switch (Opcode) { + case Instruction::UDiv: + case

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm created this revision. peterwaller-arm added reviewers: rsandifo-arm, kristof.beyls. Herald added subscribers: ctetreau, tschuett. Herald added a project: All. peterwaller-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D128166: ManagedStatic: Destroy from destructor

nhaehnle added a comment. Herald added a subscriber: anlunx. Abandoning this in favor of removing ManagedStatic entirely via the stack of changes that ends in D129134 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3897d3c - [clang-tidy] By-pass portability issues in confusable-identifiers test

Author: serge-sans-paille Date: 2022-07-05T12:36:00+02:00 New Revision: 3897d3cf71efa50da755e2fc3514b6c2bd4f1433 URL: https://github.com/llvm/llvm-project/commit/3897d3cf71efa50da755e2fc3514b6c2bd4f1433 DIFF:

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return Base::TraverseConstructorInitializer(Init); +if (const auto Member = Init->getMember()) { + const auto MemberType = Member->getType();

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

erichkeane added a comment. Wording looks fine to me, though unsure if this is a complete/accurate list for obvious reasons. If @iains can take a quick look, it woudl be greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t

li.zhe.hua updated this revision to Diff 442291. li.zhe.hua marked 2 inline comments as done. li.zhe.hua added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129097/new/ https://reviews.llvm.org/D129097 Files:

[clang-tools-extra] 9ab67cc - [pseudo] Implement guard extension.

Author: Haojian Wu Date: 2022-07-05T15:55:15+02:00 New Revision: 9ab67cc8bfe7181b7d775bab4d7a908dc8774889 URL: https://github.com/llvm/llvm-project/commit/9ab67cc8bfe7181b7d775bab4d7a908dc8774889 DIFF: https://github.com/llvm/llvm-project/commit/9ab67cc8bfe7181b7d775bab4d7a908dc8774889.diff

[PATCH] D127448: [pseudo] Implement guard extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab67cc8bfe7: [pseudo] Implement guard extension. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary added a comment. @tschuett I've corrected the patch based on your feedback. If you're happy, I'm going to land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 442211. thieta marked 3 inline comments as done. thieta added a comment. Uppercase all variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704 Files:

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

serge-sans-paille added a comment. In D128715#3629253 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/61559/step_8.txt I'm on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129093: [pseudo] Eliminate LRTable::Action. NFC

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:84 - - // NOTE: there are no typical accept actions in the LRtable, accept - //

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442276. Codesbyusman added a comment. updating some to the back strings becaue the orginal were more better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048

[clang-tools-extra] d263447 - [pseudo] Fix the build for the benchmark tool.

Author: Haojian Wu Date: 2022-07-05T15:42:41+02:00 New Revision: d26344731128ccdd8eeb27a12b2c3bd75e5e3a63 URL: https://github.com/llvm/llvm-project/commit/d26344731128ccdd8eeb27a12b2c3bd75e5e3a63 DIFF: https://github.com/llvm/llvm-project/commit/d26344731128ccdd8eeb27a12b2c3bd75e5e3a63.diff

[PATCH] D128820: [ConstExpr] Don't create div/rem expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG935570b2ad80: [ConstExpr] Dont create div/rem expressions (authored by nikic). Herald added a project: clang. Herald added a subscriber:

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

Kai added a comment. Did you consider to make this more generalized? From skimming through the change, I see only 2 ppc-specific things: - Loading of the canary word - Value of `XORWord` The first bullet is solved by the the other inline comment I made. The second bullet can be solved by using

[PATCH] D128706: [Clang] Disable clang-format entirely for clang/test tree.

aaron.ballman updated this revision to Diff 442298. aaron.ballman added a comment. Herald added projects: LLVM, clang-tools-extra. Herald added a subscriber: llvm-commits. Rebased and made the same changes for the LLVM and clang-tools-extra tests. CHANGES SINCE LAST ACTION

[clang] 1666f09 - [ARM] Add Support for Cortex-M85

Author: Archibald Elliott Date: 2022-07-05T10:43:31+01:00 New Revision: 1666f09933eefdd666be4c46887ba59ae089361c URL: https://github.com/llvm/llvm-project/commit/1666f09933eefdd666be4c46887ba59ae089361c DIFF:

[PATCH] D128415: [ARM] Add Support for Cortex-M85

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1666f09933ee: [ARM] Add Support for Cortex-M85 (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett added a comment. From reading the release note my understanding is that before this fix the caller of a function would store `z0-z7` in situations where it did not need to. Which seems low impact unless you were doing something that read the previous stack frame (but nevertheless

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

rsandifo-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:503 +- Targeting AArch64, LLVM now only preserves the z8-z23 registers across + a call if the registers z0-z7 are used to pass data into or out of a + subroutine. This new behavior now matches the

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

rsandifo-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:503 +- Targeting AArch64, since D127209 LLVM now only preserves the z8-z23 + and p4-p15 registers across a call if the registers z0-z7 or p0-p4 are + used to pass data into or out of a subroutine. The

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442299. Codesbyusman added a comment. updating the test files for the last update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129118: CommandLine: add and use cl::SubCommand::get{All,TopLevel}

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added subscribers: ayermolo, hiraditya. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a project: All. nhaehnle requested review of this revision.

[clang] f6fa998 - Fix tests with non-default CLANG_DEFAULT_LINKER

Author: Yi Kong Date: 2022-07-05T17:26:34+08:00 New Revision: f6fa9985900ee757a2cfce0f472ff1fc84463242 URL: https://github.com/llvm/llvm-project/commit/f6fa9985900ee757a2cfce0f472ff1fc84463242 DIFF: https://github.com/llvm/llvm-project/commit/f6fa9985900ee757a2cfce0f472ff1fc84463242.diff LOG:

[PATCH] D128415: [ARM] Add Support for Cortex-M85

tschuett accepted this revision. tschuett added a comment. LGTM. Please update the summary before you commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm added a comment. In D129135#3629833 , @DavidSpickett wrote: > From reading the release note my understanding is that before this fix the > caller of a function would store `z0-z7` in situations where it did not need > to. I believe

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. Thank you for getting a great start on this diagnostic rewording! I think we should also update DiagnosticParseKinds.td at the same time, but because that's about parsing rather than semantics, not all of the diagnostics should be reworded to use "static

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm updated this revision to Diff 442264. peterwaller-arm added a comment. s/p0-p4/p0-p3/, thanks for the keen eye, rsandifo-arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 Files:

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall planned changes to this revision. sammccall added a comment. Summarizing an offline discussion: - ThrottlerState isolates complexity inside TUScheduler by absolving Throttler of the need to worry about callback lifetimes - but it does so at the cost of extra aggregate complexity

[PATCH] D129104: [Modules] Add ODR Check for concepts

erichkeane added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6532 + const Expr *XCE = ConceptX->getConstraintExpr(); + const Expr *YCE = ConceptY->getConstraintExpr(); + assert(XCE && YCE && "ConceptDecl wihtout constraint expression?");

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains updated this revision to Diff 442242. iains added a comment. addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews.llvm.org/D128981 Files: clang/include/clang/Lex/Preprocessor.h

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett added a comment. > My intent was to express that the issue is present where it's the 9th or > later arguments. So I take from that that it does not matter if arguments 1-8 were all integers and so did not get put in SIMD/floating point registers. I think I am confusing what the

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm marked an inline comment as done. peterwaller-arm added inline comments. Comment at: clang/docs/ReleaseNotes.rst:503 +- Targeting AArch64, LLVM now only preserves the z8-z23 registers across + a call if the registers z0-z7 are used to pass data into or out of a

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm updated this revision to Diff 442251. peterwaller-arm added a comment. - Cite D127209 in the release note per tschuett comment. - Be more specific about p0-p4, remove 'by analogy', per rsandifo-arm comment. - Clarify 9th argument or greater, per

[PATCH] D129093: [pseudo] Eliminate LRTable::Action. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG9fbf1107cc76: [pseudo] Eliminate LRTable::Action. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D129093?vs=442127=442267#toc

[clang-tools-extra] 9fbf110 - [pseudo] Eliminate LRTable::Action. NFC

Author: Sam McCall Date: 2022-07-05T14:35:41+02:00 New Revision: 9fbf1107cc763783a82b89953be8a45097ba3390 URL: https://github.com/llvm/llvm-project/commit/9fbf1107cc763783a82b89953be8a45097ba3390 DIFF: https://github.com/llvm/llvm-project/commit/9fbf1107cc763783a82b89953be8a45097ba3390.diff

[PATCH] D127448: [pseudo] Implement guard extension.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:117 struct ParseParams { - // The grammar of the language we're going to parse. - const

[clang-tools-extra] 70c0d92 - [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

Author: Haojian Wu Date: 2022-07-05T15:17:18+02:00 New Revision: 70c0d92930b28104324b0888d6c6fdde2ffa5a07 URL: https://github.com/llvm/llvm-project/commit/70c0d92930b28104324b0888d6c6fdde2ffa5a07 DIFF: https://github.com/llvm/llvm-project/commit/70c0d92930b28104324b0888d6c6fdde2ffa5a07.diff

[PATCH] D129074: [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG70c0d92930b2: [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129074/new/

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added a comment. @nridge @sammccall if you don't have any further comments, I will commit this tomorrow, and maybe think about how to extend it to signature help/code completion :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/

[clang] f8e658e - [OpenCL] Remove fast_ half geometric builtins

Author: Sven van Haastregt Date: 2022-07-05T10:22:34+01:00 New Revision: f8e658ec9ff5b82d0c1f9d54d78c137b539319ca URL: https://github.com/llvm/llvm-project/commit/f8e658ec9ff5b82d0c1f9d54d78c137b539319ca DIFF:

[PATCH] D128436: [OpenCL] Remove fast_ half geometric builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8e658ec9ff5: [OpenCL] Remove fast_ half geometric builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128436/new/

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

peterwaller-arm added a comment. In D129135#3629860 , @peterwaller-arm wrote: > but I can't identify a specific worse issue at present. Thinking a little harder, one breaking case is where a callee-compiled-with-wrong-logic looks at its signature,

[clang] f03b876 - Reland "Reland "[NFC] Add a missing test for for clang-repl""

Author: Jun Zhang Date: 2022-07-05T18:23:26+08:00 New Revision: f03b876e7e9567ee71ee66f8f194918aac37d5fa URL: https://github.com/llvm/llvm-project/commit/f03b876e7e9567ee71ee66f8f194918aac37d5fa DIFF: https://github.com/llvm/llvm-project/commit/f03b876e7e9567ee71ee66f8f194918aac37d5fa.diff

[PATCH] D128449: [clang] Introduce -Warray-parameter

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:324-326 +- Added the ``-Warray-parameter`` warning. It detects function redefinition, + where different definition involve argument type that decay to the same + pointer type from different array

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

SchrodingerZhu added a comment. @MaskRay PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129009/new/ https://reviews.llvm.org/D129009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 935570b - [ConstExpr] Don't create div/rem expressions

Author: Nikita Popov Date: 2022-07-05T15:54:53+02:00 New Revision: 935570b2ad808035a1fd9bf6fa894657babc8694 URL: https://github.com/llvm/llvm-project/commit/935570b2ad808035a1fd9bf6fa894657babc8694 DIFF: https://github.com/llvm/llvm-project/commit/935570b2ad808035a1fd9bf6fa894657babc8694.diff

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

tschuett added a comment. Could you cite a Diff where this was changed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 ___ cfe-commits mailing list

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

ckandeler updated this revision to Diff 442257. ckandeler marked 4 inline comments as done. ckandeler added a comment. Implemented reviewer suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128977/new/ https://reviews.llvm.org/D128977

[PATCH] D129138: [clang] [docs] Update the changes of C++20 Modules in clang15

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, aaron.ballman, erichkeane. ChuanqiXu added a project: clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ff553979e8: [clang-extdef-mapping] Directly process .ast files (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e6ff553 - [clang-extdef-mapping] Directly process .ast files

Author: Tobias Hieta Date: 2022-07-05T13:45:52+02:00 New Revision: e6ff553979e850eeb7f0bbe77deab1c88fc764b3 URL: https://github.com/llvm/llvm-project/commit/e6ff553979e850eeb7f0bbe77deab1c88fc764b3 DIFF: https://github.com/llvm/llvm-project/commit/e6ff553979e850eeb7f0bbe77deab1c88fc764b3.diff

[PATCH] D129061: [Lex] Diagnose macro in command lines

serge-sans-paille added a comment. great addition. Missing a test case though, which would probably trigger @aaron.ballman scenario Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129061/new/ https://reviews.llvm.org/D129061

[PATCH] D127448: [pseudo] Implement guard extension.

hokein updated this revision to Diff 442290. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127448/new/ https://reviews.llvm.org/D127448 Files:

[PATCH] D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf10d271ae27f: [clang][dataflow] Handle null pointers of type std::nullptr_t (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo

[clang] f10d271 - [clang][dataflow] Handle null pointers of type std::nullptr_t

Author: Eric Li Date: 2022-07-05T13:49:26Z New Revision: f10d271ae27f35cd56535ff7e832a358732c8fcd URL: https://github.com/llvm/llvm-project/commit/f10d271ae27f35cd56535ff7e832a358732c8fcd DIFF: https://github.com/llvm/llvm-project/commit/f10d271ae27f35cd56535ff7e832a358732c8fcd.diff LOG:

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks great, let's ship it! feel free to land it in any form you think it is suitable. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:150 +// OldHeads is

[clang] bc36618 - Correct XFAIL according to bot owner's advice

Author: Jun Zhang Date: 2022-07-05T18:46:59+08:00 New Revision: bc366183a5928d7a7d5fd9d6971f43ff1358 URL: https://github.com/llvm/llvm-project/commit/bc366183a5928d7a7d5fd9d6971f43ff1358 DIFF: https://github.com/llvm/llvm-project/commit/bc366183a5928d7a7d5fd9d6971f43ff1358.diff

[PATCH] D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129135/new/ https://reviews.llvm.org/D129135 ___ cfe-commits mailing list

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nikic added a comment. I ended up reverting this patch in https://github.com/llvm/llvm-project/commit/a4772cbaf0dc717ab6b4639272ca2910897613f0, because I reduced another infinite loop (https://github.com/llvm/llvm-project/issues/56203) to it as well, which makes it the third one. It's

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall updated this revision to Diff 442319. sammccall marked an inline comment as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129100/new/ https://reviews.llvm.org/D129100 Files:

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:457 +// Give up on this request, releasing resources if any. +void abandon() { + std::lock_guard Lock(Mu); kadircet

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

aaron.ballman added a comment. In D112579#3625195 , @fcloutier wrote: > Thanks, Aaron. I wasn't sure how to follow up given how long it had been > since the review started. I understand that we're all busy (which explains > the week delay on my part

[PATCH] D129048: Rewording the "static_assert" to static assertion

aaron.ballman added a comment. In D129048#3630584 , @Codesbyusman wrote: > Yes I am looking into the DiagnosticParseKinds.td Excellent, thank you! In D129048#3630589 , @Codesbyusman wrote: > Yes I am looking

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:62-70 while (IndentForLevel.size() <= Line.Level) IndentForLevel.push_back(-1); if (Line.InPPDirective) { unsigned IndentWidth =

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier updated this revision to Diff 442396. fcloutier added a comment. There was a merge conflict on the release notes, updating the differential to get a CI build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112579/new/

[PATCH] D108469: Improve handling of static assert messages.

tahonermann added a comment. Herald added a reviewer: NoQ. I missed my opportunity to review while being on vacation last week. I reviewed to keep myself informed; spotted a typo. Comment at: llvm/lib/Support/Unicode.cpp:272 +/// Unicode code points of the Cf category are

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. Posted an update in rGa6e63e35ede4 , which removes the not-fully-implemented RTTI bits, and adds an extra test case to cover instantiation errors. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] f553287 - [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

Author: Anton Afanasyev Date: 2022-07-06T00:52:26+03:00 New Revision: f553287b588916de09c66e3e32bf75e5060f967f URL: https://github.com/llvm/llvm-project/commit/f553287b588916de09c66e3e32bf75e5060f967f DIFF:

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf553287b5889: [RISCV][Driver] Add libm linking to `RISCVToolchain` for C++ (authored by anton-afanasyev). Changed prior to commit:

[clang] 9b1cf2e - Fix running orc-rt tests with LLVM_BUILD_EXTERNAL_COMPILER_RT (again).

Author: Lang Hames Date: 2022-07-05T15:20:08-07:00 New Revision: 9b1cf2e2b2a8ca2bc10894d569a653429b989dd0 URL: https://github.com/llvm/llvm-project/commit/9b1cf2e2b2a8ca2bc10894d569a653429b989dd0 DIFF: https://github.com/llvm/llvm-project/commit/9b1cf2e2b2a8ca2bc10894d569a653429b989dd0.diff

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:82-83 +if (Size <= Line.Level) + IndentForLevel.insert(IndentForLevel.end(), Line.Level - Size + 1, +UnknownIndent ? -1 : Indent); }

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 442429. kito-cheng added a comment. Changes: - Less invasive way to fix this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files:

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nathanchance added a comment. Should dc969061c68e62328607d68215ed8b9ef4a1e4b1 be reverted as well? I just bisected an assertion failure while building the Linux kernel for arm64 to that change: clang:

[PATCH] D129158: [pseudo] Define recovery strategy as grammar extension.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:46 + assert(Begin > 0); + const Token = Tokens.tokens()[Begin - 1]; + if (const Token *Right = Left.pair())

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

tstellar added a comment. I similar RFC for this was proposed here: https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +genAssocMeta(); shchenz wrote: > Seems this dos not follow other functions call's style. Can we call a >

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 442425. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_differ.cpp

[clang-tools-extra] 05130a6 - new clang-tidy checker for assignments within condition clause of if statement

Author: Dmitri Gribenko Date: 2022-07-05T23:04:12+02:00 New Revision: 05130a6ba7d9974136388c1fbe63125596325d2e URL: https://github.com/llvm/llvm-project/commit/05130a6ba7d9974136388c1fbe63125596325d2e DIFF:

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG05130a6ba7d9: new clang-tidy checker for assignments within condition clause of if statement (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:62-70 while (IndentForLevel.size() <= Line.Level) IndentForLevel.push_back(-1); if (Line.InPPDirective) { unsigned IndentWidth = (Style.PPIndentWidth >= 0) ?

[clang] a6e63e3 - [NFC][HLSL] Add tests for vector alias. Remove dead code.

Author: Chris Bieneman Date: 2022-07-05T16:32:59-05:00 New Revision: a6e63e35ede4b9f23b58437263eaac9a2926c9bf URL: https://github.com/llvm/llvm-project/commit/a6e63e35ede4b9f23b58437263eaac9a2926c9bf DIFF:

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. It looks like my inline comment wasn't submitted (didn't click the submit button in the bottom). Here's my old comment. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 + + // Reformat Macro Expansion + if (!HI->MacroExpansion.empty()) {

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 442419. tingwang added a comment. Update according to comments: (1) Merged cleanupAssoc() into genAssocMeta(), and renamed genAssocMeta() to EmitAssociatedMetadata(). (2) Removed "-debug-info-kind=limited" from all test cases. Repository: rG LLVM Github

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar created this revision. tstellar added reviewers: MaskRay, h-vetinari. Herald added subscribers: StephenFan, fedor.sergeev, mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This

[clang] 92edd74 - Allow non-variadic functions to be attributed with `__attribute__((format))`

Author: Félix Cloutier Date: 2022-07-05T17:26:11-07:00 New Revision: 92edd74b37c7a96b1d47dc67cda7f92b65066025 URL: https://github.com/llvm/llvm-project/commit/92edd74b37c7a96b1d47dc67cda7f92b65066025 DIFF:

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG92edd74b37c7: Allow non-variadic functions to be attributed with `__attribute__((format))` (authored by fcloutier). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 442416. daiyousei-qz marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D124159: [SimplifyCFG] Thread branches on same condition in more cases (PR54980)

nathanchance added a comment. I ended up reducing something down anyways. At the parent commit of dc969061c68e62328607d68215ed8b9ef4a1e4b1 , there is no crash. _Bool fpsimd_context_busy; enum { false, true }

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. Given @rsmith and @iains is busy and this revision is relatively small, innocent and looks good to me, I plan to land this in Friday in case there is no further comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

owenpan updated this revision to Diff 442427. owenpan added a comment. Use `resize()` instead of `insert()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129105/new/ https://reviews.llvm.org/D129105 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index:

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

thieta accepted this revision. thieta added a comment. Thanks for switching to pragma! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152 ___ cfe-commits mailing

  1   2   3   >