[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

dyung added a comment. This change is causing a build failure on the Windows PS4 bot, can you please take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/7026 FAILED: tools/clang/lib/Analysis/FlowSensitive/CMakeFiles/obj.clangAnalysisFlo

[PATCH] D119296: KCFI sanitizer

samitolvanen marked an inline comment as done. samitolvanen added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:63 SanitizerKind::Unreachable | SanitizerKind::Return; -static const SanitizerMask AlwaysRecoverable = -SanitizerKind::KernelAddress | Saniti

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + erichkeane wrote: > royjacobson wrote: > > erichkean

[clang] 63fac42 - Revert "[clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`."

Author: Dmitri Gribenko Date: 2022-07-07T21:50:52+02:00 New Revision: 63fac424e674bbd77f63e2c76cda9ae28552916a URL: https://github.com/llvm/llvm-project/commit/63fac424e674bbd77f63e2c76cda9ae28552916a DIFF: https://github.com/llvm/llvm-project/commit/63fac424e674bbd77f63e2c76cda9ae28552916a.dif

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3636830 , @erichkeane wrote: > SO I've been playing with this for a while and all the libcxx issues. I THINK > we really need to just bit the bullet and figure out how to correctly re-add > things to the instantia

[PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 443035. ckissane added a comment. start breaking this up further, this is now the add cmake config patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: cla

[PATCH] D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS

aaron.ballman added a comment. In D129202#3634646 , @njames93 wrote: > In D129202#3633618 , @aaron.ballman > wrote: > >> Thank you for working on this, I think it's a nice new diagnostic. You >> should add a rel

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5184 - // FIXME: This mimics what GCC implements, but doesn't match up with the - // proposed resolution for core issue 692. This area needs to be sorted out, ychen wrot

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129250/new/ https://reviews.llvm.org/D129250 __

[clang] 81e6400 - [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

Author: Wei Yi Tee Date: 2022-07-07T20:21:19Z New Revision: 81e6400d8c03b74d3d6b1db2cf2746cff5de91d7 URL: https://github.com/llvm/llvm-project/commit/81e6400d8c03b74d3d6b1db2cf2746cff5de91d7 DIFF: https://github.com/llvm/llvm-project/commit/81e6400d8c03b74d3d6b1db2cf2746cff5de91d7.diff LOG: [c

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule &R = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; sammccall wrote: > so the dolla

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

shafik added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5174 std::string &SuggestedPredefines) override { - return checkPreprocessorOptions(ExistingPPOpts, PPOpts, nullptr, FileMgr, + return checkPreprocessorOpti

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. mark outdated comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits

[PATCH] D128816: [OpenMP] Add loop tripcount argument to kernel launch and remove push function

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but rename the function. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.h:890 + /// the int64 value for the number of iterations of the associated loop. + llvm::Va

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:10733-10736 // For enums, get the underlying integer type of the enum, and let the general // integer type signchanging code handle it. if (const auto *ETy = T->getAs()) T = ETy->getDecl()->getI

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 443056. abrahamcd marked 3 inline comments as done. abrahamcd added a comment. Adds argument 0 test case and refactoring based on feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://re

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb accepted this revision. cjdb added a comment. Thanks for working on this! I'll merge this on your behalf once there's maintainer approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added a comment. OK, I think the approach is fine. Comment at: llvm/include/llvm/IR/GlobalIFunc.h:97 + + /// Method to apply specific operation to all resolver-related values. + /// If resolver target is already a global object, then apply the operation to --

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until they're

[PATCH] D128754: [llvm] Remove unused and redundant crc32 funcction from llvm::compression::zlib namespace

MaskRay accepted this revision. MaskRay added a comment. You may push this patch and its prerequisite while other patches are still to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128754/new/ https://reviews.llvm.org/D128754 ___

[PATCH] D128372: [Clang-Tidy] Empty Check

denik accepted this revision. denik added a comment. Thanks Abraham! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay accepted this revision. MaskRay added a comment. Please check both `LLVM_ENABLE_ZSTD={on,off}` work. Ideally, check that when zstd' cmake (`libzstd-dev` on Debian) is unavailable, `LLVM_ENABLE_ZSTD=on` works (there is no zstd functionality but the cmake invocation should succeed). ===

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. Consider adding `have_zstd` to `compiler-rt/test/lit.common.cfg.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ cfe-commits mai

[PATCH] D128927: [libc++] Always build c++experimental.a

mstorsjo added a comment. It looks like the tests would work in CI in the clang-cl configurations with this modification: diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot index 65155ba173ed..407e93ef1575 100755 --- a/libcxx/utils/ci/run-buildbot +++ b/libcxx/utils

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. In D111081#3633908 , @mstorsjo wrote: > LGTM, thanks, and sorry for losing track of it earlier. > > Do you need someone to push the patch for you? In that case, can you provide > your preferred git author line for the patch?

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:892 + return false; if (CAT->getSize().ugt(1)) return false; Similar to SemaChecking below, could use a comment like: FIXME: While the default -fstrict-flex-arrays=0 permit

[clang] 8e21802 - [clang] [MinGW] Fix paths on Gentoo

Author: Mark Harmstone Date: 2022-07-08T00:37:08+03:00 New Revision: 8e218026f8d5eabfdef9141ae5e26aa91d1933e6 URL: https://github.com/llvm/llvm-project/commit/8e218026f8d5eabfdef9141ae5e26aa91d1933e6 DIFF: https://github.com/llvm/llvm-project/commit/8e218026f8d5eabfdef9141ae5e26aa91d1933e6.diff

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e218026f8d5: [clang] [MinGW] Fix paths on Gentoo (authored by maharmstone, committed by mstorsjo). Herald added a project: clang. Repository: rG

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5247-5248 + // ObjC + case tok::at: +return getLangOpts().ObjC; + In Objective-C, both declarations and expressions can start with `@`. In general we'd need to look at the next token t

[PATCH] D129009: [LTO] Fix LTO for aliased IFuncs

MaskRay added inline comments. Comment at: llvm/test/LTO/Resolution/X86/alias-indirect-function-lto.ll:15 + +@foo = ifunc i32 (i32), i32 (i32)* ()* @foo_resolver + Replace all these `xxx*` to `ptr` (opaque pointers). See recent clang's codegen. Repository: rG

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 443070. python3kgae added a comment. Fix test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files: clang/include/clang/Basic/TargetOptions.h clang/inc

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

phosek added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# MaskRay wrote: > How did you derive this? > > The file seems contributed by you (I don't think facebook/zstd has such a > file

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo added a comment. In D129277#3636795 , @aaron.ballman wrote: > In D129277#3636596 , @mstorsjo > wrote: > >> In D129277#3636567 , >> @aaron.ballman wrote: >> >>>

[PATCH] D129277: [clang] [Serialization] Fix swapped PPOpts/ExistingPPOpts parameters. NFC.

mstorsjo updated this revision to Diff 443075. mstorsjo added a comment. Add `/*Diags=*/nullptr` for clarity, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129277/new/ https://reviews.llvm.org/D129277 Files: clang/lib/Serialization

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:202 +return print_diff(old_tree, new_tree) elif opts.diffstat: +return print_diffstat(old_tree, new_tree) Comment at: clang/tools/clang-format/git-

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

This revision was automatically updated to reflect the committed changes. Closed by commit rGc84d29acbfa6: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129105/n

[clang] c84d29a - [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

Author: owenca Date: 2022-07-07T15:33:09-07:00 New Revision: c84d29acbfa671b4a7fb24764cbd4bfa5f6aad5c URL: https://github.com/llvm/llvm-project/commit/c84d29acbfa671b4a7fb24764cbd4bfa5f6aad5c DIFF: https://github.com/llvm/llvm-project/commit/c84d29acbfa671b4a7fb24764cbd4bfa5f6aad5c.diff LOG: [

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers added a comment. Thanks Balazs, you mean something like this correct? void strcpy_no_overflow_2(char *y) { char x[3]; strcpy(x, "12\0"); // this produces a warning, but should not. } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D129222: [pseudo] Implement a guard to determine function declarator.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:114 + const clang::pseudo::Rule &R = G.table().Rules[RID]; + // lhs$$rhs$rhs$rhs + std::string EnumName = symbolName(R.Target, G) + "$"; hokein wrote: > sammccall wr

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers updated this revision to Diff 443101. vabridgers added a comment. a proposal to handle embedded null case caught by @steakhal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/ https://reviews.llvm.org/D129269 Files: clang/lib/

[clang] eee6a12 - [clang-repl][NFC] Split weak symbol test to a new test

Author: Jun Zhang Date: 2022-07-08T09:17:11+08:00 New Revision: eee6a12227a608e4c9aa4d9428d3fe55071f2d64 URL: https://github.com/llvm/llvm-project/commit/eee6a12227a608e4c9aa4d9428d3fe55071f2d64 DIFF: https://github.com/llvm/llvm-project/commit/eee6a12227a608e4c9aa4d9428d3fe55071f2d64.diff LOG

[PATCH] D129250: [clang-repl][NFC] Split weak symbol test to a new test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeee6a12227a6: [clang-repl][NFC] Split weak symbol test to a new test (authored by junaire). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

lamb-j added a comment. @yaxunl Are you recommending I combine all 4 patches down into 1 patch? Or combine a subset of patches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 ___

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jdoerfert added a subscriber: jhuber6. jdoerfert added a comment. Isn't the offload bundler on it's "way out" (=replaced and then deleted soon)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129301/new/ https://reviews.llvm.org/D129301 ___

[PATCH] D129279: [NFC] [Coroutines] Add regression test for heap allocation elision optimization

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129279/new/ https://reviews.llvm.org/D129279

[PATCH] D128328: [C++20][Modules] Improve handing of Private Module Fragment diagnostics.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11155 +def err_export_inline_not_defined : Error< + "exported inline functions must be defined within the module purview" + " and before any private module fragment">;

[PATCH] D129301: [clang-offload-bundler][NFC] Library-ize ClangOffloadBundler (1/4)

jhuber6 added a comment. In D129301#3637642 , @jdoerfert wrote: > Isn't the offload bundler on it's "way out" (=replaced and then deleted soon)? HIP still uses it to create their `fatbinary` format for CUDA-like support for multi-architecture binaries a

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3635207 , @iains wrote: > @rsmith, @ChuanqiXu apologies for the multiple revisions, this has turned out > to be much more involved than I imagined from the standard's text. > > In D126694#3629254

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

vsapsai added a comment. After looking at this change more, I was thinking about changing the title from **how** to **what** you are doing. For example, something like "[AST] Accept identical TypeConstraint referring to other template parameters." You can tweak it as you know better what's goin

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 443123. ChuanqiXu added a comment. Minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/test/Modules/Inputs/redundant-template-default-arg/foo.cppm clang/test/Modules/Inputs/re

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu updated this revision to Diff 443124. ChuanqiXu added a comment. Minor changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/S

[clang] 354a597 - [C++20] [Modules] Don't complain about duplicated default template argument across modules

Author: Chuanqi Xu Date: 2022-07-08T11:10:51+08:00 New Revision: 354a597b9f3aad2a6a37518d47351adb99688cd2 URL: https://github.com/llvm/llvm-project/commit/354a597b9f3aad2a6a37518d47351adb99688cd2 DIFF: https://github.com/llvm/llvm-project/commit/354a597b9f3aad2a6a37518d47351adb99688cd2.diff LO

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu closed this revision. ChuanqiXu added a comment. Committed in https://reviews.llvm.org/rG354a597b9f3aad2a6a37518d47351adb99688cd2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-com

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu added a comment. The direction is approved in https://reviews.llvm.org/D113545. @MaskRay might you help to review the style? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127187/new/ https://reviews.llvm.org/D127187 ___ cfe-commits

[clang] 1934b3a - [docs] Add document "Debugging C++ Coroutines"

Author: Chuanqi Xu Date: 2022-07-08T11:29:00+08:00 New Revision: 1934b3ae59a7869d324bb34218310cae55acb140 URL: https://github.com/llvm/llvm-project/commit/1934b3ae59a7869d324bb34218310cae55acb140 DIFF: https://github.com/llvm/llvm-project/commit/1934b3ae59a7869d324bb34218310cae55acb140.diff LO

[PATCH] D127626: [docs] Add document "Debugging C++ Coroutines"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1934b3ae59a7: [docs] Add document "Debugging C++ Coroutines" (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space for " -"internal needs", -

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu updated this revision to Diff 443141. ChuanqiXu retitled this revision from "[AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter" to "[AST] Accept identical TypeConstraint referring to other template parameters.". Chua

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu added a comment. In D129068#3637716 , @vsapsai wrote: > After looking at this change more, I was thinking about changing the title > from **how** to **what** you are doing. For example, something like "[AST] > Accept identical TypeConstraint r

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6533 + const Expr *YCE = ConceptY->getConstraintExpr(); + assert(XCE && YCE && "ConceptDecl without constraint expression?"); + llvm::FoldingSetNod

[PATCH] D128974: [RFC] [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited

ChuanqiXu updated this revision to Diff 443147. ChuanqiXu retitled this revision from "[AST] [Modules] Handle full cases of DefaultArgStorage::setInherited" to "[RFC] [AST] [Modules] Handle full cases of DefaultArgStorage::setInherited". ChuanqiXu edited the summary of this revision. ChuanqiXu ad

[clang] 8db8754 - [NFC] Move isSameDefaultTemplateArgument into ASTContext

Author: Chuanqi Xu Date: 2022-07-08T14:35:01+08:00 New Revision: 8db87547beb337bee12941f379473f065adeba88 URL: https://github.com/llvm/llvm-project/commit/8db87547beb337bee12941f379473f065adeba88 DIFF: https://github.com/llvm/llvm-project/commit/8db87547beb337bee12941f379473f065adeba88.diff LO

<    1   2