[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

sepavloff created this revision. sepavloff added reviewers: kpn, rjmccall, aaron.ballman. Herald added subscribers: jsji, pengfei. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Previously compilation of a few tests produced incorrect

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. @dblaikie, could you please take a look at this and/or D113741 ? Do you see any ways to proceed? Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8*

[PATCH] D128604: [RISCV] Support Zbpbo extension v0.9.11

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZb.td:471 + Sched<[WriteCMix, ReadCMix, ReadCMix, ReadCMix]>; def FSR : RVBTernaryR<0b10, 0b101, OPC_OP, "fsr", "$rd, $rs1, $rs3, $rs2">, Sched<[WriteFSReg, ReadFSReg, ReadFSReg,

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

jansvoboda11 added a comment. This looks pretty nice. My only concern is the ad-hoc command line parsing. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:55 + getCommandLine(llvm::function_ref< + Expected(const ModuleID &)>

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added a comment. In D95588#3622052 , @sunshaoce wrote: > Hello @Jim! We are developing the P extension, are you still maintaining this > patch? Or would you mind co-development together? Yes, I am still on developing the P extension. But it seems

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

c-rhodes created this revision. c-rhodes added reviewers: paulwalker-arm, bsmith, peterwaller-arm, DavidTruby. Herald added subscribers: psnobl, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. c-rhodes requested review of this revision. Herald

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

c-rhodes updated this revision to Diff 443594. c-rhodes added a comment. Add full patch context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129476/new/ https://reviews.llvm.org/D129476 Files: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_clasta.c

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

serge-sans-paille added a comment. @kees are you ok with current state? Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + //

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd85d9aeef9b: Go-to-type on smart_ptrFoo now also shows Foo (authored by tom-anders, committed by sammccall). Repository: rG LLVM Github Monorepo

[clang] 9f57b65 - [clangd] Include "final" when printing class declaration

Author: Tom Praschan Date: 2022-07-11T12:20:23+02:00 New Revision: 9f57b65a272817752aa00e2fb94154e6eed1d0ec URL: https://github.com/llvm/llvm-project/commit/9f57b65a272817752aa00e2fb94154e6eed1d0ec DIFF: https://github.com/llvm/llvm-project/commit/9f57b65a272817752aa00e2fb94154e6eed1d0ec.diff

[PATCH] D128202: [clangd] Include "final" when printing class declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f57b65a2728: [clangd] Include final when printing class declaration (authored by tom-anders, committed by sammccall). Repository: rG LLVM Github

[clang-tools-extra] cd85d9a - Go-to-type on smart_ptr now also shows Foo

Author: Tom Praschan Date: 2022-07-11T12:13:47+02:00 New Revision: cd85d9aeef9b7e3d6784f5d0be393b463ccc5c5c URL: https://github.com/llvm/llvm-project/commit/cd85d9aeef9b7e3d6784f5d0be393b463ccc5c5c DIFF: https://github.com/llvm/llvm-project/commit/cd85d9aeef9b7e3d6784f5d0be393b463ccc5c5c.diff

[PATCH] D128826: Go-to-type on smart_ptr now also shows Foo

sammccall added a comment. In D128826#3641093 , @tom-anders wrote: > @sammccall I think you can merge this for me now (and also > https://reviews.llvm.org/D128202) Done, sorry for the delay. FWIW I think you should be able to get commit access

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 443654. vaibhav.y added a comment. Discard most likely culprit in test code causing unexpected crash. @aaron.ballman I was unable to reproduce the issue on my end using the buildbot instructions and ASAN, UBSAN. Is it possible for you to trigger a

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Code looks good to me. It's hard to be sure whether it works without running a bunch of hip test cases through it, have you already done so? If it doesn't work out of the

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. In D109701#3642561 , @vaibhav.y wrote: > Discard most likely culprit in test code causing unexpected crash. > > @aaron.ballman I was unable to reproduce the issue on my end using the > buildbot instructions and ASAN,

[clang] 69fcf4f - Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

Author: Vaibhav Yenamandra Date: 2022-07-11T12:18:13-04:00 New Revision: 69fcf4fd5a014b763061f13b5c4434d49c42c35a URL: https://github.com/llvm/llvm-project/commit/69fcf4fd5a014b763061f13b5c4434d49c42c35a DIFF:

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69fcf4fd5a01: Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface (authored by vaibhav.y, committed by aaron.ballman).

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ, Charusso. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3642777 , @iains wrote: > In D126189#3642762 , @JDevlieghere > wrote: > >> This breaks TestDataFormatterLibcxxSpan.py on GreenDragon: >> >> Undefined symbols for

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

ASDenysPetrov added a comment. @manas ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129538: [clang] adds prototype for being able to alternate diagnostic formats

cjdb updated this revision to Diff 443833. cjdb added a comment. `arc diff` no longer seems to autoformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129538/new/ https://reviews.llvm.org/D129538 Files: clang/include/clang/Basic/Diagnostic.h

[PATCH] D129149: [OMPIRBuilder] Add support for simdlen clause

psoni2628 updated this revision to Diff 443622. psoni2628 added a comment. - Rebase, ensuring that build bot failures are gone CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129149/new/ https://reviews.llvm.org/D129149 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

jhuber6 added a comment. In D129435#3642450 , @yaxunl wrote: > need a test There's a test `clang/test/Driver/openmp-offload-gpu-new.c` already making sure that the following works, so this patch should maintain the same functionality we had before.

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

NoQ added a comment. Looks great! Maybe `clang_analyzer_range()` instead? Please add documentation to https://clang.llvm.org/docs/analyzer/developer-docs/DebugChecks.html Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1

[PATCH] D129538: [clang] adds prototype for being able to alternate diagnostic formats

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In an effort to move from unstructured text diagnostics to structured diagnostics, while

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu updated this revision to Diff 443823. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.cpp

[PATCH] D129068: [AST] Accept identical TypeConstraint referring to other template parameters.

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6254 return false; if (TXTC->hasExplicitTemplateArgs() != TYTC->hasExplicitTemplateArgs()) return false; ilya-biryukov

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 443830. kastiglione added a comment. added error handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include/clang/Frontend/FrontendActions.h

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3642820 , @iains wrote: > JFTR, I did not get any notification from green dragon (which is odd, AFAIR > it's sent email before) or I would have looked right away - kicked off a > build will take a look as soon

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. In D109701#3642786 , @vaibhav.y wrote: > In D109701#3642748 , @aaron.ballman > wrote: > >> Unfortunately, it still seems to be causing failures (I had to revert again): >> >>

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm::Attribute::NoProfile);

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

ahatanak created this revision. ahatanak added reviewers: arphaman, benlangmuir. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. This patch teaches `getCursorPlatformAvailabilityForDecl` to look for availability attributes on the

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11 6.7.2.1 §18

[clang] f18de76 - Update DynInit generation for ASan globals.

Author: Mitch Phillips Date: 2022-07-11T12:23:37-07:00 New Revision: f18de7619e5d5dde301d8d4f6f3ec0f8260be710 URL: https://github.com/llvm/llvm-project/commit/f18de7619e5d5dde301d8d4f6f3ec0f8260be710 DIFF:

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129404/new/ https://reviews.llvm.org/D129404

[clang] e88d53d - [HIP] Generate offloading entries for HIP with the new driver.

Author: Joseph Huber Date: 2022-07-11T15:49:21-04:00 New Revision: e88d53d25f3b48204615195615da35e575081903 URL: https://github.com/llvm/llvm-project/commit/e88d53d25f3b48204615195615da35e575081903 DIFF: https://github.com/llvm/llvm-project/commit/e88d53d25f3b48204615195615da35e575081903.diff

[clang] ce091eb - [HIP] Add support for handling HIP in the linker wrapper

Author: Joseph Huber Date: 2022-07-11T15:49:23-04:00 New Revision: ce091eb3b91fc683513f47a565d68cf2799804c9 URL: https://github.com/llvm/llvm-project/commit/ce091eb3b91fc683513f47a565d68cf2799804c9 DIFF: https://github.com/llvm/llvm-project/commit/ce091eb3b91fc683513f47a565d68cf2799804c9.diff

[PATCH] D128850: [HIP] Generate offloading entries for HIP with the new driver.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe88d53d25f3b: [HIP] Generate offloading entries for HIP with the new driver. (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce091eb3b91f: [HIP] Add support for handling HIP in the linker wrapper (authored by jhuber6). Changed prior to commit:

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 443734. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm but be sure that Fuchsia target users get clear release-notes warning about the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

efriedma added a comment. Are you saying that it's faster to use clasta targeting a float register, then move the result to an integer register, rather than use the integer form directly? Or is the issue just that we want to split the operations in case we can simplify the resulting bitcast?

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein updated this revision to Diff 443736. hokein marked 7 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411/new/ https://reviews.llvm.org/D128411 Files:

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson updated this revision to Diff 443742. royjacobson added a comment. Warn on <=C++03 as well, warn on __has_trivial_destructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129170/new/ https://reviews.llvm.org/D129170 Files:

[PATCH] D129170: [Sema] Add deprecation warnings for some compiler provided __has_* type traits

royjacobson added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5400-5401 +SourceLocation KWLoc) { + if (!S.getLangOpts().CPlusPlus11) +return; + aaron.ballman wrote: > royjacobson wrote: > >

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 443749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir updated this revision to Diff 443755. benlangmuir added a comment. Updates per review - Switched to a per-output callback - Removed preserved-args.c test - Removed error handling that I no longer have a real use for - Only request .d and .diag paths if they were enabled in the

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3642992 , @JDevlieghere wrote: > In D126189#3642820 , @iains wrote: > >> JFTR, I did not get any notification from green dragon (which is odd, AFAIR >> it's sent email before)

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(, 1); vitalybuka wrote: > Please check for lifetime markers, I assume case 2 will have a new one > Please check for lifetime markers, I assume case 2

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

ellis added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3894-3896 + if (getCodeGenOpts().getProfileInstr() != CodeGenOptions::ProfileNone) +if (isProfileInstrExcluded(F, SourceLocation())) + F->addFnAttr(llvm::Attribute::NoProfile);

[PATCH] D129413: [InstrProf] Allow compiler generated functions in SCL

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129413/new/ https://reviews.llvm.org/D129413

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

ASDenysPetrov added a comment. Herald added a project: All. @vsavchenko Is this alive? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104647/new/ https://reviews.llvm.org/D104647 ___ cfe-commits mailing

[PATCH] D128672: Update DynInit generation for ASan globals.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-68 - if (FsanitizeArgument.has(SanitizerKind::Address)) { -// TODO(hctim): Make this conditional

[PATCH] D128672: Update DynInit generation for ASan globals.

hctim updated this revision to Diff 443702. hctim marked an inline comment as done. hctim added a comment. Integrate Vitaly's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/ https://reviews.llvm.org/D128672 Files:

[PATCH] D129298: Add denormal-fp-math attribute for f16

arsenm added a comment. In D129298#3638759 , @dcandler wrote: > There are currently no Arm specific changes, this is just being able to more > accurately describe the floating point environment via attributes in the case > where singles and doubles

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. I need to do some more builds to be able to reproduce this - my guess (at present) is that this is a manifestation of '-fcxx-modules -std=c++20' being almost, but not exactly, the same as C++20 standardised modules. It is possible that the -gmodules flag interacts with

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek marked 7 inline comments as done. klimek added inline comments. Comment at: clang/lib/Format/Macros.h:201 + /// Generally, this line tries to have the same structure as the expanded, + /// formatted unwrapped lines handed in via \c addLine(), with the exception + ///

[PATCH] D128709: [clang-format] Handle Verilog attributes

owenpan accepted this revision. owenpan added a comment. Can you mark D128709#3617654 as done? Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1466-1471 + } else if (FormatTok->is(tok::l_paren)) { +const FormatToken

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443731. mizvekov marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files:

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11551-11552 +if (Unqualified && !Ctx.hasSameType(X, Y)) { + assert(Ctx.hasSameUnqualifiedType(X, Y)); + auto XQuals = X.getCVRQualifiers(), YQuals = Y.getCVRQualifiers(); +

[PATCH] D129512: [Driver] Don't use frame pointer on Fuchsia when optimizations are enabled

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. Herald added a project: All. phosek requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This matches the standard behavior on other

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added a comment. Why not adding the assemblyFormat directly for these operations like your patch D105584 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/ https://reviews.llvm.org/D105255

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

yaxunl added a comment. In D128914#3643270 , @jhuber6 wrote: >> There is only one fatbin for -fgpu-rdc mode but the fatbin unregister >> function is called multiple times in each TU. HIP runtime expects each >> fatbin is unregistered only once. The old

[PATCH] D129514: Thread safety analysis: Support builtin pointer-to-member operators

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We consider an access to x.*pm as

[PATCH] D129389: [clang][deps] Override dependency and serialized diag files for modules

benlangmuir marked an inline comment as done. benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:55 + getCommandLine(llvm::function_ref< + Expected(const ModuleID &)> +

[PATCH] D128411: [syntax] Introduce a BaseToken class.

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:370 + TreeBuilder(syntax::Arena ) + : Arena(Arena), STM(cast(Arena.getTokenManager())), +Pending(Arena, STM.tokenBuffer()) { hokein wrote: > sammccall wrote: > >

[PATCH] D128745: [Sema] fix trailing parameter pack handling for function template partial ordering

ychen updated this revision to Diff 443756. ychen added a comment. - handle more cases to implement DR692, DR1395 - tentatively implement DR1432 which DR692 needs, otherwise there would be regressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > MaskRay wrote: > > This needs a change in

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Herald added a project: All. OK, I think we've reached the point where: - the impact is very clear, this solves a whole class of clang-format's biggest problems - the idea clearly works

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3643001 , @iains wrote: > In D126189#3642992 , @JDevlieghere > wrote: > >> In D126189#3642820 , @iains wrote: >> >>> JFTR, I did

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. Herald added a subscriber: steakhal. LGTM Zarko, sorry about taking so long to review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin updated this revision to Diff 443699. cor3ntin added a comment. Fix crash on PowerPC (I forgot to removed a non-sense line that could cause the CurPtr to move incorrectly past a / in the ALTIVEC code path). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

JDevlieghere added a comment. In D126189#3643045 , @iains wrote: > In D126189#3643021 , @JDevlieghere > wrote: > >> In D126189#3643001 , @iains wrote: >> >>> In

[clang] b19d3ee - Revert "[C++20][Modules] Build module static initializers per P1874R1."

Author: Iain Sandoe Date: 2022-07-11T19:50:31+01:00 New Revision: b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf URL: https://github.com/llvm/llvm-project/commit/b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf DIFF: https://github.com/llvm/llvm-project/commit/b19d3ee7120bff4a84db7c9fa8f86c9b6ec3b1cf.diff

[clang] e7c8ded - Revert "[C++20][Modules] Fix two tests for CTORs that return pointers [NFC]."

Author: Iain Sandoe Date: 2022-07-11T19:49:48+01:00 New Revision: e7c8ded6df6d38b019a1de268535d2dd73e7adaf URL: https://github.com/llvm/llvm-project/commit/e7c8ded6df6d38b019a1de268535d2dd73e7adaf DIFF: https://github.com/llvm/llvm-project/commit/e7c8ded6df6d38b019a1de268535d2dd73e7adaf.diff

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. Thanks for the patch. Please add the full context for the next revision: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 443726. sridhar_gopinath added a comment. Replaced subprocess.check_call with subprocess.call since the former crashes when the return code is not zero. + formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. As I mentioned, the proper approach is to add zstd functionality along with the CMake change, instead of adding CMake to all llvm-project components without a way to test them. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib =

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added a comment. In D126189#3643021 , @JDevlieghere wrote: > In D126189#3643001 , @iains wrote: > >> In D126189#3642992 , @JDevlieghere >> wrote: >> >>> In

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added a comment. The review shows the diff with the previous iteration of the patch. Can you generate a diff with the current top-of-tree? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/ https://reviews.llvm.org/D129377

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

kees added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:906 // member, only a T[0] or T[] member gets that treatment. + // Under StrictFlexArraysLevel, obey c99+ that disallows FAM in union, see + // C11 6.7.2.1 §18 jyknight wrote:

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo updated this revision to Diff 443708. abidmalikwaterloo added a comment. Update ops.mlir test cases. llvm-lit is working and all tests are passing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105255/new/

[PATCH] D128914: [HIP] Add support for handling HIP in the linker wrapper

jhuber6 added a comment. In D128914#3642869 , @yaxunl wrote: > In D128914#3642567 , @jhuber6 wrote: > >> In D128914#3642558 , >> @JonChesterfield wrote: >> >>> Code

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein updated this revision to Diff 443737. hokein added a comment. more update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128411/new/ https://reviews.llvm.org/D128411 Files: clang/include/clang/Tooling/Syntax/Mutations.h

[PATCH] D128411: [syntax] Introduce a BaseToken class.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/SyntaxTokenManager.h:20 +/// It tracks the underlying token buffers, source manager, etc. +class SyntaxTokenManager : public TokenManager { +public: sammccall wrote: > I don't think

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

clementval added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:449 ParentOneOf<["WsLoopOp", "ReductionDeclareOp", - "AtomicUpdateOp", "SimdLoopOp"]>]> { + "AtomicUpdateOp", "SimdLoopOp","DistributeOp"]>]> { let summary = "loop yield

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

rnk added subscribers: arphaman, dexonsmith. rnk added a comment. Seeking additional opinions on the PCH change: @dexonsmith @arphaman The use case makes sense to me. It seems reasonable to me that the compiler shouldn't use the same PCH file with mismatched defines on the command line.

[PATCH] D129492: Add missing sanitizer metadata plumbing from CFE.

hctim created this revision. hctim added a reviewer: eugenis. Herald added a project: All. hctim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang misses attaching sanitizer metadata for external globals. Repository: rG LLVM Github

[PATCH] D129269: [analyzer] Fix use of length in CStringChecker

vabridgers updated this revision to Diff 443658. vabridgers edited the summary of this revision. vabridgers added a comment. update per comments from @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129269/new/

Re: [clang] c8a28ae - Revert "Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface"

On Mon, Jul 11, 2022 at 12:28 PM Aaron Ballman via cfe-commits wrote: > > > Author: Aaron Ballman > Date: 2022-07-11T12:28:31-04:00 > New Revision: c8a28ae214c08c8447a4eb42418585b2b3eef6fb > > URL: > https://github.com/llvm/llvm-project/commit/c8a28ae214c08c8447a4eb42418585b2b3eef6fb > DIFF: >

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Need to update RISCVTargetLowering::decomposeMulByConstant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313

[PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione added a reviewer: Michael137. kastiglione added inline comments. Comment at: lldb/test/API/commands/target/dump-pcm-info/TestDumpPCMInfo.py:37 + +breakpoint() +self.expect( mib wrote: > Left over ? yep thanks! Repository: rG LLVM

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3853 +/// objcMessageExpr(objcMessageCallee(objcMethodDecl(hasName("foo" +AST_MATCHER_P(ObjCMessageExpr, objcMessageCallee, + internal::Matcher, InnerMatcher) {

[PATCH] D128672: Update DynInit generation for ASan globals.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf18de7619e5d: Update DynInit generation for ASan globals. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128672/new/

[clang] 359e4a8 - [Clang] Parse toolchain-specific offloading arguments directly

Author: Joseph Huber Date: 2022-07-11T15:37:50-04:00 New Revision: 359e4a8247316c2f0c21072919836fd9fd4cf0f1 URL: https://github.com/llvm/llvm-project/commit/359e4a8247316c2f0c21072919836fd9fd4cf0f1 DIFF: https://github.com/llvm/llvm-project/commit/359e4a8247316c2f0c21072919836fd9fd4cf0f1.diff

[PATCH] D129435: [Clang] Parse toolchain-specific offloading arguments directly

This revision was automatically updated to reflect the committed changes. Closed by commit rG359e4a824731: [Clang] Parse toolchain-specific offloading arguments directly (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128712: [clang-format] Handle Verilog modules

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4040 +void UnwrappedLineParser::parseVerilogSensitivityList() { + if (!FormatTok->is(tok::at)) +return; I prefer to make such checks before calling the function.

  1   2   >