Re: [clang] ee88c0c - [NFCI] Fix unused variable/function warnings in MacroCallReconstructorTest.cpp when asserts are disabled.

This is a functional change, as it removes the debug output when the tokens do not match, which is important for understanding test failures. On Wed, Jul 13, 2022 at 1:47 AM Jorge Gorbe Moya via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Jorge Gorbe Moya > Date:

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } Can we use `path::parent_path(P)` directly in `addSystemInclude()`? `remove_filename()` sounds

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

sammccall added a comment. Sorry, didn't realize this was waiting on me! I like the feature and the threshold seems like a good idea. People might find it inconsistent, but we'll have to see. I like placing it after the macro definition, I think the cases where expansion is/isn't shown feel

[PATCH] D129562: [SystemZ] Enable `-mtune=` option in clang.

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129562/new/ https://reviews.llvm.org/D129562

[PATCH] D129476: [AArch64][SVE] Prefer SIMD variant of clast[ab]

c-rhodes closed this revision. c-rhodes marked an inline comment as done. c-rhodes added a comment. In D129476#3645667 , @efriedma wrote: > Please update the comment, then LGTM Done, cheers Eli. CHANGES SINCE LAST ACTION

[clang] 7c3cda5 - [AArch64][SVE] Prefer SIMD variant of clast[ab]

Author: Cullen Rhodes Date: 2022-07-13T08:53:36Z New Revision: 7c3cda551ac702de4eb8899180aa715896020d43 URL: https://github.com/llvm/llvm-project/commit/7c3cda551ac702de4eb8899180aa715896020d43 DIFF: https://github.com/llvm/llvm-project/commit/7c3cda551ac702de4eb8899180aa715896020d43.diff

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 444188. kito-cheng added a comment. Changes: - Correct filename for testcases. - Use forward declaration for llvm::raw_ostream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

nikic added a comment. FYI this change had a noticeable compile-time impact (http://llvm-compile-time-tracker.com/compare.php?from=ee88c0cf09969ba44307068797e12533b94768a6=bdc6974f92304f4ed542241b9b89ba58ba6b20aa=instructions), is that expected? Largest regressions are in kimwitu++, where

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/ppc-emmintrin.c:631 // CHECK: %[[ADDR:[0-9a-zA-Z_.]+]] = load double*, double** %{{[0-9a-zA-Z_.]+}}, align 8 -// CHECK: %[[VAL:[0-9a-zA-Z_.]+]] = load double, double* %[[ADDR]], align 8 +// CHECK:

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4892a168f51: [Clang] Add a warning on invalid UTF-8 in comments. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] d4892a1 - [Clang] Add a warning on invalid UTF-8 in comments.

Author: Corentin Jabot Date: 2022-07-13T10:19:26+02:00 New Revision: d4892a168f51dabdba255af3a8d23049fcb66960 URL: https://github.com/llvm/llvm-project/commit/d4892a168f51dabdba255af3a8d23049fcb66960 DIFF:

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 444182. qiucf added a comment. Herald added a subscriber: ormris. Merge conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files:

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 444175. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

balazske updated this revision to Diff 444165. balazske marked 3 inline comments as done. balazske added a comment. Added comments, removed unneeded AST matcher code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129353/new/

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov added a comment. In D129498#3644222 , @NoQ wrote: > Looks great! > > Maybe `clang_analyzer_range()` instead? This was its first name. I refused. First, because it emits concrete integers as well and moreover we can extend it for arrays or

<    1   2   3