[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

njames93 added a comment. In D129953#3657925 , @zhouyizhou wrote: > In D129953#3657920 , @njames93 > wrote: > >> While you're here could you also put full stops( or periods ) at the end of >> the sentences. >

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. While you're here could you also put full stops( or periods ) at the end of the sentences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

zhouyizhou added a comment. In D129953#3657920 , @njames93 wrote: > While you're here could you also put full stops( or periods ) at the end of > the sentences. Thank Nathan for reviewing my patch I am here, and am very happy to make further

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb added a comment. Looking at the output from Clang 14 , I'm observing that a binary with 178 function templates is 13% the size of the one with 89 function objects. When only one function object is used vs all 178 function templates, the functions still win

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

curdeius added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:820-833 + ASSERT_EQ(BaseTokens.size(), NumberOfBaseTokens) << BaseTokens; + ASSERT_EQ(ConstrainedTokens.size(), +NumberOfBaseTokens + NumberOfAdditionalRequiresClauseTokens) +

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

nridge added a comment. nit: typo in commit message ("hedaer") Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129642/new/ https://reviews.llvm.org/D129642 ___ cfe-commits mailing list

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

asb added a comment. In D129802#3653544 , @efriedma wrote: > If we do decide we need to do something here, I'd prefer to model this using > explicit fences in the IR, as opposed to a new atomic ordering. Adding extra > atomic orderings just makes

[PATCH] D129953: [PATCH] [clang-tidy] NFC: add preposition "of" to code annotation of ElseAfterReturnCheck

nridge added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:266 if (IsLastInScope) { - // If the if statement is the last statement its enclosing statements + // If the if statement is the last statement of its

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

curdeius accepted this revision. curdeius added a comment. Ok for me if it's OK for Owen. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:820-833 + ASSERT_EQ(BaseTokens.size(), NumberOfBaseTokens) << BaseTokens; + ASSERT_EQ(ConstrainedTokens.size(), +

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:820-833 + ASSERT_EQ(BaseTokens.size(), NumberOfBaseTokens) << BaseTokens; + ASSERT_EQ(ConstrainedTokens.size(), +NumberOfBaseTokens +

[PATCH] D129946: [clang-format] Mark constexpr lambdas as lambda

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2130 case tok::kw_noexcept: +case tok::kw_constexpr: nextToken(); owenpan wrote: > Maybe move it up so that it's grouped with `kw_const`? Will do

[PATCH] D129926: [clang-format] Handle constructor invocations after new operator in C# correct

curdeius accepted this revision. curdeius added a comment. LGTM. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2864 do { + // Handle constructor invocation + if (FormatTok->is(tok::l_paren)) Nit: comments should be full phrases, ending

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

kimgr added a comment. In D112374#3657640 , @mizvekov wrote: > In D112374#3657472 , @kimgr wrote: > >> I'm coming at this from pretty far away, so there's very likely lots of >> details that I'm overlooking. But

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

nikic added a comment. Hm, might it be better to teach LLVM about this (in some ConstantRange/KnownBits logic)? This doesn't really seem like something the frontend should know about and encode, as that means each frontend has to add this annotation by itself. Repository: rG LLVM Github

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3658059 , @kimgr wrote: > Haha. Pun intended? :-) Yes :-) > As you noticed, it's not our tests that care about the AST, it's the tool > itself. IWYU has been around since 2010-11, so there's probably lots of code

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 445319. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files:

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

craig.topper accepted this revision. craig.topper added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:80 +{"zmmul", RISCVExtensionVersion{0, 1}}, + If it is ratified, is the version really

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9438 // FIXME: Pass in the explicit template arguments? ArgumentDependentLookup(Name, Loc, Args, Fns); rsmith wrote: > It would seem preferable to me to do the filtering in >

[PATCH] D129971: [clangd][WIP] Add doxygen parsing for Hover

tom-anders abandoned this revision. tom-anders added a comment. Sorry, meant to make this a draft Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129971/new/ https://reviews.llvm.org/D129971 ___

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

SimplyDanny created this revision. Herald added subscribers: usaxena95, kadircet. Herald added a project: All. SimplyDanny requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Without the "found declaration" it

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/TypeLocBuilder.cpp:159 - assert(Capacity - Index == TypeLoc::getFullDataSizeForType(T) && + unsigned FDSz = TypeLoc::getFullDataSizeForType(T); + assert(Capacity - Index ==

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

ychen added a comment. In D129954#3658139 , @nikic wrote: > Hm, might it be better to teach LLVM about this (in some > ConstantRange/KnownBits logic)? This doesn't really seem like something the > frontend should know about and encode, as that means

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:3-4 + +while(1) {}; // expected-error {{expected identifier or '('}} \ + // expected-note {{while loop outside of functions}} + How about just making the

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

cjdb added a comment. In D129951#3657923 , @cjdb wrote: > ~~Looking at the output from Clang 14 , I'm > observing that a binary with 178 function templates is 13% the size of the > one with 89 function objects. When

[PATCH] D129951: [clang] teaches Clang the special ADL rules for functions in std::ranges

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9438 // FIXME: Pass in the explicit template arguments? ArgumentDependentLookup(Name, Loc, Args, Fns); It would seem preferable to me to do the filtering in

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx updated this revision to Diff 445332. ksyx added a comment. Rebase and update use of M extension existence check to include Zmmul whenever needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files:

[PATCH] D129971: [clangd][WIP] Add doxygen parsing for Hover

tom-anders created this revision. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, MaskRay, ilya-biryukov. Herald added projects: LLVM, clang-tools-extra.

[clang] 8b3ed1f - Remove redundant return statements (NFC)

Author: Kazu Hirata Date: 2022-07-17T15:37:46-07:00 New Revision: 8b3ed1fa984b07c88f218d0ddc6b3e2c0629a9fa URL: https://github.com/llvm/llvm-project/commit/8b3ed1fa984b07c88f218d0ddc6b3e2c0629a9fa DIFF: https://github.com/llvm/llvm-project/commit/8b3ed1fa984b07c88f218d0ddc6b3e2c0629a9fa.diff

[clang] 8dfdb80 - Ensure newlines at the end of files (NFC)

Author: Kazu Hirata Date: 2022-07-17T15:37:45-07:00 New Revision: 8dfdb80f72c080585517f10862b3b08d745b9155 URL: https://github.com/llvm/llvm-project/commit/8dfdb80f72c080585517f10862b3b08d745b9155 DIFF: https://github.com/llvm/llvm-project/commit/8dfdb80f72c080585517f10862b3b08d745b9155.diff

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 445365. mizvekov marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files:

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

inclyc added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:3-4 + +while(1) {}; // expected-error {{expected identifier or '('}} \ + // expected-note {{while loop outside of functions}} + mizvekov wrote: > How about just

[PATCH] D129573: [Clang] add a diagnostic note 'while loop outside functions' at global scope

mizvekov added inline comments. Comment at: clang/test/Parser/while-loop-outside-function.c:3-4 + +while(1) {}; // expected-error {{expected identifier or '('}} \ + // expected-note {{while loop outside of functions}} + inclyc wrote: > mizvekov

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 445369. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128095/new/ https://reviews.llvm.org/D128095 Files: clang/include/clang/Sema/Sema.h

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 445350. royjacobson marked an inline comment as not done. royjacobson added a comment. Add a test case with more subsumption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:820-833 + ASSERT_EQ(BaseTokens.size(), NumberOfBaseTokens) << BaseTokens; + ASSERT_EQ(ConstrainedTokens.size(), +NumberOfBaseTokens +

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 445358. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:11578 + default: +return X; + } rsmith wrote: > mizvekov wrote: > > rsmith wrote: > > > For `TemplateArgument::ArgKind::Declaration`, I think it'd make sense to > > > take the common

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 445368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

h-vetinari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:494-497 +- Implemented "Conditionally Trivial Special Member Functions" (`P0848 `_). + Note: The handling of deleted functions is not yet compliant, as Clang + does not

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 445364. mizvekov marked 9 inline comments as done. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/

[PATCH] D128276: clang: perform deduction at the right depth on Sema::AddMethodTemplateCandidate

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 445370. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128276/new/ https://reviews.llvm.org/D128276 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. In D129748#3654918 , @aaron.ballman wrote: > For example, I would be IBOutletCollection, OwnerAttr, PointerAttr, and > TypeTagForDatatypeAttr all behave the same way as they all take a type > argument. I don't think we want

[PATCH] D129982: [clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D129940: [clang-format] Fix misannotation of colon in presence of requires clause

owenpan added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:820-833 + ASSERT_EQ(BaseTokens.size(), NumberOfBaseTokens) << BaseTokens; + ASSERT_EQ(ConstrainedTokens.size(), +NumberOfBaseTokens + NumberOfAdditionalRequiresClauseTokens) +

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org