[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3281138aad80: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X` (authored by gribozavr). Repository: rG LLVM Github Monorepo

[clang] 3281138 - [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

Author: Dmitri Gribenko Date: 2022-07-26T10:26:44+02:00 New Revision: 3281138aad80fcefc7f266c7e3b2e359d5dbc8da URL: https://github.com/llvm/llvm-project/commit/3281138aad80fcefc7f266c7e3b2e359d5dbc8da DIFF:

[PATCH] D128837: [analyzer] Structured binding to tuple-like types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa618d5e0dd5d: [analyzer] Structured binding to tuple-like types (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG

[clang] a618d5e - [analyzer] Structured binding to tuple-like types

Author: isuckatcs Date: 2022-07-26T10:24:29+02:00 New Revision: a618d5e0dd5d6fee5d73e823dbf8301663be0b4f URL: https://github.com/llvm/llvm-project/commit/a618d5e0dd5d6fee5d73e823dbf8301663be0b4f DIFF: https://github.com/llvm/llvm-project/commit/a618d5e0dd5d6fee5d73e823dbf8301663be0b4f.diff

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

gribozavr updated this revision to Diff 447609. gribozavr added a comment. Actually visit a subexpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130522/new/ https://reviews.llvm.org/D130522 Files:

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. AutoUpgrade is added due to similar issue at a user. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126745/new/ https://reviews.llvm.org/D126745

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126748/new/ https://reviews.llvm.org/D126748

[PATCH] D126750: [RISCV][Clang] Support policy function for all vector segment load.

nlopes added a comment. While at it, could you switch those UndefValue with PoisonValue if possible? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126750/new/ https://reviews.llvm.org/D126750

[PATCH] D126750: [RISCV][Clang] Support policy function for all vector segment load.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126748: [RISCV][Clang] Support policy functions for Vector Reduction Instructions.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126744: [RISCV][Clang] Support policy functions for vneg, vnot, vncvt, vwcvt, vwcvtu, vfabs and vfneg.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, and verified with internal testsuite :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126744/new/

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kito-cheng marked an inline comment as done. Closed by commit rG7a5cb15ea6fa: [RISCV]

[clang] 7a5cb15 - [RISCV] Lazily add RVV C intrinsics.

Author: Kito Cheng Date: 2022-07-26T15:47:47+08:00 New Revision: 7a5cb15ea6facd82756adafae76d60f36a0b60fd URL: https://github.com/llvm/llvm-project/commit/7a5cb15ea6facd82756adafae76d60f36a0b60fd DIFF: https://github.com/llvm/llvm-project/commit/7a5cb15ea6facd82756adafae76d60f36a0b60fd.diff

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:40-41 // Synthetic boolean values are either atomic values or composites that // represent conjunctions, disjunctions, and negations.

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

Ericson2314 created this revision. Ericson2314 added reviewers: beanz, sebastian-ne, mstorsjo. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't need to

[PATCH] D129967: [analyzer] Lambda capture non-POD type array

This revision was automatically updated to reflect the committed changes. Closed by commit rG996b092c5e17: [analyzer] Lambda capture non-POD type array (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 996b092 - [analyzer] Lambda capture non-POD type array

Author: isuckatcs Date: 2022-07-26T09:40:25+02:00 New Revision: 996b092c5e170786572e925345e502e5376feaee URL: https://github.com/llvm/llvm-project/commit/996b092c5e170786572e925345e502e5376feaee DIFF: https://github.com/llvm/llvm-project/commit/996b092c5e170786572e925345e502e5376feaee.diff

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng marked 9 inline comments as done. kito-cheng added a comment. @aaron.ballman thanks for your review! Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:400 + // Number of fields, greater than 1 if it's segment load/store. + uint8_t NF; +};

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added a comment. @ChuanqiXu , the release notes were updated. Could you check and merge please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119792/new/ https://reviews.llvm.org/D119792

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D129496: [analyzer] ArrayInitLoopExpr with array of non-POD type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a13326d184c: [analyzer] ArrayInitLoopExpr with array of non-POD type (authored by isuckatcs). Herald added a project: clang. Herald added a

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[clang] 8a13326 - [analyzer] ArrayInitLoopExpr with array of non-POD type

Author: isuckatcs Date: 2022-07-26T09:07:22+02:00 New Revision: 8a13326d184c2829a51d7c00f467ded06412f858 URL: https://github.com/llvm/llvm-project/commit/8a13326d184c2829a51d7c00f467ded06412f858 DIFF: https://github.com/llvm/llvm-project/commit/8a13326d184c2829a51d7c00f467ded06412f858.diff

[PATCH] D130551: [pseudo] Allow opaque nodes to represent terminals

sammccall created this revision. sammccall added reviewers: hokein, usaxena95. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This allows incomplete code such as `namespace

[PATCH] D130550: [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Previously we were calling glrRecover() ad-hoc at the end

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:273 + +// Visit a sub-value of `Val` (pick any, they are identical). + } else { Let's visit `C->getLeftSubValue()`

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if

[PATCH] D130411: [clang-format] Fix a hang when formatting C# $@ string literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffb3dd33ee1: [clang-format] Fix a hang when formatting C# $@ string literals (authored by owenpan). Changed prior to commit:

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

rusyaev-roman added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

[PATCH] D130331: [C++20] [Modules] Disable preferred_name when writing a C++20 Module interface

ChuanqiXu added a comment. Sorry for the frequent ping since 15.x is going to be branched. @aaron.ballman @tahonermann I know this might not look good to you. But I want to ask if there is any objection? Personally, the preferred_name attribute is not so important and it blocks something

[clang] 0ffb3dd - [clang-format] Fix a hang when formatting C# $@ string literals

Author: owenca Date: 2022-07-25T23:17:54-07:00 New Revision: 0ffb3dd33ee1a50a6ab5db80bb8caee9133e66dc URL: https://github.com/llvm/llvm-project/commit/0ffb3dd33ee1a50a6ab5db80bb8caee9133e66dc DIFF: https://github.com/llvm/llvm-project/commit/0ffb3dd33ee1a50a6ab5db80bb8caee9133e66dc.diff LOG:

[PATCH] D130514: [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0df7d8bc355d: [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build (authored by abrachet). Herald added a project: clang. Herald added

[clang] 0df7d8b - [CMake][Fuchsia] Enable assertions and backtraces in stage 1 build

Author: Alex Brachet Date: 2022-07-26T06:09:38Z New Revision: 0df7d8bc355dd506bb1a330b9f73e611f0deaf9f URL: https://github.com/llvm/llvm-project/commit/0df7d8bc355dd506bb1a330b9f73e611f0deaf9f DIFF: https://github.com/llvm/llvm-project/commit/0df7d8bc355dd506bb1a330b9f73e611f0deaf9f.diff LOG:

[clang-tools-extra] 3f3930a - Remove redundaunt virtual specifiers (NFC)

Author: Kazu Hirata Date: 2022-07-25T23:00:59-07:00 New Revision: 3f3930a451e118e82885a6dd20e3918427b816c2 URL: https://github.com/llvm/llvm-project/commit/3f3930a451e118e82885a6dd20e3918427b816c2 DIFF: https://github.com/llvm/llvm-project/commit/3f3930a451e118e82885a6dd20e3918427b816c2.diff

[clang] ae002f8 - Use isa instead of dyn_cast (NFC)

Author: Kazu Hirata Date: 2022-07-25T23:00:58-07:00 New Revision: ae002f8bca11bf652fa4d2683c8a627fa77158a8 URL: https://github.com/llvm/llvm-project/commit/ae002f8bca11bf652fa4d2683c8a627fa77158a8 DIFF: https://github.com/llvm/llvm-project/commit/ae002f8bca11bf652fa4d2683c8a627fa77158a8.diff

[PATCH] D119792: [Clang] [P2025] Analyze only potential scopes for NRVO

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/Scope.cpp:152-154 + // Consider the variable as NRVO candidate if the return slot is available + // for it in the current scope, or if it can be available in outer scopes. + NRVO = CanBePutInReturnSlot ? VD :

<    1   2   3