[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp added a comment. @njames93 Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126880/new/ https://reviews.llvm.org/D126880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D127812: [AArch64] Function multiversioning support added.

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:188 +AARCH64_CPU_FEATURE("sve_aes",SVE_AES, "+sve2-aes", 330) +AARCH64_CPU_FEATURE("sve_pmull128", SVE_PMULL128, "", 340) +AARCH64_CPU_FEATURE("sve_bitperm",

[clang] 7042417 - [NFC][clang] Bring `and_present` and `if_present` casting functions to clang namespace

Author: Nathan James Date: 2022-08-08T08:38:50+01:00 New Revision: 7042417ef11ce34300908c53ee9659bf8f2ab9ec URL: https://github.com/llvm/llvm-project/commit/7042417ef11ce34300908c53ee9659bf8f2ab9ec DIFF: https://github.com/llvm/llvm-project/commit/7042417ef11ce34300908c53ee9659bf8f2ab9ec.diff

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

balazske updated this revision to Diff 450716. balazske added a comment. Removed one unreachable, added new tests, improvement of `TagDecl` check, re-arranged source code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/ https://reviews.l

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch updated this revision to Diff 450717. t-8ch marked 5 inline comments as done. t-8ch added a comment. Implement stylistic change requested by reviewers and add better description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131067/new/ https

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. It gets very confusing that phab now attaches the old review comments in the wrong place. Comment at: clang/docs/CPlusPlus20Modules.rst:22 +different semantics, it might be more friendly for users who care about C++20 +modules only to create a new p

[PATCH] D131067: [analyzer] Treat values passed as parameter as escaped

t-8ch added a comment. @steakhal Thanks for your review! I think I have addressed all your points. In D131067#3702044 , @steakhal wrote: > Please, consider stating the motivation behind this change. This is now added. > For me, by looking at the modifi

[PATCH] D131134: [X86] Report error if the amx enabled on the non-64-bits target

LiuChen3 updated this revision to Diff 450724. LiuChen3 added a comment. change the error report Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131134/new/ https://reviews.llvm.org/D131134 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu marked 8 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:316-317 + +Currently Clang would accept the above example. But it may produce surprising results if the +debugging code depends on consistent use of ``NDEBU

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 450731. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131062/new/ https://reviews.llvm.org/D131062 Files: clang/docs/CPlusPlus20Modules.rst clang/docs/in

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a comment. In D131062#3705767 , @h-vetinari wrote: > It gets very confusing that phab now attaches the old review comments in the > wrong place. Yeah, I am also worrying if the comments may block other reviewers to review. Do you know

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. In D131062#3705864 , @ChuanqiXu wrote: > Yeah, I am also worrying if the comments may block other reviewers to review. > Do you know any method to ignore these comments in phab? If not, I guess I > need to create a new page (

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. If you do open a new revision, please also consider breaking the lines at a length that phabricator doesn't overflow (seems to be 122 characters), and change all occurrences of "codes" to "code". Comment at: clang/docs/CPlusPlus20Modules.rst:676-67

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang modules for header units is that +we've see some differences between header units and Clang modules and we think the differe

[PATCH] D131385: [clangd] Support for standard type hierarchy

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is most

[PATCH] D126745: [RISCV][Clang] Support policy functions for vmerge, vfmerge and vcompress.

nlopes added a comment. In D126745#3693790 , @khchen wrote: > @nlopes we will update all undef to poison in follow up patches. Thank you! The benefit is that we want to remove undef altogether, so I'm trying to avoid having more undefs introduced, and i

[PATCH] D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`

njames93 created this revision. njames93 added reviewers: aaron.ballman, JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Adds a

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang modules for header units is that +we've see some differences between header units and Clang modules and we think the differ

[PATCH] D131062: [docs] Add "C++20 Modules"

iains added a comment. @h-vetinari you are right, this has become difficult to review - I will try and do some more later - just the one comment for now. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang mo

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang modules for header units is that +we've see some differences between header units and Clang modules and we think the differe

[PATCH] D131388: [docs] Add "C++20 Modules"

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, urnathan, erichkeane, aaron.ballman, tahonermann, ilya-biryukov, Mordante, tschuett, philnik, cpplearner, h-vetinari. ChuanqiXu added projects: clang-modules, clang-language-wg, clang. Herald added a subscriber: arphaman. Herald ad

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Let's review it in https://reviews.llvm.org/D131388 later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131062/new/ https://reviews.llvm.org/D131062 ___ cfe-commits mailing list

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

ivanmurashko updated this revision to Diff 450750. ivanmurashko added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.llvm.org/D130847 Files: clang/lib/Basic/SourceManager.cpp Index: clang/lib/Basic/

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added a comment. thanks, i think we should change the behaviour to not fold the last line in any case. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:943 Callback> Reply) { - Server->foldingRanges(Params.textDocument.uri.file(), std::move(Reply)); + S

[PATCH] D131388: [docs] Add "C++20 Modules"

h-vetinari added a comment. Thanks! Repeating a point that might have been overlooked from D131062 (this time not as comments in the diff to avoid the "pollution" that caused the move to this PR): > If you do open a new revision, please also consider breaking

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:64-67 +Terms enclosed in ``[]`` are optional. The syntax of ``module_name`` and ``partition_name`` +in regex form corresponds to ``[a-zA-Z_][a-zA-Z_0-9\.]*``. The dot ``.`` in the name has +no speci

[PATCH] D131388: [docs] Add "C++20 Modules"

iains added a comment. general comment. Do we encourage contractions (don't, can't) etc. in documentation? I would suggest that to assist in any translation process it is better to write "do not" or "can not" instead (but that's just an opinion, not a matter of correctness).

[PATCH] D131388: [docs] Add "C++20 Modules"

iains added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:673-674 + +Another reason is that there are proposals to introduce module mappers to the C++ standard (for example, https://wg21.link/p1184r2). +If we decide to reuse Clang's modulemap, we may get in trou

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

john.brawn added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) +LIBBUILTIN(r

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I assume you'll be removing the macro definition from Compiler.h once all the projects have been updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131390: [clang-tidy] Fix a regression of readability-container-size-empty after the AST ElaboratedType change.

hokein created this revision. hokein added reviewers: aaron.ballman, ymandel. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. With 15f3cd6bfc670ba6106184a903eb04be059e5977

[PATCH] D131390: [clang-tidy] Fix a regression of readability-container-size-empty after the AST ElaboratedType change.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! It makes me a little sad that `QualType` has both `isIntegerType` and `isIntegralType`. Nice spotting that difference! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D130689: [LLVM] Update C++ standard to 17

cor3ntin added a comment. In D130689#3706135 , @aaron.ballman wrote: > In D130689#3705131 , @royjacobson > wrote: > >> This seems to have been more disruptive than expected, since an existing >> CMakeCache.txt

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706199 , @cor3ntin wrote: > Trying to read the logs,, notably > `C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe > `, it would seem that this particular bot is running a version much

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

abidh added a comment. I think this patch is moving the things in the right direction. But please wait for some other reviewers to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131225/new/ https://reviews.llvm.org/D131225 __

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

nemanjai added a comment. Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is very clear and obvious. What do we gain by getting rid of it? Don't get me wrong, I am not super opposed to using a standard string instead of an LLVM-specific macro. However, it seems that th

[clang] 99a5a02 - [ASTMatchers] Replace hand-coded copy of std::apply with the real C++17 function. NFCI

Author: Benjamin Kramer Date: 2022-08-08T14:08:04+02:00 New Revision: 99a5a029e66643364c87d3945fb6990e943915dc URL: https://github.com/llvm/llvm-project/commit/99a5a029e66643364c87d3945fb6990e943915dc DIFF: https://github.com/llvm/llvm-project/commit/99a5a029e66643364c87d3945fb6990e943915dc.dif

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

aaron.ballman added a comment. In D131346#3706216 , @nemanjai wrote: > Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is > very clear and obvious. What do we gain by getting rid of it? Less novel macro usage helps readability

[PATCH] D131258: [Sema] Merge variable template specializations

ilya-biryukov updated this revision to Diff 450770. ilya-biryukov added a comment. - Add the forgotten `-fmodules-local-submodule-visibility` flag to the test - Add newlines to the test files - Switch to C++14 mode for tests, they don't use C++17. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D131258: [Sema] Merge variable template specializations

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. In D131258#3705503 , @ChuanqiXu wrote: > When I run this locally, it emits several unexpected errors: Sorry, my bad. I was testing this with `-std=c++20` and later switched to

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

barannikov88 added a comment. In D131225#3706207 , @abidh wrote: > I think this patch is moving the things in the right direction. But please > wait for some other reviewers to chime in. It seems quite opposite to me. Comment at: cla

[PATCH] D131274: [clang][Darwin] Re-apply "Always set the default C++ Standard Library to libc++"

ldionne updated this revision to Diff 450771. ldionne added a comment. Herald added a reviewer: JDevlieghere. Fix additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131274/new/ https://reviews.llvm.org/D131274 Files: clang/lib/Drive

[clang-tools-extra] 7dc410c - [clang-tidy] Fix a regression of readability-container-size-empty after the AST ElaboratedType change.

Author: Haojian Wu Date: 2022-08-08T14:40:36+02:00 New Revision: 7dc410cbff28270fcfcf7f2dd80f57ead7ab7d18 URL: https://github.com/llvm/llvm-project/commit/7dc410cbff28270fcfcf7f2dd80f57ead7ab7d18 DIFF: https://github.com/llvm/llvm-project/commit/7dc410cbff28270fcfcf7f2dd80f57ead7ab7d18.diff LO

[PATCH] D131390: [clang-tidy] Fix a regression of readability-container-size-empty after the AST ElaboratedType change.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dc410cbff28: [clang-tidy] Fix a regression of readability-container-size-empty after the AST… (authored by hokein). Repository: rG LLVM Github Mo

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706200 , @thieta wrote: > In D130689#3706199 , @cor3ntin > wrote: > >> Trying to read the logs,, notably >> `C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.301

[PATCH] D130689: [LLVM] Update C++ standard to 17

barannikov88 added a comment. In D130689#3706263 , @aaron.ballman wrote: > The failures I am getting are the same as what's shown by the sanitizer bot > for Windows: > https://lab.llvm.org/buildbot/#/builders/127/builds/33980/steps/4/logs/stdio > (I'm

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706276 , @barannikov88 wrote: > In D130689#3706263 , @aaron.ballman > wrote: > >> The failures I am getting are the same as what's shown by the sanitizer bot >> for Wi

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

hokein added a comment. In D131154#3706062 , @kadircet wrote: > thanks, i think we should change the behaviour to not fold the last line in > any case. +1, I think we should always do it for all bracket cases, but we probably don't want it for other ca

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706263 , @aaron.ballman wrote: > > Something odd is going on here and we might want to consider a revert of this > patch until we resolve it. When I do a git pull and cmake files change, > Visual Studio's built-i

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

abidh added a comment. In D131225#3706239 , @barannikov88 wrote: > In D131225#3706207 , @abidh wrote: > >> I think this patch is moving the things in the right direction. But please >> wait for some other review

[PATCH] D130689: [LLVM] Update C++ standard to 17

jhenderson added a comment. FWIW, I've got a Visual Studio configuration (admittedly using a direct Visual Studio generator, not ninja), and I don't have any issues - C++17 is being used. However, I currently only have LLD as an additional project enabled, and don't build compiler-rt. Reposit

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706303 , @thieta wrote: > In D130689#3706263 , @aaron.ballman > wrote: > >> > > > >> Something odd is going on here and we might want to consider a revert of >> this p

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706336 , @aaron.ballman wrote: > That's the only reason this hasn't been reverted already. Landing sweeping > changes on a weekend is a good way to reduce the pain, but we really need to > be sure someone watches the

[PATCH] D131351: [C] Default implicit function pointer conversions diagnostic to be an error

erichkeane accepted this revision. erichkeane added a comment. Yep, i think this is a good direction, and code changes look correct to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131351/new/ https://reviews.llvm.org/D131351 _

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

erichkeane added a comment. I did a pass through, this seems like it is the right thing. I looked over the codegen tests, and I'm convinced it does what we want from that perspective. I'll leave it to @aaron.ballman to take another look for +1'ing this though. Repository: rG LLVM Github Mo

[PATCH] D131396: [pseudo] Use C++17 variant to simplify the DirectiveTree::Chunk class, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131396 File

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D131307#3704709 , @thakis wrote: > It's already an error, but it's a warning default-mapped to an error. You can > -Wno-error=name to downgrade it into a warning, but that requires an explicit > action. So people are unlik

[PATCH] D130689: [LLVM] Update C++ standard to 17

aaron.ballman added a comment. In D130689#3706377 , @thieta wrote: > In D130689#3706336 , @aaron.ballman > wrote: > >> That's the only reason this hasn't been reverted already. Landing sweeping >> changes on a w

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

thakis added a comment. Default-mapped-to-error and release notes seems like a pretty strong signal to me. I think this is fine as is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___ cfe-commits

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D131307#3705362 , @smeenai wrote: > In D131307#3704709 , @thakis wrote: > >> It's already an

[PATCH] D130705: [clang][ASTImporter] Improve import of functions with auto return type.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thank you for the update! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130705/new/ https://reviews.llvm.org/D130705 __

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706424 , @aaron.ballman wrote: > +1, thank you for thinking about how we can improve this process in the > future! Given that C++17 adoption across compilers has been far better than > C++20, I suspect the next time

[clang] fc47001 - [Docs] Add HLSL ResourceType documentation

Author: Chris Bieneman Date: 2022-08-08T09:06:38-05:00 New Revision: fc470013d13f2b996731c865b921df5a87a40e3f URL: https://github.com/llvm/llvm-project/commit/fc470013d13f2b996731c865b921df5a87a40e3f DIFF: https://github.com/llvm/llvm-project/commit/fc470013d13f2b996731c865b921df5a87a40e3f.diff

[PATCH] D130794: [Docs] Add HLSL ResourceType documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc470013d13f: [Docs] Add HLSL ResourceType documentation (authored by beanz). Changed prior to commit: https://reviews.llvm.org/D130794?vs=448699&id=450795#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D130889: [llvm] Introduce a pass plugin registry and loader

viroulep added a comment. Thanks for your review @w2yehia! Comment at: llvm/lib/Passes/PassPluginLoader.cpp:23 +void PassPluginLoader::operator=(const std::string &Filename) { + sys::SmartScopedLock Lock(*PluginsLock); + auto PassPlugin = PassPlugin::Load(Filename); -

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

MyDeveloperDay added a comment. So trying to understand the problem statement, is it: 1. you have some files staged 2. and then you have to change them locally (review comment) 3. but forget to git add them, 4. you run git clang-format --staged 5. and it formats the new file (not added) based on

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:225 + Position End) { +// For LineFoldingsOnly clients, do not fold the last line if it +// contains tokens after `End`. hokei

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

raghavendhra added a comment. @abidmalikwaterloo Can you please check your last patch pushed for review? https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can not apply your patch something to do with usage of diff --update ? Can you please check? Repository: rG LLVM Gi

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:83 +/// overload sets. change the key to support uniqueness. +llvm::Expected> +buildFunctionMapFromAST(ASTUnit &Unit); `#include "llvm/ADT/StringMap.h"` ==

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added a comment. Since this is adding a new AST node (hopefully the only one we need in HLSL) it would be nice to get @aaron.ballman to take a look here too to make sure this isn't too insane. Comment at: clang/lib/AST/DeclBase.cpp:1191 + if (getDeclKind() == Decl::H

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 450812. balazske added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp cla

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

asb added a comment. @zixuan-wu we discussed this a bit in the last community sync call . One aspect that makes this patch a little hard to review is the lack of a clear patch description summarising the behaviour befo

[clang] e640250 - Update the C status page from the latest working draft

Author: Aaron Ballman Date: 2022-08-08T11:30:49-04:00 New Revision: e64025045457b7f52201fbd48b24739f64074b59 URL: https://github.com/llvm/llvm-project/commit/e64025045457b7f52201fbd48b24739f64074b59 DIFF: https://github.com/llvm/llvm-project/commit/e64025045457b7f52201fbd48b24739f64074b59.diff

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel updated this revision to Diff 450823. ymandel added a comment. Address reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131280/new/ https://reviews.llvm.org/D131280 Files: clang/include/clang/Analysis/FlowSensitive/Contro

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

xazax.hun added a comment. The concept of fully qualified name is somewhat ambiguous for me. Do we expect the user to specify inline namespaces as well? I'd love to see some test cases and comments that clarify this. Comment at: clang/lib/Analysis/FlowSensitive/ControlFlowCon

[PATCH] D130847: [clang] SourceManager: fix isOffsetInFileID for the case of a fake SLocEntry

aaron.ballman added a comment. Precommit CI is still failing and I verified locally that the failure is with this patch (instead of some transient issue with precommit CI). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130847/new/ https://reviews.

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

scanon added a comment. The CFP working group and C23 have since clarified this in Annex F: > The returned value is exact and is independent of the current rounding > direction mode. They never set inexact on an implementation that claims 60559 conformance. The only flag that these operations

[PATCH] D131265: Fixed sm version for .and bmma operator.

JackAKirk added a comment. In D131265#3702954 , @tra wrote: > Looks like the tests needed to be updated (and I've found one bug which > explains how we've missed this). Ah yes I see it. Thanks for updating the tests. Repository: rG LLVM Github Monor

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

MaskRay added a comment. In D131346#3706216 , @nemanjai wrote: > Why? There are many years of precedent for using `LLVM_FALLTHROUGH` and it is > very clear and obvious. What do we gain by getting rid of it? > Don't get me wrong, I am not super opposed to

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

smeenai added a comment. All right, SGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

ymandel marked an inline comment as done. ymandel added a comment. In D131280#3706836 , @xazax.hun wrote: > The concept of fully qualified name is somewhat ambiguous for me. Do we > expect the user to specify inline namespaces as well? I'd love to see so

[PATCH] D131346: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f18f7c0072b: [clang] LLVM_FALLTHROUGH => [[fallthrough]]. NFC (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

abrachet updated this revision to Diff 450836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131214/new/ https://reviews.llvm.org/D131214 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/lld-repro.c Index: clang/test/Driver/lld-repro.c ==

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1639 +Twine ReproduceOption = +C.getDefaultToolChain().getTriple().isOSBinFormatCOFF() +? "/reproduce:" mstorsjo wrote: > th

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks lgtm! Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2187 +TEST(CompletionTest, FixItForMembersUsing) { + const Annotations Code(R"cpp( --

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ilya-biryukov added a comment. Hey! Also wondering what's the status of this. @Rakete do you plan to finish the patch? Or would it be ok if someone takes it over? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.or

[PATCH] D131280: [clang][dataflow] Parameterize analysis by explicit map of analyzable functions.

xazax.hun added a subscriber: gribozavr2. xazax.hun added a comment. In D131280#3706915 , @ymandel wrote: > Sure. This is probably worth some discussion. Fully qualified names, however > we define them, will not be enough, since they don't cover overload

[PATCH] D130889: [llvm] Introduce a pass plugin registry and loader

viroulep updated this revision to Diff 450844. viroulep added a comment. I took into account @w2yehia's comment, and I also noticed there was no test in clang for the `-fpass-plugin` option, so I added one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130889/new/ https://reviews.llvm.

[PATCH] D131225: Driver: Refactor and support per target dirs in baremetal

manojgupta added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:384 + /// IsBareMetal - Does this tool chain is a baremetal target. + static bool IsBareMetal(const llvm::Triple &); barannikov88 wrote: > Is this a correct sentence? (My Eng

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

abidmalikwaterloo added a comment. In D105255#3706602 , @raghavendhra wrote: > @abidmalikwaterloo Can you please check your last patch pushed for review? > https://buildkite.com/llvm-project/diff-checks/builds/117796 states it can > not apply your patc

[PATCH] D131412: [clang][deps] Stop sharing FileManager across module builds in scanner

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sharing the FileManager across implicit module builds currentl

[PATCH] D131314: [clang] format string checks for `InitListExpr`

inclyc added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131314/new/ https://reviews.llvm.org/D131314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D131412: [clang][deps] Stop sharing FileManager across module builds in scanner

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks. (For context, this patch build on top of D131076 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane updated this revision to Diff 450857. erichkeane added a comment. I pulled out a good amount of this patch as NFC, which should shrink the patch. I have a 'new approach' that I think will work, which is to suppress the constraint evaluation the same way we did with the requires clause

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

justinstitt created this revision. Herald added a project: All. justinstitt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Justin Stitt Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131416 Files: cla

[PATCH] D131298: [clang-doc] Read docstrings for record members

phosek added a comment. Would it be possible to extend the existing unit tests to cover this: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/unittests/clang-doc/BitcodeTest.cpp https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/unittests/clang-doc/SerializeTest.cpp

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. In D130108#3706550 , @MyDeveloperDay wrote: > So trying to understand the problem statement, is it: > > 1. you have some files staged > 2. and then you have to change them locally (review comment) > 3. but forget to git add them

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

dblaikie added a comment. Update this to use something like https://reviews.llvm.org/D131381 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 ___ cfe-commits m

  1   2   3   >