[PATCH] D131704: [Clang] Tighten restrictions on enum out of range diagnostic

shafik added a comment. In D131704#3719954 , @thakis wrote: >> This is constant initialization, so this is indeed expected. > > Do we have a test for this in clang? It seems that the diag appeared for that > case after the change that turned this diag

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

awarzynski added a comment. This is primarily a Clang change, so added some Clang reviewers. I will review shortly - thanks for taking this on! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452393. alexiprof added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: clang/docs/ClangCommandLineReference.rst

[clang] 452fbbd - [Driver] Use addOptInFlag. NFC

Author: Fangrui Song Date: 2022-08-13T00:51:04-07:00 New Revision: 452fbbda391815fef7874170fab6faa2bd4f7ae2 URL: https://github.com/llvm/llvm-project/commit/452fbbda391815fef7874170fab6faa2bd4f7ae2 DIFF: https://github.com/llvm/llvm-project/commit/452fbbda391815fef7874170fab6faa2bd4f7ae2.diff

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp added a comment. In D131780#3719881 , @Eugene.Zelenko wrote: > Please mention changes in Release Notes. Thanks for the quick review, @Eugene.Zelenko ! This check was newly added a couple of days ago (as per the "New checks" section in

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp updated this revision to Diff 452391. carlosgalvezp added a comment. Test also capture by reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/D131780 Files:

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

awarzynski added a comment. Thanks, mostly makes sense! https://github.com/llvm/llvm-project/issues/57033 mentions `-O{n}` as well :) Could you fix that too? More comments inline. CI is still failing :( Are you able to re-produce that? (I'm traveling atm, so can't check).

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added a comment. In D131808#3720910 , @awarzynski wrote: > Thanks, mostly makes sense! https://github.com/llvm/llvm-project/issues/57033 > mentions `-O{n}` as well :) Could you fix that too? More comments inline. > > CI is still failing :(

[PATCH] D119296: KCFI sanitizer

joaomoreira added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:121 +if (N == Value) + return ~Value; + } samitolvanen wrote: > joaomoreira wrote: > > Can we use another constant blinding scheme, such as a Value++ or anything > >

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452405. alexiprof added a comment. Set new text hint for option fsyntax-only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files:

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added inline comments. Comment at: clang/include/clang/Driver/Options.td:2798-2799 def fsyntax_only : Flag<["-"], "fsyntax-only">, - Flags<[NoXarchOption,CoreOption,CC1Option,FC1Option]>, Group; + Flags<[NoXarchOption,CoreOption,CC1Option,FC1Option,FlangOption]>,

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452429. alexiprof added a comment. this pull request contains a fix for the problem with displaying options -fsyntax_only in clang and fland-new in help https://github.com/llvm/llvm-project/issues/57033 Before: $ clang -help | grep syntax

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof updated this revision to Diff 452431. alexiprof added a comment. remove Unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

ShawnZhong added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; aaron.ballman wrote: > aaron.ballman wrote: > >

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

aykevl accepted this revision. aykevl added a comment. This revision is now accepted and ready to land. Looks good to me! Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539 +// Link to compiler-rt. We directly put the libclang.builtins.a +// as input file, other than

[PATCH] D131091: [clang][index] Index unresolved member expression as reference

denis-fatkulin added a comment. @hokein, could you please also merge my pacth to code base? I haven't such permissions yet. My git user name and address: Denis Fatkulin (fatkulin.de...@huawei.com) Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 44a647d - [Driver] Support linking to compiler-rt for target AVR

Author: Ben Shi Date: 2022-08-13T20:40:21+08:00 New Revision: 44a647d21d946f8cc3eb7c1fea33311cf778f303 URL: https://github.com/llvm/llvm-project/commit/44a647d21d946f8cc3eb7c1fea33311cf778f303 DIFF: https://github.com/llvm/llvm-project/commit/44a647d21d946f8cc3eb7c1fea33311cf778f303.diff LOG:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44a647d21d94: [Driver] Support linking to compiler-rt for target AVR (authored by benshi001). Changed prior to commit:

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13069 - // therefore don't strictly fit into a signed bitfield of width 1. - if (FieldWidth == 1 && Value == 1) -return false; aaron.ballman wrote: > ShawnZhong wrote: > >

[clang] ba79c2a - Update the implementation status of some C11 features

Author: Aaron Ballman Date: 2022-08-13T10:17:47-04:00 New Revision: ba79c2a25069f09728625982c424920452fa6b83 URL: https://github.com/llvm/llvm-project/commit/ba79c2a25069f09728625982c424920452fa6b83 DIFF: https://github.com/llvm/llvm-project/commit/ba79c2a25069f09728625982c424920452fa6b83.diff

[clang] f385eaf - [OpenMP] Fix use after scope after D129608

Author: Vitaly Buka Date: 2022-08-13T09:40:51-07:00 New Revision: f385eaf48f5c4123b61272cd243c339d6f8526ed URL: https://github.com/llvm/llvm-project/commit/f385eaf48f5c4123b61272cd243c339d6f8526ed DIFF: https://github.com/llvm/llvm-project/commit/f385eaf48f5c4123b61272cd243c339d6f8526ed.diff

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

denis-fatkulin updated this revision to Diff 452408. denis-fatkulin added a comment. Patch is updated with context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131088/new/ https://reviews.llvm.org/D131088 Files:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539 +// Link to compiler-rt. We directly put the libclang.builtins.a +// as input file, other than '-lclang.builtins'. +if (RtLib ==

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

Eugene.Zelenko added a comment. In D131780#3720896 , @carlosgalvezp wrote: > In D131780#3719881 , > @Eugene.Zelenko wrote: > >> Please mention changes in Release Notes. > > Thanks for the quick review,

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. Some documentation/test nits, and one question, but otherwise LGTM. Could you fix the merge conflict? It would be nice to see pre-commit CI results. Given the complexity of the

[PATCH] D131385: [clangd] Support for standard type hierarchy

nridge added a comment. Related issue: https://github.com/clangd/clangd/issues/826 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131385/new/ https://reviews.llvm.org/D131385 ___ cfe-commits mailing list

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 452459. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 Files: clang/include/clang/AST/ASTContext.h

[clang] 2f9be69 - [OpenMP] Fix another after scope after D129608

Author: Vitaly Buka Date: 2022-08-13T12:13:54-07:00 New Revision: 2f9be69d843d12864128f4e23920ba214c5e212d URL: https://github.com/llvm/llvm-project/commit/2f9be69d843d12864128f4e23920ba214c5e212d DIFF: https://github.com/llvm/llvm-project/commit/2f9be69d843d12864128f4e23920ba214c5e212d.diff

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson updated this revision to Diff 452447. royjacobson added a comment. Update to handle some edge cases better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ https://reviews.llvm.org/D131541 Files:

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson updated this revision to Diff 452448. royjacobson added a comment. Add another test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131541/new/ https://reviews.llvm.org/D131541 Files: clang/lib/Sema/SemaDecl.cpp

[clang] 64f0f7e - __has_trivial_copy should map to __is_trivially_copyable

Author: Zachary Henkel Date: 2022-08-13T22:54:52+03:00 New Revision: 64f0f7e6460019a38fe2f1cbe4b9446a3268af18 URL: https://github.com/llvm/llvm-project/commit/64f0f7e6460019a38fe2f1cbe4b9446a3268af18 DIFF:

[clang-tools-extra] 7c69476 - [clangd] Drop unnecessary const from return types (NFC)

Author: Kazu Hirata Date: 2022-08-13T12:55:44-07:00 New Revision: 7c6947656496cb66f592e4e556a2f1fa40324b76 URL: https://github.com/llvm/llvm-project/commit/7c6947656496cb66f592e4e556a2f1fa40324b76 DIFF: https://github.com/llvm/llvm-project/commit/7c6947656496cb66f592e4e556a2f1fa40324b76.diff

[clang] 2b43bd0 - Remove unused forward declarations (NFC)

Author: Kazu Hirata Date: 2022-08-13T12:55:47-07:00 New Revision: 2b43bd0bd98a4ae556b0a75b8016e27a0642b8a4 URL: https://github.com/llvm/llvm-project/commit/2b43bd0bd98a4ae556b0a75b8016e27a0642b8a4 DIFF: https://github.com/llvm/llvm-project/commit/2b43bd0bd98a4ae556b0a75b8016e27a0642b8a4.diff

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

This revision was automatically updated to reflect the committed changes. Closed by commit rG64f0f7e64600: __has_trivial_copy should map to __is_trivially_copyable (authored by zahen, committed by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D3976: -Wcomma, a new warning for questionable uses of the comma operator

gpakosz added a comment. Herald added a project: All. Hello, As of today, `-Wcomma` is not really documented: https://clang.llvm.org/docs/DiagnosticsReference.html#wcomma > The current whitelisted expressions are increments, decrements, assignments, > compound assignments, overloaded versions

[clang] 2117fcb - Use Optional::transform instead of Optional::map (NFC)

Author: Kazu Hirata Date: 2022-08-13T11:48:26-07:00 New Revision: 2117fcb1c06207b5eea09b66fb8e0ff58314afa8 URL: https://github.com/llvm/llvm-project/commit/2117fcb1c06207b5eea09b66fb8e0ff58314afa8 DIFF: https://github.com/llvm/llvm-project/commit/2117fcb1c06207b5eea09b66fb8e0ff58314afa8.diff

[PATCH] D131541: [Sema] Fix friend destructor declarations after D130936

royjacobson added reviewers: erichkeane, hubert.reinterpretcast, shafik. royjacobson added a comment. Updated the patch and added more test coverage. I still don't diagnose the dependent friend case, but I didn't see how to do it easily. Comment at:

[PATCH] D131730: __has_trivial_copy should map to __is_trivially_copyable

royjacobson added a comment. Added a backport request here - https://github.com/llvm/llvm-project/issues/57140 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131730/new/ https://reviews.llvm.org/D131730

[PATCH] D130831: [CodeGen] Track DeferredDecls that have been emitted

junaire added a comment. gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130831/new/ https://reviews.llvm.org/D130831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

MaskRay accepted this revision. MaskRay added a comment. > Subject: [clang,flang] Add missing options fsyntax-only in help Prefer `-fsyntax-only` to `fsyntax-only` since the former is what a user writes. > this pull request contains a fix for the problem with displaying options > -fsyntax_only

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

MaskRay added a comment. > https://github.com/llvm/llvm-project/issues/57033 Use `Fix https://github.com/llvm/llvm-project/issues/57033` or `Fixes https://github.com/llvm/llvm-project/issues/57033` or (I usually prefer this for non-bugs but still some issues worth addressing) `Close ...`, then

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

MaskRay added a comment. To be clear, some issues should be addressed before someone lands this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

alexiprof added a comment. I do not have commit access, i do not have merge :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 ___ cfe-commits mailing list