[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822653 , @sammccall wrote: > It doesn't scale very well though: we're limited to 30 modifiers in total, > this patch brings us up to 16, if we followed this class.constructor > precedent for function.operator,

[PATCH] D134733: [clang-format][chore] transparent #include name regex

owenpan added a project: clang-format. owenpan added a comment. See D134852 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134733/new/ https://reviews.llvm.org/D134733

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

MaskRay added a comment. It seems that the intention of `-mgeneral-regs-only` is to prevent FP and SIMD register use. aarch64-linux-gnu-gcc has such an error error: ‘-mgeneral-regs-only’ is incompatible with the use of floating-point types Clang doesn't reject FP in Sema yet, but I think

[PATCH] D131939: [clang-tidy] Add performance-expensive-flat-container-operation check

njames93 added a comment. I have a feeling the default should be to only warm in loops otherwise this could get noisy. Though setting it as the default you'd likely want to change the name to something along the lines of WarmOutsideLoops. Comment at:

[PATCH] D134733: [clang-format][chore] transparent #include name regex

owenpan added a comment. While attempting to review this patch, I came to the conclusion that we should first clean up the `HeaderIncludes` class and Format.cpp a little. I will submit a patch for review ASAP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, kwk, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:2774 - -const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; Did I miss where this comes from now? Repository: rG LLVM Github

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld

[PATCH] D134824: Fix frint ACLE intrinsic names

jaykang10 accepted this revision. jaykang10 added a comment. This revision is now accepted and ready to land. Thanks for fixing it! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134824/new/ https://reviews.llvm.org/D134824

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat marked 2 inline comments as done. azat added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat updated this revision to Diff 463778. azat added a comment. Update the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

DoDoENT added a comment. > Generally the way to do it, if you want to introspect into the type, its > template parameters, etc, then yes, keeping pointers to the AST or reparsing > the name with Clang as-needed, would be the way to go - or walking the AST > up-front and generating your own

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

phosek added a comment. A possible alternative solution would be to build `clangSupport_sources` as an object library, and then link that library into `clangSupport` and `clang-tblgen` which could be done unconditionally; the advantage is that you don't need to compile `clangSupport_sources`

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. Actually, you already have a logic for checking if there is a contradiction in your D103096 patch, in ConstraintAssignor::updateExistingConstraints: // Update constraints in the map which bitwidth is equal or lower then //

[clang-tools-extra] 4c862da - [clangd] Avoid using constructor/destructor of vector

Author: Sam McCall Date: 2022-09-29T09:30:03+02:00 New Revision: 4c862da8d43f32bed7ad7e3b700e01d04b3b0f8d URL: https://github.com/llvm/llvm-project/commit/4c862da8d43f32bed7ad7e3b700e01d04b3b0f8d DIFF: https://github.com/llvm/llvm-project/commit/4c862da8d43f32bed7ad7e3b700e01d04b3b0f8d.diff

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

sammccall added a comment. TL;DR: let's go with this patch as-is rather than borrowing problems from the future. This enum isn't growing very rapidly. In D134728#3822775 , @ckandeler wrote: > In D134728#3822653

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added a comment. `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run `check-llvm` for generic changes which may have farreaching effects to other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[clang] dba8fce - Fix frint ACLE intrinsic names

Author: Michael Platings Date: 2022-09-29T09:13:07+01:00 New Revision: dba8fced969e2eca9e8650a874293927db17d131 URL: https://github.com/llvm/llvm-project/commit/dba8fced969e2eca9e8650a874293927db17d131 DIFF:

[PATCH] D134824: Fix frint ACLE intrinsic names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdba8fced969e: Fix frint ACLE intrinsic names (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134733: [clang-format][chore] transparent #include name regex

kwk updated this revision to Diff 463786. kwk added a comment. - Remove ad-hoc instantiated IncludeRegex objects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134733/new/ https://reviews.llvm.org/D134733 Files:

[PATCH] D134733: [clang-format][chore] transparent #include name regex

kwk added inline comments. Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:407 +const llvm::SmallVectorImpl ) { + if (Matches.size() >= 3) { +return Matches[2]; MyDeveloperDay wrote: > kwk wrote: > > MyDeveloperDay wrote: > > > ‘>= 2’ > >

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

sepavloff accepted this revision. sepavloff added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Driver.h:758 + /// Return the typical executable name for the specified driver \p Mode. + static const char *getExecutableForDriverMode(DriverMode Mode); }; This should be private

[PATCH] D134790: [Driver] Add --config= as canonical spelling of --config

This revision was automatically updated to reflect the committed changes. Closed by commit rG08af5ba37135: [Driver] Add --config= as canonical spelling of --config (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134790/new/

[clang] 08af5ba - [Driver] Add --config= as canonical spelling of --config

Author: Fangrui Song Date: 2022-09-29T00:38:12-07:00 New Revision: 08af5ba3713523d9596a414e6a64b26494199fdd URL: https://github.com/llvm/llvm-project/commit/08af5ba3713523d9596a414e6a64b26494199fdd DIFF: https://github.com/llvm/llvm-project/commit/08af5ba3713523d9596a414e6a64b26494199fdd.diff

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel commandeered this revision. rymiel added a reviewer: eoanermine. rymiel added a comment. Commandeering to finish the final nits as per https://github.com/llvm/llvm-project/issues/56283#issuecomment-1261653291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 463772. rymiel added a comment. Resolve nits: - Re-sorted uses of the name RequiresExpressionIndentationKind - Updated version to be 16 - Add test for demonstrating indentation as subexpression - Reformatted Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske updated this revision to Diff 463776. balazske added a comment. added test, added a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133119/new/ https://reviews.llvm.org/D133119 Files:

[PATCH] D133413: [clang-tidy] Fix crashes on `if consteval` in readability checks

rymiel added a comment. Ping? This is fixing a segmentation fault. Please let me know if there are other people I should add as reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133413/new/ https://reviews.llvm.org/D133413

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

kwk added a comment. I didn't see much difference in what this patch does compare to mine but I saw that it removes the need for instantiating multiple `llvm::Regex` objects from a single static pattern. But that's something I've just done in a new revision of my own patch:

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

sammccall accepted this revision. sammccall added a comment. Sorry about the delay, I've been juggling too many things :-( TL;DR: yes, I think it's reasonable. I think the implementation complexity is justified by what we get. Thanks for explaining! I think to minimize interface complexity, we

[PATCH] D134788: [ARM64EC][clang-cl] Add /arm64EC flag

DavidSpickett added a comment. Has Microsoft documented this option? Not doubting it exists but I mostly see how to use it rather than a specific page describing the option and its behaviour. Not a big deal but if there is one, please include a link to it in the commit message.

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:130 + if (T->isFloatingType()) { +unsigned Bytes = getASTContext().getTypeSize(T); +if (Bytes == 32) Comment at: clang/lib/AST/Interp/Floating.h:106 + //

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463815. SixWeining added a comment. Herald added a subscriber: pengfei. The flag in the INLINEASM SDNode in llvm/test/CodeGen/X86/callbr-asm-kill.mir is updated because enum `Constraint_k` is added before `Constraint_m`. Repository: rG LLVM Github

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7baddc7557e: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC (authored by SixWeining). Repository: rG LLVM Github Monorepo

[clang] b7baddc - [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

Author: Weining Lu Date: 2022-09-29T15:02:08+08:00 New Revision: b7baddc7557e5c35a0f6a604a134d849265a99d4 URL: https://github.com/llvm/llvm-project/commit/b7baddc7557e5c35a0f6a604a134d849265a99d4 DIFF: https://github.com/llvm/llvm-project/commit/b7baddc7557e5c35a0f6a604a134d849265a99d4.diff

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 463773. rymiel added a comment. Missed a spot when re-sorting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.llvm.org/D129443 Files: clang/docs/ClangFormatStyleOptions.rst

[clang] 04a65d6 - Revert D134638 "[Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC"

Author: Fangrui Song Date: 2022-09-29T00:54:56-07:00 New Revision: 04a65d62a0c67da0ee383c8f1d74dea6d8b83a7e URL: https://github.com/llvm/llvm-project/commit/04a65d62a0c67da0ee383c8f1d74dea6d8b83a7e DIFF: https://github.com/llvm/llvm-project/commit/04a65d62a0c67da0ee383c8f1d74dea6d8b83a7e.diff

[PATCH] D134728: [clangd] Add highlighting modifiers "constructor" and "destructor"

ckandeler added a comment. In D134728#3822898 , @sammccall wrote: > If the distinction isn't important, maybe we should add a single "constructor > or destructor" modifier... No, it's not. I will update the patch accordingly. Repository: rG LLVM

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 463785. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D134804: [clang][Interp] Implement bitwise Not operations

tbaeder updated this revision to Diff 463791. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134804/new/ https://reviews.llvm.org/D134804 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Integral.h

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

Amanieu added a comment. Currently using Clang with -mgeneral-regs-only generates perfectly fine soft-float AArch64, with the except of the va_arg() implementation which is fixed here. In fact Rust even has a aarch64-unknown-none-softfloat which relies on this behavior in LLVM. I believe this

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

rovka added inline comments. Herald added a subscriber: zero9178. Comment at: flang/test/Driver/convert.f90:1 +! Ensure argument -fconvert= works as expected. + jpenix-quic wrote: > awarzynski wrote: > > rovka wrote: > > > Nit: Shouldn't you also check that

[PATCH] D133119: [clang-tidy] Add checker 'bugprone-suspicious-realloc-usage'.

balazske updated this revision to Diff 463812. balazske added a comment. rebase to current main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133119/new/ https://reviews.llvm.org/D133119 Files:

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3822926 , @MaskRay wrote: > `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run at least > `check-llvm check-clang` for generic changes which may have farreaching > effects to other targets. Sorry

[PATCH] D134329: [clang-format][NFC] Reformat clang/lib/Format using 6257832bf94f

MyDeveloperDay added a comment. yeah I'm ok with that too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134329/new/ https://reviews.llvm.org/D134329 ___ cfe-commits mailing list

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

azat added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld

[PATCH] D134790: [Driver] Add --config= as canonical spelling of --config

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I don't know the fancy option magic you're using here, I haven't tested it but it seems to make sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134685: Fix SourceManager::isBeforeInTranslationUnit bug with token-pasting

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for digging into the rabbit role and the great analysis. It looks good from my side. Re the test case `ID(I TWO 3)` we discussed yesterday, I verified that there is no issue. (we

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This only handles floats for now, so 32 bit

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 463807. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added a comment. > Suppose we have found the way to handle it. But what if we find a > contradiction while simplifying, like (short)(int x) = 0 and (int x) = 1. So > that we would already know that it is impossible. What SVal should we return > in such case? Undef? Unknown? Original

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

dmgreen added a comment. > With -mgeneral-regs-only, all arguments are passed in GPRs, so we should use > gr_top/gr_offs in va_list even for floating-point types. I don't believe that -mgeneral-regs-only was intended to define an ABI passing floats in GPRs for AArch64. If it has that is likely

[PATCH] D134717: [Clang][AArch64] Fix va_arg with -mgeneral-regs-only

Amanieu added a comment. I fully agree that this likely wasn't intentional, but this is still very useful for code that can't use FP registers for whatever reason (e.g. kernels). Regarding the ABI, it doesn't need to be officially defined: it just needs to be compatible with other code

[PATCH] D133885: [Clang][Arm] Convert -fallow-half-arguments-and-returns to a target option. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG123064dc397d: [Clang][Arm] Convert -fallow-half-arguments-and-returns to a target option. NFC (authored by dmgreen). Herald added a project: clang.

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463944. mgorny marked an inline comment as done. mgorny added a comment. Change confusing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) +EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if

[PATCH] D133659: [Clang] P1169R4: static operator()

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1265 + if (Intro.hasLambdaCapture()) +P.Diag(StaticLoc, diag::err_static_lambda_captures); +} aaron.ballman wrote: > aaron.ballman wrote: > > royjacobson wrote: > > > cor3ntin

[clang] 013012b - [Clang][NFC] Add missing feature macros to lexer test

Author: Roy Jacobson Date: 2022-09-29T21:16:29+03:00 New Revision: 013012b99a5448f067cfdce8dd07cf503a6172a7 URL: https://github.com/llvm/llvm-project/commit/013012b99a5448f067cfdce8dd07cf503a6172a7 DIFF: https://github.com/llvm/llvm-project/commit/013012b99a5448f067cfdce8dd07cf503a6172a7.diff

[clang] 29e0435 - [libclang] Split-out parts of `Index.h`

Author: Jan Svoboda Date: 2022-09-29T11:29:53-07:00 New Revision: 29e0435ac04957861aa1f85d41291c8b19db0122 URL: https://github.com/llvm/llvm-project/commit/29e0435ac04957861aa1f85d41291c8b19db0122 DIFF: https://github.com/llvm/llvm-project/commit/29e0435ac04957861aa1f85d41291c8b19db0122.diff

[clang] 1392126 - [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies()`

Author: Jan Svoboda Date: 2022-09-29T11:29:53-07:00 New Revision: 13921262cae0e7346e41875c1850d8861be0488e URL: https://github.com/llvm/llvm-project/commit/13921262cae0e7346e41875c1850d8861be0488e DIFF: https://github.com/llvm/llvm-project/commit/13921262cae0e7346e41875c1850d8861be0488e.diff

[PATCH] D134837: [libclang] Split-out some data structures out of `Index.h`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29e0435ac049: [libclang] Split-out parts of `Index.h` (authored by jansvoboda11). Changed prior to commit:

[PATCH] D134838: [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG13921262cae0: [clang][deps] NFC: Expose more flexible version of `Worker::computeDependencies… (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

MaskRay added a comment. mips computed sysroot from GCCInstallation very early in 2013 rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 and Android followed up in 2018 (D45291 ), but I am not sure

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

MaskRay added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) probinson wrote: > But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're >

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 464001. qiongsiwu1 added a comment. Try fixing the test case on Windows, hopefully one last time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files:

[clang] 6523814 - [Clang] P1169R4: static operator()

Author: Roy Jacobson Date: 2022-09-29T23:03:26+03:00 New Revision: 6523814c4e38ad70f8fd3fc3c39d089195e099a1 URL: https://github.com/llvm/llvm-project/commit/6523814c4e38ad70f8fd3fc3c39d089195e099a1 DIFF: https://github.com/llvm/llvm-project/commit/6523814c4e38ad70f8fd3fc3c39d089195e099a1.diff

[PATCH] D133659: [Clang] P1169R4: static operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6523814c4e38: [Clang] P1169R4: static operator() (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/

[PATCH] D134874: [Concepts] Fix Concepts on generic lambda in a VarTemplateSpecDecl

erichkeane updated this revision to Diff 464003. erichkeane added a comment. Looks like that problem was fixed easy enough, so back to all tests passing :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134874/new/ https://reviews.llvm.org/D134874 Files:

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. Thanks for the patient review and the discussion! @aaron.ballman @cor3ntin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133659/new/ https://reviews.llvm.org/D133659 ___

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nickdesaulniers added subscribers: justinstitt, nikic, tstellar, serge-sans-paille. nickdesaulniers added a comment. In D20401#3823476 , @sammccall wrote: > In D20401#2770059 , @nickdesaulniers > wrote: > >> I

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. I'll grab an Arch Linux machine for testing, but I don't think this is currently in a form for submitting. This adds new functionality for non-MIPS and we need some fake file

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson created this revision. royjacobson added a reviewer: cor3ntin. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Define the feature test macro for named character escapes. I assume this

[PATCH] D134671: [Driver] Prevent Mips specific code from claiming -mabi argument on other targets.

nickdesaulniers added subscribers: nathanchance, nickdesaulniers. nickdesaulniers added a comment. I don't think it's an issue for us to work around downstream, but this did regress support for `-mabi=ms` used in UEFI related build scripts. https://github.com/ClangBuiltLinux/linux/issues/1725

[PATCH] D134020: [clang][Interp] Handle enums

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/enums.cpp:25 + SIX = FIVE + 2, + +}; tbaeder wrote: > aaron.ballman wrote: > > tbaeder wrote: > > > aaron.ballman wrote: > > > > tbaeder wrote: > > > > > aaron.ballman wrote: > > > > > >

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/Driver/hlsl-entry.cpp:1 +// RUN:not %clang -cc1 -triple dxil-pc-shadermodel6.3-compute -x c++ -hlsl-entry foo %s 2>&1 | FileCheck %s --check-prefix=NOTHLSL +

[clang] e09a6f3 - [NFC] Move cc1 test out of Driver test

Author: Xiang Li Date: 2022-09-29T14:19:12-07:00 New Revision: e09a6f37d5ec0dea47fe0feb32556e77450cd6c4 URL: https://github.com/llvm/llvm-project/commit/e09a6f37d5ec0dea47fe0feb32556e77450cd6c4 DIFF: https://github.com/llvm/llvm-project/commit/e09a6f37d5ec0dea47fe0feb32556e77450cd6c4.diff

[PATCH] D134820: [LTO][clang] Teaching Clang to Pass Plugin Options to the AIX Linker

qiongsiwu1 updated this revision to Diff 463943. qiongsiwu1 added a comment. Fix test case on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134820/new/ https://reviews.llvm.org/D134820 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8686 +def warn_cast_function_type_strict : Warning, + InGroup, DefaultIgnore; def err_cast_pointer_to_non_pointer_int : Error< kees wrote: > aaron.ballman wrote: >

[PATCH] D133659: [Clang] P1169R4: static operator()

royjacobson added a comment. In D133659#3824472 , @aaron.ballman wrote: > Double-checking my understanding of the overload resolution changes: we added > a new conversion sequence, but we don't expect that conversion sequence to > cause a change in

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

sammccall added a comment. Thanks Nick for the info! No kernel experience here, so if you have any particular suggestions about how to measure the workload you care about it'd be much appreciated (e.g. are particular files that are slow enough to measure in isolation, or is it better to do a

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rG1609a5d7715c: [clang] [test] Use %clang_cc1 substitution consistently (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

royjacobson updated this revision to Diff 464007. royjacobson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134898/new/ https://reviews.llvm.org/D134898 Files: clang/lib/Frontend/InitPreprocessor.cpp

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. I'm not sure if we should be documenting this in the user manual, or if it should be considered an internal-use envvar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134905/new/ https://reviews.llvm.org/D134905 ___

[PATCH] D134898: [Clang] define __cpp_named_character_escapes

cor3ntin added a comment. Thanks for catching that, I missed there was a feature test macro for it. It doesn't really make sense for it to be a feature test macro (given WG21's current policies) so I'll make raise an issue about that but I'm happy to approve the change in the meantime

[PATCH] D134878: Update developer policy on potentially breaking changes

ldionne accepted this revision. ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) +EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if (EffectiveDriverMode.empty()) +EffectiveDriverMode =

[PATCH] D133659: [Clang] P1169R4: static operator()

aaron.ballman added a comment. Double-checking my understanding of the overload resolution changes: we added a new conversion sequence, but we don't expect that conversion sequence to cause a change in overload resolution in practice? (I'm wondering if there's test coverage we should be adding

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

probinson added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're not testing the

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

MaskRay added a comment. Since this decreases complexity, it's probably fine. But we really need some tests in clang/test/Driver see linux-cross.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134454/new/ https://reviews.llvm.org/D134454

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

MaskRay added inline comments. Comment at: clang/test/Driver/config-file3.c:176 // -// SHORT-NAME: Configuration file: {{.*}}/testdmode/qqq.cfg -// SHORT-NAME: -Werror -// SHORT-NAME-NOT: -Wundefined-func-template +// FULL3-NOT: Configuration file: +// FULL3: Configuration

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

ojeda added a comment. Thanks Nick for the ping. Indeed, `rustc` allows to use a "target specification file" to create new targets that are not built-in, as a JSON file. They are unstable though, since they are fairly tied to LLVM, and I think the Rust compiler team prefers to stabilize flags

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74085ebfb68e: [llvm] [lit] Move %clang_dxc substitution from clang/test (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063e17d8b04b: [clang] [Driver] More flexible rules for loading default configs (authored by mgorny). Herald added a project: clang. Repository:

[clang] 063e17d - [clang] [Driver] More flexible rules for loading default configs

Author: Michał Górny Date: 2022-09-29T20:58:59+02:00 New Revision: 063e17d8b04b41cd8bd174aebb6603eb1a76d34a URL: https://github.com/llvm/llvm-project/commit/063e17d8b04b41cd8bd174aebb6603eb1a76d34a DIFF: https://github.com/llvm/llvm-project/commit/063e17d8b04b41cd8bd174aebb6603eb1a76d34a.diff

[clang] 74085eb - [llvm] [lit] Move %clang_dxc substitution from clang/test

Author: Michał Górny Date: 2022-09-29T20:59:00+02:00 New Revision: 74085ebfb68e067ba6c21722ac02d2ffbb42a00c URL: https://github.com/llvm/llvm-project/commit/74085ebfb68e067ba6c21722ac02d2ffbb42a00c DIFF: https://github.com/llvm/llvm-project/commit/74085ebfb68e067ba6c21722ac02d2ffbb42a00c.diff

[clang] 1609a5d - [clang] [test] Use %clang_cc1 substitution consistently

Author: Michał Górny Date: 2022-09-29T20:59:00+02:00 New Revision: 1609a5d7715c06ff52c13af8b20ee64811a8ec7b URL: https://github.com/llvm/llvm-project/commit/1609a5d7715c06ff52c13af8b20ee64811a8ec7b DIFF: https://github.com/llvm/llvm-project/commit/1609a5d7715c06ff52c13af8b20ee64811a8ec7b.diff

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

probinson added a comment. In D111000#3822354 , @ychen wrote: > It is possible to just use `clang-format @response.txt`? That should also > invoke the executable once. It's true that whatever file you're handing to `--files` could just as easily be

[PATCH] D133983: [HLSL] Add SV_DispatchThreadID

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a think-o that I introduced with an earlier suggested change. I'm not super qualified for the CodeGen changes. They look correct to me, but @beanz would probably

  1   2   3   >