[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1125 +llvm::Type *selType = CGF.ConvertType(CGF.getContext().getObjCSelType()); +return llvm::UndefValue::get(selType); + } mwyman wrote: > nlopes wrote: > > Please consider using

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

efriedma added a comment. You might actually want to run this twice, once early, and once in the backend. Early to get high-quality optimization, late in case optimizations don't run for some reason. (Not sure how that works if `T.getEnvironment() == Triple::EnvironmentType::Library`,

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth created this revision. Herald added subscribers: mgrang, hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Issue #58168 describes the difficulty diagnosing stack

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

dyung added a comment. Thanks, this is necessary because the Playstation platforms default to C++14, not C++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135486/new/ https://reviews.llvm.org/D135486

[clang] c585a44 - [Clang] Use C++17 in constant-builtins-fmax.cpp test

Author: Evgeny Shulgin Date: 2022-10-07T21:31:38Z New Revision: c585a44651f485c1a10fefdc6625ad998c05c61c URL: https://github.com/llvm/llvm-project/commit/c585a44651f485c1a10fefdc6625ad998c05c61c DIFF: https://github.com/llvm/llvm-project/commit/c585a44651f485c1a10fefdc6625ad998c05c61c.diff

[PATCH] D135486: [Clang] Use C++17 in constant-builtins-fmax.cpp test

This revision was automatically updated to reflect the committed changes. Closed by commit rGc585a44651f4: [Clang] Use C++17 in constant-builtins-fmax.cpp test (authored by Izaron). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135486/new/

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:169 +// For renaming, we're only interested in foo's declaration, so drop the other one +void filterBaseUsingDecl(llvm::DenseSet& Decls) { + if (Decls.size() == 2) { I'm

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

paulkirth added subscribers: nickdesaulniers, phosek. paulkirth added a comment. @nickdesaulniers @phosek You may be interested in this super hacky prototype. There's a bunch of things to improve(tests, output, code structure, plumbing...), but when we emit the diagnostic for

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

nickdesaulniers added a comment. In D135488#3843992 , @paulkirth wrote: > Roland mentioned there's probably a clever way to do this using only DWARF, > but that it's probably simpler to do in the compiler backend. That's essentially what I do in:

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae added a comment. In D135429#3843906 , @efriedma wrote: > You might actually want to run this twice, once early, and once in the > backend. Early to get high-quality optimization, late in case optimizations > don't run for some reason.

[PATCH] D135493: [Clang] Support constexpr builtin fmin

Izaron created this revision. Izaron added reviewers: efriedma, jcranmer-intel, aaron.ballman, cor3ntin. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support constexpr version of __builtin_fmin and

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet updated this revision to Diff 466198. BigPeet added a comment. fixed wrong arc diff handling :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 Files:

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

isuckatcs created this revision. isuckatcs added reviewers: njames93, baloghadamsoftware, aaron.ballman, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, rnkovacs, xazax.hun. Herald added a project: All. isuckatcs

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

efriedma added a comment. > The pass will be always enabled in > registerPipelineEarlySimplificationEPCallback (Not controlled by optimization > level), is it possible that things registered in > registerPipelineEarlySimplificationEPCallback be skipped? I think we won't end up running it at

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1125 +llvm::Type *selType = CGF.ConvertType(CGF.getContext().getObjCSelType()); +return llvm::UndefValue::get(selType); + } mwyman wrote: > nlopes wrote: > > mwyman wrote: > > >

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

gulfem added a comment. In D129755#3844059 , @aaronpuchert wrote: > In D129755#3843144 , @gulfem wrote: > >> We also started seeing `-Wthread-safety-precise` error in our Fuchsia code. >>

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

sammccall added a reviewer: aaron.ballman. sammccall added a subscriber: aaron.ballman. sammccall added a comment. This looks good to me, I think we should ask @aaron.ballman about the memory increase. If we wanted to eliminate SLocEntry::Offset then we could add

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:169 +// For renaming, we're only interested in foo's declaration, so drop the other one +void filterBaseUsingDecl(llvm::DenseSet& Decls) { + if (Decls.size() == 2) {

[PATCH] D135411: Add generic KCFI operand bundle lowering

kees added a comment. In D135411#3841841 , @samitolvanen wrote: > That being said, I did compile a 64-bit MIPS kernel using this pass, but I > didn't try booting it. I would expect to run into quite a few issues > initially. I've done a test build

[PATCH] D134597: [CMake] install clang resource headers into `CLANG_RESOURCE_DIR/include` if `CLANG_RESOURCE_DIR` is not empty

paperchalice updated this revision to Diff 466249. paperchalice added a comment. Herald added subscribers: llvm-commits, openmp-commits, Sanitizers, Enna1. Herald added projects: Sanitizers, OpenMP, LLVM. Let other projects consider CLANG_RESOURCE_DIR too. Repository: rG LLVM Github Monorepo

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

ChuanqiXu added a comment. I guess the reason why we didn't check odr violation for attributes is that the attributes was not a part of declarations in C++ before. But it is odd to skip the check for attributes from the perspective of users. So I think this one should be good. The only

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

owenpan added a comment. @MyDeveloperDay Cool! In D135466#3843792 , @HazardyKnusperkeks wrote: > Maybe even extend the option to other unnecessary semicolons like `int x = > 5;;` or other noop statements, one just has to be careful not to remove the

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

owenpan added a comment. In D129443#3842427 , @HazardyKnusperkeks wrote: > We can //fix// that regression, and I will adopt this change for my company > to keep the requires expressions where they are. :) Then we have three options: 1. Only fix the

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

sammccall added a comment. It'd be great to have some numbers for overall memory increase based on clang rather than clangd, that's a more critical case and has a different memory pattern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135440/new/

[PATCH] D133968: [clangd] Enable standard library index by default.

sammccall updated this revision to Diff 466243. sammccall added a comment. tickle premerge test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133968/new/ https://reviews.llvm.org/D133968 Files: clang-tools-extra/clangd/Config.h

[PATCH] D135384: [AIX] Enable the use of the -pg flag

francii updated this revision to Diff 466248. francii added a comment. Removed use of -no-opaque-pointers and call to "__mcount.aix" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files:

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3824657 , @MaskRay wrote: > mips computed sysroot from GCCInstallation very early in 2013 > rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 > and >

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5d21462d1e: BareMetal: detect usr/include/c++/v1 path in sysroot (authored by manojgupta). Changed prior to commit: https://reviews.llvm.org/D134478?vs=465647=466250#toc Repository: rG LLVM Github

[clang] 5e5d214 - BareMetal: detect usr/include/c++/v1 path in sysroot

Author: Manoj Gupta Date: 2022-10-07T21:25:18-07:00 New Revision: 5e5d21462d1ea7dbaa13bcd9bcf0156cee45b97c URL: https://github.com/llvm/llvm-project/commit/5e5d21462d1ea7dbaa13bcd9bcf0156cee45b97c DIFF: https://github.com/llvm/llvm-project/commit/5e5d21462d1ea7dbaa13bcd9bcf0156cee45b97c.diff

[PATCH] D135508: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof

sammccall added a comment. Sorry to dump more patches on you, but I want your opinion on whether we should carry such a hack. My initial inclination is no, but the class of bug is not very hard to understand, could plausibly come up in other clients, and the fix is fairly simple. I'd like to

[PATCH] D135508: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof

sammccall added a comment. (also the desyncs are incredibly annoying, and happen pretty much any time you clear all text out of a file) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135508/new/ https://reviews.llvm.org/D135508

[PATCH] D134303: [AST] Preserve more structure in UsingEnumDecl node.

sammccall added a reviewer: hokein. sammccall added a comment. ping, +additional potential reviewer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134303/new/ https://reviews.llvm.org/D134303 ___

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. A polite ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/ https://reviews.llvm.org/D134638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135506: [clangd] FindTarget: UsingEnumDecl is not an alias

sammccall created this revision. sammccall added a reviewer: tom-anders. Herald added subscribers: jeroen.dobbelaere, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

zixuan-wu added a comment. It's fine for CSKY to use config file. I only have 2 points. 1. I agree sysroot should be separated from GCC because sysroot is not dependent to GCC and there is even not gcc when we use llvm runtime. This rule should also apply to multilib logic. Sysroot can detect

[PATCH] D135495: [clang-tidy] handle pointers in `ExceptionAnalyzer`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:68 + + auto BPointeeUQTy = BPointeeTy->getUnqualifiedDesugaredType(); + auto TPointeeUQTy = TPointeeTy->getUnqualifiedDesugaredType(); Please

[PATCH] D135384: [AIX] Enable the use of the -pg flag

francii updated this revision to Diff 466252. francii added a comment. Removed __mcount.aix usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files: clang/test/CodeGen/mcount-aix.c

[PATCH] D133968: [clangd] Enable standard library index by default.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG79ed24eea37f: [clangd] Enable standard library index by default. (authored by sammccall). Repository: rG LLVM Github

[clang-tools-extra] 79ed24e - [clangd] Enable standard library index by default.

Author: Sam McCall Date: 2022-10-08T06:45:59+02:00 New Revision: 79ed24eea37f00b02d427f8ca59570546a5037a4 URL: https://github.com/llvm/llvm-project/commit/79ed24eea37f00b02d427f8ca59570546a5037a4 DIFF: https://github.com/llvm/llvm-project/commit/79ed24eea37f00b02d427f8ca59570546a5037a4.diff

[PATCH] D133968: [clangd] Enable standard library index by default.

sammccall added a comment. In D133968#3794850 , @kadircet wrote: > thanks, LG but seems to be failing on windows :/ This seemed very plausible but then none of the actual tests hit this codepath, and everything passes on rerun :-\ Repository: rG

[PATCH] D135384: [AIX] Enable the use of the -pg flag

francii updated this revision to Diff 466254. francii added a comment. Replace target pointers with opaque pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135384/new/ https://reviews.llvm.org/D135384 Files:

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

sammccall added a comment. Want to probe a bit at the behavior we're aiming for here. TL;DR is I think the handling is basically right but considering the general case tells us how to simplify filterBaseUsingDecl. --- The testcase is great to illustrate the common case. The thing we need to

[PATCH] D135489: [clangd] Fix rename for symbol introduced by UsingDecl

sammccall added a comment. (Thanks for fixing this BTW!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135489/new/ https://reviews.llvm.org/D135489 ___ cfe-commits mailing list

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. This LGTM for apple's runtime assuming it knows how to handle the new string. Comment at: clang/lib/AST/ASTContext.cpp:7857 + if (PD->isOptional()) { +S += ",?";

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a reviewer: rsmith. ChuanqiXu added a comment. In D134267#3815453 , @dblaikie wrote: >> This also tries to fix the problem I raised a year ago: >>

[PATCH] D135508: [clangd] Heuristic to avoid desync if editors are confused about newline-at-eof

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. As

[clang] 74e4f77 - [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

Author: Haojian Wu Date: 2022-10-07T09:16:08+02:00 New Revision: 74e4f778cf16cbf7163b5c6de6027a43f5e9169f URL: https://github.com/llvm/llvm-project/commit/74e4f778cf16cbf7163b5c6de6027a43f5e9169f DIFF: https://github.com/llvm/llvm-project/commit/74e4f778cf16cbf7163b5c6de6027a43f5e9169f.diff

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG74e4f778cf16: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation. (authored by

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:447 +APInt Val(getIntWidth(LitType), E->getValue()); +return this->emitConst(*T, 0, Val, E); + } The `0` here is unused in `emitConst` anyway. I have a follow-up NFC

[PATCH] D135091: Create storage for the `_cmd` argument to the helper function for generated getters/setters of `direct` Objective-C properties.

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1125 +llvm::Type *selType = CGF.ConvertType(CGF.getContext().getObjCSelType()); +return llvm::UndefValue::get(selType); + } Please consider using PoisonValue here instead (if

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a0d9ecd5d7: [SourceManager] Improve getFileIDLocal. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a6a0d9e - [SourceManager] Improve getFileIDLocal.

Author: Haojian Wu Date: 2022-10-07T09:37:04+02:00 New Revision: a6a0d9ecd5d744316e699fa78a053376bb659dd1 URL: https://github.com/llvm/llvm-project/commit/a6a0d9ecd5d744316e699fa78a053376bb659dd1 DIFF: https://github.com/llvm/llvm-project/commit/a6a0d9ecd5d744316e699fa78a053376bb659dd1.diff

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

njames93 added a comment. Why limit this to just the value type traits, makes sense to also support type type traits. Comment at: clang-tools-extra/clang-tidy/modernize/TypeTraitsCheck.cpp:73 +const auto *RecordQualifier = +cast_if_present( +

[clang] 83d93d3 - [clang] Fix a warning

Author: Kazu Hirata Date: 2022-10-06T23:59:34-07:00 New Revision: 83d93d3c11ac9727bf3d4c5c956de44233cc7f87 URL: https://github.com/llvm/llvm-project/commit/83d93d3c11ac9727bf3d4c5c956de44233cc7f87 DIFF: https://github.com/llvm/llvm-project/commit/83d93d3c11ac9727bf3d4c5c956de44233cc7f87.diff

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein updated this revision to Diff 465988. hokein marked an inline comment as done. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135132/new/ https://reviews.llvm.org/D135132 Files:

[PATCH] D135132: [SourceManager] Improve getFileIDLocal.

hokein added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:797 - LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() < SLocOffset) { -// Neither loc prunes our search. -I = LocalSLocEntryTable.end(); nickdesaulniers wrote: >

[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

python3kgae created this revision. python3kgae added reviewers: efriedma, pow2clk, beanz, bogner. Herald added subscribers: Anastasia, hiraditya. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466037. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367 Files:

[PATCH] D135361: [clang][Interp] Implement bitwise Or operations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135361/new/ https://reviews.llvm.org/D135361 ___ cfe-commits mailing list

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

nlopes accepted this revision. nlopes added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135392/new/ https://reviews.llvm.org/D135392

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1789 + auto inserted = ConstructedObjects.insert({Exp, Placeholder.first}); + assert(inserted.second && "Are we visiting the same expression again?"); + if (isa(Exp))

[clang] 14e2592 - [clang][CodeGen] Use poison instead of undef as placeholder in ARM builtins [NFC]

Author: Manuel Brito Date: 2022-10-07T12:50:59+01:00 New Revision: 14e2592ff6112d1869ba1533d058822200162bf1 URL: https://github.com/llvm/llvm-project/commit/14e2592ff6112d1869ba1533d058822200162bf1 DIFF: https://github.com/llvm/llvm-project/commit/14e2592ff6112d1869ba1533d058822200162bf1.diff

[PATCH] D135392: Use PoisonValue in vector BIs [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG14e2592ff611: [clang][CodeGen] Use poison instead of undef as placeholder in ARM builtins… (authored by ManuelJBrito, committed by nlopes). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4627cef - [OpenMP][OMPIRBuilder] Migrate emitOffloadingArraysArgument from clang

Author: Jan Sjodin Date: 2022-10-07T07:03:03-05:00 New Revision: 4627cef1134f99f3802a5ebfe26188d2c66da22f URL: https://github.com/llvm/llvm-project/commit/4627cef1134f99f3802a5ebfe26188d2c66da22f DIFF: https://github.com/llvm/llvm-project/commit/4627cef1134f99f3802a5ebfe26188d2c66da22f.diff

[PATCH] D134662: [OpenMPIRBuilder] Migrate emitOffloadingArraysArgument from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG4627cef1134f: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArraysArgument from clang (authored by jsjodin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[PATCH] D135397: [clang][dataflow] Add support for a Top value in boolean formulas.

ymandel added a comment. Thanks for the thorough reviews! Agreed on all points, and will address. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:157 + TopValue () { +return takeOwnership(std::make_unique()); + }

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

tbaeder updated this revision to Diff 466022. tbaeder added a comment. Add `break` and `continue` support as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135433/new/ https://reviews.llvm.org/D135433 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b771b9fc2f: Keep inherited dllimport/export attrs for explicit specialization of class… (authored by hans). Changed prior to commit: https://reviews.llvm.org/D135154?vs=464984=466023#toc Repository:

[clang] c9b771b - Keep inherited dllimport/export attrs for explicit specialization of class template member functions

Author: Hans Wennborg Date: 2022-10-07T12:24:19+02:00 New Revision: c9b771b9fc2f17cccd9ccbf8f1d52e2642679b8a URL: https://github.com/llvm/llvm-project/commit/c9b771b9fc2f17cccd9ccbf8f1d52e2642679b8a DIFF: https://github.com/llvm/llvm-project/commit/c9b771b9fc2f17cccd9ccbf8f1d52e2642679b8a.diff

[PATCH] D135154: Keep inherited dllimport/export attrs for explicit specialization of template class member functions

hans added a comment. Looking at the Chromium code some more, the case of trying to delete a specialization of a dllexport class template member seems suspect. Since the error also matches MSVC I think we should keep that behavior, but I'll add a release note about it. Repository: rG LLVM

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 466027. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 466031. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h clang/lib/AST/Interp/ByteCodeExprGen.cpp

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff created this revision. sepavloff added reviewers: MaskRay, mgorny. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. Class

[PATCH] D135440: [SourceManager] Speedup getFileIDLocal with a separate Offset Table.

hokein created this revision. hokein added reviewers: sammccall, nickdesaulniers. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project: clang. This patch introduces a separate

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel added a comment. It wasn't an accidental regression, though, it was a conscious formatting decision (maybe ask @HazardyKnusperkeks for more). Similar to how lambdas can be formatted aligned to the introducer, i think this option does make sense. Repository: rG LLVM Github Monorepo

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void marked an inline comment as done. void added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:2 // REQUIRES: x86-registered-target -// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0 -fsanitize=array-bounds%s -o - | FileCheck

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void updated this revision to Diff 466011. void added a comment. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Update comments to reflect reality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

kadircet added a comment. I wasn't claiming that there are legitimate reasons for having null children, I completely agree with your verdict on this one. The only one I can think of is cases like this, i.e. you don't want to perform some analysis if function body has invalid code in it. but i

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

ilya-biryukov added a comment. To be clear: landing this change seems fine, I was not trying to block it, sorry if it seemed that way. I'm just trying to understand whether it would also make sense to change the defaults. I believe we are on the same page here, it's just a matter of booking

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3841248 , @owenpan wrote: > Is this option really required? Can we just fix the regression as reported in > https://github.com/llvm/llvm-project/issues/56283? It seems that we haven't > followed the policy

[PATCH] D135433: [clang][Interp] Implement while and do-while loops

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I was wondering whether it is somehow possible to

[clang-tools-extra] e09aa0d - [clangd][Tweak] Make sure enclosing function doesnt have invalid children

Author: Kadir Cetinkaya Date: 2022-10-07T12:00:22+02:00 New Revision: e09aa0d192e0ae240c55aaf8205e8320d49f9bdb URL: https://github.com/llvm/llvm-project/commit/e09aa0d192e0ae240c55aaf8205e8320d49f9bdb DIFF:

[PATCH] D135257: [clangd][Tweak] Make sure enclosing function doesnt have invalid children

This revision was automatically updated to reflect the committed changes. Closed by commit rGe09aa0d192e0: [clangd][Tweak] Make sure enclosing function doesnt have invalid children (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

This revision was automatically updated to reflect the committed changes. Closed by commit rG02c1c939486f: [LLDB] Fix printing a static bool struct member when using image lookup -t (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5a9e213 - [LLDB] Fix crash when printing a struct with a static signed char member

Author: David Spickett Date: 2022-10-07T09:11:15Z New Revision: 5a9e21305803336dc359f72014849845b1a7e173 URL: https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173 DIFF: https://github.com/llvm/llvm-project/commit/5a9e21305803336dc359f72014849845b1a7e173.diff

[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9e21305803: [LLDB] Fix crash when printing a struct with a static signed char member (authored by DavidSpickett). Repository: rG LLVM Github

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

HazardyKnusperkeks added a comment. Please add a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 ___ cfe-commits mailing list

[clang] d779356 - [SourceManager] Fix the incorrect counting stats in getFileIDLoaded.

Author: Haojian Wu Date: 2022-10-07T14:24:31+02:00 New Revision: d779356043a895280d0880551ef33d663fe36c7e URL: https://github.com/llvm/llvm-project/commit/d779356043a895280d0880551ef33d663fe36c7e DIFF: https://github.com/llvm/llvm-project/commit/d779356043a895280d0880551ef33d663fe36c7e.diff

[clang] a4afa2b - Revert "Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls"

Author: Hans Wennborg Date: 2022-10-07T14:30:36+02:00 New Revision: a4afa2bde6f4db215ddd3267a8d11c04367812e5 URL: https://github.com/llvm/llvm-project/commit/a4afa2bde6f4db215ddd3267a8d11c04367812e5 DIFF: https://github.com/llvm/llvm-project/commit/a4afa2bde6f4db215ddd3267a8d11c04367812e5.diff

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. We're hitting a false positive in grpc after this: > ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: error: calling function 'TlsSessionKeyLoggerCache' requires holding mutex 'g_tls_session_key_log_cache_mu' exclusively

[PATCH] D135362: [clang] Make variables of undeduced types to have dependent alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a42c90b778c: [clang] Make variables of undeduced types to have dependent alignment (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5a42c90 - [clang] Make variables of undeduced types to have dependent alignment

Author: Aleksandr Platonov Date: 2022-10-07T20:40:03+08:00 New Revision: 5a42c90b778c65238a54f0f1d8c8d6b35e2f6007 URL: https://github.com/llvm/llvm-project/commit/5a42c90b778c65238a54f0f1d8c8d6b35e2f6007 DIFF:

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaron.ballman added a comment. In D129755#3842729 , @hans wrote: > We're hitting a false positive in grpc after this: > > > ../../third_party/grpc/src/src/core/lib/gprpp/ref_counted_ptr.h:335:31: > error: calling function 'TlsSessionKeyLoggerCache'

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman updated this revision to Diff 466052. aaron.ballman added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Updated to fix the clangd unit test breakage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134813/new/

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

hans added a comment. We also hit a different case: https://bugs.chromium.org/p/chromium/issues/detail?id=1372394#c6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129755/new/ https://reviews.llvm.org/D129755

[clang] 853df5e - [Concepts] Fix friend duplicate detection when referencing containing Record

Author: Erich Keane Date: 2022-10-07T06:14:11-07:00 New Revision: 853df5e1d63684cbf3bf3da63d3e467003262282 URL: https://github.com/llvm/llvm-project/commit/853df5e1d63684cbf3bf3da63d3e467003262282 DIFF: https://github.com/llvm/llvm-project/commit/853df5e1d63684cbf3bf3da63d3e467003262282.diff

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 466056. lime added a comment. > The changes in Sema.h and the changes of CalculateTemplateDepthForConstraints I think it might be fine now. The above changes are related to `NormalizationCache`. This cache used to take `NamedDecl` as its key. However, as

<    1   2