[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3911005 , @sstwcw wrote: > Here is one problem: > > clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1, > IndentWidth: 4, IndentCaseLabels: true}' > > actual: > #define X

[clang] f4707af - [clang][Interp][NFCI] Cleanup emitConst()

Author: Timm Bäder Date: 2022-11-07T09:05:29+01:00 New Revision: f4707af2944015732b1f35e1bc66cc62f489cef2 URL: https://github.com/llvm/llvm-project/commit/f4707af2944015732b1f35e1bc66cc62f489cef2 DIFF: https://github.com/llvm/llvm-project/commit/f4707af2944015732b1f35e1bc66cc62f489cef2.diff

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

nridge updated this revision to Diff 473588. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137056/new/ https://reviews.llvm.org/D137056 Files: clang-tools-extra/clangd/test/system-include-extractor.test

[clang-tools-extra] 41fa7d2 - [clangd] Fix a small inconsistency in system-include-extractor.test

Author: Nathan Ridge Date: 2022-11-07T03:29:42-05:00 New Revision: 41fa7d2093e0b7ff5f729b318643e8e18feb URL: https://github.com/llvm/llvm-project/commit/41fa7d2093e0b7ff5f729b318643e8e18feb DIFF: https://github.com/llvm/llvm-project/commit/41fa7d2093e0b7ff5f729b318643e8e18feb.diff

[PATCH] D137409: [clang-format][NFCish] Alphabetical sort Format.(h|pp)

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:23323 "WhitespaceSensitiveMacros: ['FOO', 'BAR']"))); - std::vector

[PATCH] D137056: [clangd] Fix a small inconsistency in system-include-extractor.test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41fa7d2093e0: [clangd] Fix a small inconsistency in system-include-extractor.test (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 473595. tbaeder added a comment. Return `opStatus` from `convertToInteger` as well, and add a test case to `floats.cpp` that tests float-to-integer conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but let's wait others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136906/new/ https://reviews.llvm.org/D136906

[clang] c8341a6 - [clang][Interp][NFC] Avoid a getSource() call in the common case

Author: Timm Bäder Date: 2022-11-07T09:42:41+01:00 New Revision: c8341a66159703de242ab8de362b59548cdda71e URL: https://github.com/llvm/llvm-project/commit/c8341a66159703de242ab8de362b59548cdda71e DIFF: https://github.com/llvm/llvm-project/commit/c8341a66159703de242ab8de362b59548cdda71e.diff

[clang] 6b3e5c5 - [clang][Interp][NFC] Remove unused function

Author: Timm Bäder Date: 2022-11-07T09:42:41+01:00 New Revision: 6b3e5c595b6930ae87aef6d75377663d238c0921 URL: https://github.com/llvm/llvm-project/commit/6b3e5c595b6930ae87aef6d75377663d238c0921 DIFF: https://github.com/llvm/llvm-project/commit/6b3e5c595b6930ae87aef6d75377663d238c0921.diff

[clang] 5dfacb1 - [clang][Interp][NFC] Replace dyn_cast_or_null with _if_present

Author: Timm Bäder Date: 2022-11-07T09:42:41+01:00 New Revision: 5dfacb12452026eb9492d046e816fafa0ff5915c URL: https://github.com/llvm/llvm-project/commit/5dfacb12452026eb9492d046e816fafa0ff5915c DIFF: https://github.com/llvm/llvm-project/commit/5dfacb12452026eb9492d046e816fafa0ff5915c.diff

[clang] 5bd6bd1 - [clang][Interp][NFC] Simplify visitReturnStmt()

Author: Timm Bäder Date: 2022-11-07T09:42:41+01:00 New Revision: 5bd6bd12276ff5e5c38002cf607976e8ac9ed8a6 URL: https://github.com/llvm/llvm-project/commit/5bd6bd12276ff5e5c38002cf607976e8ac9ed8a6 DIFF: https://github.com/llvm/llvm-project/commit/5bd6bd12276ff5e5c38002cf607976e8ac9ed8a6.diff

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:592 + Arg = IC->getSubExprAsWritten(); +if (auto *UO = dyn_cast(Arg)) { + if (UO->getOpcode() == UO_AddrOf) nridge wrote: > Could you add a test case

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

nridge added a comment. In D137040#3909906 , @tom-anders wrote: > We now probably also need a unit test for Sema that tests the new flag, right? Good point. My understanding is that most test coverage of libSema's code completion takes the form of lit

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:502 + let Types = [AluTypeClass]; + let Args = [ArgFltSemantics]; + let HasGroup = 1; sepavloff wrote: > tbaeder wrote: > > jcranmer-intel wrote: > > > Integer-to-floating point

[PATCH] D137252: [include-cleaner] Testing helpers for ast walking

hokein added a comment. In D137252#3907743 , @kadircet wrote: > In D137252#3907665 , @hokein wrote: > >> Just share my experience when reading the code, overall I have a feeling >> that we're regressing the code

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kadircet added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:35 +// Concat BasicType, LMUL and Proto as key +static std::unordered_map LegalTypes; +static std::set IllegalTypes; these were previously owned by `RVVEmitter`, hence we

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3910800 , @goldstein.w.n wrote: > In D137181#3910799 , @owenpan wrote: > >> IMO we should find a simpler way to indent bodies of macro definitions that >> are nested more

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

steakhal added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136603/new/ https://reviews.llvm.org/D136603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d causes compilation timeout on some of our internal files. We're trying to get a test case we can share, but so far the only information I can

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

diseraluca added a comment. I finally had some time to look into the pre-merge failure. I couldn't replicate it on my machine by following https://buildkite.com/llvm-project/premerge-checks/builds/119952#01843856-e8c7-4709-89c6-d52d0286862a . Looking at the log it does not seem related to the

[clang] 39dbfa7 - Revert "Only add targetFallback if target is not in defined in current product"

Author: Daniel Grumberg Date: 2022-11-07T13:33:59Z New Revision: 39dbfa72aaebe64e913d65f1eeab48c5f33b8010 URL: https://github.com/llvm/llvm-project/commit/39dbfa72aaebe64e913d65f1eeab48c5f33b8010 DIFF: https://github.com/llvm/llvm-project/commit/39dbfa72aaebe64e913d65f1eeab48c5f33b8010.diff

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM except 2 nits. And let's wait others. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:174 +const std::vector ) const { + + if (getTriple().getArch() ==

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin updated this revision to Diff 473620. gonglingqin added a comment. Delete blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137316/new/ https://reviews.llvm.org/D137316 Files: clang/include/clang/Basic/BuiltinsLoongArch.def

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining updated this revision to Diff 473627. SixWeining added a comment. Add test for warning: argument unused during compilation. And address other comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136146/new/

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:174 +const std::vector ) const { + + if (getTriple().getArch() == llvm::Triple::loongarch64) SixWeining wrote: > Delete blank line. Thanks, I will delete it.

[PATCH] D137252: [include-cleaner] Testing helpers for ast walking

sammccall added a comment. Agree there are readability concerns here (long macro names, out-of-line kinds, complicated macros). My suggestion would be to treat RefKind as an optional feature. Most tests would just assert the set of marked locations and test the cases where kind is interesting

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

sammccall added a comment. I admire the goals of this patch, but I think it needs some explanation "why we expect this to be roughly correct/safe", rather than just trying to think of cases that might go wrong and patch them. The test coverage for incorrect code is not good, I'd expect to need

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

frasercrmck added a comment. In D137516#3911245 , @arsenm wrote: > I think this is fine, but think the name needs to be bikeshedded. "Target" > and "Support" are already overloaded enough as it is. Is there anything else > that would really ever go

[PATCH] D137409: [clang-format][NFCish] Alphabetical sort Format.(h|pp)

owenpan added a comment. Don't forget to run dump_format_style.py before landing. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137409/new/ https://reviews.llvm.org/D137409 ___ cfe-commits mailing

[PATCH] D137486: [clang-format] Correctly annotate function names before attributes

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:76 +static bool isCppAttribute(bool IsCpp, const FormatToken ) { + if (!IsCpp || !Tok.startsSequence(tok::l_square, tok::l_square)) +return false; HazardyKnusperkeks wrote: >

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:5392-5394 + case tok::amp: + case tok::ampamp: +return getLangOpts().CPlusPlus; aaron.ballman wrote: > Looking for `*`, `&`, and `&&` will help catch some cases... but it's not >

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

This revision was automatically updated to reflect the committed changes. Closed by commit rG671709f0e7d4: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f63db91 - Only add targetFallback if target is not in defined in current product

Author: Daniel Grumberg Date: 2022-11-07T13:12:34Z New Revision: f63db91590db98e13cb4440fdaa5c40e219b URL: https://github.com/llvm/llvm-project/commit/f63db91590db98e13cb4440fdaa5c40e219b DIFF: https://github.com/llvm/llvm-project/commit/f63db91590db98e13cb4440fdaa5c40e219b.diff

[clang] 671709f - [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

Author: Daniel Grumberg Date: 2022-11-07T13:12:34Z New Revision: 671709f0e7d49826fd0908be2c9aed07debf5bc9 URL: https://github.com/llvm/llvm-project/commit/671709f0e7d49826fd0908be2c9aed07debf5bc9 DIFF: https://github.com/llvm/llvm-project/commit/671709f0e7d49826fd0908be2c9aed07debf5bc9.diff

[PATCH] D137545: [clang][Interp] DerivedToBase casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10634 "OpenMP constructs may not be nested inside an atomic region">; +def err_omp_prohibited_region_order +: Error<"construct %0 not allowed in a region associated with a

[PATCH] D137524: clang/AMDGPU: Emit atomicrmw for atomic_inc/dec builtins

foad added a comment. In D137524#3911439 , @JonChesterfield wrote: > Do you know where the uinc_wrap etc were introduced? D137361 in the stack for this patch. CHANGES SINCE LAST ACTION

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

isuckatcs accepted this revision. isuckatcs added a comment. This revision is now accepted and ready to land. I have nothing else to add, this patch looks good to me. If the others don't have anything to add either, feel free to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

sammccall added a comment. I don't think we should add significant build-system complexity here in order to support the completion model on ppc32. Do people actually use clangd on ppc32 machines? (The linked bug calls this a clang build failure, but this code is not part of clang). If we need

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

ckandeler updated this revision to Diff 473603. ckandeler marked an inline comment as done. ckandeler added a comment. Rebased and updated comment as indicated in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder updated this revision to Diff 473608. tbaeder added a comment. Report overflows when converting floats to integers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 Files: clang/lib/AST/CMakeLists.txt clang/lib/AST/Interp/Boolean.h

[clang-tools-extra] 2bf960a - [clangd] Add "usedAsMutablePointer" highlighting modifier

Author: Christian Kandeler Date: 2022-11-07T11:58:33+01:00 New Revision: 2bf960aef08e93d687f21e6d636186561b56cbf3 URL: https://github.com/llvm/llvm-project/commit/2bf960aef08e93d687f21e6d636186561b56cbf3 DIFF:

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bf960aef08e: [clangd] Add usedAsMutablePointer highlighting modifier (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130015/new/

[PATCH] D130015: [clangd] Add "usedAsMutablePointer" highlighting modifier

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:592 + Arg = IC->getSubExprAsWritten(); +if (auto *UO = dyn_cast(Arg)) { + if (UO->getOpcode()

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

qiucf created this revision. qiucf added reviewers: nemanjai, lkail, shchenz, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

Ericson2314 added a comment. This change introduces a lot of conditional code, that is not necessary. This change also uses `CLANG_` outside `clang/` which is messy. and confusing. Please clean up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/

[PATCH] D137558: [clang][Interp] Reject reinterpret_casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An appropriate diagnostic has already been emitted

[clang] 6ebca03 - [Clang] Update test after wasm intrinsics attribute change (NFC)

Author: Nikita Popov Date: 2022-11-07T17:42:35+01:00 New Revision: 6ebca0302126c43ec8614d26aa444060e7a6da76 URL: https://github.com/llvm/llvm-project/commit/6ebca0302126c43ec8614d26aa444060e7a6da76 DIFF: https://github.com/llvm/llvm-project/commit/6ebca0302126c43ec8614d26aa444060e7a6da76.diff

[PATCH] D137563: [clang][Interp] Check declarations for constexpr-ness in Load() instructions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refering to non-constexpr variables in a constant

[PATCH] D137564: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

tmatheson created this revision. tmatheson added reviewers: lenary, pratlucas, DavidSpickett. Herald added subscribers: hiraditya, kristof.beyls, dschuff. Herald added a project: All. tmatheson requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits,

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Followup to D134378 . With PrintingPolicy::SuppressScope, we'd also

[PATCH] D137584: Add const information about AST nodes used to construct CFG elements.

merrymeerkat created this revision. Herald added a reviewer: NoQ. Herald added a project: All. merrymeerkat requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most constructors and destructors in CFG.h already specify const arguments, but

[PATCH] D137531: [clang] Fix the GitHub issue #58674

cor3ntin added a comment. Thanks for working on this. I agree with Aaron, can you make the commit message clearer as to what is fixed, and mention in clang/docs/ReleaseNotes that the issue is fixed. Comment at: clang/lib/Sema/SemaExpr.cpp:2698-2704 + if (!SS.isEmpty()) +

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473779. ayzhao added a comment. remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473789. ayzhao added a comment. s/pro20/post20/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. In D137205#3913192 , @Febbe wrote: > In D137205#3912243 , @Skylion007 > wrote: > >> One other bug I found with this diff, is it seems to suggest calling >> std::move() on function

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Generally LGTM, though I found a few minor things. Comment at: clang/include/clang/AST/Decl.h:546 + + enum Flags : unsigned { F_Inline = 1 << 0, F_Nested = 1

[clang] cafe50d - Explicitly initialize opaque pointer mode in CodeGenAction

Author: Matthias Braun Date: 2022-11-07T12:31:28-08:00 New Revision: cafe50daf525971ffc3b8c5f2f6343d24e381384 URL: https://github.com/llvm/llvm-project/commit/cafe50daf525971ffc3b8c5f2f6343d24e381384 DIFF:

[PATCH] D137475: Explicitly initialize opaque pointer mode in CodeGenAction

This revision was automatically updated to reflect the committed changes. Closed by commit rGcafe50daf525: Explicitly initialize opaque pointer mode in CodeGenAction (authored by MatzeB). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137475/new/

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 473770. Febbe added a comment. Fixed lValueReference detection in matcher Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files:

[clang] 41ce74e - [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

Author: Sami Tolvanen Date: 2022-11-07T23:05:28Z New Revision: 41ce74e6e983f523d44d3a80be5ae778c35df85a URL: https://github.com/llvm/llvm-project/commit/41ce74e6e983f523d44d3a80be5ae778c35df85a DIFF: https://github.com/llvm/llvm-project/commit/41ce74e6e983f523d44d3a80be5ae778c35df85a.diff

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

This revision was automatically updated to reflect the committed changes. Closed by commit rG41ce74e6e983: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict (authored by samitolvanen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#3912243 , @Skylion007 wrote: > One other bug I found with this diff, is it seems to suggest calling > std::move() on function args that are references, despite the fact that > invalidating the reference to the input

[clang] 86674f6 - [HLSL] Added HLSL this as a reference

Author: Grace Jennings Date: 2022-11-07T13:50:08-08:00 New Revision: 86674f66cc78a1a121d43fe51f076cbfa8710b1a URL: https://github.com/llvm/llvm-project/commit/86674f66cc78a1a121d43fe51f076cbfa8710b1a DIFF:

[PATCH] D135721: [HLSL] Added HLSL this as a reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG86674f66cc78: [HLSL] Added HLSL this as a reference (authored by gracejennings, committed by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman added a comment. I'd like to see some test coverage for what these changes catch that wasn't caught before. On its face, this seems reasonable in that we don't want to bother running the interpreter (further) once we know we've hit an expression, declaration, or type that's not

[clang] f64802e - [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

Author: Amara Emerson Date: 2022-11-07T15:04:09-08:00 New Revision: f64802e8d3e9db299cad913ffcb734c8d35dc5f0 URL: https://github.com/llvm/llvm-project/commit/f64802e8d3e9db299cad913ffcb734c8d35dc5f0 DIFF: https://github.com/llvm/llvm-project/commit/f64802e8d3e9db299cad913ffcb734c8d35dc5f0.diff

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf64802e8d3e9: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64… (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D137269?vs=472753=473807#toc Repository:

[PATCH] D137401: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG428ac8f3a0f9: [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3909043 , @zahiraam wrote: > In D136786#3907235 , > @michele.scandale wrote: > >> In D136786#3903646 , @zahiraam >> wrote: >> >>>

[clang] cd8c6ab - [NFC] clang-format part of TypePrinter.cpp

Author: Arthur Eubanks Date: 2022-11-07T13:20:36-08:00 New Revision: cd8c6ab084c05b50c41163cd9f415a4c70aea8e9 URL: https://github.com/llvm/llvm-project/commit/cd8c6ab084c05b50c41163cd9f415a4c70aea8e9 DIFF:

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 473772. ayzhao added a comment. whoops, uploaded the wrong commit. should be fixed now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files:

[PATCH] D137484: [Test] Fix driverkit-path.c with lib64 dir

yln accepted this revision. yln added a comment. This revision is now accepted and ready to land. Looks harmless enough.. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137484/new/ https://reviews.llvm.org/D137484

[clang-tools-extra] afa22c5 - [clangd] Pass the entire tooling::CompileCommand to CommandMangler

Author: Nathan Ridge Date: 2022-11-07T17:58:37-05:00 New Revision: afa22c563f12f22da93b8f172d18c7991392d071 URL: https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071 DIFF: https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071.diff

[clang-tools-extra] 68e230a - [clangd] Perform system include extraction inside CommandMangler

Author: Nathan Ridge Date: 2022-11-07T17:58:39-05:00 New Revision: 68e230aa29f71ed840a0ea9c0be97c8c6ead1c69 URL: https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69 DIFF: https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69.diff

[PATCH] D133756: [clangd] Pass the entire tooling::CompileCommand to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGafa22c563f12: [clangd] Pass the entire tooling::CompileCommand to CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 428ac8f - [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

Author: Nathan Ridge Date: 2022-11-07T17:58:42-05:00 New Revision: 428ac8f3a0f9572fcff03c2fae62c4ae8420a0df URL: https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df DIFF: https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df.diff

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68e230aa29f7: [clangd] Perform system include extraction inside CommandMangler (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. One other bug I found with this diff, is it seems to suggest calling std::move() on function args that are references, despite the fact that invalidating the reference to the input arg could be undesirable. For instance take a function that takes in a reference to a

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

aaron.ballman added inline comments. Comment at: clang/docs/SafeBuffers.rst:31 +convert large amounts of old code to conform to the warning; + - Attribute ``[[unsafe_buffer_usage]]`` lets you annotate custom functions as +unsafe, while providing a safe alternative that

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 473708. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp clang/test/AST/Interp/cxx20.cpp Index:

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta added a reviewer: hans. thieta added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137322/new/ https://reviews.llvm.org/D137322 ___ cfe-commits mailing list

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD added a comment. Upon additional modification to this code base I am tempt to prefer having a `NumberOfCategories` under the enum and make the sanity check explicit. I understand this is totally a problem of personal taste so definitely feel free to argue with me :) Repository: rG

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/lib/TargetSupport/CMakeLists.txt:2 + +set(LLVM_TARGET_DEFINITIONS ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/RISCV.td) + tmatheson wrote: > Here `RISCVTargetSupportTableGen` depends on files in `lib/Target/RISCV`, >

[PATCH] D135721: [HLSL] Added HLSL this as a reference

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/test/AST/HLSL/RWBuffer-AST.hlsl:49-50 // CHECK-NEXT: ArraySubscriptExpr 0x{{[0-9A-Fa-f]+}} <> 'element_type' lvalue -//

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 473679. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Dedup code, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files:

[PATCH] D137372: [AIX][pg] Add 32-bit Test Case to Linker Tests

cebowleratibm added a comment. Use the [Test] tag in the abstract. Suggest: "[Test][AIX][pg] Add 32-bit expected driver output" No need for a summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137372/new/ https://reviews.llvm.org/D137372

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:509 -def : ProcessorModel<"generic-rv32", NoSchedModel, [Feature32Bit]>; -def : ProcessorModel<"generic-rv64", NoSchedModel, [Feature64Bit]>; +class RISCVProcessorModelPROC { + string Enum = enum;

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli added a comment. In D137516#3912842 , @lenary wrote: > In D137516#3912751 , @fpetrogalli > wrote: > >> @arsenm @frasercrmck @lenary - thank you for the feedback >> >> 1. The library could host

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with nits Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:47 +// MESSAGELEN: 0x{{.+}} | LF_BUILDINFO [size = {{.+}}] +// MESSAGELEN-NOT: 0x{{.+}}:

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Friendly ping, does anyone else have any more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 ___ cfe-commits mailing list

[PATCH] D134231: [clang][C++20] p0960 Allow initializing aggregates from a parenthesized list of values

aaron.ballman added a comment. In D134231#3910882 , @ecatmur wrote: > In D134231#3803380 , @shafik wrote: > >> Hello Ed, thank you for picking up this work. >> >> I liked the approach in the first PR, did you

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r updated this revision to Diff 473662. Trass3r edited the summary of this revision. Trass3r added a comment. remove bases codelens for classes fix lit test exclude self from ref count Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131295/new/

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii added a comment. In D137375#3906777 , @MaskRay wrote: > This needs a clang/test/Driver test. And, does this work with --sysroot= ? Thanks for your comment. It seems there will need to be a separate patch for `--sysroot`. From my initial

[PATCH] D131295: [clangd] Implement textDocument/codeLens

Trass3r added inline comments. Comment at: clang-tools-extra/clangd/CodeLens.cpp:93 + if (auto Loc = declToLocation(P->getCanonicalDecl())) +Super.locations.emplace_back(*Loc); +} As noted in the previous PR it may be of low value, I guess only

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

lenary added a comment. In D137516#3912751 , @fpetrogalli wrote: > @arsenm @frasercrmck @lenary - thank you for the feedback > > 1. The library could host anything that needs to be auto-generated with > tablegen. If we add `MVT`s, the name

[PATCH] D137475: Explicitly initialize opaque pointer mode in CodeGenAction

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137475/new/ https://reviews.llvm.org/D137475 ___

[PATCH] D133757: [clangd] Perform system include extraction inside CommandMangler

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Woohoo, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133757/new/ https://reviews.llvm.org/D133757

[PATCH] D136811: -Wunsafe-buffer-usage: WIP: RFC: NFC: User documentation.

xazax.hun added inline comments. Comment at: clang/docs/SafeBuffers.rst:124 + - Array subscript expression on raw arrays or raw pointers, + - unless the index is a compile-time constant ``0``, + - Increment and decrement of a raw pointer with operators ``++`` and ``--``;

  1   2   >