[PATCH] D138458: [Clang][Driver] Add KCFI to SupportsCoverage

MaskRay added inline comments. Comment at: clang/test/CodeGen/sanitize-coverage.c:94 + // CHECK-NOT: call void @__sanitizer_cov_trace_const_cmp + // KCFI-NOT: call void %{{.}}() [ "kcfi"(i32 {{.*}}) ] + f(); samitolvanen wrote: > MaskRay wrote: > > `%c()` > >

[PATCH] D138466: Don't use Optional::getPointer (NFC)

kazu added a comment. Thanks for the review! In D138466#3942622 , @MaskRay wrote: > `getPointer` asserts `hasValue`, so `&*` is safe, Yes. `operator*` also asserts `hasVal` via `value()`, so we maintain the same level of safety. Repository: rG

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kadircet added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:289 + + static uint64_t computeRVVTypeHashValue(BasicType BT, int Log2LMUL, + PrototypeDescriptor Proto); khchen wrote: >

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

xazax.hun added a comment. I am a bit conflicted. It is unfortunate that C and C++ compilers regarded single element array members as flexible array members. On the other hand, looking at GCC, it recently added -fstrict-flex-arrays=2

[PATCH] D138466: Don't use Optional::getPointer (NFC)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. `getPointer` asserts `hasValue`, so `&*` is safe, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138466/new/ https://reviews.llvm.org/D138466

[PATCH] D138464: Return None instead of Optional() (NFC)

kazu added a comment. Thanks for the review! In D138464#3942626 , @MaskRay wrote: > We have `return llvm::None;` and `return None;`. Shall we always prefer > `llvm::None`? Either one is OK (to me). I can deprecate `None` in my personal tree, and get

[clang] 1f91494 - Don't use Optional::getPointer (NFC)

Author: Kazu Hirata Date: 2022-11-21T19:03:40-08:00 New Revision: 1f914944b6c9a5e4229ceb9f06140fdf178c5ea0 URL: https://github.com/llvm/llvm-project/commit/1f914944b6c9a5e4229ceb9f06140fdf178c5ea0 DIFF: https://github.com/llvm/llvm-project/commit/1f914944b6c9a5e4229ceb9f06140fdf178c5ea0.diff

[PATCH] D138466: Don't use Optional::getPointer (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f914944b6c9: Dont use Optional::getPointer (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry abandoned this revision. v1nh1shungry added a comment. Sorry for the delay. I'd say I was convinced and about to abandon this patch. Sincere apologies for wasting everyone's time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6ba4b62 - Return None instead of Optional() (NFC)

Author: Kazu Hirata Date: 2022-11-21T19:06:42-08:00 New Revision: 6ba4b62af8df00edb7e1cc0c473f6770fb1cfe3b URL: https://github.com/llvm/llvm-project/commit/6ba4b62af8df00edb7e1cc0c473f6770fb1cfe3b DIFF: https://github.com/llvm/llvm-project/commit/6ba4b62af8df00edb7e1cc0c473f6770fb1cfe3b.diff

[PATCH] D138464: Return None instead of Optional() (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba4b62af8df: Return None instead of OptionalT() (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3a95d7d - [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

Author: KAWASHIMA Takahiro Date: 2022-11-22T13:04:26+09:00 New Revision: 3a95d7d0983af26811e72d238d94f11c25f1851a URL: https://github.com/llvm/llvm-project/commit/3a95d7d0983af26811e72d238d94f11c25f1851a DIFF:

[PATCH] D131295: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D131295#3935759 , @Trass3r wrote: > Yeah quite complex: https://godbolt.org/z/8T5Pqadro Not very hard with a track of visited decls. It should also reslove other duplicate codelens.

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

This revision was automatically updated to reflect the committed changes. kawashima-fj marked an inline comment as done. Closed by commit rG3a95d7d0983a: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func (authored by kawashima-fj). Changed prior to commit:

[PATCH] D138466: Don't use Optional::getPointer (NFC)

kazu created this revision. Herald added subscribers: kadircet, arphaman, javed.absar, hiraditya. Herald added a project: All. kazu requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Since std::optional

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

mgorny added a comment. From Gentoo perspective, correct is better, correct and matching GCC is the best (we support mixing compilers to some degree). I think it'd be best to wait for confirmation on GCC end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9df8ba6 - pr59000: Clarify packed-non-pod warning that it's pod-for-the-purposes-of-layout

Author: David Blaikie Date: 2022-11-22T00:02:09Z New Revision: 9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af URL: https://github.com/llvm/llvm-project/commit/9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af DIFF: https://github.com/llvm/llvm-project/commit/9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af.diff

[clang] 799b6b9 - [clang][docs] Use `option` directive in User's Manual

Author: KAWASHIMA Takahiro Date: 2022-11-22T10:40:54+09:00 New Revision: 799b6b9f3193bd8a4499da063dc7f74cfccadefd URL: https://github.com/llvm/llvm-project/commit/799b6b9f3193bd8a4499da063dc7f74cfccadefd DIFF:

[clang] 2a0919b - [clang][docs] Remove an unnecessary space

Author: KAWASHIMA Takahiro Date: 2022-11-22T10:40:55+09:00 New Revision: 2a0919b965b88080ef67fdffe57d3fa8d865d885 URL: https://github.com/llvm/llvm-project/commit/2a0919b965b88080ef67fdffe57d3fa8d865d885 DIFF:

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

This revision was automatically updated to reflect the committed changes. Closed by commit rG799b6b9f3193: [clang][docs] Use `option` directive in Users Manual (authored by kawashima-fj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138088/new/

[clang] 9359185 - [clang][docs] Correct indent of option explanation

Author: KAWASHIMA Takahiro Date: 2022-11-22T10:40:56+09:00 New Revision: 93591851d8416b64ee756a87508add76da2395aa URL: https://github.com/llvm/llvm-project/commit/93591851d8416b64ee756a87508add76da2395aa DIFF:

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

khchen added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:284 + +class RVVTypeCache { +private: nit: maybe we could add some comments to said the motivation for `RVVTypeCache`. Comment at:

[PATCH] D138464: Return None instead of Optional() (NFC)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. We have `return llvm::None;` and `return None;`. Shall we always prefer `llvm::None`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136806: [Pipelines] Introduce SROA after (final, full) loop unrolling

dyung added a comment. Hi @lebedev.ri, we recently noticed a failure in one of our internal tests which I bisected back to your change. I have filed the details in Issue #59122 . Can you take a look? Repository: rG LLVM Github Monorepo

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138472 Files: clang/CMakeLists.txt

[PATCH] D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally

steakhal added a comment. In D108230#3942374 , @xazax.hun wrote: > I am a bit conflicted. It is unfortunate that C and C++ compilers regarded > single element array members as flexible array members. On the other hand, > looking at GCC, it recently

[PATCH] D138464: Return None instead of Optional() (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, ThomasRaoux, pmatos, asb, sdasgup3, wenzhicui, wrengr, jsetoain, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst,

[PATCH] D138474: [clang] Speedup LineOffsetMapping::get

serge-sans-paille created this revision. serge-sans-paille added reviewers: aaron.ballman, nikic, lattner. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LineOffsetMapping::get is a critical

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. In D124351#3940888 , @aaron.ballman wrote: > In D124351#3940786 , @cor3ntin > wrote: > >> Now that Kona is over, I'm hoping to get back to that in the coming weeks. >> Rebasing will

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3935740 , @rjmccall wrote: > I'm too often slow to actually apply edits to the ABI document. There's been > plenty of time for feedback on this one; go ahead and act like it's accepted. CWG 2596 was discussed at Kona

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

aaron.ballman added a comment. In D124351#3940890 , @cor3ntin wrote: > In D124351#3940888 , @aaron.ballman > wrote: > >> In D124351#3940786 , @cor3ntin >> wrote: >> >>>

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. Thanks for your feedback @rnk! I hope some of the ObjCARCOpts authors will share their opinions as well. Comment at: llvm/lib/Transforms/ObjCARC/ObjCARCOpts.cpp:767 +const ColorVector = BlockColors.find(BB)->second; +assert(CV.size() == 1

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3940898 , @dfrib wrote: > In D126818#3935740 , @rjmccall > wrote: > >> I'm too often slow to actually apply edits to the ABI document. There's >> been plenty of time for

[PATCH] D138425: [clangd] Parameter hints for template specialization

sammccall added a comment. The code looks pretty good and this makes a lot of logical sense. However, there's an ugly practical issue: it's overwhelmingly common for template parameters to have cryptic and useless names. It seems like turning `vector` into `vector` actually makes things worse.

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kadircet added a comment. thanks! +1 from my side as well for thread-safety purposes (and I hope having 2 separate caches for tablegen and sema doesn't have unexpected effects). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138429/new/

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. In D124351#3940786 , @cor3ntin wrote: > Now that Kona is over, I'm hoping to get back to that in the coming weeks. > Rebasing will be... fun. > I want to make sure we are all

[PATCH] D137818: Add support for querying SubstTemplateTypeParm types

aaron.ballman added a comment. In D137818#3939213 , @anderslanglands wrote: > Arg just noticed an issue: clang_Type_getReplacementType should be in the > LLVM_16 block in libclang.map not in the LLVM_13 block. I've blown away my > local branch so

[PATCH] D138426: Fix #58958 on github

krsch created this revision. krsch added reviewers: NoQ, xazax.hun. Herald added a subscriber: rnkovacs. Herald added a project: All. krsch requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not suggest to take the address of a const

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

kito-cheng created this revision. kito-cheng added reviewers: ilya-biryukov, kadircet, sammccall, khchen. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

kito-cheng added a comment. Proposed fix: D138429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138287/new/ https://reviews.llvm.org/D138287 ___ cfe-commits mailing

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a typo in a warning message. rdar://79707705 Repository: rG LLVM Github Monorepo

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl marked an inline comment as done. yaxunl added a comment. In D138221#3939384 , @MaskRay wrote: >> Some host relocatable objects may not contain device relocatable objects, >> where an empty file is passed to lld, which causes lld to fail. > > How

[PATCH] D138088: [clang][docs] Use `option` directive in User's Manual

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D138088#3938687 , @kawashima-fj wrote: > In D138088#3937680 , @aaron.ballman > wrote: >

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

aaron.ballman added a comment. In D127462#3939243 , @ksaunders wrote: > Hi Aaron. Unfortunately, I don't feel I can make a great case for why these > extensions should be in Clang. Although there are users of Plan 9 C > extensions, I don't see these

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. The behaviour of tabs still doesn't match that of spaces, but at least this makes it idempotent. This also fixes https://github.com/llvm/llvm-project/issues/51808, I'm closing it as

[PATCH] D138429: [clang][RISCV][NFC] Prevent data race in RVVType::computeType

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from a thread-safety perspective, thanks! Approving because it looks mechanically "obviously correct", but you may want to wait for another reviewer to confirm the API changes are

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

dfrib added a comment. In D126818#3941036 , @erichkeane wrote: > In D126818#3940898 , @dfrib wrote: > >> In D126818#3935740 , @rjmccall >> wrote: >> >>> I'm too often

[PATCH] D138221: [HIP] Fix lld failure when devie object is empty

yaxunl updated this revision to Diff 476892. yaxunl added a comment. Herald added subscribers: kerbowa, jvesely. add test emulation-amdgpu.s CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138221/new/ https://reviews.llvm.org/D138221 Files: clang/lib/Driver/ToolChains/HIPAMD.cpp

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

grosser added a comment. I just checked and I get the same error on a linux system. @nhaehnle, did you try an mlir build with the previously mentioned cmake options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138278/new/

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added a comment. ping Comment at: clang/lib/CodeGen/CGCall.cpp:5402-5411 +if (SanOpts.has(SanitizerKind::ExceptionEscape) && +ExceptionEscapeUBLastInvokeSrcLoc) { + llvm::Constant *CheckSourceLocation = EmitCheckSourceLocation(Loc); +

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry created this revision. v1nh1shungry added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[clang] 281a5c7 - [llvm,polly,clang] Stop setting config.enable_shared in most places

Author: Nico Weber Date: 2022-11-21T08:54:14-05:00 New Revision: 281a5c7ef112d5d09dd947ecd3f85484047c5502 URL: https://github.com/llvm/llvm-project/commit/281a5c7ef112d5d09dd947ecd3f85484047c5502 DIFF: https://github.com/llvm/llvm-project/commit/281a5c7ef112d5d09dd947ecd3f85484047c5502.diff

[PATCH] D138301: [llvm, polly, clang] Stop setting config.enable_shared in most places

This revision was automatically updated to reflect the committed changes. Closed by commit rG281a5c7ef112: [llvm,polly,clang] Stop setting config.enable_shared in most places (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. This patch implements: - Template specialization type - Class template specialization declaration - Variable template specialization declaration - Function specialization declaration It would be sweet to also implement: template constexpr int value = 0;

[clang] eb4373a - Remove -cc1 -fconcepts-ts flag

Author: Erich Keane Date: 2022-11-21T06:31:29-08:00 New Revision: eb4373abe829f8731b3e6d4da97ad88a9a93aa28 URL: https://github.com/llvm/llvm-project/commit/eb4373abe829f8731b3e6d4da97ad88a9a93aa28 DIFF: https://github.com/llvm/llvm-project/commit/eb4373abe829f8731b3e6d4da97ad88a9a93aa28.diff

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng added a comment. @kadircet Proposed fix: D138429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/ https://reviews.llvm.org/D124730 ___ cfe-commits

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. @sammccall Thank you for reviewing and giving suggestions! I must admit I didn't use it for very long. But I do think this is helpful, at least for templates I'm unfamiliar with. Yes, there is a common situation where people use a meaningless template parameter

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Protocol.h:231 +/// Special Location-like type to be used for textDocument/references +/// Contains an additional field for the context in which the reference occurs This doesn't seem as

Re: [PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

thanks Kito! not sure if you've noticed D138287, but if landing a solution is going to take a long while here, i'd like to move forward with that approach to make sure this doesn't stay in a broken state. so it'd be great if you can give some updates/estimates about fixing this soon. On Mon, Nov

[PATCH] D119541: [RISCV] Fix RISCVTargetInfo::initFeatureMap, add non-ISA features back after implication

arichardson added a comment. Herald added subscribers: sunshaoce, StephenFan, shiva0217. Herald added a project: All. I just noticed that target features (e.g. -mrelax) are broken in all LLVM 14 releases due to D113336 . This should have been cherry-picked

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

sammccall added a comment. Since this is a protocol extension, you might want to add an end-to-end test: variant of `clang-tools-extra/clangd/test/xrefs.test` (`xrefs-container.test`? to avoid complicating all the existing tests). And one this lands, one of us should update

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

kito-cheng added a comment. Apparently I missed those comments during llvm dev meeting, I'll figure out a fix soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138287/new/ https://reviews.llvm.org/D138287

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

sammccall added a comment. In D138287#3940602 , @kito-cheng wrote: > Apparently I missed those comments during llvm dev meeting, I'll figure out a > fix soon. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

grosser added a comment. This patch overcomes the issue of cl options being defined multiple times. That is great! I just tried it on Windows on top of e7fb6c394f519d6e6812f1fbbff1571d5e51f5c4 with (msys2), as well as

[PATCH] D137794: [clangd] Enable configuring include insertions

sammccall added a comment. The replacement rules design is just too complicated I'm afraid. It's unclear that it solves a widespread problem, and even when there is one and the solution applies, the result is still difficult to use. Angles vs quotes is something we've had multiple reports on,

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. Now that Kona is over, I'm hoping to get back to that in the coming weeks. Rebasing will be... fun. I want to make sure we are all okay making that a DR following WG21 guidance, given that not making it a DR would have potentially large impact on the PR. Thanks!

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1434-1436 + if (Style.UseTab == FormatStyle::UT_Never) { +ReplacementText.append(Spaces, ' '); + } else { owenpan wrote: > Doing this would lose some

[PATCH] D138357: [clang-format][NFC] Don't add a load of 0es

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e00909b00f9: [clang-format][NFC] Dont add a load of 0es (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138356: [clang-format][NFC] Format lambda in conditional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc89d2fd596ce: [clang-format][NFC] Format lambda in conditional (authored by HazardyKnusperkeks). Herald added a project: clang. Herald added a

[clang] aff838f - [clang-format][NFC] Remove unneeded braces

Author: Björn Schäpers Date: 2022-11-21T13:24:17+01:00 New Revision: aff838fb8f1d398e8d9fc6ec15b5a10db3e1c057 URL: https://github.com/llvm/llvm-project/commit/aff838fb8f1d398e8d9fc6ec15b5a10db3e1c057 DIFF:

[clang] c89d2fd - [clang-format][NFC] Format lambda in conditional

Author: Björn Schäpers Date: 2022-11-21T13:24:18+01:00 New Revision: c89d2fd596cec8cf3a8100c504f045b9727fa98a URL: https://github.com/llvm/llvm-project/commit/c89d2fd596cec8cf3a8100c504f045b9727fa98a DIFF:

[clang] 9e00909 - [clang-format][NFC] Don't add a load of 0es

Author: Björn Schäpers Date: 2022-11-21T13:24:18+01:00 New Revision: 9e00909b00f9e75b4f710bc60f13ceea1215746c URL: https://github.com/llvm/llvm-project/commit/9e00909b00f9e75b4f710bc60f13ceea1215746c DIFF:

[clang] 5ba5f7c - [clang-format][NFC] Removed unused include

Author: Björn Schäpers Date: 2022-11-21T13:24:19+01:00 New Revision: 5ba5f7c46ccfe98fd68d6e31d25f386d67d484b4 URL: https://github.com/llvm/llvm-project/commit/5ba5f7c46ccfe98fd68d6e31d25f386d67d484b4 DIFF:

[PATCH] D138354: [clang-format][NFC] Remove unneeded braces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaff838fb8f1d: [clang-format][NFC] Remove unneeded braces (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

WowbaggersLiquidLunch accepted this revision. WowbaggersLiquidLunch added a comment. Yes this works! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138403/new/ https://reviews.llvm.org/D138403

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

sammccall added a comment. In D136594#3940143 , @nridge wrote: > I believe highlighting of **built-in** operators should be out of scope for > semantic highlighting, at least in the default mode; client-side highlighting > should be sufficient for

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

sammccall added a comment. In D137205#3939720 , @njames93 wrote: > @sammccall I have a feeling you're gonna want to examine this checks > feasibility in clangd. Thanks! As it uses the CFG, by default we're going to have to turn it off (AFAIK building

[PATCH] D124730: [RISCV][NFC] Refactor RISC-V vector intrinsic utils.

kito-cheng marked 2 inline comments as done. kito-cheng added a comment. @kadircet ooops, sorry for missing your comment, let me figure out how to fix that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124730/new/

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

sammccall added a comment. Not sure this is ready for review again, ignore me if not... I'm still not sure why this is correct in principle. Without that, if someone finds a misparse 6 months from now I don't know how we determine where to fix it. For example, this path is called from

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940427 , @WowbaggersLiquidLunch wrote: >> I get the following error: >> >>> CMake Error: Could not create named generator Xcode > > Sorry, I forgot to mention that Xcode is only available on macOS. > >> But when

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940432 , @WowbaggersLiquidLunch wrote: > In D136906#3940377 , @gonglingqin > wrote: > >> Can you use https://reviews.llvm.org/D138403 to solve this problem? > > Thanks

[PATCH] D137943: [clangd] Mark "override" and "final" as keywords

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM with optional mechanical replacement of `Keyword` with `Modifier`. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:52 Macro, + Keyword,

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:76 ConstructorOrDestructor, + UserProvided, sammccall wrote: > sammccall wrote: > > sammccall wrote: > > > Can you give some background here or on the bug tracker

[PATCH] D138143: [FPEnv] Enable strict fp for AArch64 in clang

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138143/new/ https://reviews.llvm.org/D138143

[PATCH] D138287: [clang][RISCV] Drop caching from RVVType as it introduces data races

sammccall added a subscriber: kito.cheng. sammccall added a comment. I think there almost certainly *is* a better way here, but it may be a significant amount of work and we need to get back to a correct state (revert doesn't seem feasible). Not approving yet in the hope that @kito-cheng

[PATCH] D137943: [clangd] Mark "override" and "final" as modifiers

ckandeler updated this revision to Diff 476843. ckandeler marked 3 inline comments as done. ckandeler retitled this revision from "[clangd] Mark "override" and "final" as keywords" to "[clangd] Mark "override" and "final" as modifiers". ckandeler edited the summary of this revision. ckandeler

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but wait for @WowbaggersLiquidLunch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138403/new/ https://reviews.llvm.org/D138403

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3940143 , @nridge wrote: > A couple of high-level thoughts on this: > > 1. Based on the discussion in https://github.com/clangd/clangd/issues/1115, I > believe highlighting of **built-in** operators should be out of

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. In D136906#3940377 , @gonglingqin wrote: > Can you use https://reviews.llvm.org/D138403 to solve this problem? Thanks for letting me know. I'll give it a try. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode"

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. > I get the following error: > >> CMake Error: Could not create named generator Xcode Sorry, I forgot to mention that Xcode is only available on macOS. > But when I change Xcode to Ninja, no error output is generated. Indeed. Ninja works fine for me as

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137894: [clangd] Add extension for adding context (enclosing function or class) in references results

tom-anders added a comment. In D137894#3940600 , @sammccall wrote: > Since this is a protocol extension, you might want to add an end-to-end test: > variant of `clang-tools-extra/clangd/test/xrefs.test` > (`xrefs-container.test`? to avoid complicating

[PATCH] D138377: add clang_Type_getFullyQualifiedName

aaron.ballman added a comment. In terms of testing, I'd recommend adding `-test-print-qualified-type` and see if you can thread a qualified vs unqualified parameter through `PrintType()` and friends to try to share as much code as possible. You'll probably need new wrapper functions that calls

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1732 +.. option:: -fexcess-precision: + + By default, Clang uses excess precision to calculate ``_Float16`` rjmccall wrote: > >The C and C++ standards allow floating-point expressions

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476913. zahiraam marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/FPOptions.def

[PATCH] D138210: [clang] Require parameter pack to be last argument in concepts.

ilya-biryukov added a comment. E.g. gcc actually accepts the concept definition, but later fails with "wrong number of template arguments". I wonder why Clang has not been doing the latter before this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138091: [Clang] Fix Sema::ClassifyName so that it classifies EnumConstantDecl as NonType when they are brought into scope via using enum

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1250-1251 bool ADL = UseArgumentDependentLookup(SS, Result, NextToken.is(tok::l_paren)); - if (Result.isSingleResult() && !ADL && !FirstDecl->isCXXClassMember()) + if (Result.isSingleResult() &&

[PATCH] D138425: [clangd] Parameter hints for template specialization

sammccall added a comment. In D138425#3941183 , @v1nh1shungry wrote: > @sammccall Thank you for reviewing and giving suggestions! > > I must admit I didn't use it for very long. But I do think this is helpful, > at least for templates I'm unfamiliar

  1   2   >