[PATCH] D139745: Use poison instead of undef where its used as placeholder[NFC]

nikic added a comment. The struct/insertvalue changes here are fine (no change in semantics). Can't comment on the vector/insertelement changes, you might want to split them out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139745/new/

[PATCH] D139760: Revert "[clang-format] Link the braces of a block in UnwrappedLineParser"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91b5d508e350: Revert [clang-format] Link the braces of a block in UnwrappedLineParser (authored by owenpan). Repository: rG LLVM Github Monorepo

[clang] 91b5d50 - Revert "[clang-format] Link the braces of a block in UnwrappedLineParser"

Author: Owen Pan Date: 2022-12-10T02:31:53-08:00 New Revision: 91b5d508e350a26028b7fc1397f21334e49dda5d URL: https://github.com/llvm/llvm-project/commit/91b5d508e350a26028b7fc1397f21334e49dda5d DIFF: https://github.com/llvm/llvm-project/commit/91b5d508e350a26028b7fc1397f21334e49dda5d.diff

[clang] d9bef74 - [Driver] -fstack-size-section: pass -stack-size-section to backend for LTO

Author: Fangrui Song Date: 2022-12-10T10:15:29Z New Revision: d9bef74a212b502271eb8fa6a0a8714126e88b2b URL: https://github.com/llvm/llvm-project/commit/d9bef74a212b502271eb8fa6a0a8714126e88b2b DIFF: https://github.com/llvm/llvm-project/commit/d9bef74a212b502271eb8fa6a0a8714126e88b2b.diff LOG:

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

Amir added a comment. In D139496#3986435 , @phosek wrote: > Could we add the `perf` related logic to > https://github.com/llvm/llvm-project/blob/ba3d808feedaa7f31750d8bc02754e15b372c868/clang/utils/perf-training/perf-helper.py? > I think that's a

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. Nice catch. I had a look at https://lists.llvm.org/pipermail/llvm-dev/2021-March/149216.html, and http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1169.pdf. Your change makes

[clang] 1cb7fba - [StaticAnalyzer] Don't use Optional::create (NFC)

Author: Kazu Hirata Date: 2022-12-10T12:35:03-08:00 New Revision: 1cb7fba3e57d6c31f05c7a2bda1634da49dd1d18 URL: https://github.com/llvm/llvm-project/commit/1cb7fba3e57d6c31f05c7a2bda1634da49dd1d18 DIFF: https://github.com/llvm/llvm-project/commit/1cb7fba3e57d6c31f05c7a2bda1634da49dd1d18.diff

[clang-tools-extra] f7dffc2 - Don't include None.h (NFC)

Author: Kazu Hirata Date: 2022-12-10T11:24:26-08:00 New Revision: f7dffc28b3f82e25a0e283d2b11ffb9c6a129340 URL: https://github.com/llvm/llvm-project/commit/f7dffc28b3f82e25a0e283d2b11ffb9c6a129340 DIFF: https://github.com/llvm/llvm-project/commit/f7dffc28b3f82e25a0e283d2b11ffb9c6a129340.diff

[clang] 29041bc - [APInt] Convert GetMostSignificantDifferentBit to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-10T14:03:29-06:00 New Revision: 29041bc0507f2b04d116ee3150bfd61ea01c5565 URL: https://github.com/llvm/llvm-project/commit/29041bc0507f2b04d116ee3150bfd61ea01c5565 DIFF:

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy created this revision. vedgy added a reviewer: aaron.ballman. Herald added subscribers: arphaman, hiraditya. Herald added a project: All. vedgy requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Fixes:

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

Mordante added a comment. Sorry I overlooked this review. Based on the CI output it only runs the Clang CI right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138042/new/ https://reviews.llvm.org/D138042

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aeubanks I think i got it. Were you having this issue with an open source project by any chance? Maybe i could try it locally before commiting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

mstorsjo added a comment. In D131830#3985449 , @koops wrote: > Martin Storsjö (or anybody who works on windows) I have uploaded a new patch > which has __kmpc_omp_taskwait_51 in dllexports. Can you please check the > patch on windows? Thanks, now this

[PATCH] D139113: [clang-tidy] Fix a couple additional cases in misc-use-anonymous-namespace

carlosgalvezp added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139113/new/ https://reviews.llvm.org/D139113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 628556b - [Checkers] Use std::optional in UnixAPIChecker.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T08:10:24-08:00 New Revision: 628556b1c53b53946ae0ee39a7a090e5bbdd6aec URL: https://github.com/llvm/llvm-project/commit/628556b1c53b53946ae0ee39a7a090e5bbdd6aec DIFF: https://github.com/llvm/llvm-project/commit/628556b1c53b53946ae0ee39a7a090e5bbdd6aec.diff

[clang] b5fdd53 - [Checkers] Use std::optional in StdLibraryFunctionsChecker.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T08:09:00-08:00 New Revision: b5fdd533e5c8ed9726bfaaf961272010cbde6c75 URL: https://github.com/llvm/llvm-project/commit/b5fdd533e5c8ed9726bfaaf961272010cbde6c75 DIFF: https://github.com/llvm/llvm-project/commit/b5fdd533e5c8ed9726bfaaf961272010cbde6c75.diff

[PATCH] D139496: [CMake] Add perf profiling for clang-bolt

phosek added a comment. Could we add the `perf` related logic to https://github.com/llvm/llvm-project/blob/ba3d808feedaa7f31750d8bc02754e15b372c868/clang/utils/perf-training/perf-helper.py? I think that's a better place since we eventually want to replace the use of `ExternalProject_Add` with

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 481850. cor3ntin added a comment. - Make sure cleanups expressions are created in the correct evaluation context. This simplifies and reduce the numbers of nested evaluation contexts we create, notably to make sure the creation of the initialier and

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5966 (Context.hasSameUnqualifiedType(SourceType, DestType) || - S.IsDerivedFrom(Initializer->getBeginLoc(), SourceType, DestType + (Initilializer && +

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops added a comment. > (There seems to be another unrelated regression at the same time though, > regarding the symbol __kmpc_fork_call_if.) I do not know about this regression. I have not touched this function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 added a comment. > int foo(void); > > void bar(int a, int b[*]); // variable length array used, correct > void bar(int a, int b[a]) { variable length array used, correct > int x[foo()]; // variable length array that may require stack allocation > used, correct > >

[clang] 02c905c - [Checkers] Use std::optional in MallocChecker.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T08:04:28-08:00 New Revision: 02c905cd4d4411a7b97a618101f59e54d779f336 URL: https://github.com/llvm/llvm-project/commit/02c905cd4d4411a7b97a618101f59e54d779f336 DIFF: https://github.com/llvm/llvm-project/commit/02c905cd4d4411a7b97a618101f59e54d779f336.diff

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

mstorsjo added a comment. In D131830#3986436 , @koops wrote: >> (There seems to be another unrelated regression at the same time though, >> regarding the symbol __kmpc_fork_call_if.) > > I do not know about this regression. I have not touched this

Re: [clang] 91b5d50 - Revert "[clang-format] Link the braces of a block in UnwrappedLineParser"

Reminder to please always mention the reason for the revert in the commit message. On Sat, Dec 10, 2022 at 1:32 PM Owen Pan via cfe-commits wrote: > > > Author: Owen Pan > Date: 2022-12-10T02:31:53-08:00 > New Revision: 91b5d508e350a26028b7fc1397f21334e49dda5d > > URL: >

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 481858. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files: clang/include/clang/Sema/HLSLExternalSemaSource.h

[clang] 9ddc8af - [Checkers] Use std::optional in BasicObjCFoundationChecks.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T07:58:36-08:00 New Revision: 9ddc8af97f7ccc4a8090a2ac870c79f3e172c8b9 URL: https://github.com/llvm/llvm-project/commit/9ddc8af97f7ccc4a8090a2ac870c79f3e172c8b9 DIFF: https://github.com/llvm/llvm-project/commit/9ddc8af97f7ccc4a8090a2ac870c79f3e172c8b9.diff

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 481861. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136743/new/ https://reviews.llvm.org/D136743 Files: clang/lib/Sema/HLSLExternalSemaSource.cpp

[clang] 6c8b8a6 - [Checkers] Use std::optional in GenericTaintChecker.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T08:00:24-08:00 New Revision: 6c8b8a6a2a52143d91af883dea30d8549e38cada URL: https://github.com/llvm/llvm-project/commit/6c8b8a6a2a52143d91af883dea30d8549e38cada DIFF: https://github.com/llvm/llvm-project/commit/6c8b8a6a2a52143d91af883dea30d8549e38cada.diff

[clang] b5716de - [RetainCountChecker] Use std::optional in RetainCountDiagnostics.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T08:07:12-08:00 New Revision: b5716decbd4a4be3dba2318799871b062f3859d2 URL: https://github.com/llvm/llvm-project/commit/b5716decbd4a4be3dba2318799871b062f3859d2 DIFF: https://github.com/llvm/llvm-project/commit/b5716decbd4a4be3dba2318799871b062f3859d2.diff

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers added a comment. Thanks for the comments. I assumed git-clang-format cleaned up the cruft, but it didn't - that's disappointing. I'll try these things and update the review. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers updated this revision to Diff 481882. vabridgers edited the summary of this revision. vabridgers added a comment. correct formatting of test case and expand test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139759/new/

[clang] e55cc7d - Remove using llvm::None

Author: Fangrui Song Date: 2022-12-11T02:47:19Z New Revision: e55cc7d11881f232ac19041b28fa46627c276577 URL: https://github.com/llvm/llvm-project/commit/e55cc7d11881f232ac19041b28fa46627c276577 DIFF: https://github.com/llvm/llvm-project/commit/e55cc7d11881f232ac19041b28fa46627c276577.diff LOG:

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. yes, it was chrome I went ahead and tried the latest patch, it successfully compiles the file that crashed before. I built all of chrome, and now I'm getting one last linker error, I'll try to get some more info about that Repository: rG LLVM Github Monorepo

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers marked 2 inline comments as done. vabridgers added a comment. Thanks Balazs, I think the comments have been addressed. Let me know if there's anything else to do, or if this is ready to land. Best! Comment at:

[clang-tools-extra] c824db4 - [clang-tools-extra] Use std::optional instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-10T16:59:22-08:00 New Revision: c824db46d4bc0e34cd365b94a5262145757080a9 URL: https://github.com/llvm/llvm-project/commit/c824db46d4bc0e34cd365b94a5262145757080a9 DIFF: https://github.com/llvm/llvm-project/commit/c824db46d4bc0e34cd365b94a5262145757080a9.diff

RE: [clang-tools-extra] f7dffc2 - Don't include None.h (NFC)

Hi Kazu, Your change caused the build of cross-project-tests to fail, can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/32528 https://lab.llvm.org/buildbot/#/builders/216/builds/14213 Douglas Yung -Original Message- From: cfe-commits On Behalf Of Kazu Hirata

[clang] ec94a5b - [StaticAnalyzer] Use std::optional in BugReporter.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T20:54:38-08:00 New Revision: ec94a5b71685d7d1d384fae5f6aa51b0c3d41037 URL: https://github.com/llvm/llvm-project/commit/ec94a5b71685d7d1d384fae5f6aa51b0c3d41037 DIFF: https://github.com/llvm/llvm-project/commit/ec94a5b71685d7d1d384fae5f6aa51b0c3d41037.diff

[clang] a67a115 - [StaticAnalyzer] Use std::optional in BugReporterVisitors.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T21:11:31-08:00 New Revision: a67a11536e1cfaec0e02a740b5a77f0db4e1481a URL: https://github.com/llvm/llvm-project/commit/a67a11536e1cfaec0e02a740b5a77f0db4e1481a DIFF: https://github.com/llvm/llvm-project/commit/a67a11536e1cfaec0e02a740b5a77f0db4e1481a.diff

[clang] 602af71 - [StaticAnalyzer] Use std::optional in BugReporter.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T21:11:29-08:00 New Revision: 602af71c29a7553b68368443e6d938827a1dce8f URL: https://github.com/llvm/llvm-project/commit/602af71c29a7553b68368443e6d938827a1dce8f DIFF: https://github.com/llvm/llvm-project/commit/602af71c29a7553b68368443e6d938827a1dce8f.diff

[clang] 3e57273 - [StaticAnalyzer] Use std::optional in RetainCountDiagnostics.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T21:15:44-08:00 New Revision: 3e572733d9d8eba90cfc5812c70e0d2df02f72b2 URL: https://github.com/llvm/llvm-project/commit/3e572733d9d8eba90cfc5812c70e0d2df02f72b2 DIFF: https://github.com/llvm/llvm-project/commit/3e572733d9d8eba90cfc5812c70e0d2df02f72b2.diff

[clang] eacf7c8 - [StaticAnalyzer] Use std::optional in MallocChecker.cpp (NFC)

Author: Kazu Hirata Date: 2022-12-10T21:15:43-08:00 New Revision: eacf7c874b1e17818742b0c1d4fd325e3459cfa1 URL: https://github.com/llvm/llvm-project/commit/eacf7c874b1e17818742b0c1d4fd325e3459cfa1 DIFF: https://github.com/llvm/llvm-project/commit/eacf7c874b1e17818742b0c1d4fd325e3459cfa1.diff

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:157-158 + Loc::isLocType(T)); return APSIntType(Ctx.getIntWidth(T), !T->isSignedIntegerOrEnumerationType()); }