[clang] b7894eb - [clang][Interp] Initialize remaining InlineDescriptor fields

Author: Timm Bäder Date: 2023-01-20T10:04:16+01:00 New Revision: b7894ebf8439c0141614fbb8bfc1a27a0a67e946 URL: https://github.com/llvm/llvm-project/commit/b7894ebf8439c0141614fbb8bfc1a27a0a67e946 DIFF: https://github.com/llvm/llvm-project/commit/b7894ebf8439c0141614fbb8bfc1a27a0a67e946.diff

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. One idea discussed in comments to the KDevelop merge request, which I haven't mentioned here is this: remove the preamble files immediately after creating and opening them. This is safe on Unix-like OSes, because every file that is still open will not actually be deleted

[PATCH] D119708: [clang][lex] Remove `PPCallbacks::FileNotFound()`

Hahnfeld added a comment. In D119708#4062632 , @jansvoboda11 wrote: > If the plan is to eventually upstream that part of Cling, I'm fine with > re-adding a safe version of this API. I'll be honest here and say that I personally find it unlikely that

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. In D140619#4058232 , @KKoovalsky wrote: > Hey! I can see that the build: > https://reviews.llvm.org/harbormaster/build/311598/ failed, but I am not sure > whether this is related to my change. Could someone take a look? I can

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. By the way, I also got linker errors when trying to build this patch in a shared-libs build. Resolved by adding `clangASTMatchers` to `clang_target_link_libraries` in `clang-tools-extra/clangd/tool/CMakeLists.txt`. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D140838: [clang] fix crash on generic lambda with lambda in decltype

This revision was automatically updated to reflect the committed changes. Closed by commit rGea4fd668c2cd: [clang] fix crash on generic lambda with lambda in decltype (authored by v1nh1shungry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ea4fd66 - [clang] fix crash on generic lambda with lambda in decltype

Author: v1nh1shungry Date: 2023-01-20T17:11:07+08:00 New Revision: ea4fd668c2cd88d13b36a5d64e3dedb1106340bc URL: https://github.com/llvm/llvm-project/commit/ea4fd668c2cd88d13b36a5d64e3dedb1106340bc DIFF: https://github.com/llvm/llvm-project/commit/ea4fd668c2cd88d13b36a5d64e3dedb1106340bc.diff

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. > How does this affect LTO? More detailed answer. We work with bitcode files only when use `lto`. If we don't use `lto` clang produces `.o` file that are already contains target information. We don't work with function attributes to get subtarget without lto.

[PATCH] D140619: ExtractFunction: support extracting expressions and selected part of it

nridge added a comment. In D140619#4067940 , @nridge wrote: > I can reproduce the failures locally with the patch applied. (The failures seem to have to do with `ExtractFunction` segfaulting when invoked at a particular location in the code in

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a comment. In D139705#4067774 , @lattner wrote: > Got it this time, sorry for the confusion! Confirmed that I received the invitation. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet created this revision. kadircet added reviewers: hokein, cor3ntin, aaron.ballman. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was regressed in ca619613801233ef2def8c3cc7d311d5ed0033cb

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina added a comment. I've created one more patch connected with lto https://reviews.llvm.org/D142191 and it also uses attributes of functions as the way to get right TargetMachine in linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks added a comment. In D141811#4064428 , @rymiel wrote: > In D141811#4055485 , > @HazardyKnusperkeks wrote: > >> What about `decltype(auto)`? > > Turns out this is a problem even without this

[clang] e74f9e7 - [include-mapping] Parse zombie_names.html into a removed symbols map.

Author: Viktoriia Bakalova Date: 2023-01-20T08:53:31Z New Revision: e74f9e7885078e7c847b2672a70b6743731aa53a URL: https://github.com/llvm/llvm-project/commit/e74f9e7885078e7c847b2672a70b6743731aa53a DIFF: https://github.com/llvm/llvm-project/commit/e74f9e7885078e7c847b2672a70b6743731aa53a.diff

[PATCH] D141855: [include-mapping] Parse zombie_names.html into a removed symbols map.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe74f9e788507: [include-mapping] Parse zombie_names.html into a removed symbols map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo

[PATCH] D142024: [clang] Optimize clang::Builtin::Info density

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. The task-clock improvement is likely noise, but there's definitely a code size / max-rss win here. Comment at: clang/include/clang/Basic/BuiltinHeaders.def:9 +// +//

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 2 inline comments as done. TIFitis added a comment. I'm planning on merging the patch early next week. If you'd like to see any changes or need more time to review, please let me know :) Akash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG149521091499: [OpenCL] Always add nounwind attribute for OpenCL (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke added inline comments. Comment at: flang/docs/DiagnosticsReference.md:1 +% This file intentionally left blank. Silences a warning about a missing reference from the automatically generated FlangCommandLineReference.rst This is pretty hairy and it will link

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

clementval added a comment. Just small nit Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:628-629 +int64_t mapTypeBits = 0x00; +auto mapOp = map_operands[i]; +auto mapTypeOp = map_types[i]; + auto should be spelled out here.

[PATCH] D142196: [clang][Lex] Add back PPCallbacks::FileNotFound

Hahnfeld added a comment. I just checked and this "simplified" version of the callback would give us enough information to implement all we need in ROOT (plus some, the `bool` return value is nicer than temporarily playing with `SuppressIncludeNotFoundError`). For an upstream test, I could

[PATCH] D142187: [clang] Fix typos in member initializers

hokein added a comment. In D142187#4068092 , @ilya-biryukov wrote: > Randomly chiming in here. > I never had a good model of where `CorrectDelayedTyposInExpr`, but wanted to > note that `ActOnFullExpr` also calls it. This may be fine, I just wanted to

[PATCH] D142187: [clang] Fix typos in member initializers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4103 + /*RecoverUncorrectedTypos=*/true); + if (!FD->getType()->isDependentType() && !Init.get()->isTypeDependent()) { +Init =

[PATCH] D140959: RFC: Multilib prototype

michaelplatings added a comment. A constraint is that the user should be able to choose the library with a single list of arguments, as displayed with `-print-multi-lib`. Therefore I'm sceptical about making the selection mechanism too expressive, because `-print-multi-lib` can't explain that

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:52 + AArch64::AEK_RDM | AArch64::AEK_RCPC | AArch64::AEK_DOTPROD | + AArch64::AEK_SM4 | AArch64::AEK_SHA3 | AArch64::AEK_BF16| +

[clang] 1495210 - [OpenCL] Always add nounwind attribute for OpenCL

Author: Sven van Haastregt Date: 2023-01-20T12:01:22Z New Revision: 1495210914997bcd0ca6937be0ae3cd6809b5ef5 URL: https://github.com/llvm/llvm-project/commit/1495210914997bcd0ca6937be0ae3cd6809b5ef5 DIFF: https://github.com/llvm/llvm-project/commit/1495210914997bcd0ca6937be0ae3cd6809b5ef5.diff

[PATCH] D142033: [OpenCL] Always add nounwind attribute for OpenCL

svenvh added a comment. In D142033#4062671 , @bader wrote: > Should we generalize and rename `clang/test/CodeGenOpenCL/convergent.cl` to > validate function attributes other than `convergent`? It's not obvious that > presence of `nounwind` attribute is

[PATCH] D78028: move shebangs from python2 to python3

RKSimon added a comment. @LocutusOfBorg - a grep of llvm-project *.py files is not finding many matches for python2 - I'm assuming this was handled (e.g. update_cc_test_checks.py was updated in D129590 ). There might still be a few missed cases (or references

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") ==

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet updated this revision to Diff 490793. kadircet marked 3 inline comments as done. kadircet added a comment. assert on usability of initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142187/new/ https://reviews.llvm.org/D142187

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. since we modify the python script, could you please update its artifacts (`StdSymbolMap.inc`, `CSymbolMap`) as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

luke created this revision. luke added reviewers: kuhnel, Shivamgupta1234, mehdi_amini. Herald added subscribers: kosarev, pmatos, kerbowa, arphaman, jvesely. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. luke requested review of this revision. Herald added subscribers:

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 ___ cfe-commits mailing list

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added a comment. In D139705#4067774 , @lattner wrote: > Got it this time, sorry for the confusion! Thank you for the help, Chris! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/

[PATCH] D142187: [clang] Fix typos in member initializers

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4101 - ExprResult Init = InitExpr; - if (!FD->getType()->isDependentType() && !InitExpr->isTypeDependent()) { -Init =

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added inline comments. Herald added a subscriber: asb. Comment at: flang/docs/ComplexOperations.md:37 **FIR** -```c func.func @_QPpow_self(%arg0: !fir.ref>) -> !fir.complex<4> { Do these changes have any affected on the output html? Is there another

[PATCH] D139395: Add CFI integer types normalization

samitolvanen added a comment. In D139395#4067391 , @pcc wrote: > I discussed this out of band with Ramon and we agreed that the new option > should be marked as experimental because the rustc implementation is not yet > finalized. I think that the

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

vitalybuka added a comment. Fails on this bot https://lab.llvm.org/buildbot/#/builders/5/builds/30884/steps/13/logs/stdio https://reviews.llvm.org/D142233 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 updated this revision to Diff 491015. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142268/new/ https://reviews.llvm.org/D142268 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel added a comment. In D141811#4068180 , @HazardyKnusperkeks wrote: > I thought about `auto NAME() -> int { return 42; }`. > > `decltype(auto) a = (b) -> c;` is something else... I'm not sure how that affects this? Using `decltype(auto)` as in

[PATCH] D141709: [clang][dataflow] Fix bug in joining bool values.

gribozavr2 added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141709/new/ https://reviews.llvm.org/D141709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] c8b31da - [clang][dataflow] Allow analyzing multiple functions in unit tests

Author: Dmitri Gribenko Date: 2023-01-21T01:28:03+01:00 New Revision: c8b31da1ef0a3f2a0ba5c39bb4281b1438e511fb URL: https://github.com/llvm/llvm-project/commit/c8b31da1ef0a3f2a0ba5c39bb4281b1438e511fb DIFF:

[PATCH] D140859: [clang][dataflow] Allow analyzing multiple functions in unit tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b31da1ef0a: [clang][dataflow] Allow analyzing multiple functions in unit tests (authored by gribozavr). Repository: rG LLVM Github Monorepo

[PATCH] D139395: Add CFI integer types normalization

rcvalle marked an inline comment as done. rcvalle added inline comments. Comment at: clang/docs/ControlFlowIntegrity.rst:241 + +``-fsanitize-cfi--icall-experimental-normalize-integers`` +- samitolvanen

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** This patch

[PATCH] D142268: [clang][DebugInfo] Don't canonicalize names in template argument list for alias templates

Michael137 added a comment. @dblaikie suggested that the best way to go about the recurring "how do we print template names" question is to turn on `-gsimple-template-names` on by default. For alias templates this means we would have to attach template parameters to their DIEs too.

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD updated this revision to Diff 491041. eopXD marked 4 inline comments as done. eopXD added a comment. Address comment from Kito. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 Files:

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD updated this revision to Diff 491042. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 Files: clang/include/clang/Support/RISCVVIntrinsicUtils.h

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 added a comment. In D142233#4070572 , @vitalybuka wrote: > Fails on this bot > https://lab.llvm.org/buildbot/#/builders/5/builds/30884/steps/13/logs/stdio It's been fixed by

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 491013. rcvalle added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersManual.rst

[clang] 275ab24 - [Clang][test] Avoid FileCheck error when matching `-cc1`

Author: hezuoqiang Date: 2023-01-20T23:36:09-05:00 New Revision: 275ab246ee811507a2b1d2e42b2d655a25c8df6c URL: https://github.com/llvm/llvm-project/commit/275ab246ee811507a2b1d2e42b2d655a25c8df6c DIFF: https://github.com/llvm/llvm-project/commit/275ab246ee811507a2b1d2e42b2d655a25c8df6c.diff

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG275ab246ee81: [Clang][test] Avoid FileCheck error when matching `-cc1` (authored by hezuoqiang hezuoqia...@huawei.com, committed by bryanpkc).

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

eopXD added a comment. In D141754#4057829 , @kito-cheng wrote: > Wait, I fell HasTailPolicy and HasMaskPolicy should be part of Policy object, > and then it's the Omit to present it's no policy. I think the simplification here

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

eopXD added a comment. In D142094#4065611 , @asb wrote: > In D142094#4065175 , @eopXD wrote: > >> @asb I just saw the cancellation of the sync-up call today. Regarding the >> branch out on 01/24 I think it would

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

eopXD added a comment. > Not related to this patch, but this enum should probably be using double > underscores for its names. Thanks for mentioning this, probably should start a PR under rvv-intrinsic-doc before having a patch here. @craig.topper @kito-cheng I don't have a preference here,

[PATCH] D142265: [AArch64] Function multi-versioning release notes added. NFC.

ilinpv created this revision. ilinpv added reviewers: danielkiss, samtebbs, dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. ilinpv requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D142138: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

arsenm added a comment. In D142138#4066420 , @JonChesterfield wrote: > @arsenm as above, mcpu != march important? llc takes a different one to clang > iirc I don't know what the difference would be Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7249 // checking for any calls inside an Order region if (Scope->isOpenMPOrderClauseScope()) Diag(LParenLoc, diag::err_omp_unexpected_call_to_omp_runtime_api);

[PATCH] D139774: [libclang] Add API to set temporary directory location

dblaikie added a comment. In D139774#4069014 , @aaron.ballman wrote: > In D139774#4066920 , @dblaikie > wrote: > >> Don't let me hold this up - I think it all feels a bit too ad-hoc for my own >> preferences

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a89825a289d: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm… (authored by Peter). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0a89825 - [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Author: Peter Rong Date: 2023-01-20T13:25:15-08:00 New Revision: 0a89825a289d149195be390003424adad026067f URL: https://github.com/llvm/llvm-project/commit/0a89825a289d149195be390003424adad026067f DIFF: https://github.com/llvm/llvm-project/commit/0a89825a289d149195be390003424adad026067f.diff

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") ==

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski updated this revision to Diff 490999. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136315/new/ https://reviews.llvm.org/D136315 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

steven_wu added a comment. In D136315#4067205 , @calebzulawski wrote: > One thing to throw into the mix: Apple's clang has a default sysroot > configured, so with the default system compiler, there is no way to replicate > this "build without a

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

tianshilei1992 updated this revision to Diff 490896. tianshilei1992 added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142233/new/ https://reviews.llvm.org/D142233 Files: clang/lib/Sema/SemaOpenMP.cpp

[clang] c4fa504 - [AArch64] Enable libm vectorized functions via SLEEF

Author: Daniel Kiss Date: 2023-01-20T18:52:38+01:00 New Revision: c4fa504f797f68297c252dc91a24c7d37c1de4df URL: https://github.com/llvm/llvm-project/commit/c4fa504f797f68297c252dc91a24c7d37c1de4df DIFF: https://github.com/llvm/llvm-project/commit/c4fa504f797f68297c252dc91a24c7d37c1de4df.diff

[PATCH] D134719: [AArch64] Enable libm vectorized functions via SLEEF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4fa504f797f: [AArch64] Enable libm vectorized functions via SLEEF (authored by danielkiss). Herald added a project: clang. Herald added a

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

thakis added a comment. This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://103570533 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142243 Files:

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069779 , @enh wrote: > is there a corresponding glibc change so that `va_list` is exported for > `_POSIX_SOURCE` cases? see > https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where > i'm

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I spent some time looking at this. Rather than changing the dependency from RISCVTargetParserTableGen to LLVMTargetParser, I think the correct fix is to handle RISCVTargetParserTableGen in llvm/cmake/modules/LLVMConfig.cmake.in. alongside the intrinsics_gen,

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added inline comments. Comment at: clang/test/Driver/darwin-sdk-detect.c:1 +// REQUIRES: system-darwin + steven_wu wrote: > This test won't work in all conditions. Like I said, you requires to have a > Xcode/CommandLineTools installation to make

[clang] fb9b3e9 - Update the status of some C11 and C99 features we support

Author: Aaron Ballman Date: 2023-01-20T14:50:39-05:00 New Revision: fb9b3e9a5f23cfc43106c1209fd4a07761eee5e9 URL: https://github.com/llvm/llvm-project/commit/fb9b3e9a5f23cfc43106c1209fd4a07761eee5e9 DIFF: https://github.com/llvm/llvm-project/commit/fb9b3e9a5f23cfc43106c1209fd4a07761eee5e9.diff

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069935 , @enh wrote: > In D137268#4069856 , @zatrazz wrote: > >> I think I have caught this because your standard conformance tests checks >> for __gnuc_va_list >> on

[PATCH] D133539: [OpenMP] Replace OpenMP register requires constructor with a global array

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10515 +default: + RequiresFlags.push_back(OMP_REQ_NONE); +} jdoerfert wrote: > Really? Not an error or unexpected state?

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:79 + if (LLVM_WINSYSROOT) +set(CLANG_WINDOWS_CROSS_FLAGS + -Xclang I think we'll want to use these flags even when not cross-compiling so I'd change the name to reflect

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:7249 // checking for any calls inside an Order region if (Scope->isOpenMPOrderClauseScope()) Diag(LParenLoc, diag::err_omp_unexpected_call_to_omp_runtime_api);

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

steven_wu added a comment. This is not an apple platform problem. This is a cross compile problem where you have a SDK that is installed for cross compile target. In those cases, you just can't hard code the path to isysroot, and figuring out the sysroot is generally considered a problem for

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 created this revision. Herald added a project: All. usama54321 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rdar://103570533 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142242 Files:

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. In my situation, at least, I am the vendor of the toolchain and my configuration file contains `--sysroot=/../path/to/sysroot` with a known relative path to where the sysroot is distributed. Apple is unique in this situation, since I am not distributing the

[PATCH] D142233: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rG2ebda47619d7: [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash (authored

[clang] 2ebda47 - [Clang][OpenMP] Bail out early if `Scope` is nullptr in case of any crash

Author: Shilei Tian Date: 2023-01-20T14:40:24-05:00 New Revision: 2ebda47619d7e8b72d460a955de4f398f637489f URL: https://github.com/llvm/llvm-project/commit/2ebda47619d7e8b72d460a955de4f398f637489f DIFF: https://github.com/llvm/llvm-project/commit/2ebda47619d7e8b72d460a955de4f398f637489f.diff

[PATCH] D142243: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

aprantl added a comment. Code LGTM, it would be nice if we could further reduce the test case. Comment at: clang/test/CodeGenObjC/objc-arc-ubsan-debugging.m:2 +// RUN: %clang -x objective-c -target arm64-apple-macos12.0 -fobjc-arc -std=gnu99 -O0 -fsanitize=undefined

[PATCH] D142238: [clang/CodeGenActionTest] Use the platform's path separator for the `DebugInfoCWDCodeGen` test

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2b078adc2d0: [clang/CodeGenActionTest] Use the platforms path

[PATCH] D142165: [clang][deps] Account for transitive spurious dependencies

jansvoboda11 updated this revision to Diff 490962. jansvoboda11 added a comment. Fix test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142165/new/ https://reviews.llvm.org/D142165 Files:

[clang] 56b038f - [BPF][clang] Ignore stack protector options for BPF target

Author: Eduard Zingerman Date: 2023-01-20T15:12:43-08:00 New Revision: 56b038f887f37f69afac2d3abe02b46dcb9305ec URL: https://github.com/llvm/llvm-project/commit/56b038f887f37f69afac2d3abe02b46dcb9305ec DIFF:

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56b038f887f3: [BPF][clang] Ignore stack protector options for BPF target (authored by eddyz87, committed by yonghong-song). Repository: rG LLVM

[clang] 255922b - [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

Author: Joseph Huber Date: 2023-01-20T17:33:56-06:00 New Revision: 255922be7f008362bae16c708a2d90f60b4aba35 URL: https://github.com/llvm/llvm-project/commit/255922be7f008362bae16c708a2d90f60b4aba35 DIFF: https://github.com/llvm/llvm-project/commit/255922be7f008362bae16c708a2d90f60b4aba35.diff

[PATCH] D142138: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG255922be7f00: [OpenMP] Clean up AMD handling for `-fopenmp-targets=amdgcn` arch inference (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

This revision was automatically updated to reflect the committed changes. Closed by commit rG028d13b15612: [clang] Add ElaboratedType sugaring for types on implicit special members (authored by brad.king, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141738: Add initial support for cross compile Windows runtimes under Linux when building Fuchsia clang toolchain

haowei added a comment. Thanks for the review. I will land the change once Fuchsia clang builders are green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141738/new/ https://reviews.llvm.org/D141738

[clang] 49d47c4 - Add Parse/Sema for iterator for map clause.

Author: Doru Bercea Date: 2023-01-20T12:54:49-06:00 New Revision: 49d47c4d2f280d15d1de94c53b72b6ab3c127b35 URL: https://github.com/llvm/llvm-project/commit/49d47c4d2f280d15d1de94c53b72b6ab3c127b35 DIFF: https://github.com/llvm/llvm-project/commit/49d47c4d2f280d15d1de94c53b72b6ab3c127b35.diff

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 closed this revision. doru1004 added a comment. Commit 49d47c4d2f280d15d1de94c53b72b6ab3c127b35 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:485-486 +// Works like BoolOption except without specifying a KeyPathAndMacro, as these +// would refer to non-existant members of clang data structures +multiclass

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139168/new/ https://reviews.llvm.org/D139168 ___ cfe-commits mailing list

[PATCH] D142242: [CodeGen] bugfix: ApplyDebugLocation goes out of scope before intended

usama54321 updated this revision to Diff 490922. usama54321 added a comment. Renaming identifiers in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142242/new/ https://reviews.llvm.org/D142242 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[clang] 12251c6 - Correct documentation for the refersToType AST matcher

Author: Aaron Ballman Date: 2023-01-20T15:36:57-05:00 New Revision: 12251c64548785cb70b09ffd3ba91f639660341f URL: https://github.com/llvm/llvm-project/commit/12251c64548785cb70b09ffd3ba91f639660341f DIFF: https://github.com/llvm/llvm-project/commit/12251c64548785cb70b09ffd3ba91f639660341f.diff

[clang] c3efd52 - [clang][modules] Disallow importing private framework in the implementation

Author: Jan Svoboda Date: 2023-01-20T13:37:36-08:00 New Revision: c3efd52770ca964ba46287298c1d2f7697fd446c URL: https://github.com/llvm/llvm-project/commit/c3efd52770ca964ba46287298c1d2f7697fd446c DIFF: https://github.com/llvm/llvm-project/commit/c3efd52770ca964ba46287298c1d2f7697fd446c.diff

[PATCH] D142167: [clang][modules] Disallow importing private framework in the implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3efd52770ca: [clang][modules] Disallow importing private framework in the implementation (authored by jansvoboda11). Repository: rG LLVM Github

  1   2   >