[PATCH] D140415: [flang] stack arrays pass

jeanPerier accepted this revision. jeanPerier added a comment. I do not have any further comments, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 ___

[PATCH] D143472: [clang] Cast the pointer to right type with different address space

cdai2 created this revision. Herald added subscribers: pengfei, arichardson, Anastasia. Herald added a project: All. cdai2 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The source type has OpenCL general address space but dest type does

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb added a comment. Herald added a subscriber: jobnoorman. Friendly ping on this (I think mostly directed at @kito-cheng who was hoping to find time to review the linked abi issue ). CHANGES SINCE LAST ACTION

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

This revision was automatically updated to reflect the committed changes. Closed by commit rGce6de98b80ad: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] ce6de98 - [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Author: Sockke Date: 2023-02-07T19:34:54+08:00 New Revision: ce6de98b80ada8efbff93766b5303db5ab052efc URL: https://github.com/llvm/llvm-project/commit/ce6de98b80ada8efbff93766b5303db5ab052efc DIFF: https://github.com/llvm/llvm-project/commit/ce6de98b80ada8efbff93766b5303db5ab052efc.diff LOG:

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3599cbd3f6db: [include-mapping] Better #includes support for std input/output symbols (authored by hokein). Repository: rG LLVM Github Monorepo

[clang] 3599cbd - [include-mapping] Better #includes support for std input/output symbols

Author: Haojian Wu Date: 2023-02-07T14:19:32+01:00 New Revision: 3599cbd3f6db94e7358dcc901f41c7e357716c77 URL: https://github.com/llvm/llvm-project/commit/3599cbd3f6db94e7358dcc901f41c7e357716c77 DIFF: https://github.com/llvm/llvm-project/commit/3599cbd3f6db94e7358dcc901f41c7e357716c77.diff

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 495517. VitaNuo added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

clementval added a comment. In D143493#4110230 , @awarzynski wrote: > In what cases would this flag be used in practice? I've scanned Clang and > couldn't find any answers. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

jacobly updated this revision to Diff 495543. jacobly added a comment. Added regression test specific to the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak added a comment. In D143493#4110323 , @awarzynski wrote: > In D143493#4110272 , @skatrak wrote: > >> It is introduced to the arguments list in `Clang::AddPreprocessingOptions` >> in certain cases to add

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein updated this revision to Diff 495477. hokein added a comment. - Rebase to main, and some small tweaks - unittest will be added when landing the https://reviews.llvm.org/D143280 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, raghavendhra. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 495545. VitaNuo added a comment. Add header spelling to fix suggestion. Fix range to only underline the symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496

[PATCH] D143507: [RISCV][MC] Mark Zawrs extension as non-experimental

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495464. michaelplatings added a comment. Herald added a subscriber: jobnoorman. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files:

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. LGTM, thanks! Looks like a straight-forward extension of the existing builtins. Comment at:

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 495557. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings updated this revision to Diff 495460. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/

[PATCH] D142893: [NFC] Class for building MultilibSet

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:25 namespace driver { /// This corresponds to a single GCC Multilib, or a segment of one controlled peter.smith wrote: > It took a bit of reading to work out what the

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

pvellien created this revision. pvellien added reviewers: yaxunl, b-sumner. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. pvellien requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project:

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 495516. VitaNuo added a comment. Undo turning spellHeader method public. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

jdoerfert added a comment. Please avoid the MLIR style in any other subproject. I know some of the OpenMP Builder stuff already uses `llvm::` and MLIR style names, but that is in itself bad, not something we should extend. Comment at:

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495463. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

hokein updated this revision to Diff 495479. hokein added a comment. add a unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143280/new/ https://reviews.llvm.org/D143280 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

sunshaoce updated this revision to Diff 495522. sunshaoce added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 Files: clang/include/clang/Driver/Options.h

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495530. TIFitis edited the summary of this revision. TIFitis added a comment. Added explicit failure for use_device_ptr and use_device_addr clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. Herald added a subscriber: JDevlieghere. The alternative would be attaching the preferred name as a new attribute or an existing attribute like `DW_AT_description`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143386: Add function pointer alignment to DataLayout

gchatelet added a comment. Herald added a subscriber: jobnoorman. In D143386#4107144 , @efriedma wrote: > Almost all the specifications you're specifying are wrong. Very few targets > should be using "i". Off the top of my head, 32-bit ARM, MIPS

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

akyrtzi abandoned this revision. akyrtzi added a comment. In D143461#4110405 , @benlangmuir wrote: > Dupe of https://reviews.llvm.org/D143428 ? Indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1ab62d9 - [Tooling/Inclusion] Support multiple headers in the stdlib APIs.

Author: Haojian Wu Date: 2023-02-07T14:18:13+01:00 New Revision: 1ab62d9d8e964d41da9afa04fa226d300693a261 URL: https://github.com/llvm/llvm-project/commit/1ab62d9d8e964d41da9afa04fa226d300693a261 DIFF: https://github.com/llvm/llvm-project/commit/1ab62d9d8e964d41da9afa04fa226d300693a261.diff

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ab62d9d8e96: [Tooling/Inclusion] Support multiple headers in the

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:524 const auto *Tok = TB.spelledTokenAt(Loc); -assert(Tok); - +if (!Tok) + return

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

hokein updated this revision to Diff 495502. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc

[PATCH] D142905: Change multilib selection algorithm

michaelplatings updated this revision to Diff 495532. michaelplatings marked an inline comment as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? s_label : 0; + } else { When `res != NULL`, then `res` is derived from `*s`, not from `s`. e.g. ```

[PATCH] D142933: Add -print-multi-selection-flags argument

michaelplatings updated this revision to Diff 49. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

benlangmuir added a comment. Dupe of https://reviews.llvm.org/D143428 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143461/new/ https://reviews.llvm.org/D143461 ___ cfe-commits mailing list

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

benlangmuir added a comment. > This should allow the path serialization of input files to use the paths used > when looking up a file entry, instead of the last reference. Isn't this at odds with not having the VFS-mapped paths? It's not obvious to me why we want these specific semantics.

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We encounter a few internal

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); The import of attributes is handled in function `ASTImporter::Import(Decl*)`. This

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

hokein added a comment. Thanks, it looks mostly good. This needs some work on rebase (as we have landed a few patches that change `StandardLibrary.cpp` file). I will rebase it and land it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4da283872ad9: [include-mapping] Regenerate the StdSymbolMap.inc from the 20220730 html book. (authored by VitaNuo,

[clang] 4da2838 - [include-mapping] Regenerate the StdSymbolMap.inc from the 20220730 html book.

Author: Viktoriia Bakalova Date: 2023-02-07T14:52:18+01:00 New Revision: 4da283872ad925cbffca94f74800a987cc9ba85f URL: https://github.com/llvm/llvm-project/commit/4da283872ad925cbffca94f74800a987cc9ba85f DIFF:

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. **Summary** This patch makes debug-info generation

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 495554. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 495558. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

Sockke added a comment. @carlosgalvezp Thanks for your review! I committed it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 495493. TIFitis marked 4 inline comments as done. TIFitis added a comment. Changed namespace to mlir::LLVM for common files. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

hokein updated this revision to Diff 495496. hokein marked an inline comment as done. hokein added a comment. add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143486/new/ https://reviews.llvm.org/D143486 Files:

[clang-tools-extra] 41a6085 - [clangd] Fix a crash in semantic highlighting.

Author: Haojian Wu Date: 2023-02-07T14:54:39+01:00 New Revision: 41a6085252efe4c2b806e03d923c0b0b35fc3baa URL: https://github.com/llvm/llvm-project/commit/41a6085252efe4c2b806e03d923c0b0b35fc3baa DIFF: https://github.com/llvm/llvm-project/commit/41a6085252efe4c2b806e03d923c0b0b35fc3baa.diff

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

rmaz updated this revision to Diff 495512. rmaz edited the summary of this revision. rmaz added a comment. Use FileEntryRef, rename method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files:

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

skatrak added a comment. In D143493#4110230 , @awarzynski wrote: > In what cases would this flag be used in practice? I've scanned Clang and > couldn't find any answers. It is introduced to the arguments list in `Clang::AddPreprocessingOptions` in

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 495559. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6085252ef: [clangd] Fix a crash in semantic highlighting. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142905: Change multilib selection algorithm

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:31 public: - using flags_list = std::vector; + using flags_list = std::set; + using arg_list = std::vector; peter.smith wrote: > would flags_set be a better name. I'm

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

awarzynski added a comment. In what cases would this flag be used in practice? I've scanned Clang and couldn't find any answers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143493/new/ https://reviews.llvm.org/D143493

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

awarzynski added a comment. In D143493#4110272 , @skatrak wrote: > It is introduced to the arguments list in `Clang::AddPreprocessingOptions` in > certain cases to add the OpenMP wrapper "__clang_openmp_device_functions.h" > to the list of includes for

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495627. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/AST/ASTContext.cpp clang/lib/AST/CMakeLists.txt

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 495592. bryanpkc marked 4 inline comments as done. bryanpkc added a comment. Rebased on trunk and addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added a comment. Hmm, this doesn't work if the callee is somewhere in between the path from the dynamic to the static type, e.g. struct A { virtual constexpr int foo() const { return 1; } }; struct B : A { virtual constexpr int foo() const { return A::foo(); } };

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 495611. ManuelJBrito added a comment. Add end to end tests Currrently these expect a mov that will be removed when the instcombine bug is fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143287/new/

[clang] 836249b - Add codegen for llvm log2/log10 elementwise builtins

Author: Joshua Batista Date: 2023-02-07T12:23:48-08:00 New Revision: 836249b1c2f0540ed0c886d6c3558b2f4f179249 URL: https://github.com/llvm/llvm-project/commit/836249b1c2f0540ed0c886d6c3558b2f4f179249 DIFF:

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, ldionne. Herald added a project: All. v.g.vassilev requested review of this revision. https://reviews.llvm.org/D29877 implements a useful -Wunused-template diagnostic detects unused internal linkage templates. This

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

mikerice accepted this revision. mikerice added a comment. This revision is now accepted and ready to land. LGTM. Thanks for taking care of this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } without these two lines to promote i32, I suppose

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito added a comment. In D143287#4108165 , @craig.topper wrote: > In D143287#4107439 , @ManuelJBrito > wrote: > >> In D143287#4103597 , @craig.topper >> wrote:

[clang] a29e676 - [-Wunsafe-buffer-usage] Generate fix-it for local variable declarations

Author: Ziqing Luo Date: 2023-02-07T13:17:44-08:00 New Revision: a29e67614c3b7018287e5f68c57bba7618aa880e URL: https://github.com/llvm/llvm-project/commit/a29e67614c3b7018287e5f68c57bba7618aa880e DIFF: https://github.com/llvm/llvm-project/commit/a29e67614c3b7018287e5f68c57bba7618aa880e.diff

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa29e67614c3b: [-Wunsafe-buffer-usage] Generate fix-it for local variable declarations (authored by ziqingluo-90). Changed prior to commit:

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya reopened this revision. hiraditya added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. reopening to update the failing testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/

[PATCH] D143439: [RISCV] Add vendor-defined XTheadBb (basic bit-manipulation) extension

philipp.tomsich added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:318 +if (Subtarget.is64Bit()) + setOperationAction({ISD::CTLZ, ISD::CTLZ_ZERO_UNDEF}, MVT::i32, Custom); + } craig.topper wrote: > without these two lines to

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak updated this revision to Diff 495615. ahatanak marked an inline comment as done. ahatanak added a comment. Instead of pushing an empty lambda scope, switch to the enclosing context if the variable is used in a default argument expression of a lambda call operator. Repository: rG

[PATCH] D143386: Add function pointer alignment to DataLayout

efriedma added a comment. In D143386#4110398 , @gchatelet wrote: >> And the x86 doesn't specify 4-byte alignment. > > I thought that specifying it in the `DataLayout` would help getting rid of > the special handling in ConstantFold >

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak updated this revision to Diff 495619. ahatanak added a comment. Fix indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143109/new/ https://reviews.llvm.org/D143109 Files: clang/lib/Sema/SemaExpr.cpp

[clang] 4cbf4bb - Remove textual headers from module map

Author: Adrian Prantl Date: 2023-02-07T13:24:47-08:00 New Revision: 4cbf4bb4dd17b813179467396c692180681cb003 URL: https://github.com/llvm/llvm-project/commit/4cbf4bb4dd17b813179467396c692180681cb003 DIFF: https://github.com/llvm/llvm-project/commit/4cbf4bb4dd17b813179467396c692180681cb003.diff

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

francii updated this revision to Diff 495570. francii added a comment. Update test case verbosity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc marked 9 inline comments as done. bryanpkc added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:312 + /// Flags to identify the types for overloaded SME builtins. + class SMETypeFlags { +uint64_t Flags; david-arm wrote: >

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

DHowett-MSFT added a comment. Thanks for the review! I’ll need somebody to help land this, as I don’t have write access to the project. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143410/new/ https://reviews.llvm.org/D143410

[PATCH] D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values

hiraditya updated this revision to Diff 495641. hiraditya added a comment. Updated the failing testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131230/new/ https://reviews.llvm.org/D131230 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143495/new/ https://reviews.llvm.org/D143495

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 495588. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Driver/Options.td

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

augusto2112 added a comment. Hi @hokein, this broke the LLDB incremental build (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/50629/console). How do we fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143399/new/

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495609. domada added a reviewer: akyrtzi. domada added a comment. Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue reported by @akyrtzi . I modified CMakeLists.txt so that it requires generation of missing `Attributes.inc`. @akyrtzi

[PATCH] D143109: [Sema] Push a LambdaScopeInfo before calling SubstDefaultArgument

ahatanak added a comment. I agree that pushing an empty scope without initializing any of its members seems wrong. Instead of doing that, the updated patch changes the decl context instead if we are trying to capture a variable in a default argument expression of a lambda call operator. I

[PATCH] D143428: [clang][deps] Fix race condition

This revision was automatically updated to reflect the committed changes. Closed by commit rG152f2914607f: [clang][deps] Fix race condition (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143428/new/

[clang] 5e14a48 - [clang] NFC: Remove GCC 5.1 workaround in FileEntry

Author: Jan Svoboda Date: 2023-02-07T09:27:24-08:00 New Revision: 5e14a48463b4c3eb3f36eeef30dee7312f9127da URL: https://github.com/llvm/llvm-project/commit/5e14a48463b4c3eb3f36eeef30dee7312f9127da DIFF: https://github.com/llvm/llvm-project/commit/5e14a48463b4c3eb3f36eeef30dee7312f9127da.diff

[PATCH] D143427: [clang] NFC: Remove GCC 5.1 workaround in FileEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e14a48463b4: [clang] NFC: Remove GCC 5.1 workaround in FileEntry (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143427/new/

[clang] 152f291 - [clang][deps] Fix race condition

Author: Jan Svoboda Date: 2023-02-07T09:26:56-08:00 New Revision: 152f2914607ffe632202ee660208d6dfba6c8870 URL: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870 DIFF: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870.diff

[clang] e716b02 - [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

Author: Fazlay Rabbi Date: 2023-02-07T12:09:52-08:00 New Revision: e716b0204a5ae2a96289a335b2ab30a6c3fb09cf URL: https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf DIFF: https://github.com/llvm/llvm-project/commit/e716b0204a5ae2a96289a335b2ab30a6c3fb09cf.diff

[PATCH] D143021: [OpenMP 5.2] Deprecate 'destroy' clause without argument for 'depobj' construct

This revision was automatically updated to reflect the committed changes. Closed by commit rGe716b0204a5a: [OpenMP 5.2] Deprecate destroy clause without argument for depobj construct (authored by mdfazlay, committed by mikerice). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG836249b1c2f0: Add codegen for llvm log2/log10 elementwise builtins (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D143207?vs=494477=495612#toc Repository: rG LLVM Github

[PATCH] D142630: [clang][Interp] Implement virtual function calls

aaron.ballman added a comment. In D142630#4110839 , @tbaeder wrote: > Hmm, this doesn't work if the callee is somewhere in between the path from > the dynamic to the static type, e.g. > > struct A { > virtual constexpr int foo() const { return 1;

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4111048 , @domada wrote: > Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue > reported by @akyrtzi . > > I modified CMakeLists.txt so that it requires generation of missing > `Attributes.inc`. >

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

benlangmuir updated this revision to Diff 495573. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143446/new/ https://reviews.llvm.org/D143446 Files: clang/include/clang/Frontend/CompilerInvocation.h clang/lib/Basic/LangOptions.cpp clang/lib/Frontend/CompilerInvocation.cpp

[clang] d27fb5e - [Serialization] Add support for (de)serializing #pragma pack

Author: Dustin Howett Date: 2023-02-07T11:37:02-08:00 New Revision: d27fb5efc5f2086fa157e7d836b61bae4d5f3734 URL: https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734 DIFF: https://github.com/llvm/llvm-project/commit/d27fb5efc5f2086fa157e7d836b61bae4d5f3734.diff

[PATCH] D143410: [Serialization] Add support for (de)serializing #pragma pack

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd27fb5efc5f2: [Serialization] Add support for (de)serializing #pragma pack (authored by DHowett-MSFT, committed by mikerice). Changed prior to

[clang-tools-extra] 3c07db5 - [Clang] Refactor "Designators" into a unified implementation [NFC]

Author: Bill Wendling Date: 2023-02-07T12:59:17-08:00 New Revision: 3c07db5f58e9852f35202f0fffed50fc7506f37b URL: https://github.com/llvm/llvm-project/commit/3c07db5f58e9852f35202f0fffed50fc7506f37b DIFF: https://github.com/llvm/llvm-project/commit/3c07db5f58e9852f35202f0fffed50fc7506f37b.diff

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG3c07db5f58e9: [Clang] Refactor Designators into a unified implementation [NFC] (authored by void). Repository: rG LLVM

  1   2   >