[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

brad marked 2 inline comments as done. brad added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:432 + Triple.getOSMajorVersion() >= 13)) || Triple.isOSOpenBSD() || + Triple.isMusl()) +ABI = "elfv2"; dim wrote: >

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

brad updated this revision to Diff 498648. brad added a comment. reformatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 Files: clang/lib/Basic/Targets/PPC.h

[PATCH] D141215: [clang-repl][WIP] Implement pretty printing

junaire updated this revision to Diff 498655. junaire added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D144341: [Driver][FreeBSD]

brad created this revision. brad added a reviewer: dim. brad added a project: clang. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: MaskRay. While looking at other usage of

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. nudge! at anyone who knows what to do here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 ___ cfe-commits mailing list

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

inglorion added a comment. Is this intended to warn on code that casts a function taking a pointer to some non-void type to a function that takes a void*? void set(void (*g)(int*)) { f = (void(*)(void*)) g; } gives me warning: cast from 'void (*)(int *)' to 'void (*)(void *)'

[PATCH] D144136: Add a "remark" to report on array accesses

kees added a comment. Here's a test-case. I'd expect 6 remarks from building this: /* Build with -Wall -O2 -fstrict-flex-arrays=3 -fsanitize=bounds -Rarray-bounds */ #include #include #include #include #define report_size(p, index) do {\ const size_t bdos =

[PATCH] D144320: [Clang][OpenMP] Update tests using update_cc_test_checks.py

tianshilei1992 updated this revision to Diff 498610. tianshilei1992 added a comment. unify check prefix(es) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144320/new/ https://reviews.llvm.org/D144320 Files:

[clang] c31bc7b - [clang-format] Handle tabs in file path for git-clang-format

Author: Michael Kirk Date: 2023-02-18T12:56:46-08:00 New Revision: c31bc7bdf8108fae490585763bf69a1b51327954 URL: https://github.com/llvm/llvm-project/commit/c31bc7bdf8108fae490585763bf69a1b51327954 DIFF: https://github.com/llvm/llvm-project/commit/c31bc7bdf8108fae490585763bf69a1b51327954.diff

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan closed this revision. owenpan added a comment. Landed in c31bc7bdf810 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron updated this revision to Diff 498622. Izaron added a comment. A small fix for `def FutureAttrs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144334/new/ https://reviews.llvm.org/D144334 Files: clang/docs/ReleaseNotes.rst

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1448 +def Assume : StmtAttr { + let Spellings = [CXX11<"", "assume", 202302>]; + let Documentation = [AssumeDocs]; Honestly I don't have a clue what these numbers `202302` (apparently

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron updated this revision to Diff 498625. Izaron added a comment. More thorough AST test. Set the right macros number - thanks to @philnik! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144334/new/ https://reviews.llvm.org/D144334 Files:

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

dim added a comment. In D144232#4136787 , @brad wrote: > I noticed this review. I have provided a more complete diff for review at > D144321 . Yeah I think that is probably the better option, hope @pkubaj and @adalava

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, some minor clang-format nits, but these aren't critical (to me at least :) Comment at: clang/lib/Basic/Targets/PPC.h:432 + Triple.getOSMajorVersion() >= 13)) ||

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. In D141569#4136493 , @ccotter wrote: > @PiotrZSL I added an option to allow disabling the strict behavior. It should > address many of your examples (e.g., moving subobjects) . Let me know if you > have more feedback. I will

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser added a comment. I am currently unable to progress as all of my interceptors are not working. The interceptors are failing, because the `GetInstructionSize` function fails. For example, the `CreateThread` Win32 function starts on my Windows 11 installation with `4c 8b dc mov

[clang] 7ac658a - [WebAssembly] assert(false) -> llvm_unreachable

Author: Benjamin Kramer Date: 2023-02-18T09:38:18+01:00 New Revision: 7ac658a07b9a2937f1a9319a47a9cec6afae2370 URL: https://github.com/llvm/llvm-project/commit/7ac658a07b9a2937f1a9319a47a9cec6afae2370 DIFF:

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

cor3ntin updated this revision to Diff 498573. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. - Reword Release note - Restore dependent instantiation tests using Richard's suggestion - Add additional test to check that diagnostics for static_assert are emitted once per

[PATCH] D144157: Add 128-bit integer support to enum element

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/enum2.c:30 +// CHECK: ![[E]] = !DIEnumerator(name: "b0", value: 24197857203266734864629346612071973665, isUnsigned: true) +

[PATCH] D144157: Add 128-bit integer support to enum element

zhouyizhou updated this revision to Diff 498571. zhouyizhou added a comment. delete the trailing blank line Thank you all ;-) I have no access write to LLVM, could you commit it for me when you are not busy? Thanks a lot Cheers Zhouyi Zhouyi Zhou CHANGES SINCE LAST ACTION

[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2665 +if (Style.isVerilog() && Precedence == prec::Comma && +VerilogFirstOfType != nullptr) { + addFakeParenthesis(VerilogFirstOfType, prec::Comma); And other places

[PATCH] D144157: Add 128-bit integer support to enum element

h-vetinari added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:19571-19573 - // TODO: If the result value doesn't fit in an int, it must be a long or long - // long value. ISO C does not support this, but GCC does as an extension, - // emit a warning.

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders marked an inline comment as done. tom-anders added inline comments. Comment at: clang/lib/AST/RawCommentList.cpp:227 + SourceMgr.getLocForStartOfFile(SourceMgr.getMainFileID()), + Allocator, SourceMgr.getDiagnostics(),

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders updated this revision to Diff 498586. tom-anders added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. - Move to free function in CodeCompletionStrings.h - Add back comment markers before parsing (Index stores comments without markers, but

[PATCH] D144136: Add a "remark" to report on array accesses

kees added a comment. This appears to be working for me. For before/after changes, the other half is still needed, i.e. a "accessing array of unknown size" and eventually splitting the dynamic sizing check off of that one (once -fsanitize=bounds checks __builtin_dynamic_object_size). For

[PATCH] D144317: [clang-format] Fix handling of TypeScript tuples with optional last member

owenpan added reviewers: krasimir, HazardyKnusperkeks, rymiel. owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestJS.cpp:2826 +TEST_F(FormatTestJS, TupleTypeWithOptionalLastElement) { + verifyFormat("type T = [number?];"); +} Can you

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron added a comment. If you are not familiar with the `[[assume(expr]]` concept and want to know more, I wrote a small article about it recently, with a lot of additional links (including to the author of the proposal) - https://izaron.github.io/posts/assume/ Repository: rG LLVM Github

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron updated this revision to Diff 498637. Izaron added a comment. Use the common `isInAnonymousNamespace` matcher. Split the test into two files. Thanks to @carlosgalvezp for advices! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron marked 2 inline comments as done. Izaron added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-inline-const-variables-in-headers.hpp:1 +// RUN: %check_clang_tidy %s -std=c++17 modernize-use-inline-const-variables-in-headers %t +

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

Izaron created this revision. Izaron added reviewers: clang-language-wg, aaron.ballman, rsmith, nikic. Herald added a subscriber: StephenFan. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang already

[PATCH] D144334: [Clang] Add C++2b attribute [[assume(expression)]]

philnik added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1448 +def Assume : StmtAttr { + let Spellings = [CXX11<"", "assume", 202302>]; + let Documentation = [AssumeDocs]; Izaron wrote: > Honestly I don't have a clue what these numbers

[PATCH] D144321: [PowerPC] Correctly use ELFv2 ABI on all OS's that use the ELFv2 ABI

brad updated this revision to Diff 498642. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144321/new/ https://reviews.llvm.org/D144321 Files: clang/lib/Basic/Targets/PPC.h llvm/lib/Target/PowerPC/PPCTargetMachine.cpp