[PATCH] D143587: [Docs] Multilib design

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499511. michaelplatings marked 8 inline comments as done. michaelplatings added a comment. Rebase and apply changes requested by @MaskRay and @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8bd13ad - [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

2023-02-22 Thread via cfe-commits
Author: ShangwuYao Date: 2023-02-22T15:44:46Z New Revision: 8bd13ad6c5374f39408be4a34989007999a57ee9 URL: https://github.com/llvm/llvm-project/commit/8bd13ad6c5374f39408be4a34989007999a57ee9 DIFF: https://github.com/llvm/llvm-project/commit/8bd13ad6c5374f39408be4a34989007999a57ee9.diff LOG:

[PATCH] D144047: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on host/device

2023-02-22 Thread Shangwu Yao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd13ad6c537: [CUDA][SPIRV] Match builtin types and __GCC_ATOMIC_XXX_LOCK_FREE macros on… (authored by shangwuyao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

2023-02-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D143891#4144161 , @aaron.ballman wrote: > LGTM but we should add a release note for the change. This fixes P0848R3, which is a clang 16 feature. If we backport this we don't need a changelog entry. Repository: rG LLVM

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

2023-02-22 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Ugh, I admit, its a little hard to follow what happened here. You moved a lot of code around (I agree with that!), but also changed code as well. Can you just summarize what is NOT just moved code and needs a more thorough look? Comment at:

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I guess this is fine. We should try to run V tests, this is really just checking if we generate (some) code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143075: BareMetal ToolChain multilib layering

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499503. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[PATCH] D144179: [Clang] Added functionality to provide config file name via env variable

2023-02-22 Thread Jolanta Jensen via Phabricator via cfe-commits
jolanta.jensen updated this revision to Diff 499502. jolanta.jensen added a comment. Adjusting the test for Windows OS again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144179/new/ https://reviews.llvm.org/D144179 Files:

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

2023-02-22 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I'm worried this makes use of LLVM on HPC machines even harder. That said, I'm open to suggestions and I am not well versed in all the ways we can make it work. Our problem is that there are N `libomptarget.so` files and N `libomptarget.nvptx.so` files on a system,

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499500. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Rebase and apply changes requested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

2023-02-22 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield requested changes to this revision. JonChesterfield added a comment. This revision now requires changes to proceed. Marking this as "no" because as far as I can tell it'll stop anyone running openmp built from source which constitutes a severe regression and I am struggling to

[PATCH] D143075: BareMetal ToolChain multilib layering

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499491. michaelplatings added a comment. Rebase and remove some braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-22 Thread Kiran Chandramohan via Phabricator via cfe-commits
kiranchandramohan requested changes to this revision. kiranchandramohan added a comment. This revision now requires changes to proceed. Please add tests for the MLIR portion. Could you also post the full LLVM IR for a construct with the map clause? Comment at:

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-22 Thread Akash Banerjee via Phabricator via cfe-commits
TIFitis added a comment. @kiranchandramohan @clementval can you please take a look and let me know if any more changes are required for this patch? Thanks, Akash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D144456: [clangd] Publish diagnostics with stale preambles

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG465ee9bfb26d: [clangd] Publish diagnostics with stale preambles (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2a12f7f9b6: [clangd] Provide patched diagnostics with preamble patch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/

[PATCH] D143095: [clangd] Respect preamble-patch when handling diags

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG909cd1f9a893: [clangd] Respect preamble-patch when handling diags (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143095/new/

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG7177a237b68f: [clangd] Add config option for fast diagnostics mode (authored by kadircet). Changed prior to commit:

[PATCH] D143093: [clangd] #undef macros inside preamble patch

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG75ae784e8f49: [clangd] #undef macros inside preamble patch (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143093/new/

[clang-tools-extra] 465ee9b - [clangd] Publish diagnostics with stale preambles

2023-02-22 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-02-22T15:54:16+01:00 New Revision: 465ee9bfb26d46f2732d8b238dcbadc38373dbb3 URL: https://github.com/llvm/llvm-project/commit/465ee9bfb26d46f2732d8b238dcbadc38373dbb3 DIFF:

[clang-tools-extra] 8c2a12f - [clangd] Provide patched diagnostics with preamble patch

2023-02-22 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-02-22T15:54:15+01:00 New Revision: 8c2a12f7f9b6dc078bfb18df979fdf27c6a3 URL: https://github.com/llvm/llvm-project/commit/8c2a12f7f9b6dc078bfb18df979fdf27c6a3 DIFF:

[clang-tools-extra] 909cd1f - [clangd] Respect preamble-patch when handling diags

2023-02-22 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-02-22T15:54:15+01:00 New Revision: 909cd1f9a8934033a803659da8c54c87013941ef URL: https://github.com/llvm/llvm-project/commit/909cd1f9a8934033a803659da8c54c87013941ef DIFF:

[clang-tools-extra] 75ae784 - [clangd] #undef macros inside preamble patch

2023-02-22 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-02-22T15:54:15+01:00 New Revision: 75ae784e8f49cf2425f3bf702a1bbf6c581e721a URL: https://github.com/llvm/llvm-project/commit/75ae784e8f49cf2425f3bf702a1bbf6c581e721a DIFF:

[clang-tools-extra] 7177a23 - [clangd] Add config option for fast diagnostics mode

2023-02-22 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2023-02-22T15:54:14+01:00 New Revision: 7177a237b68f32befcecedba78a875f1bbc4a609 URL: https://github.com/llvm/llvm-project/commit/7177a237b68f32befcecedba78a875f1bbc4a609 DIFF:

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

2023-02-22 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:4218-4223 defm openmp_implicit_rpath: BoolFOption<"openmp-implicit-rpath", LangOpts<"OpenMP">, - DefaultTrue, + DefaultFalse, PosFlag, NegFlag, BothFlags<[NoArgumentUnused]>>;

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added inline comments. Comment at: clang/test/Driver/baremetal-multilib.cpp:14 +// RUN: | FileCheck %s +// CHECK: "{{.*}}clang{{.*}}" "-cc1" "-triple" "thumbv8m.main-none-unknown-eabihf" +// CHECK-SAME: "-internal-isystem"

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499479. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply changes requested by @peter.smith and @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

2023-02-22 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. So what is this configuration file? Joseph found a Gentoo blog post https://blogs.gentoo.org/mgorny/2022/10/07/clang-in-gentoo-now-sets-default-runtimes-via-config-file/ and I don't have a clang.cfg file in my install dir Repository: rG LLVM Github Monorepo

[PATCH] D144484: [Tooling/Inclusion] Handle std::get symbol.

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144484/new/ https://reviews.llvm.org/D144484

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks (both for the patch and for bearing with me)! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-22 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end())

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-22 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 499456. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files:

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

2023-02-22 Thread Domján Dániel via Phabricator via cfe-commits
isuckatcs added a comment. @xazax.hun can we merge this or should we wait for someone else's approval too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 ___ cfe-commits mailing list

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

2023-02-22 Thread Domján Dániel via Phabricator via cfe-commits
isuckatcs updated this revision to Diff 499453. isuckatcs added a comment. Added tests for function pointers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/new/ https://reviews.llvm.org/D135495 Files: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

2023-02-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144540/new/ https://reviews.llvm.org/D144540

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) VitaNuo wrote: > kadircet wrote: > > nit: >

[PATCH] D143891: [Clang] Adjust triviality computation in QualType::isTrivialType to C++20 cases.

2023-02-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but we should add a release note for the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143891/new/

[PATCH] D142933: Add -print-multi-selection-flags argument

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499450. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces and blank lines as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings abandoned this revision. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Squashed into D142932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143763/new/

[PATCH] D142932: [NFC] Multilib YAML parsing

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499443. michaelplatings added a subscriber: peter.smith. michaelplatings added a comment. - Squash D143763 into this change as suggested by @MaskRay - Use PascalCase field names as requested by @phosek - Applied

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

2023-02-22 Thread Donát Nagy via Phabricator via cfe-commits
donat.nagy added a comment. Note that the Debian x64 test failure is from the unit test TEST(ClangdServer, MemoryUsageTest) { MockFS FS; MockCompilationDatabase CDB; ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); auto FooCpp = testPath("foo.cpp");

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-22 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Headers.cpp:303 + llvm::SmallVector Includes; + auto It = MainFileIncludesBySpelling.find(Spelling); + if (It == MainFileIncludesBySpelling.end()) kadircet wrote: > nit:

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-22 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 499436. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files:

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

2023-02-22 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 499433. DmitryPolukhin added a comment. Move call addTargetAndModeForProgramName after SystemIncludeExtractor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

2023-02-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added a comment. Overall not bad, except reported things, I don't have any complains. Number of options is not an issue. 90% of users wont use them, 10% will be happy to find them instead of dealing with NOLINT. Comment at:

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

2023-02-22 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 499417. zyounan added a comment. Move parsing logic to Record.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D142905: Change multilib selection algorithm

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 499416. michaelplatings marked 2 inline comments as done. michaelplatings added a comment. Remove braces as requested by @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

2023-02-22 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. I don't know how this configuration file works. Running clang from the build directory is useful when developing, but to avoid user facing regression we'd need it to run from the install directory. The use case is someone builds trunk or a release on a HPC

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Animesh Kumar via Phabricator via cfe-commits
animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.

[PATCH] D142893: [NFC] Class for building MultilibSet

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. michaelplatings marked 4 inline comments as done. Closed by commit rG850dab0f2537: [NFC] Class for building MultilibSet (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 850dab0 - [NFC] Class for building MultilibSet

2023-02-22 Thread Michael Platings via cfe-commits
Author: Michael Platings Date: 2023-02-22T09:24:48Z New Revision: 850dab0f2537bb31103578fc35caef2f1ad98f04 URL: https://github.com/llvm/llvm-project/commit/850dab0f2537bb31103578fc35caef2f1ad98f04 DIFF: https://github.com/llvm/llvm-project/commit/850dab0f2537bb31103578fc35caef2f1ad98f04.diff

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67e28a3010e1: [Clang] Improve hermeticity of clang_rt tests (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 67e28a3 - [Clang] Improve hermeticity of clang_rt tests

2023-02-22 Thread Michael Platings via cfe-commits
Author: Michael Platings Date: 2023-02-22T09:23:10Z New Revision: 67e28a3010e1852ec670cf5346fd171bf2a16774 URL: https://github.com/llvm/llvm-project/commit/67e28a3010e1852ec670cf5346fd171bf2a16774 DIFF: https://github.com/llvm/llvm-project/commit/67e28a3010e1852ec670cf5346fd171bf2a16774.diff

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

2023-02-22 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG341dd6076b12: [Lex] Fix a crash in updateConsecutiveMacroArgTokens. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 341dd60 - [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

2023-02-22 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-02-22T10:16:02+01:00 New Revision: 341dd6076b123946f79a3148b660d6579f9683a7 URL: https://github.com/llvm/llvm-project/commit/341dd6076b123946f79a3148b660d6579f9683a7 DIFF: https://github.com/llvm/llvm-project/commit/341dd6076b123946f79a3148b660d6579f9683a7.diff

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

2023-02-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 499405. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144054/new/ https://reviews.llvm.org/D144054 Files:

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

2023-02-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144542/new/ https://reviews.llvm.org/D144542

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

2023-02-22 Thread Piotr Zegar via Phabricator via cfe-commits
PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:101 + IgnoreComparisonForTypesRegexp( + Options.get("IgnoreComparisonForTypesRegexp", "^::std::array")) {} + carlosgalvezp wrote: > I

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added a comment. https://reviews.llvm.org/D144542 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666 ___ cfe-commits mailing list

[PATCH] D144542: [Clang] Improve hermeticity of clang_rt tests

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added a project: All. michaelplatings requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifying --sysroot prevents libclang_rt from being located in

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

2023-02-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D143666#4143702 , @michaelplatings wrote: > I'm happy to revert this and add `--sysroot` if you prefer. That would fit > with keeping the tests hermetic. That would be my preference and it would match what we do in other

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

2023-02-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/TokenLexer.cpp:1029 + // Including Limit will not mischeck for across-file-id tokens + // because SourceManager allocates

[PATCH] D143840: [clang] Add the check of membership for the issue #58674 and improve the lookup process

2023-02-22 Thread Liming Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8498ba6c2860: [clang] Add the check of membership for the issue #58674 and improve the lookup… (authored by lime). Repository: rG LLVM Github

[clang] 8498ba6 - [clang] Add the check of membership for the issue #58674 and improve the lookup process

2023-02-22 Thread Liming Liu via cfe-commits
Author: Liming Liu Date: 2023-02-22T16:43:50+08:00 New Revision: 8498ba6c2860c838183f9951b63df26ab5f02265 URL: https://github.com/llvm/llvm-project/commit/8498ba6c2860c838183f9951b63df26ab5f02265 DIFF: https://github.com/llvm/llvm-project/commit/8498ba6c2860c838183f9951b63df26ab5f02265.diff

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added a comment. I'm happy to revert this and add `--sysroot` if you prefer. That would fit with keeping the tests hermetic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143666/new/ https://reviews.llvm.org/D143666

[PATCH] D143666: [Clang] Fix clang_rt tests when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is ON

2023-02-22 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added a comment. Hi Petr, In LLVM Embedded Toolchain for Arm we put libclang_rt in the regular library directory, not the resource dir. Therefore `-resource-dir` has no effect for us. Instead of this change, I could have added a `--sysroot` argument to each test, but this change

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

2023-02-22 Thread Kristina Bessonova via Phabricator via cfe-commits
krisb added a comment. @jmmartinez thank you for looking at this! Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags,

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

2023-02-22 Thread Sam James via Phabricator via cfe-commits
thesamesam created this revision. thesamesam added a reviewer: aaron.ballman. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is for 16.x. Bug: https://github.com/llvm/llvm-project/issues/59792

<    1   2