[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1561 + /// should be placed. + /// \param HasRegion True if the op has a region associated with it, false + /// otherwise kiranchandramohan wrote: > Can't the

[PATCH] D143704: [flang] Part one of Feature List action

elmcdonough updated this revision to Diff 502691. elmcdonough retitled this revision from "[Flang] Part one of Feature List action" to "[flang] Part one of Feature List action". elmcdonough added a comment. Allow for plugin to parse semantically incorrect files. Repository: rG LLVM Github

[PATCH] D145362: [clang] Update test according to P1937

Fznamznon added inline comments. Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14 -// bad_assert_copyable is not needed for constant evaluation -// (and thus not instantiated) +// consteval assert is not instantiated as well. template consteval void assert_copyable() {

[clang] 3e00f24 - [NFC][Clang] add test comments for GitHub issue 58896

Author: Yuanfang Chen Date: 2023-03-06T11:55:39-08:00 New Revision: 3e00f24f6356cb351b969bc7414546c2d220e059 URL: https://github.com/llvm/llvm-project/commit/3e00f24f6356cb351b969bc7414546c2d220e059 DIFF: https://github.com/llvm/llvm-project/commit/3e00f24f6356cb351b969bc7414546c2d220e059.diff

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D145344#4171087 , @MyDeveloperDay wrote: > Thanks for this, LGTM (maybe we can cherry pick this to 16.0) +1 because of the invalid code. Repository: rG LLVM Github

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd added a comment. Just a friendly reminder, I'd like to get this merged to do a follow up change to improve some of the usability of these flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145007/new/ https://reviews.llvm.org/D145007

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9306ef9750b7: [clang][alias|ifunc]: Add a diagnostic for mangled names (authored by 0xdc03, committed by erichkeane). Changed prior to commit:

[clang] 9306ef9 - [clang][alias|ifunc]: Add a diagnostic for mangled names

Author: Dhruv Chawla Date: 2023-03-06T08:59:02-08:00 New Revision: 9306ef9750b7a319d59f6d3e4977e01e39b8f161 URL: https://github.com/llvm/llvm-project/commit/9306ef9750b7a319d59f6d3e4977e01e39b8f161 DIFF: https://github.com/llvm/llvm-project/commit/9306ef9750b7a319d59f6d3e4977e01e39b8f161.diff

[PATCH] D144912: [clang-tidy] readability-identifier-naming: fix hungarian enum prefix in C

amurzeau added a comment. Hi, thanks PiotrZSL, the build is now passed and is green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144912/new/ https://reviews.llvm.org/D144912 ___ cfe-commits mailing

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

wolfgangp added a comment. In D145271#4171267 , @hans wrote: > Interesting! Do you have an example where this (local dllexport/import > classes) comes up in practice? A customer complained about the following code (I'm obscuring the class names)

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added a comment. In D144878#4171234 , @karapsinie wrote: > PTAL. Have you seen the comments on the GCC issue that @MaskRay filed? Is that something we should do as well? (It doesn't have to be part of this patch, but it'd be good to

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised awarzynski wrote: > agozillon wrote: > >

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

Fznamznon updated this revision to Diff 502754. Fznamznon added a comment. Rebase and add quoting [expr.const] p15.1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145251/new/ https://reviews.llvm.org/D145251 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D145021: [Clang][AIX][p] Claim -p in front end

francii updated this revision to Diff 502693. francii added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145021/new/ https://reviews.llvm.org/D145021 Files: clang/lib/Driver/ToolChains/AIX.cpp

[clang] c4de9b9 - [clang][deps] Un-XFAIL test on AIX

Author: Jan Svoboda Date: 2023-03-06T10:57:43-08:00 New Revision: c4de9b9c021d14972157096514d17692f15fbb15 URL: https://github.com/llvm/llvm-project/commit/c4de9b9c021d14972157096514d17692f15fbb15 DIFF: https://github.com/llvm/llvm-project/commit/c4de9b9c021d14972157096514d17692f15fbb15.diff

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM, Comment at: clang/include/clang/Driver/Options.td:4257 + HelpText<"Add -rpath with architecture-specific resource directory to the linker flags. " + "When --hip-link is

[PATCH] D145362: [clang] Update test according to P1937

Fznamznon updated this revision to Diff 502742. Fznamznon added a comment. Rebase and apply the nitpick Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145362/new/ https://reviews.llvm.org/D145362 Files: clang/test/CXX/expr/expr.const/p8-2a.cpp

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 + `#61177 `_ in anticipation + of `CWG2699 _` being accepted by WG21.

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this LGTM! I have to head out shortly, so I'll land this on your behalf tomorrow when I have the time to babysit the postcommit build farm. However, if you'd like to

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. If others don't have anything to add on this matter, I guess this is fine. The new option names feel rather wordy and unwieldy (especially compared to the clang-cl forms they're aliases

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 502670. TIFitis marked 9 inline comments as done. TIFitis added a comment. Adrresed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Files:

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `(DRE.data() + any)`

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1079 +dyn_cast(ArraySub->getBase()->IgnoreImpCasts())) { + // FIXME: this `getASTContext` call is costy, we should pass the + // ASTContext in: Nit:

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. We can’t let specific flag usage leak into the semantics. Cu mode is on or off. If someone really cares about supporting older compilers they could always define their own macro

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestObjC.cpp:1528 + // This is added to acknowledge the behavior, but it should be improved. + verifyFormat("ATTRIBUTE_MACRO ATTRIBUTE_MACRO(X)\n" + "@interface Foo\n"

[PATCH] D144136: Add a "remark" to report on array accesses

void updated this revision to Diff 502760. void added a comment. Revise with Kees's code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144136/new/ https://reviews.llvm.org/D144136 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker added inline comments. Comment at: clang/include/clang-c/Index.h:3552 + * If the cursor does not reference a bit field declaration or if the bit + * field's width does not depend on template parameters, 0 is returned. + */ vedgy wrote: > I just

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 502762. collinbaker added a comment. Add release notes and remove unneeded include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files:

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers updated this revision to Diff 502781. nickdesaulniers added a comment. - add sema test to validate 'p' inputs as per @efriedma Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145416/new/ https://reviews.llvm.org/D145416 Files:

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:70-74 + const auto CharExpr = expr(anyOf( + ignoringParenImpCasts(characterLiteral()), +

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/test/Sema/inline-asm-validate.c:9 + // inputs. + asm (""::"p"(t), "p"(p)); } I should add a test case for `"p"()`. Repository: rG LLVM Github

[PATCH] D145362: [clang] Update test according to P1937

shafik accepted this revision. shafik added a comment. Besides the nitpick, LGTM Comment at: clang/test/CXX/expr/expr.const/p8-2a.cpp:14 -// bad_assert_copyable is not needed for constant evaluation -// (and thus not instantiated) +// consteval assert is not instantiated as

[PATCH] D145141: [Driver] Reject -march= for ppc

This revision was automatically updated to reflect the committed changes. Closed by commit rG7370b9c8ea00: [Driver] Reject -march= for ppc (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D145141?vs=501759=502686#toc Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 7370b9c - [Driver] Reject -march= for ppc

Author: Fangrui Song Date: 2023-03-06T09:16:57-08:00 New Revision: 7370b9c8ea0049f103daae0126861ba4f6ff6f4a URL: https://github.com/llvm/llvm-project/commit/7370b9c8ea0049f103daae0126861ba4f6ff6f4a DIFF: https://github.com/llvm/llvm-project/commit/7370b9c8ea0049f103daae0126861ba4f6ff6f4a.diff

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 502683. john.brawn edited the summary of this revision. john.brawn added a comment. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Herald added a project: clang-tools-extra. Fixed a couple of things causing failures in clangd tests (path

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

awarzynski added inline comments. Comment at: clang/test/Driver/flang/flang-omp.f90:1 +! Check that flang -fc1 is invoked when in --driver-mode=flang +! and the relevant openmp and openmp offload flags are utilised agozillon wrote: > awarzynski wrote: > >

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:186 + `#61177 `_ in anticipation + of `CWG2699 _` being accepted by WG21. This link seems broken? I get

[PATCH] D145411: [WIP][Fuchsia] Include baremetal ARM builtins

phosek created this revision. Herald added subscribers: abrachet, kristof.beyls. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145411

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

efriedma added a comment. I think this is going to change what inputs Sema will accept for "p". If that's intentional, please add test coverage. Otherwise, please make a narrower change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145416/new/

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth added inline comments. Comment at: llvm/include/llvm/IR/MDBuilder.h:61 /// Return metadata containing two branch weights. + MDNode *createBranchWeights(uint32_t TrueWeight, uint32_t FalseWeight, tejohnson wrote: > Update comment to mention new

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. yaxunl requested review of this revision. HIP runtime is the language runtime of HIP. When users need to specify rpath, they usually need to specify rpath

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. This does not seem to be a pressing issue as there are no other reported module/cpp20 related crashes which were fixed by this. Also since it has no tests, it should be fine to postpone it to the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

carlo.bertolli added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { carlo.bertolli wrote: > koops wrote: > > carlo.bertolli

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This LGTM, I agree w/ @cor3ntin about quoting [expr.cont] to document this choice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145251/new/

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

cor3ntin accepted this revision. cor3ntin added a comment. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145251/new/ https://reviews.llvm.org/D145251 ___ cfe-commits mailing list

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker marked 3 inline comments as done. collinbaker added a comment. Thanks for the review. Someone else will need to commit since I don't have permission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/

[PATCH] D145415: add test case

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145415 Files:

[PATCH] D145391: [HIP] Supports env var HIP_PATH

MaskRay added inline comments. Comment at: clang/test/Driver/rocm-detect.hip:42 + +// RUN: rm -rf %T/myhip +// RUN: rm -rf %T/myhip_nouse `%T` is not recommended. https://llvm.org/docs/CommandGuide/lit.html "parent directory of %t (not unique, deprecated, do

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 502776. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

MaskRay added a comment. In D142174#4171731 , @JonChesterfield wrote: > I'm happy with this but agree that "what might be a system path?" is a tricky > heuristic. What we want is to exclude the places that the application will > search anyway, but

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:747-748 break; case 'g': // general register, memory operand or immediate integer. case 'X': // any operand. Info.setAllowsRegister(); nickdesaulniers

[PATCH] D145397: [Lex] Use line markers in preprocessed assembly predefines file

john.brawn created this revision. john.brawn added reviewers: aaron.ballman, rsmith, jansvoboda11, rjmccall. Herald added a project: All. john.brawn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GNU line marker directives are not

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. In D144654#4156430 , @aaron.ballman wrote: > This seems to cause precommit CI failures that should be addressed, and it > should also have a release note about the fix. Failures in CI should be fixed by D145397

[PATCH] D145408: Fix false positive with unreachable C++ catch handlers

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, shafik, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. This addresses an issue found by WG21 and tracked by CWG2699 (which is not yet

[PATCH] D145393: [HIP] Make `--offload-add-rpath` alias of `-frtlib-add-rpath`

MaskRay added a comment. Seems fine. Should we eventually remove `--offload-add-rpath` and `-fopenmp-implicit-rpath`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145393/new/ https://reviews.llvm.org/D145393 ___ cfe-commits mailing list

[PATCH] D145201: [clang] fixes header processing for `-fdiagnostics-format=sarif`

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Sarif.cpp:314-317 + llvm::sort(*Artifacts, [](const json::Value , const json::Value ) { +return x.getAsObject()->getNumber("index") < + y.getAsObject()->getNumber("index"); + });

[PATCH] D145391: [HIP] Supports env var HIP_PATH

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:442 + llvm::sys::Process::GetEnv("HIP_PATH")) { +if (!HIPPathEnv->empty()) { + HIPSearchDirs.emplace_back(std::move(*HIPPathEnv)); Style nit. Single-statement if

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 502758. collinbaker added a comment. Sync with upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/include/clang-c/Index.h

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

collinbaker updated this revision to Diff 502763. collinbaker added a comment. Add symbol to version map Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130303/new/ https://reviews.llvm.org/D130303 Files: clang/docs/ReleaseNotes.rst

[clang] a02c3af - [clang-format] Don't annotate left brace of class as FunctionLBrace

Author: Owen Pan Date: 2023-03-06T13:07:23-08:00 New Revision: a02c3af9f19d805411364e7a0de785c1d1c4e348 URL: https://github.com/llvm/llvm-project/commit/a02c3af9f19d805411364e7a0de785c1d1c4e348 DIFF: https://github.com/llvm/llvm-project/commit/a02c3af9f19d805411364e7a0de785c1d1c4e348.diff

[PATCH] D145344: [clang-format] Don't annotate left brace of class as FunctionLBrace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa02c3af9f19d: [clang-format] Dont annotate left brace of class as FunctionLBrace (authored by owenpan). Repository: rG LLVM Github Monorepo

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

aaronmondal added subscribers: MaskRay, phosek, compnerd, aaronmondal. aaronmondal added a comment. Herald added a subscriber: Enna1. Herald added a project: All. Hmm I tried to fiddle around with this but I'm out of my depth here. Pulling in @MaskRay @compnerd @phosek in the hopes that one of

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. In D145416#4172799 , @efriedma wrote: > I think this is going to change what inputs Sema will accept for "p". If > that's intentional, please add test coverage.

[PATCH] D145251: [clang] Treat function parameter scope as an immediate function context

cor3ntin added a comment. I think this make sense. Maybe we should add a comment quoting [expr.const] p15.1 in both places though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145251/new/ https://reviews.llvm.org/D145251

[PATCH] D143675: Discussion: Darwin Sanitizers Stable ABI

kubamracek added a comment. @kcc Any takes from you on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 ___ cfe-commits mailing list

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`

tra added a comment. Can `__has_feature` be used to accomplish what you need? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145343/new/ https://reviews.llvm.org/D145343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144136: Add a "remark" to report on array accesses

void updated this revision to Diff 502766. void added a comment. Slight typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144136/new/ https://reviews.llvm.org/D144136 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:747-748 break; case 'g': // general register, memory operand or immediate integer. case 'X': // any operand. Info.setAllowsRegister(); I wonder if we should

[PATCH] D141307: Add -f[no-]loop-versioning option

tblah added a comment. Please could you add tests for the flag forwarding logic in flang/tests/Driver/frontend-forwarding.f90. For example see https://reviews.llvm.org/rGd0d4b635786d510cd919cadbeb7e5e19983242cf Comment at: clang/lib/Driver/ToolChains/Flang.cpp:69 + Arg

[PATCH] D130303: Handle template parameter-dependent bit field widths in libclang

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In D130303#3724392 , @dexonsmith wrote: > In D130303#3724247 , @rnk wrote: > >> Pinging alternative

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL updated this revision to Diff 502752. PiotrZSL added a comment. Ping, Rebase, Changed Option from Regexp to List, Improved documentation, Removed usage of deprecated API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC doesn't CSE inline asm when 'p' is used on inputs, neither should clang. In order to do so, we must not

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL updated this revision to Diff 502790. PiotrZSL added a comment. Ping, Rebase, Changed Regexp option into List Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files:

[PATCH] D145429: add test case

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145429 Files:

[PATCH] D145430: [clang] accept inline asm 'p' constraint on outputs

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC allows this; we reject it. Link: https://reviews.llvm.org/D145416#inline-1404524 Repository: rG

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers updated this revision to Diff 502820. nickdesaulniers added a comment. - add test additional case for Sema Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145416/new/ https://reviews.llvm.org/D145416 Files:

[PATCH] D145415: add test case

nickdesaulniers updated this revision to Diff 502819. nickdesaulniers added a comment. - update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145415/new/ https://reviews.llvm.org/D145415 Files:

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/test/Driver/ohos.c:240 + +// CHECK-OHOS-PTHREAD-NOT: -lpthread + DavidSpickett wrote: > This one is checking that we do not link to a pthread library, because when >

[PATCH] D145436: add test case

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145436 Files:

[PATCH] D145436: add test case

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. duplicate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145436/new/ https://reviews.llvm.org/D145436 ___ cfe-commits mailing

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

jyknight added a comment. Also, I note the doc says it's useful for `for “load address” and “push address” instructions` (note, "load address" means e.g. x86 "lea" instruction) -- which should NOT be dependent upon the value stored in the memory. The x86 backend actually uses a "Ts" constraint

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers added a comment. https://lore.kernel.org/lkml/alpine.LFD.2.01.0908011214330.3304@localhost.localdomain/ has historical context around the introduction of "p" in the kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145416/new/

[PATCH] D145125: [RISCV] Make D extension imply F extension.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90f6a4cc73d5: [RISCV] Make D extension imply F extension. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked 2 inline comments as done. kpdev42 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8161 +EXPECT_EQ(true, FD->hasAttr()); +} + balazske wrote: > Does this test fail without the changes applied? And does it not fail

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

nickdesaulniers added a comment. In D145416#4173250 , @jyknight wrote: > It looks to me from GCC that constraint 'p' is intended to be used > internally, not for inline-asm. I question whether the kernel should be using > it, and whether we should even

[PATCH] D145451: Disable tests which don't pass in HWASAN+LSAN mode

kstoimenov created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 502875. paulkirth added a comment. Remove redunant assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131306/new/ https://reviews.llvm.org/D131306 Files:

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

akyrtzi added a comment. > Is this observable from a clang command line tool? Be nice to have a lit test. Added lit test here: https://reviews.llvm.org/D145473 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145256/new/

[PATCH] D145430: [clang] accept inline asm 'p' constraint on outputs

nickdesaulniers updated this revision to Diff 502822. nickdesaulniers added a comment. - rebase, additional unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145430/new/ https://reviews.llvm.org/D145430 Files:

[PATCH] D145429: add test case

nickdesaulniers updated this revision to Diff 502821. nickdesaulniers added a comment. - rebase, additional unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145429/new/ https://reviews.llvm.org/D145429 Files:

[PATCH] D145449: [Fuchsia] Add LLDB options to stage 1 cmake.

haowei added inline comments. Comment at: clang/cmake/caches/Fuchsia.cmake:167 +if(FUCHSIA_ENABLE_LLDB) + list(APPEND _FUCHSIA_ENABLE_PROJECTS lldb) +endif() You probably need a `string(REPLACE ";" "|" value "${_FUCHSIA_ENABLE_PROJECTS}")` after append a

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal updated this revision to Diff 502855. Ayal added a comment. It's hard for getOpenCLKernelParameterType() to detect and diagnose invalid pointer cases w/o context (of an enclosing struct or not), but it's easy to detect valid pointer cases for v2.0+ and return ValidKernelParam. Rebased.

[PATCH] D131306: [llvm][misexpect] Track provenance of branch weights

paulkirth updated this revision to Diff 502873. paulkirth marked 4 inline comments as done. paulkirth added a comment. Rebase and address comments. - update doc comments and describe `IsExpected` parameter - add assert when scaling branch weights on calls - remove redundant check, now done in

[PATCH] D145473: [test/ARCMT/verify.m] Add lit test for `5e035651fd3acbb2645abbe80cae332d90eac78a` commit

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145473 Files: clang/test/ARCMT/verify.m Index:

[PATCH] D145435: Choose style (file) from within code for use in IDEs

bersbersbers created this revision. bersbersbers added a reviewer: owenpan. bersbersbers created this object with visibility "All Users". bersbersbers added a project: clang-format. Herald added a project: All. bersbersbers requested review of this revision. Herald added a project: clang. Herald

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. In D141569#4163607 , @ccotter wrote: > bump. I never heard back on the case where using an rvalue reference for a > big pod type as opposed to const ref. I have such use cases in project, they not necessary POD, but more like

[PATCH] D145438: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb created this revision. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is one of two alternative designs that Clang can adopt when writing SARIF to file. In this design, the Clang driver invokes

[PATCH] D145439: PLEASE DO NOT COMMENT ON THIS PATCH

cjdb created this revision. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is one of two alternative designs that Clang can adopt when writing SARIF to file. In this design, the Clang driver will

[PATCH] D144603: Disable compiler launcher on external projects and multi stage clang

haowei updated this revision to Diff 502841. haowei retitled this revision from "Add option to disable compiler launcher on external projects" to "Disable compiler launcher on external projects and multi stage clang". haowei edited the summary of this revision. Repository: rG LLVM Github

[PATCH] D143849: [Clang][OpenCL] Allow pointers in structs as kernel arguments from 2.0

Ayal added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9494 + // of SVM. + if (S.getLangOpts().getOpenCLCompatibleVersion() > 120 && + (ParamType == PtrKernelParam || ParamType == PtrPtrKernelParam)) Anastasia wrote: > Ayal wrote:

[PATCH] D145256: [clang/Diagnostic] Use `optional` to disambiguate between a `StoredDiagMessage` that is not set vs set as empty string

dblaikie added a comment. > "But when would you have a completely empty diagnostic message", you ask dear > reader? > That is when there is an empty "#warning" in code. Is this observable from a clang command line tool? Be nice to have a lit test. Repository: rG LLVM Github Monorepo

  1   2   >