[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.h:45 /// /// When \p CompletingPattern is true, the last placeholder will be of the form /// ${0:…}, indicating the cursor should stay there. Sorry, I forget to revise

[PATCH] D146021: [Tooling/Inclusion] Index more sub std namespace symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/61373 Repository: rG LLVM Github

[PATCH] D121670: [RISCV] Add zihintntl instructions

joshua-arch1 added a comment. Herald added subscribers: jobnoorman, luke. It seems that llvm implementation is different from Binutils/GCC. Binutils didn't regard ntl instructions as aliases of add since encoding space is reserved for HINT instructions. Repository: rG LLVM Github Monorepo

[PATCH] D145567: [Driver] Rename multilib flags to tags

michaelplatings abandoned this revision. michaelplatings marked an inline comment as done. michaelplatings added a comment. We're going back to "flags": https://discourse.llvm.org/t/rfc-multilib/67494/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146028: [clangd] Patch main file macros in preamble

kadircet created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Depends on D146026

[clang] 6603c68 - [clang][sema][NFC] Make a few functions const

Author: Timm Bäder Date: 2023-03-14T13:48:11+01:00 New Revision: 6603c68302c16e52be6d6262033def4348a9f864 URL: https://github.com/llvm/llvm-project/commit/6603c68302c16e52be6d6262033def4348a9f864 DIFF: https://github.com/llvm/llvm-project/commit/6603c68302c16e52be6d6262033def4348a9f864.diff

[PATCH] D145947: [clang][sema][NFC] Make a few functions const

This revision was automatically updated to reflect the committed changes. Closed by commit rG6603c68302c1: [clang][sema][NFC] Make a few functions const (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145947/new/

[PATCH] D146041: initial commit

mehdi_amini added a comment. Herald added a subscriber: JDevlieghere. You should look into the title and description of the commit: https://cbea.ms/git-commit/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146041/new/

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. In D145965#4192147 , @iains wrote: > In D145965#4192072 , @ChuanqiXu > wrote: > >> In D145965#4192051 , @iains wrote: >> >>> > > > >>> >>>

[PATCH] D121670: [RISCV] Add zihintntl instructions

asb added a comment. In D121670#4192158 , @joshua-arch1 wrote: > It seems that llvm implementation is different from Binutils/GCC. Binutils > didn't regard ntl instructions as aliases of add since encoding space is > reserved for HINT instructions.

[PATCH] D145951: [docs] Add more complete documentation for -f[no]split-lto-unit

nikic added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145951/new/ https://reviews.llvm.org/D145951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D121670: [RISCV] Add zihintntl instructions

asb added a comment. I've created a PR on the ISA manual to try to clarify the confusing overloaded use of the term "reserved" https://github.com/riscv/riscv-isa-manual/pull/990 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/

[clang] 586e497 - [Tooling/Inclusion] Index more sub std namespace symbols.

Author: Haojian Wu Date: 2023-03-14T13:08:44+01:00 New Revision: 586e497f7985ddb0ca481b45f82e202d3b6f23ea URL: https://github.com/llvm/llvm-project/commit/586e497f7985ddb0ca481b45f82e202d3b6f23ea DIFF: https://github.com/llvm/llvm-project/commit/586e497f7985ddb0ca481b45f82e202d3b6f23ea.diff

[PATCH] D146021: [Tooling/Inclusion] Index more sub std namespace symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rG586e497f7985: [Tooling/Inclusion] Index more sub std namespace symbols. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146021/new/

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

DavidSpickett added a comment. Also failing on our Windows on Arm bot: https://lab.llvm.org/buildbot/#/builders/65/builds/8607 I think some lines need to account for Windows slashes, `{{/|}}` should do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142933: Add -print-multi-selection-tags-experimental option

michaelplatings updated this revision to Diff 505048. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td

[PATCH] D130303: Fix include order in CXType.cpp

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; vedgy wrote: > vedgy wrote: > > I just noticed the `clang_Cursor_isBitField()` function implemented

[PATCH] D145861: [clang][Interp] Ignore more non-VarDecl declarations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:224 for (auto *D : DS->decls()) { -if (isa(D)) +if (isa(D)) continue; tbaeder wrote: > aaron.ballman wrote: > > What about other kinds of declarations,

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. In D145965#4192051 , @iains wrote: > In D145965#4191973 , @ChuanqiXu > wrote: > >> Yeah, it is indeed a problem that `Sema::isModuleUnitOfCurrentTU` doesn't >> work for implementation

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. There are some unresolved comments in the test (cast is not needed at `Import` and `EXPECT_TRUE` can be used) but otherwise LGTM. (But I have a feeling that problems may happen with

[clang] c916390 - [clang-format] Treat &/&& as reference when followed by requires clause

Author: Emilia Dreamer Date: 2023-03-14T12:51:34+02:00 New Revision: c9163901c8e118ec0b7d415ae6ef267c4b6d549f URL: https://github.com/llvm/llvm-project/commit/c9163901c8e118ec0b7d415ae6ef267c4b6d549f DIFF:

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unfortunately I couldn't find an existing test

[PATCH] D145656: [clang-format] Treat &/&& as reference when followed by requires clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9163901c8e1: [clang-format] Treat / as reference when followed by requires clause (authored by rymiel). Repository: rG LLVM Github Monorepo

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 505030. DmitryPolukhin added a comment. Update test to use any available target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files:

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 505050. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; aaron.ballman wrote: > vedgy wrote: > > vedgy wrote: > > > I just noticed the `clang_Cursor_isBitField()`

[PATCH] D146024: [clangd] Drop stale macro and mark ranges

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. I'll follow up

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains added a comment. In D145965#4192072 , @ChuanqiXu wrote: > In D145965#4192051 , @iains wrote: > >> >> >> >> >> The checks for internal-linkage symbols and the improvements to diagnostics >> do not

[PATCH] D146026: [clangd] Patch PragmaMarks in preamble section of the file

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D145941: [Clang] Always use -zdefs when linking AMDGPU images

arsenm added a comment. Release note change should be here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145941/new/ https://reviews.llvm.org/D145941 ___ cfe-commits mailing list

[PATCH] D146024: [clangd] Drop stale macro and mark ranges

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/PreambleTests.cpp:22 #include "XRefs.h" +#include "index/FileIndex.h" +#include "support/Context.h"

[PATCH] D142932: Multilib YAML parsing

michaelplatings updated this revision to Diff 505047. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h

[clang] de401ac - [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

Author: Takuya Shimizu Date: 2023-03-14T08:43:35-04:00 New Revision: de401ac2a4ab74392b8234aa3a517481a1e2762c URL: https://github.com/llvm/llvm-project/commit/de401ac2a4ab74392b8234aa3a517481a1e2762c DIFF:

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGde401ac2a4ab: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute (authored by hazohelet, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 created this revision. Herald added a subscriber: mgrang. Herald added a project: All. jp4a50 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The previous implementation of the option involved a hack which corrupted the parenthesis

[PATCH] D146039: [libclang] No longer attempt to get a dependent bit-width

vedgy added inline comments. Comment at: clang/include/clang-c/Index.h:3043 + * For example: + * if (clang_Cursor_isBitField(Cursor)) { + * int Width = clang_getFieldDeclBitWidth(Cursor); Surround the example with ` \code` and `\endcode` commands.

[clang] a1fae98 - [AArch64] Add svboolx2_t and svboolx4_t tuple types

Author: Matt Devereau Date: 2023-03-14T10:16:51Z New Revision: a1fae98ba95c18ea6b673fc3c177b917e0f5aa56 URL: https://github.com/llvm/llvm-project/commit/a1fae98ba95c18ea6b673fc3c177b917e0f5aa56 DIFF: https://github.com/llvm/llvm-project/commit/a1fae98ba95c18ea6b673fc3c177b917e0f5aa56.diff

[PATCH] D144651: [Serialization] Place command line defines in the correct file

mstorsjo added a reviewer: aaron.ballman. mstorsjo added a subscriber: aaron.ballman. mstorsjo added a comment. Adding @aaron.ballman as fallback Clang reviewer here. While I did touch code in the vicinity of this area recently, I'm not familiar enough with the whole area to take on reviewing

[PATCH] D146000: [OpenMP]Skip generating this[:1] map info for non-member variable.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146000/new/ https://reviews.llvm.org/D146000

[clang-tools-extra] c11c2f5 - [clangd] Drop stale macro and mark ranges

Author: Kadir Cetinkaya Date: 2023-03-14T13:18:16+01:00 New Revision: c11c2f5f6548a5303517c89ba6629bbfa7fae0d9 URL: https://github.com/llvm/llvm-project/commit/c11c2f5f6548a5303517c89ba6629bbfa7fae0d9 DIFF:

[PATCH] D146024: [clangd] Drop stale macro and mark ranges

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGc11c2f5f6548: [clangd] Drop stale macro and mark ranges (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D146024?vs=504990=505046#toc

[PATCH] D145842: [clang][Sema] Avoid duplicate diagnostics for unreachable fallthrough attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145842/new/ https://reviews.llvm.org/D145842 ___ cfe-commits mailing

[PATCH] D143059: [Driver] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 505051. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D143075: BareMetal ToolChain multilib layering

michaelplatings updated this revision to Diff 505052. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp

[clang] f81317a - [NFC][OHOS] Temporarily switch off tests for windows

Author: Pavel Kosov Date: 2023-03-14T16:14:47+03:00 New Revision: f81317a54586dbcef0c14cf512a0770e8ecaab3d URL: https://github.com/llvm/llvm-project/commit/f81317a54586dbcef0c14cf512a0770e8ecaab3d DIFF: https://github.com/llvm/llvm-project/commit/f81317a54586dbcef0c14cf512a0770e8ecaab3d.diff

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains added a comment. In D145965#4191973 , @ChuanqiXu wrote: > Yeah, it is indeed a problem that `Sema::isModuleUnitOfCurrentTU` doesn't > work for implementation units. And I have been thinking about this for a > while. My thought is that the root

[PATCH] D144976: [clangd] Add provider info on symbol hover.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1099 + trace::Span Tracer("Hover::maybeAddSymbolProviders"); + include_cleaner::walkUsed( + AST.getLocalTopLevelDecls(), MacroReferences, AST.getPragmaIncludes(), It seems that

[clang] 72474af - [LLVM][OHOS] Clang toolchain and targets

Author: Pavel Kosov Date: 2023-03-14T12:24:44+03:00 New Revision: 72474afa27570a0a1307f3260f0187b703aa6d84 URL: https://github.com/llvm/llvm-project/commit/72474afa27570a0a1307f3260f0187b703aa6d84 DIFF: https://github.com/llvm/llvm-project/commit/72474afa27570a0a1307f3260f0187b703aa6d84.diff

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72474afa2757: [LLVM][OHOS] Clang toolchain and targets (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

TWeaver added a comment. Good morning, I believe the two tests added in this patch, clang::ohos.c and clang::ohos.cpp are failing on the following buildbot: https://lab.llvm.org/buildbot/#/builders/216/builds/18323 is anyone able to take a look? thanks, Tom W Repository: rG LLVM Github

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

john.brawn accepted this revision. john.brawn added a comment. This revision is now accepted and ready to land. LGTM, with one minor nitpick. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106 + +def : TokenAlias<"DSYNC", "dsync">; + It would make

[PATCH] D146022: Remove an extra `//` in the IWYU pragma for gtest-matchers.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGca431a4fcbec: Remove an extra `//` in the IWYU pragma for gtest-matchers.h (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146022/new/

[PATCH] D145851: [Clang][Sema] Fix incorrect deletion of default constructors for some unions

aaron.ballman added a comment. Precommit CI found related failures: /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/union-non-trivial-member.cpp:29:16: error: found empty check string with prefix 'CHECK:' // CHECK-NEXT: ^ error: unknown argument: '-g0'

[clang] 20fb4c3 - Revert "Fix include order in CXType.cpp"

Author: Aaron Ballman Date: 2023-03-14T08:57:25-04:00 New Revision: 20fb4c3270b9d3596f213623d39c507711d1c165 URL: https://github.com/llvm/llvm-project/commit/20fb4c3270b9d3596f213623d39c507711d1c165 DIFF: https://github.com/llvm/llvm-project/commit/20fb4c3270b9d3596f213623d39c507711d1c165.diff

[PATCH] D146041: initial commit

AryanGodara created this revision. Herald added a reviewer: bollu. Herald added subscribers: steakhal, martong, arphaman. Herald added a reviewer: aaron.ballman. Herald added a reviewer: NoQ. Herald added a project: All. AryanGodara requested review of this revision. Herald added projects: clang,

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Please split out the fixes to individual passes. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:48 +

[PATCH] D145505: [AArch64][SVE] Add svboolx2_t and svboolx4_t tuple types

MattDevereau closed this revision. MattDevereau added a comment. a1fae98ba95c18ea6b673fc3c177b917e0f5aa56 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145505/new/

[PATCH] D146021: [Tooling/Inclusion] Index more sub std namespace symbols.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146021/new/ https://reviews.llvm.org/D146021

[PATCH] D145238: [NVPTX] Expose LDU builtins

jchlanda marked an inline comment as done. jchlanda added a comment. @tra is there anything else I should do for this patch? Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145238/new/ https://reviews.llvm.org/D145238

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 505053. michaelplatings added a comment. tags->flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst clang/docs/index.rst

[PATCH] D145970: [MSVC][PS][dllexport/dllimport] Propagate a dllexport/dllimport attribute to template baseclasses

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. LGTM I've always found this to be an interesting behavior, and I'm guessing you found some code where it does matter :) Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2612 + if

[PATCH] D145564: [clang][docs] Clarify the semantics of -fexceptions

asb updated this revision to Diff 505060. asb added a comment. Adjust wording based on discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145564/new/ https://reviews.llvm.org/D145564 Files: clang/docs/CommandGuide/clang.rst Index: clang/docs/CommandGuide/clang.rst

[PATCH] D146039: [libclang] No longer attempt to get a dependent bit-width

aaron.ballman created this revision. aaron.ballman added reviewers: collinbaker, dexonsmith, vedgy. Herald added a subscriber: arphaman. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Handle template parameter-dependent bit field

[PATCH] D130303: Fix include order in CXType.cpp

aaron.ballman added a comment. I reverted this patch in 20fb4c3270b9d3596f213623d39c507711d1c165 and I've put up a new patch for review at https://reviews.llvm.org/D146039. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D141098: [clang-format][NFC] Set LineEnding to LF in config files

mehdi_amini added a comment. In D141098#4111809 , @owenpan wrote: > Can we just fix the buildbot so that it runs git-clang-format with > `--binary`? Using clang-format-15 to format a patch to clang-format-16 source > still looks wrong to me. The

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504947. zyounan marked 3 inline comments as done. zyounan added a comment. Address the comments. Revise parameters of `getSignature` to avoid passing CCR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:441 getSignature(*SemaCCS, , , - , IsPattern); + , IsPattern, C.SemaResult); if (!C.SemaResult->FunctionCanBeCall) nridge

[PATCH] D146017: [clangd][wip] Get rid of the include-cleaner hacky macro-reference implementation

hokein created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. By extending and using the existing

[clang] 6b50bfc - [clang] Store the template param list of an explicit variable template specialization

Author: Nathan Ridge Date: 2023-03-14T03:03:30-04:00 New Revision: 6b50bfc8f25a4d78a17a9134c3e2e26c19bb7dff URL: https://github.com/llvm/llvm-project/commit/6b50bfc8f25a4d78a17a9134c3e2e26c19bb7dff DIFF: https://github.com/llvm/llvm-project/commit/6b50bfc8f25a4d78a17a9134c3e2e26c19bb7dff.diff

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; vedgy wrote: > I just noticed the `clang_Cursor_isBitField()` function implemented [[ >

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b50bfc8f25a: [clang] Store the template param list of an explicit variable template… (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains added a comment. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. notes: a) I need to update the

[PATCH] D130303: Fix include order in CXType.cpp

vedgy added inline comments. Comment at: clang/tools/libclang/CXType.cpp:374 +unsigned clang_isBitFieldDecl(CXCursor C) { + using namespace cxcursor; I just noticed the `clang_Cursor_isBitField()` function implemented [[

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1171 + /// attribute + void markEmpty() { data().Empty = true; } balazske wrote: > This change looks not related. The `markEmpty` is still

[PATCH] D146022: Remove an extra `//` in the IWYU pragma for gtest-matchers.h

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146022 Files:

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 added a comment. In D145765#4189153 , @aaron.ballman wrote: > Thanks for the additional tests! Can you also add a release note to > `clang/docs/ReleaseNotes.rst` and document the new builtin in > `clang\docs\LanguageExtensions.rst`? Hi,

[clang-tools-extra] 9b5a934 - [IncludeCleaner][NFC] Dont rely on implicit conversion of StringRef

Author: Kadir Cetinkaya Date: 2023-03-14T09:20:30+01:00 New Revision: 9b5a934def7ff02f51d972c80021c9d601f91beb URL: https://github.com/llvm/llvm-project/commit/9b5a934def7ff02f51d972c80021c9d601f91beb DIFF:

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. Yeah, it is indeed a problem that `Sema::isModuleUnitOfCurrentTU` doesn't work for implementation units. And I have been thinking about this for a while. My thought is that the root cause may be that we shouldn't push the module interface to `Sema::ModuleScopes()`

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 updated this revision to Diff 504956. kpdev42 marked an inline comment as done. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145057/new/ https://reviews.llvm.org/D145057 Files:

[clang-tools-extra] e9a88b6 - [clangd] Fix a bug in TweakTest::decorate()

Author: Nathan Ridge Date: 2023-03-14T03:02:26-04:00 New Revision: e9a88b6178d3a30123394d1fef6b51140f79d03a URL: https://github.com/llvm/llvm-project/commit/e9a88b6178d3a30123394d1fef6b51140f79d03a DIFF: https://github.com/llvm/llvm-project/commit/e9a88b6178d3a30123394d1fef6b51140f79d03a.diff

[PATCH] D144453: [clangd] Fix a bug in TweakTest::decorate()

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9a88b6178d3: [clangd] Fix a bug in TweakTest::decorate() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144453/new/

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504950. zyounan added a comment. Update doxygen comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

tingwang updated this revision to Diff 504952. tingwang added a reviewer: PowerPC. tingwang added a comment. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Address comments: (1) Add test case to show how associated metadata will be used on AIX (currently not

[clang] 3e78fa8 - [C++20] [Modules] Profile TemplateName by canonical decl

Author: Chuanqi Xu Date: 2023-03-14T14:34:44+08:00 New Revision: 3e78fa860235431323aaf08c8fa922d75a7cfffa URL: https://github.com/llvm/llvm-project/commit/3e78fa860235431323aaf08c8fa922d75a7cfffa DIFF: https://github.com/llvm/llvm-project/commit/3e78fa860235431323aaf08c8fa922d75a7cfffa.diff

[PATCH] D145765: Add __builtin_set_flt_rounds

xiongji90 updated this revision to Diff 504957. xiongji90 marked an inline comment as done. xiongji90 added a comment. Simplify test and update release doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145765/new/ https://reviews.llvm.org/D145765

[PATCH] D145765: Add __builtin_set_flt_rounds

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D145765#4191800 , @xiongji90 wrote: > I have simplified the test as you suggested and I also updated release doc to > add

[PATCH] D145767: [Verifier][NFC] Refactor check for associated metadata to allow multiple operands on AIX

arsenm added a comment. Missing verifier test in llvm/test/Verifier (e.g., the ones I added in 87f2e9448e82bbed4ac59bb61bea03256aa5f4de ) Comment at: clang/test/CodeGen/PowerPC/aix-init-ref-null.cpp:2 +//

[PATCH] D145369: Emit const globals with constexpr destructor as constant LLVM values

hans updated this revision to Diff 505127. hans added a comment. Thanks for the review! Added tests to cover other calls that change behavior due to this. Please take another look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145369/new/ https://reviews.llvm.org/D145369 Files:

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 updated this revision to Diff 505134. HerrCai0907 added a comment. rebase to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateVariadic.cpp

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

HerrCai0907 added a comment. HerrCai0907 and congcongcai0...@163.com Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145892/new/ https://reviews.llvm.org/D145892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

sunshaoce added a comment. Any other opinions? If not, I will land it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 ___ cfe-commits mailing list

[PATCH] D144844: [C++20] [Modules] Offer -fno-import-inter-module-function-defs to avoid duplicated compilation in modules

dblaikie added a comment. Seem to recall @iains and others were concerned about the number of modules flags - this one I'd be inclined to suggest we shouldn't add if possible. If one way or the other is generally better - we should, at least initially, dictate that behavior entirely until

[PATCH] D145888: [clang-format] Fix non-case colons in Verilog case lines

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4424 -if (Line.First->isOneOf(tok::kw_default, tok::kw_case)) - return Style.SpaceBeforeCaseColon; const FormatToken *Next = Right.getNextNonComment(); Hmm.. this

[PATCH] D145892: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe417f02b5159: [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag (authored by HerrCai0907). Repository: rG LLVM Github

[clang] e417f02 - [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

Author: Congcong Cai Date: 2023-03-15T01:08:41+08:00 New Revision: e417f02b5159c13f011335636faaf8c6847b627f URL: https://github.com/llvm/llvm-project/commit/e417f02b5159c13f011335636faaf8c6847b627f DIFF: https://github.com/llvm/llvm-project/commit/e417f02b5159c13f011335636faaf8c6847b627f.diff

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses

aeubanks created this revision. aeubanks added a reviewer: yrouban. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In

[PATCH] D145726: Fix assembler error when -g and -gdwarf-* is passed with -fno-integrated-as.

garvitgupta08 added a comment. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:978-986 + if (Arg *A = Args.getLastArg(options::OPT_g_Flag, options::OPT_gN_Group, + options::OPT_gdwarf_2, options::OPT_gdwarf_3, +

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak created this revision. skatrak added reviewers: gregrodgers, dpalermo, domada, jsjodin, agozillon, kiranchandramohan, awarzynski. Herald added subscribers: sunshaoce, bzcheeseman, rriddle, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 505215. jrmolin marked 3 inline comments as done. jrmolin added a comment. respond to code review requests/comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171

  1   2   3   >