[PATCH] D146653: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Since the check belongs to the google module, it

[clang] 38d69df - [Driver][test] Fix avr-ld.c for -DCLANG_DEFAULT_LINKER=lld after D145646

Author: Fangrui Song Date: 2023-03-22T11:36:02-07:00 New Revision: 38d69df5c2dad0d4ceb08d840840ab083dd673fe URL: https://github.com/llvm/llvm-project/commit/38d69df5c2dad0d4ceb08d840840ab083dd673fe DIFF: https://github.com/llvm/llvm-project/commit/38d69df5c2dad0d4ceb08d840840ab083dd673fe.diff

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1676 +Inst->setLexicalDeclContext(Owner); +RecordInst->setLexicalDeclContext(Owner); + this bit is important Repository: rG LLVM Github Monorepo

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4213943 , @alexander-shaposhnikov wrote: > @erichkeane - thanks for the comments, the changes in > SemaTemplateInstantiateDecl.cpp are necessary, in particular, they enable us > to handle the case > > template

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

MaskRay added a comment. In D145646#4213547 , @gulfem wrote: > We started seeing a test failure in `avr-ld.c`. > > /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: > // LINKP: {{".*ld.*"}} {{.*}}

[PATCH] D146595: [clang] Add clang trampoline attribute

dblaikie added a comment. So looking at the DWARF spec for this - I see what it's going for, but yeah, I wouldn't want to use a textual representation either at the source or bitcode level, ideally... - perhaps this should just be implemented in LLVM when something's being lowered to a

[PATCH] D146342: [WIP][-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ added a comment. Yeah this information is probably at least partially unavailable in the fully parsed AST. We have all the instantiations with their AST copied from the original template AST, but we no longer remember *why* we copied it (which is what the `CodeSynthesisContext` stack

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks for the comments, the changes in SemaTemplateInstantiateDecl.cpp are necessary, in particular, they enable us to handle the case template concept Constraint = true; template struct Iterator { template friend

[PATCH] D146595: [clang] Add clang trampoline attribute

dblaikie added a comment. Yeah, this seems a bit burdensome for both the frontend (encoding more information, the author has to duplicate the name of the implementation function so there's a risk they get out of sync?) and the debugger (is the debugger expected to jump directly and not call

[PATCH] D146284: [clang-format] Annotate noexcept, explicit specifiers as containing expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGead9644684e8: [clang-format] Annotate noexcept, explicit specifiers as containing expressions (authored by rymiel). Repository: rG LLVM Github

[clang] ead9644 - [clang-format] Annotate noexcept, explicit specifiers as containing expressions

Author: Emilia Dreamer Date: 2023-03-22T20:27:17+02:00 New Revision: ead9644684e85e0611f3b0ff72926820f1277e09 URL: https://github.com/llvm/llvm-project/commit/ead9644684e85e0611f3b0ff72926820f1277e09 DIFF:

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. Hmm... there is a lot going on here that I'm not sure is necessary? I was able to change the `AreConstraintExpressionsEqual` 'if' body to just: +MultiLevelTemplateArgumentList OldMLTAL = +getTemplateArgumentsForComparison(*this, Old); +

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1352 + + // Both at once? Probably not even valid. + Tokens = annotate("[] requires Foo (T t) requires Bar {}"); usaxena95 wrote:

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel added a comment. In D145642#4213256 , @usaxena95 wrote: > Another point: > While testing this patch, the following still fails to recognise. Might be > something special with `true`. > > auto y = [&] > requires true(Callable && callable)

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 507440. rymiel added a comment. Remove unnecessary musing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

rymiel updated this revision to Diff 507439. rymiel added a comment. Fix `true` edge case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145642/new/ https://reviews.llvm.org/D145642 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 507432. alexander-shaposhnikov edited the summary of this revision. alexander-shaposhnikov added a comment. New approach to constraints' comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/D146155 ___ cfe-commits mailing list

[PATCH] D146466: [clang] diagnose function fallthrough

nickdesaulniers added a comment. In D146466#4207915 , @efriedma wrote: > I'm concerned about the potential for false positives: > > - If a user doesn't mark a function noreturn, but it doesn't actually ever > return. Ok, but a user //can// fix that in

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 507430. TIFitis added a comment. Updated tests. All tests pass now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. I think just checking that the toplevel binary operator is a logical or should be enough? Since that only fails if both operands evaluate to false, so we don't need to print the "false or false" diagnostic. Comment at:

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn added a comment. In D144651#4210787 , @fdeazeve wrote: > According to git-bisect, this patch is causing the LLDB bots to crash. > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console > > (They were failing for other reasons

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp updated this revision to Diff 507428. wolfgangp added a comment. Instead of suppressing the error message we drop the dllimport/dllexport attribute when we see that a class has UniqueExternal linkage. This will suppress exporting or importing any members, which could not be accessed

[PATCH] D146595: [clang] Add clang trampoline attribute

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. This revision now requires changes to proceed. I can see some minor utility to this for some kinds of libraries perhaps, but I'm on the fence about adding the attribute.

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. I'm not certain that the result of the transformation is more "readable"; is this check intended to aid conformance to a style guide? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130630: [clang-tidy] Add readability-nested-ifs check

LegalizeAdulthood added a comment. Herald added a subscriber: PiotrZSL. How does this check interact with macros that expand to `if` statements? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130630/new/ https://reviews.llvm.org/D130630

[PATCH] D72940: Add a support for clang tidy to import another configurations files from .clang-tidy

LegalizeAdulthood resigned from this revision. LegalizeAdulthood added a comment. This revision now requires review to proceed. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. No action taken, removing myself as a reviewer Repository: rG

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:21918-21927 + verifyFormat("Result doSomething(Promise promise) {\n" + " return promise.then(\n" + " [this, obj = std::move(s)](int evaluated) mutable {\n" +

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

schittir updated this revision to Diff 507425. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146604/new/ https://reviews.llvm.org/D146604 Files: clang/include/clang/Basic/TargetOptions.h Index: clang/include/clang/Basic/TargetOptions.h

[PATCH] D146608: [CMake] Build runtimes for riscv64-unknown-fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77044a47b4de: [CMake] Build runtimes for riscv64-unknown-fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 77044a4 - [CMake] Build runtimes for riscv64-unknown-fuchsia

Author: Petr Hosek Date: 2023-03-22T17:30:14Z New Revision: 77044a47b4dec308e02c796e7951ab1745a7f53c URL: https://github.com/llvm/llvm-project/commit/77044a47b4dec308e02c796e7951ab1745a7f53c DIFF: https://github.com/llvm/llvm-project/commit/77044a47b4dec308e02c796e7951ab1745a7f53c.diff LOG:

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 updated this revision to Diff 507422. augusto2112 added a comment. Herald added a subscriber: jdoerfert. Fix pragma-attribute-supported-attributes-list.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146595/new/

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186 + Logger () const { +return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null(); + } xazax.hun wrote: > If we already have a

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

sammccall updated this revision to Diff 507418. sammccall marked 3 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files:

[PATCH] D146101: [clang-format] Add DesignatedInitializerIndentWidth option.

jp4a50 added a comment. In D146101#4208962 , @MyDeveloperDay wrote: > What I'd really like to see, is... in the event that > `ContinuationIndentWidth` is set and I do NOTset > `DesignatedInitializerIndentWidth` , then >

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

xazax.hun added a comment. In D146591#4213614 , @sammccall wrote: > (e.g. does the MLIR dataflow framework have the same idea about how the > analysis timeline relates to the CFG and elements within it? And if we want > to show the clang AST or the

[PATCH] D146595: [clang] Add clang trampoline attribute

augusto2112 added a comment. In D146595#4213412 , @aprantl wrote: > So this attribute will lower into a `DW_AT_trampoline("target_func_name")` > attribute on the `DW_TAG_subprogram` of the function definition? Exactly, there's already functionality to

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. ipriyanshi1708 added reviewers: samtebbs, aaron.ballman. ipriyanshi1708 published this revision for review. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fixes

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/D146155

[PATCH] D146376: Update static_assert message for redundant cases

cjdb added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:261-265 static_assert(invert(true) == invert(false), ""); // expected-error {{failed}} \ -// expected-note {{evaluates to 'false == true'}}

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne added a reviewer: aaron.ballman. ldionne added a comment. Gentle ping, this was likely a copy-paste error. Adding Aaron in case he has time to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 507413. Krishna-13-cyber added a comment. Have worked on the top level with Boolean literals unlike the previous diffs.I have updated the test case as well with this new upcoming change. Thanks! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added a comment. In D146591#4213319 , @xazax.hun wrote: > While I am OK with this approach, I wonder if it would be too much work to > split the HTML generation and emitting data up. E.g., the logger could emit > YAML or JSON that could be

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk updated this revision to Diff 507409. mhalk added a comment. Patch rework, implementing the mentioned changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145591/new/ https://reviews.llvm.org/D145591 Files:

[PATCH] D146338: [MSVC compatibility][dllimport/dllexport][PS] Allow dllexport/dllimport for classes with UniqueExternalLinkage

wolfgangp added a comment. In D146338#4206222 , @hans wrote: >> In D145271 it was suggested that we drop >> the attribute in such contexts, and this is effectively what happens. The >> compiler does not produce any

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

gulfem added a comment. We started seeing a test failure in `avr-ld.c`. /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/avr-ld.c:48:11: error: // LINKP: {{".*ld.*"}} {{.*}} "--defsym=__DATA_REGION_ORIGIN__=0x800100" "-plugin" {{.*}} "-plugin-opt=mcpu=atmega328" ^ :1:1:

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added a comment. The user isn't modifying the `float_t` type definition, they're using it. I think the diagnostic should say something like `cannot use type 'float_t' within '#pragma clang fp eval_method'; type is set according to the default eval method for the translation unit`.

[PATCH] D146595: [clang] Add clang trampoline attribute

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. So this attribute will lower into a `DW_AT_trampoline("target_func_name")` attribute on the `DW_TAG_subprogram` of the function definition? The debug info parts LGTM. It would be nice to

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Logger.cpp:17 +Logger ::null() { + struct NullLogger : Logger {}; + static auto *Instance = new NullLogger(); Adding `final`? Just in case it can help with devirtualization.

[PATCH] D146041: Fix weirdly apologetic diagnostic messages

ipriyanshi1708 added a comment. Hi @AryanGodara , I am an Outreachy applicant. I was also working on this issue and also created a patch for this issue i.e., https://reviews.llvm.org/D146530 . Can we collaborate to solve this issue so that only one patch will be there for a issue as told by

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 added a comment. In D146530#4213078 , @aaron.ballman wrote: > In D146530#4213076 , > @ipriyanshi1708 wrote: > >> In D146530#4213045 , >> @aaron.ballman

[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186 + Logger () const { +return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null(); + } If we already have a `NullLogger`, I

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

xazax.hun added a comment. While I am OK with this approach, I wonder if it would be too much work to split the HTML generation and emitting data up. E.g., the logger could emit YAML or JSON that could be parsed by a python script to create the HTML (or the HTML itself could use JS to parse it

[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

xazax.hun added a comment. In D146514#4212528 , @mboehme wrote: > No, I think this is a different case. Sorry, I might have been unclear. I am 100% agree that these are different cases. I was wondering whether we can/should have a single code path

[PATCH] D146634: [clang][USR] Prevent crashes when parameter lists have nulls

kadircet created this revision. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D146426 Repository: rG LLVM Github

[PATCH] D144569: [Clang][OpenMP] Fix accessing of aligned arrays in offloaded target regions

doru1004 closed this revision. doru1004 added a comment. Commit: 65a0d669b4625c34775436a6d3643d15bbc2465a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144569/new/

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

usaxena95 added a comment. > starting a line with an opening paren is pretty weird!) I do not think this is weird. On the contrary, this is more readable to me and separates the requires clause from the parameters list. For example this one looks so much better: // trunk. template void

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:728 bool SkipForSpecialization = false) { MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( ND, /*Final=*/false,

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4213235 , @alexander-shaposhnikov wrote: > @erichkeane - yes, I'm working on it, I hope to have a new version ~soon > (within a few days). Ok, thanks for the update then! I'll do just enough looking into it to

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146507/new/ https://reviews.llvm.org/D146507 ___ cfe-commits mailing list

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - yes, I'm working on it, I hope to have a new version ~soon (within a few days). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak added a comment. Thanks again for helping improving this patch. I made most of the changes requested, and tried to clarify a bit better the approach followed for this implementation, to see if it is acceptable or if some more fundamental changes have to be done.

[PATCH] D146075: [flang][driver][openmp] Write MLIR for -save-temps

skatrak updated this revision to Diff 507365. skatrak marked 6 inline comments as done. skatrak added a comment. Changes to tests and path manipulation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146075/new/ https://reviews.llvm.org/D146075

[PATCH] D146417: [clangd] Fix AddUsing in the face of typo-correction

kadircet closed this revision. kadircet added a comment. relanded in 35c2aac6e3957c2e82bf92269039fa02bab0e1d9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146417/new/

[PATCH] D146625: [dataflow] handle missing case in value debug strings

sammccall created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. sammccall published this revision for review. sammccall added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8635 + "HIP does not support OpenMP target directives; directive has been ignored">, + InGroup; + mhalk wrote: > >>! In D145591#4182945, @jdoerfert wrote: > > I would

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 507360. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaType.cpp

[PATCH] D146604: [NFC] Fix uninitalized member variable use in ASTReader::ParseTargetOptions()

tahonermann added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:5890-5892 + TargetOpts.EABIVersion = llvm::EABI::Default; + // Initialize CodeObjectVersion with default i.e., 4 + TargetOpts.CodeObjectVersion = TargetOptions::CodeObjectVersionKind::COV_4;

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

aaron.ballman added a comment. In D146530#4213076 , @ipriyanshi1708 wrote: > In D146530#4213045 , @aaron.ballman > wrote: > >> This appears to be the same efforts that have been going on in >>

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

ipriyanshi1708 added a comment. In D146530#4213045 , @aaron.ballman wrote: > This appears to be the same efforts that have been going on in > https://reviews.llvm.org/D146041. Can you coordinate with @AryanGodara so > that there's only one patch for

[PATCH] D146165: docs: add some documentation on Windows SDK search

This revision was automatically updated to reflect the committed changes. Closed by commit rG893ce5759fe2: docs: add some documentation on Windows SDK search (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D146165?vs=506978=507346#toc Repository: rG LLVM Github

[clang] 893ce57 - docs: add some documentation on Windows SDK search

Author: Saleem Abdulrasool Date: 2023-03-22T09:46:36-04:00 New Revision: 893ce5759fe2e450dc637d4c76e779f883535882 URL: https://github.com/llvm/llvm-project/commit/893ce5759fe2e450dc637d4c76e779f883535882 DIFF:

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

awarzynski added a comment. A few more comments, but mostly nits. Btw, is this patch sufficient to generate code for AMDGPU? Or, put differently, what's the level of support atm? Comment at: clang/lib/Driver/ToolChains/Flang.cpp:107 break; + case llvm::Triple::r600: +

[PATCH] D146530: [clang][diagnostics]Removed "sorry" from all the required files

aaron.ballman added a subscriber: AryanGodara. aaron.ballman added a comment. This appears to be the same efforts that have been going on in https://reviews.llvm.org/D146041. Can you coordinate with @AryanGodara so that there's only one patch for this? Repository: rG LLVM Github Monorepo

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacf6a3224955: [flang] add -flang-experimental-hlfir flag to flang-new (authored by tblah). Changed prior to commit:

[clang] acf6a32 - [flang] add -flang-experimental-hlfir flag to flang-new

Author: Tom Eccles Date: 2023-03-22T13:36:54Z New Revision: acf6a3224955779724a35a383d63c48af2163171 URL: https://github.com/llvm/llvm-project/commit/acf6a3224955779724a35a383d63c48af2163171 DIFF: https://github.com/llvm/llvm-project/commit/acf6a3224955779724a35a383d63c48af2163171.diff LOG:

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada marked an inline comment as done. domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:93 +std::string CodeGenAction::getAllTargetFeatures() { + std::string allFeaturesStr; awarzynski wrote: > This method could be simplified

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. @alexander-shaposhnikov : Are you working on @rsmith 's suggestion? I finally have time to look into it, but dont want to repeat effort if you're already 1/2 way into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 507339. sammccall added a comment. Use a process-shared counter for HTML output filenames to avoid clobbering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

ymandel accepted this revision. ymandel added a comment. thanks! Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:36-40 +auto BlockIt = CFCtx.getStmtToBlock().find((S)); +assert(BlockIt != CFCtx.getStmtToBlock().end()); +const auto =

[PATCH] D145579: [Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 507333. domada retitled this revision from "[Flang][AMDGPU][OpenMP] Save target features in OpenMP MLIR dialect" to "[Flang][AMDGPU] Add support for AMDGPU to Flang driver". domada edited the summary of this revision. domada added a comment. Applied

[PATCH] D146557: [MLIR][OpenMP] Added OMPIRBuilder support for use_device_ptr clause

TIFitis updated this revision to Diff 507337. TIFitis added a comment. Removed use_dev_ptr clause related code. This patch only refactors the map clause prcoessing now. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added reviewers: rjmccall, serge-sans-paille. aaron.ballman added a comment. > Where do you suggest I add the documentation? Somewhere around https://clang.llvm.org/docs/LanguageExtensions.html#extensions-to-specify-floating-point-flags where we document `clang fp eval_method`.

[PATCH] D146513: Add missing nearbyintf16 builtin functions

aaron.ballman added a subscriber: cfe-commits. aaron.ballman added a comment. Please also add a release note and add documentation for the builtin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146513/new/ https://reviews.llvm.org/D146513

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:19 +! CHECK-NEXT: } +! NO-HLFIR-NOT: hlfir. [ultra nit] I would

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Ping for review/comments. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:15-17 #include "clang/Basic/TargetInfo.h" +#include "clang/Lex/LexDiagnostic.h" #include "clang/Lex/Preprocessor.h" Endill wrote: > aaron.ballman wrote: > > > I'm using

[PATCH] D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Transfer.h:35 + /// The result is guaranteed never to be null. + virtual const Environment *getEnvironment(const Stmt ) const { +auto BlockIt =

[PATCH] D146503: Fix highlighting issue with _complex and initialization list with more than 2 items

aaron.ballman added a comment. Thanks for this! One thing that's missing is test coverage for the highlight itself, as that was what the original issue was about. You should add a test that uses `-fcaret-diagnostics-max-lines` and `FileCheck` so that you can test that the caret shows up where

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1158 + const SourceManager = AST.getSourceManager(); + std::set UsedSymbolNames; + include_cleaner::walkUsed( hokein wrote: > just want to check the intention,

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 507326. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files:

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah updated this revision to Diff 507321. tblah added a comment. Thanks for the suggestion - Added a test to check that hlfir is not output without the flag - clang-formatted CLOptions.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145591: [clang][HIP][OpenMP] Add warning if mixed HIP / OpenMP offloading

mhalk added a comment. In D145591#4182360 , @jhuber6 wrote: > I'm not a fan of the same warning being copied in 24 places. Why do we set > `LangOpts.IsOpenMP` on the GPU compilation side, couldn't we just filter out > the `-fopenmp` or whatever it is

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

JiruiWu marked 2 inline comments as done. JiruiWu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5811 +// For alignment adjusted HFAs, cap the argument alignment to 16, otherwise +// set it to 8 according to the AAPCS64 document. unsigned Align

[PATCH] D145813: [clang-format] Respect Cpp11BraceListStyle when aligning array of structures

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20273 + Style.ColumnLimit = 20; + EXPECT_EQ( + "demo = std::array<\n" hch12907 wrote: > MyDeveloperDay wrote: > > any reason you didn't use verifyFormat here? > No

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. Can you add a github issue and reference it here Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1445 + EXPECT_TOKEN(Tokens[3], tok::identifier, TT_Unknown); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_StartOfName); +

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke marked 2 inline comments as done. MarcoFalke added a comment. Minor NFC, I plan to land this tomorrow or Friday CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 ___ cfe-commits mailing

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. 1. your diff is messed up 2. you have to get an accept before anyone will commit for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146247/new/ https://reviews.llvm.org/D146247

[PATCH] D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer

MarcoFalke updated this revision to Diff 507304. MarcoFalke added a comment. NFC CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146288/new/ https://reviews.llvm.org/D146288 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D146401: [clang-format] Don't squash Verilog escaped identifiers

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestVerilog.cpp:897 } +} // namespace +} // namespace test is this correct? do you have an anonymous namespace? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2   3   >