[PATCH] D147395: [Clangd] Make the type hint length limit configurable

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good with a nit. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:80 C.InlayHints.Designators = false; + C.InlayHints.TypeNameLimit = 1;

[PATCH] D147534: [clang][Interp] Make sure we have a variable scope for initializers

tbaeder updated this revision to Diff 510998. tbaeder added a comment. Move the scope and add a test that ensures destruction order of the temporaries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147534/new/ https://reviews.llvm.org/D147534 Files:

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a CXXConstructExpr, so create a local

[PATCH] D147563: [clang-tidy] Deprecate cert-dcl21-cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG712dfec1781d: [clang-tidy] Deprecate cert-dcl21-cpp (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147563/new/

[clang-tools-extra] 712dfec - [clang-tidy] Deprecate cert-dcl21-cpp

Author: Carlos Galvez Date: 2023-04-05T06:33:40Z New Revision: 712dfec1781db8aa92782b98cac5517db548b7f9 URL: https://github.com/llvm/llvm-project/commit/712dfec1781db8aa92782b98cac5517db548b7f9 DIFF: https://github.com/llvm/llvm-project/commit/712dfec1781db8aa92782b98cac5517db548b7f9.diff

[PATCH] D147563: [clang-tidy] Deprecate cert-dcl21-cpp

carlosgalvezp added a comment. In D147563#4244227 , @Eugene.Zelenko wrote: > I think will be good idea to track deprecated features on GitHub issues with > something like `deprecate in XYZ` label(s). Great idea, I started to have the feeling we have

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

tschuett added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:198 +// These better to put in a runtime header but we can't. This is because we +// can't find the percise resource directory in unittests so we have to hard +// code them.

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511084. junaire added a comment. Add IncrementalASTConsumer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. All comments addressed. Thanks for the review @steakhal . Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:162 + const CallEvent& Call) { + const LocationContext* LC = Call.getCalleeStackFrame(0); +

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

erichkeane added a comment. In D147574#4245877 , @Manna wrote: > Thanks @erichkeane. > > Is this known failure? > > Failed Tests (1): > > Clang :: > SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp > >

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

asb updated this revision to Diff 511081. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147611/new/ https://reviews.llvm.org/D147611 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib/Support/RISCVISAInfo.cpp

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 ___ cfe-commits mailing list

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Previous comments on this were here: https://reviews.llvm.org/D147552. I've copy/pasted them into here to keep history at least somewhat reasonable. This LGTM.

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb updated this revision to Diff 511080. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib/Support/RISCVISAInfo.cpp

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

asb updated this revision to Diff 511082. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147612/new/ https://reviews.llvm.org/D147612 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib/Support/RISCVISAInfo.cpp

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 511090. junaire added a comment. Remove old code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[clang] 8ee5029 - [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

Author: Richard Howell Date: 2023-04-05T07:19:48-07:00 New Revision: 8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1 URL: https://github.com/llvm/llvm-project/commit/8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1 DIFF:

[PATCH] D147561: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ee5029b225b: [clang] dont serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147561/new/

[PATCH] D147615: [clang][Sema][NFC] Save token name instead of the full token

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it a bit clearer why we're saving the token (so no need for the later

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

carlosgalvezp added a comment. Such a great check, thanks! I have very minor comments, the most debatable one about the name of the check (but no strong opinion). Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:107 +CheckFactories.registerCheck( +

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL added a comment. Thank you for review, I will correct comments in this week. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:107 +CheckFactories.registerCheck( +"bugprone-enum-to-bool-conversion");

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Fix review comments, rename check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036

[PATCH] D147590: [clang] Add test for CWG607

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG607 is resolved by looking up unqualified

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 511098. jp4a50 added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D147621: [clang][Interp] Start handling mutable record members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 511078. dkrupp marked 21 inline comments as done. dkrupp added a comment. @steakhal thanks for your review. I tried to address all your concerns. I added an extra test case too (multipleTaintSources(..)) which highlights the limitation of the current patch:

[PATCH] D146873: [2/N][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 511093. eopXD added a comment. Rebase upon change of parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCVVTypes.def

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. Thanks @erichkeane. Is this known failure? Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp https://buildkite.com/llvm-project/premerge-checks/builds/145026#01874e21-00e2-47a9-9bc4-975357d197ef Repository: rG LLVM

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. Hi @awarzynski would it please be possible to get this reviewed when you have a spare moment or few, it's essentially the segment of the modifications from this patch which you accepted: https://reviews.llvm.org/D145264 the lowering has been separated into a

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. In D147574#4245881 , @erichkeane wrote: > In D147574#4245877 , @Manna wrote: > >> Thanks @erichkeane. >> >> Is this known failure? >> >> Failed Tests (1): >> >> Clang :: >>

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. This portion of the patch was accepted in https://reviews.llvm.org/D145264. See inline comment about location of LLVM Dialect tests. You may either remove the LLVM

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4244615 , @leonardchan wrote: > Hi. I think this led to some test failures on our builder at > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Hi

[PATCH] D147601: [clang][dataflow] Eliminate code duplication in Environment::createValueUnlessSelfReferential().

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] a5e1a93 - [clang] Fix crash when handling nested immediate invocations

Author: Mariya Podchishchaeva Date: 2023-04-05T05:20:51-04:00 New Revision: a5e1a93ea10ffc06a32df6d9f410e9b297ed136d URL: https://github.com/llvm/llvm-project/commit/a5e1a93ea10ffc06a32df6d9f410e9b297ed136d DIFF:

[PATCH] D146234: [clang] Fix crash when handling nested immediate invocations

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5e1a93ea10f: [clang] Fix crash when handling nested immediate invocations (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D146234?vs=509039=511027#toc Repository: rG LLVM

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

peter.smith added a comment. Approach looks good to me. Some suggestions, mostly around documenting the interface. Comment at: clang/include/clang/Driver/Multilib.h:56 /// This is enforced with an assert in the constructor. Multilib(StringRef GCCSuffix = {}, StringRef

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Hahnfeld added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:43-44 public: static llvm::Expected> create(std::vector ); + static llvm::Expected> If I understand the change correctly, the "old" `create` function on its own is

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:296 } + LinkModules.clear(); return false; // success argentite wrote: > Hahnfeld wrote: > > This looks like a change that has implications beyond support for

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `()[any]`

DavidSpickett added a comment. The test is also failing on our Windows on Arm bot: https://lab.llvm.org/buildbot/#/builders/65/builds/8950 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143128/new/ https://reviews.llvm.org/D143128

[clang] d5c4283 - Revert "[-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `()[any]`"

Author: David Spickett Date: 2023-04-05T08:07:19Z New Revision: d5c428356f6ee107a97977eb9ef1aa4d5fa0c378 URL: https://github.com/llvm/llvm-project/commit/d5c428356f6ee107a97977eb9ef1aa4d5fa0c378 DIFF: https://github.com/llvm/llvm-project/commit/d5c428356f6ee107a97977eb9ef1aa4d5fa0c378.diff

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

nextsilicon-itay-bookstein added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147603: [clang][dataflow] Use `isRecordType()` where appropriate.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is less verbose than checking for class,

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings updated this revision to Diff 511073. michaelplatings marked 3 inline comments as done. michaelplatings added a comment. Expand constructor comment as suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146757: [Driver] Enable defining multilib print options independently of flags

michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:58 + StringRef IncludeSuffix = {}, const flags_list = flags_list(), + PrintOptionsType PrintOptions = PrintOptionsType::PlusFlags, + const flags_list =

[PATCH] D143128: [-Wunsafe-buffer-usage] Fix-Its transforming `[any]` to `()[any]`

DavidSpickett added a comment. I've reverted this, please try to fix the test then reland. The full test output can be downloaded from the buildbot page, if you need any more information let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite added a comment. In D146389#4243900 , @tra wrote: >> Initial interactive CUDA support for clang-repl > > What should a user expect to be supported, functionality wise? I assume it > should cover parsing and compilation. I'm not so sure about

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

Hahnfeld added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:296 } + LinkModules.clear(); return false; // success v.g.vassilev wrote: > argentite wrote: > > Hahnfeld wrote: > > > This looks like a change that has

[clang-tools-extra] dfa8f5b - [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion

Author: Piotr Zegar Date: 2023-04-05T10:22:10Z New Revision: dfa8f5b13e58cd742821860c351005e63f9ce890 URL: https://github.com/llvm/llvm-project/commit/dfa8f5b13e58cd742821860c351005e63f9ce890 DIFF: https://github.com/llvm/llvm-project/commit/dfa8f5b13e58cd742821860c351005e63f9ce890.diff LOG:

[PATCH] D147551: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfa8f5b13e58: [clang-tidy] Fix init-list handling in readability-implicit-bool-conversion (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2357-2361 +if (SubobjectDecl) { + Info.FFDiag(DiagLoc, diag::note_constexpr_uninitialized) << SubobjectDecl; + Info.Note(SubobjectDecl->getLocation(), +

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. Looks even better. Only minor concerns remained, mostly about style and suggestions of llvm utilities. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:129-130 /// Given a pointer/reference argument, return the value it refers

[libunwind] d080b5f - [libunwind] Fix a case of inconsistent indentation. NFC.

Author: Martin Storsjö Date: 2023-04-05T19:23:18+03:00 New Revision: d080b5f1737b4040aa74a5614ae01338f28cd714 URL: https://github.com/llvm/llvm-project/commit/d080b5f1737b4040aa74a5614ae01338f28cd714 DIFF:

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman added a comment. In D146376#4244355 , @Krishna-13-cyber wrote: > - Updated with release note > - I had tried adding more text to the `expected-error` but it already gives a > diagnostic of `static assertion failed due to requirement`

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added a comment. An LLVM code change should be testable on its own; this has it tested by Clang. I think you need a new command-line option to set TargetOptions::UseTargetPathSeparator e.g. via llvm-mc. Other TargetOptions are handled this way. Repository: rG LLVM Github Monorepo

[clang] 53152f1 - [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

Author: Andrew Gozillon Date: 2023-04-05T12:50:32-05:00 New Revision: 53152f12a47bf6e97f1f2f2d6b71e7b4d4e3740a URL: https://github.com/llvm/llvm-project/commit/53152f12a47bf6e97f1f2f2d6b71e7b4d4e3740a DIFF:

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

This revision was automatically updated to reflect the committed changes. Closed by commit rG53152f12a47b: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate… (authored by agozillon). Changed prior to commit: https://reviews.llvm.org/D147324?vs=510080=511154#toc

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this looks much better to me! LGTM, but please add a release note about the fix when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. In D147209#4245229 , @fpetrogalli wrote: > In D147209#4244615 , @leonardchan > wrote: > >> Hi. I think this led to some test failures on our builder at >>

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

vaibhav.y added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4246622 , @leonardchan wrote: > In D147209#4245229 , @fpetrogalli > wrote: > >> In D147209#4244615 , @leonardchan >> wrote: >>

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. I think as we converge, now it could be time to update the summary of the patch to reflect the current implementation. (e.g. flowids etc.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144269/new/ https://reviews.llvm.org/D144269

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:91-92 expressions and how their types are deduced therein, in all C++ language versions. +- Implemented partial support for `P2448R2: Relaxing some constexpr restrictions

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems;

[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

erichkeane added a comment. Ah, needs a release note however! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 78d0d59 - Add some additional comments to this test; NFC

Author: Aaron Ballman Date: 2023-04-05T13:15:34-04:00 New Revision: 78d0d59209bf858435bcd19046e94fce0386ace8 URL: https://github.com/llvm/llvm-project/commit/78d0d59209bf858435bcd19046e94fce0386ace8 DIFF: https://github.com/llvm/llvm-project/commit/78d0d59209bf858435bcd19046e94fce0386ace8.diff

[clang] 57caadc - [MSVC] Allow declaration of multi-dim 'property' array fields

Author: Mike Rice Date: 2023-04-05T10:29:37-07:00 New Revision: 57caadc57a30f2279099e5b86bb555b4aab621ce URL: https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce DIFF: https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce.diff

[clang] 5bab909 - Add release note for D147569.

Author: Zequan Wu Date: 2023-04-05T14:43:52-04:00 New Revision: 5bab9097ce5b093289e8d40809d02f002febe910 URL: https://github.com/llvm/llvm-project/commit/5bab9097ce5b093289e8d40809d02f002febe910 DIFF: https://github.com/llvm/llvm-project/commit/5bab9097ce5b093289e8d40809d02f002febe910.diff

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 511126. sammccall marked 8 inline comments as done. sammccall added a comment. address comments (sorry about long turnaround!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. In D147324#4245932 , @kiranchandramohan wrote: > LG. This portion of the patch was accepted in > https://reviews.llvm.org/D145264. > > See inline comment about location of LLVM Dialect tests. You may either > remove the LLVM

[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

mikerice closed this revision. mikerice added a comment. 57caadc57a30f2279099e5b86bb555b4aab621ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623

[clang] 4e93bd4 - [Coverage] Fix crash when visiting PseudoObjectExpr.

Author: Zequan Wu Date: 2023-04-05T14:37:41-04:00 New Revision: 4e93bd4174454c7c70b8f2fa7512e2f97681f295 URL: https://github.com/llvm/llvm-project/commit/4e93bd4174454c7c70b8f2fa7512e2f97681f295 DIFF: https://github.com/llvm/llvm-project/commit/4e93bd4174454c7c70b8f2fa7512e2f97681f295.diff

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93bd417445: [Coverage] Fix crash when visiting PseudoObjectExpr. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 58. zequanwu added a comment. Herald added a subscriber: ormris. - Pass `LangOptions.UseTargetPathSeparator` down to TargetOptions to use host path separator when it's set. - Add a test case. The problem is when if we are targeting to linux, clang

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to missing check on union, there was a null expression added to init list that caused crash later. Fixes

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 511153. john.brawn edited the summary of this revision. john.brawn added a comment. New version that checks for special filenames in ResolveImportedPath. I spent a while trying to come up with a test using just clang where not doing this fails, but

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu added a comment. Added the missing release note at rG5bab9097ce5b093289e8d40809d02f002febe910 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. In D147574#4246004 , @aaron.ballman wrote: > LGTM Thank you @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574

[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

aaron.ballman accepted this revision. aaron.ballman added a comment. Changes LGTM but please add a release note about the new functionality when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman added a comment. Ah, I like this approach -- it keeps things roughly in sync with checking for unique object representations, which is great. I spotted a few questions, but in general this is heading in the right direction. You should also add a release note to

[clang] 59cb470 - [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Author: Manna, Soumi Date: 2023-04-05T16:00:45-04:00 New Revision: 59cb47015a184862f3709a7ab084ccd086816176 URL: https://github.com/llvm/llvm-project/commit/59cb47015a184862f3709a7ab084ccd086816176 DIFF: https://github.com/llvm/llvm-project/commit/59cb47015a184862f3709a7ab084ccd086816176.diff

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I can check out a copy of this patch and help test it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list

[clang] 5c614bd - [clang-format] Fix bugs with "LambdaBodyIndentation: OuterScope"

Author: Jon Phillips Date: 2023-04-05T14:38:38-07:00 New Revision: 5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2 URL: https://github.com/llvm/llvm-project/commit/5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2 DIFF: https://github.com/llvm/llvm-project/commit/5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2.diff

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c614bd88f12: [clang-format] Fix bugs with LambdaBodyIndentation: OuterScope (authored by jp4a50, committed by owenpan). Repository: rG LLVM

[clang] 385bcc6 - Revert "[clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR."

Author: Francesco Petrogalli Date: 2023-04-05T20:55:08+02:00 New Revision: 385bcc65ff44d9860572ee85adb5df1333860a05 URL: https://github.com/llvm/llvm-project/commit/385bcc65ff44d9860572ee85adb5df1333860a05 DIFF:

[clang] 65c0134 - [clang][deps] NFC: Make PCH test more debuggable

Author: Jan Svoboda Date: 2023-04-05T12:29:05-07:00 New Revision: 65c0134872c1e298ade176b5c84d86b4a058a85c URL: https://github.com/llvm/llvm-project/commit/65c0134872c1e298ade176b5c84d86b4a058a85c DIFF: https://github.com/llvm/llvm-project/commit/65c0134872c1e298ade176b5c84d86b4a058a85c.diff

[clang] 34f1439 - [clang][deps] NFC: Don't collect PCH input files

Author: Jan Svoboda Date: 2023-04-05T12:29:03-07:00 New Revision: 34f143988f3f18dcca6d26a7a9817d8523300440 URL: https://github.com/llvm/llvm-project/commit/34f143988f3f18dcca6d26a7a9817d8523300440 DIFF: https://github.com/llvm/llvm-project/commit/34f143988f3f18dcca6d26a7a9817d8523300440.diff

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

rsmith added a comment. I'm happy whenever Aaron is. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8809 + // + // We will support P2448R2 in language modes earlier than C++23 as an extenion + // The concept of constexpr-compatible was removed.

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: arphaman, erichkeane. Herald added a reviewer: aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Two calls to

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 511181. Krishna-13-cyber added a comment. - Updated with the diagnostic messages (comments for test cases) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. Thanks for accepting! Commit details as follows as per previous diff: Name: Jon Phillips Email: jonap2...@gmail.com If someone could commit for me that would be much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. Here's the diff to `test_demangle.pass.cpp`: --- a/libcxxabi/test/test_demangle.pass.cpp +++ b/libcxxabi/test/test_demangle.pass.cpp @@ -29995,10 +29995,10 @@ const char* cases[][2] = {"_Z15test_uuidofTypeI10TestStructEvDTu8__uuidofT_EE", "void

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

erichkeane added a comment. I can't really review the libcxxabi parts, or the llvm-demangler parts, but everything looks right to me. I've got a pair of quick questions, otherwise I think this is going to be fine for me. Note the extra paren changes are something I think are valuable, but I'm

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. Following on from our discussion about new options needing motivation from public style guides, I've updated the KJ style guide to clarify its stance on braced init lists: https://github.com/capnproto/capnproto/blob/master/style-guide.md#spacing-and-bracing

[clang] c61f45f - Update clang :: Driver/debug-options.c to fix the buildbots

Author: Matthew Voss Date: 2023-04-05T13:27:17-07:00 New Revision: c61f45fc3e041606c5b94c468a5c092e8a6e5601 URL: https://github.com/llvm/llvm-project/commit/c61f45fc3e041606c5b94c468a5c092e8a6e5601 DIFF: https://github.com/llvm/llvm-project/commit/c61f45fc3e041606c5b94c468a5c092e8a6e5601.diff

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. I have committed the patch here: https://reviews.llvm.org/rG59cb47015a18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 ___ cfe-commits

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. @asb, @craig.topper, @jrtc27 Are there any remaining considerations for us here? From the discussions in psABI and sig-toolchain, I think we have a consensus that this is the approach we'll be taking for RISC-V. We'd prefer to correct this ASAP, so as to prevent

[PATCH] D147546: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc37b95b515a5: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld (authored by ormris). Herald added a project: clang. Herald

  1   2   >