[PATCH] D147888: Update declaration message of extern linkage

tbaeder added inline comments. Comment at: clang/test/SemaCXX/extern_static.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -Wabstract-vbase-init +void f(void) That's unnecessary, isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

craig.topper added a comment. What is the interaction between this and the -m32 and -m64 options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148124/new/ https://reviews.llvm.org/D148124 ___

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

kadircet updated this revision to Diff 512898. kadircet added a comment. - Expose helper to get preamble patch entry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148143/new/ https://reviews.llvm.org/D148143 Files:

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 I would just say "Yes", i think clang 3.8 predates these issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148148: [clang] Bump AS_GNU to 1

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This LGTM, though curious about the re-ordering. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:55 + +/// The attibute has no source code manifestation and is only created +/// implicitly. erichkeane wrote: > If I recall, there was some pretty awful

[PATCH] D148124: [RISCV][Driver] Allow the use of CPUs with a different XLEN than the triple.

kito-cheng created this revision. kito-cheng added reviewers: asb, craig.topper, luismarques. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 512805. skatrak added a comment. Add unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2262 + /// Return true if the given vector types are lax-compatible RISC-V vector + /// types as defined by -flax-vector-conversions=, false otherwise. + bool

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2263 + /// types as defined by -flax-vector-conversions=, which permits implicit + /// conversions between vectors wit different number of elemnts and/or + /// incompatible element types, false

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu updated this revision to Diff 512868. zequanwu added a comment. Add assertion on source locations in `pushRegion`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147073/new/ https://reviews.llvm.org/D147073 Files:

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Since we

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 suggestion to catch a few more cases that I think are incorrect, but this is a move in the right direction. Thanks! Comment at:

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin added a comment. In D125171#4261301 , @MyDeveloperDay wrote: > is it possible to point to a github issue that this related to in the review > summary, if not please can you make one so we can track the issue its trying > to solve added an

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MultipleNewInOneExpressionCheck.cpp:44-45 +return BinOp->getOpcode() == BO_Assign && + BinOp->getRHS()->IgnoreParenCasts() == E; + +

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + @erichkeane does this cover the dependent case or were you looking for something else? Here are on the only mentions of

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

erichkeane added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > erichkeane wrote: > > craig.topper wrote: > > > @erichkeane does this cover the dependent case or were you

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ Endill wrote: > cor3ntin

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. In D146101#4261293 , @MyDeveloperDay wrote: > If all comments and concerns are done, then I'm inclined to accept, but I'd > like @owenpan and @HazardyKnusperkeks to give their opinion before we land > this. Sure. Thanks!

[clang] d982643 - [clang] Implement CWG 2397

Author: Younan Zhang Date: 2023-04-12T22:30:23+08:00 New Revision: d9826433f31cd081d0229d47d7982b5bf3c0055f URL: https://github.com/llvm/llvm-project/commit/d9826433f31cd081d0229d47d7982b5bf3c0055f DIFF: https://github.com/llvm/llvm-project/commit/d9826433f31cd081d0229d47d7982b5bf3c0055f.diff

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1894 and its duplicate CWG2199 are resolved

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu added a comment. In D147256#4261949 , @hans wrote: >> Well, MSVC cl removes redundant dots so we shouldn't remove >> llvm::sys::path::remove_dots. > > Could we do the `remove_dots` on the Clang side, where we can decide based on > the

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/test/OpenMP/loop_bind_codegen.cpp:51-56 +void thread_loop2() { + #pragma omp loop bind(thread) + for (int j = 0 ; j < NNN ; j++) { +aaa[j] = j*NNN; + } +} ABataev wrote: > I think it should trigger the assert

[PATCH] D143364: [RISCV] Support scalar/fix-length vector NTLH intrinsic with different domain

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/ntlh-intrinsics/riscv32-zihintntl.c:19 +typedef signed short v8ss __attribute__((vector_size(16))); +typedef signed char v16sc __attribute__((vector_size(16))); +v4si v4si1, v4si2; What

[PATCH] D148112: [include-cleaner] Improve handling for templates

dyung added a comment. @kadircet, your change is causing 3 test failures on Windows bots, can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/216/builds/19740 https://lab.llvm.org/buildbot/#/builders/123/builds/18332 Repository: rG LLVM

[clang] d945b64 - [clang] Make make_cxx_dr_status script runnable from anywhere

Author: Vlad Serebrennikov Date: 2023-04-12T20:46:05+03:00 New Revision: d945b6496ec6604f692804d501fc96583069d432 URL: https://github.com/llvm/llvm-project/commit/d945b6496ec6604f692804d501fc96583069d432 DIFF:

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd945b6496ec6: [clang] Make make_cxx_dr_status script runnable from anywhere (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

reames added a comment. I would be fine landing this as experimental before ratification. I see no real downside to doing that, and would essentially leave it the judgement of the patch author as to whether just waiting until ratification or doing the extra work for staging as experimental is

[PATCH] D147941: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

This revision was automatically updated to reflect the committed changes. skatrak marked 2 inline comments as done. Closed by commit rG2266f4a3b38f: [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang (authored by skatrak). Repository: rG LLVM Github Monorepo

[clang] 2266f4a - [Flang][Driver][OpenMP] Enable options for selecting offloading phases in flang

Author: Sergio Afonso Date: 2023-04-12T14:59:37+01:00 New Revision: 2266f4a3b38f4b59d313cdd2a9209952afb29d14 URL: https://github.com/llvm/llvm-project/commit/2266f4a3b38f4b59d313cdd2a9209952afb29d14 DIFF: https://github.com/llvm/llvm-project/commit/2266f4a3b38f4b59d313cdd2a9209952afb29d14.diff

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512837. junaire added a comment. dont include if we don't have it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. In D147073#4261633 , @zequanwu wrote: > In D147073#4258981 , @aaron.ballman > wrote: > >> Perhaps a way to split the middle would be to assert that the source >> locations are

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

hans added a comment. > Well, MSVC cl removes redundant dots so we shouldn't remove > llvm::sys::path::remove_dots. Could we do the `remove_dots` on the Clang side, where we can decide based on the LangOpts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512869. junaire added a comment. fix ci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > @erichkeane does this cover the dependent case or were you looking for > >

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

craig.topper added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + aaron.ballman wrote: > erichkeane wrote: > > craig.topper wrote: > > > erichkeane wrote: > > > > craig.topper wrote: > > > > >

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9792 + "construct">; +def error_loop_reduction_clause : Error< + "reduction clause not handled with '#pragma omp loop bind(teams)'">; err_omp_...

[PATCH] D148148: [clang] Bump AS_GNU to 1

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:28 /// __attribute__((...)) -AS_GNU, +AS_GNU = 1, Note for others: we're now at 11 items (10 items + starting at 1), stored in 4 bits. So this doesn't

[PATCH] D148101: [clang] Ensure that Attr::Create(Implicit) chooses a valid syntax

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:55 + +/// The attibute has no source code manifestation and is only created +/// implicitly. rsandifo-arm wrote: > erichkeane wrote: > > If I recall, there was

[PATCH] D147989: [clang] Fix Attribute Placement

aaron.ballman added a comment. Precommit CI has several failures introduced by this patch -- some test cases need to be fixed up (in addition to the new test coverage). Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3424 "attribute %0 is ignored, place it

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

erichkeane added a comment. I'm not sold on the value of this patch, but I don't see any problems with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 ___

[PATCH] D147875: [clang][Diagnostics] WIP: Show line numbers when printing code snippets

tbaeder added a comment. Since basically nobody has seen multiple snippet lines being printed, we probably need to fix up a bunch of diagnostics afterwards to be more useful, e.g. ./array.cpp:111:5: error: no matching function for call to 'func' 111 | func(1, 2, 3, 4), "hah,

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jp4a50 requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet updated this revision to Diff 512851. kadircet marked an inline comment as done. kadircet added a comment. Herald added a subscriber: ChuanqiXu. - Ignore explicit instantiations - Update tests to use decls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148112: [include-cleaner] Improve handling for templates

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:109 ADD_FAILURE() << DiagBuf << "\nfrom code:\n" << ReferencingCode; + llvm::sort(TargetDeclKinds); +

[clang] 3704752 - [clang][NFC] Use range-for loop in TextDiagnostic.cpp

Author: Timm Bäder Date: 2023-04-12T18:50:37+02:00 New Revision: 37047523a9fb5ffa74eaf94d9d52db831f99c062 URL: https://github.com/llvm/llvm-project/commit/37047523a9fb5ffa74eaf94d9d52db831f99c062 DIFF: https://github.com/llvm/llvm-project/commit/37047523a9fb5ffa74eaf94d9d52db831f99c062.diff

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added a comment. I've not done a complete review yet, but I got started on it and have a handful of comments. Comment at: clang/include/clang/Basic/TokenKinds.def:945 +// Annotation for end of input in clang-repl. +ANNOTATION(input_end) + Should

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{ I think i would prefer

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

Endill created this revision. Endill added reviewers: clang-language-wg, cor3ntin. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This script has hardcoded relative paths to `clang/test/CXX/drs`,

[PATCH] D148148: [clang] Bump AS_GNU to 1

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo *AttrName, const IdentifierInfo *ScopeName, SourceRange AttrRange, rsandifo-arm wrote: >

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

erichkeane added a comment. Again, not sold on value, but no problems with the patch itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103/new/ https://reviews.llvm.org/D148103 ___ cfe-commits

[PATCH] D138777: [clang-tidy] Add check bugprone-multiple-new-in-one-expression.

balazske updated this revision to Diff 512808. balazske added a comment. Simplified AST matchers a bit. Added check for list-initialization syntax at constructor call. Added some tests. Updated documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147909: [clang] Implement CWG 2397

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9826433f31c: [clang] Implement CWG 2397 (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147909/new/ https://reviews.llvm.org/D147909

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:333 + // enabled. + !(Current.is(TT_LambdaLBrace) && Style.BraceWrapping.BeforeLambdaBody) && CurrentState.NoLineBreakInOperand) { AFAICT, this only matters when

[PATCH] D147888: Update declaration message of extern linkage

Krishna-13-cyber updated this revision to Diff 512848. Krishna-13-cyber added a comment. - Updated with removing redundant flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147888/new/ https://reviews.llvm.org/D147888 Files:

[PATCH] D148112: [include-cleaner] Improve handling for templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34f5774920f5: [include-cleaner] Improve handling for templates (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 34f5774 - [include-cleaner] Improve handling for templates

Author: Kadir Cetinkaya Date: 2023-04-12T17:36:05+02:00 New Revision: 34f5774920f54f81b3e3a361a7c7f21a61e39b39 URL: https://github.com/llvm/llvm-project/commit/34f5774920f54f81b3e3a361a7c7f21a61e39b39 DIFF:

[PATCH] D147307: [clang] Do not require GNUInlineAttr for inline builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147307/new/ https://reviews.llvm.org/D147307 ___ cfe-commits mailing list

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

aaron.ballman added a comment. Aside from the commenting issue pointed out by @shafik, I think we should move the test case into its own test file in SemaCXX and that `RUN` line should *not* use `-verify`. This way, we can test that we don't crash but we don't have to worry about spurious test

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 512801. junaire added a comment. use unsigned long instead of std::size_t when including the runtimes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D98012: [RFC][doc] Document that RISC-V's __fp16 has different behavior

kito-cheng abandoned this revision. kito-cheng added a comment. Herald added subscribers: pcwang-thead, VincentWu, arichardson. Herald added a project: All. RISC-V using `_Float16` as official half-precision type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148143: [clangd] Treat preamble patch as main file for include-cleaner analysis

sammccall added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:379 + (H.physical() == MainFile || + H.physical()->getName().endswith(PreamblePatch::HeaderName))) { Satisfied = true; Comparing

[PATCH] D148146: [clang] Make make_cxx_dr_status script runnable from anywhere

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Great idea, looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148146/new/ https://reviews.llvm.org/D148146

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added a comment. Thank you for taking a look at this. Comment at: clang/test/CXX/drs/dr18xx.cpp:172-227 +namespace dr1894 { // dr1894: 3.8 + // NB: reusing dr407 test + struct S; + typedef struct S S; + void f() { +struct S *p; +{

[PATCH] D148148: [clang] Bump AS_GNU to 1

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Following a suggestion from Erich in

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 cor3ntin wrote: > I would just say "Yes", i think clang 3.8 predates these issues It's not the case: 2199 was filed 12.11.2015,

[PATCH] D148148: [clang] Bump AS_GNU to 1

rsandifo-arm added inline comments. Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135 AttributeCommonInfo(const IdentifierInfo *AttrName, const IdentifierInfo *ScopeName, SourceRange AttrRange, erichkeane wrote: > Did

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

erichkeane added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 Endill wrote: > cor3ntin wrote: > > I would just say "Yes", i think clang 3.8 predates these issues > It's not the case: 2199

[PATCH] D148105: [clang] Fix FIXME in isAlignasAttribute()

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Huh, this is much less disruptive than I thought it was going to be. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148105/new/

[PATCH] D148103: [clang] Allow attributes to be constructed from keyword tokens

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Later patches show enough value to this, I'm OK with it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148103/new/

[PATCH] D148102: [clang] Specify attribute syntax & spelling with a single argument

erichkeane added a comment. Later patches show enough value to this, I'm OK with it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148102/new/ https://reviews.llvm.org/D148102 ___ cfe-commits

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

zequanwu added a comment. In D147073#4258981 , @aaron.ballman wrote: > In D147073#4258664 , @zequanwu > wrote: > >> In D147073#4258529 , >> @aaron.ballman wrote: >>

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + erichkeane wrote: > craig.topper wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > @erichkeane does this cover

[PATCH] D148136: [clang] Add test for CWG1894 and CWG2199

Endill added inline comments. Comment at: clang/www/cxx_dr_status.html:13004 Typedefs and tags -Unknown +Clang 3.8 erichkeane wrote: > Endill wrote: > > cor3ntin wrote: > > > I would just say "Yes", i think clang 3.8 predates these issues > >

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1665-1669 + const auto DesignatedInitializerIndentWidth = + Style.DesignatedInitializerIndentWidth < 0 + ?

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

asb added a comment. In D148066#4262379 , @reames wrote: > I would be fine landing this as experimental before ratification. I see no > real downside to doing that My concern would be that as we don't gate CSR names on enabling the relevant

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 512945. kpdev42 added a comment. Thanks for pointing out the bug @Michael137 . It seems that clang assigns arbitrary offsets for non_unique_address so analyzing them brings me nowhere. In this patch I tried assigning no_unique_address to every empty

[PATCH] D148148: [clang] Bump AS_GNU to 1

rsandifo-arm updated this revision to Diff 512947. rsandifo-arm added a comment. Gah, sorry. Due to a botched git operation, I posted a first cut with a stupid typo, rather than the version that passed testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147121: [hwasan] remove requirment for PIE

vitalybuka removed 1 blocking reviewer(s): eugenis. vitalybuka added a comment. This revision is now accepted and ready to land. Feel free to land. It works on my arm linux setup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147121/new/

[PATCH] D146987: [Assignment Tracking] Enable by default

MaskRay added a comment. The latest reland 3820e9a2b29a2e268319ed6635da0d59e18d736d still caused some issues to our internal workloads. Stay tuned... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. I'm seeing llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned int): Assertion `AssignmentTrackingEnabled && "expected assignment tracking to be enabled"' failed.

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers created this revision. nickdesaulniers added reviewers: erichkeane, MaskRay. Herald added subscribers: pmatos, asb, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: jhenderson. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho.

[PATCH] D148181: [Demangle] make llvm::demangle take a StringRef; NFC

nickdesaulniers added a comment. There's a few more callsites I'd like to clean up, tomorrow: - llvm/tools/llvm-objdump/llvm-objdump.cpp - llvm/tools/llvm-objdump/XCOFFDump.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148181/new/

[PATCH] D147263: Fix an assertion failure in unwrapSugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba88443b31a: Fix an assertion failure in unwrapSugar (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 2ba8844 - Fix an assertion failure in unwrapSugar

Author: Akira Hatanaka Date: 2023-04-12T16:45:56-07:00 New Revision: 2ba88443b31a437a3e80ac4bb6d8ca1675828d1b URL: https://github.com/llvm/llvm-project/commit/2ba88443b31a437a3e80ac4bb6d8ca1675828d1b DIFF:

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

MaskRay added a comment. Herald added subscribers: bviyer, ekilmer, jplehr, thopre. @Ericson2314 @phosek What's the state of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608

[PATCH] D147176: [clang-format] NFC ensure Style operator== remains sorted for ease of editing

owenpan added a comment. Herald added a reviewer: rymiel. @MyDeveloperDay We keep getting "spammed" by [libc++][format] patches. Can you delete the rule in H987 : "field": "differential.revision.title", "condition": "contains", "value": "[Format]" or change

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. https://github.com/llvm/llvm-project/issues/62110 (in addition to the self-friendship case) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. F27125556: a.tgz this is the original repro that crashed but maybe differently (you'll need to remove the plugin arguments since our clang has some custom plugins) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147920: [clang] Add test for CWG399

shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test Endill wrote: > shafik wrote: > > Endill wrote: > > > Despite a couple of

[PATCH] D148158: [include-cleaner] Handle incomplete template specializations

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Instantiation pattern is null for incomplete template types and using

[PATCH] D147121: [hwasan] remove requirment for PIE

eugenis added a comment. Sorry, I do not remember why this requirement is there. Must be related to shadow / allocator placement and kernel mapping conflicts, but hwasan is using dynamic shadow so that should not be an issue... LGTM as long as it works. Repository: rG LLVM Github Monorepo

[clang] efc8b52 - Revert D146987 "[Assignment Tracking] Enable by default"

Author: Fangrui Song Date: 2023-04-12T15:01:04-07:00 New Revision: efc8b52cbd942f4bd5ffe8f64da5fb8a3b7adc32 URL: https://github.com/llvm/llvm-project/commit/efc8b52cbd942f4bd5ffe8f64da5fb8a3b7adc32 DIFF: https://github.com/llvm/llvm-project/commit/efc8b52cbd942f4bd5ffe8f64da5fb8a3b7adc32.diff

[PATCH] D146329: [Clang] Fix defaulted equality operator so that it does not attempt to compare unnamed bit-fields

shafik updated this revision to Diff 512983. shafik added a comment. - Added codegen test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146329/new/ https://reviews.llvm.org/D146329 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D141307: Add -f[no-]loop-versioning option

Leporacanthicus updated this revision to Diff 512929. Leporacanthicus marked 3 inline comments as done. Leporacanthicus added a comment. - Add new function to help clarify the purpose of the options being used. - Add descriptive comment to make function use clearer. - Update tests to make them a

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/attr-riscv-rvv-vector-bits.cpp:12 + +template struct S { T var; }; + craig.topper wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > craig.topper wrote: > > > > erichkeane wrote: > > > >

[PATCH] D147073: [Coverage] Handle invalid end location of an expression/statement.

aaron.ballman added a comment. Thank you! I think there's only a few small things left then: - Add a release note about the fact that we worked around this issue in non-asserts builds but that assert builds may see new assertions triggered from this and to file an issue with a reproducer if

[PATCH] D141307: Add -f[no-]loop-versioning option

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141307/new/ https://reviews.llvm.org/D141307 ___ cfe-commits mailing list

  1   2   >