[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Fix function pointer compare Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 ___

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, tianshilei1992, MaskRay, jdoerfert. Herald added subscribers: kosarev, abrachet, phosek, kerbowa, s.egerton, simoncook, asb, jvesely. Herald added a project: All. jhuber6 requested review of this revision.

[PATCH] D147920: [clang] Add test for CWG399

aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added inline comments. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test shafik wrote: > Endill wrote: > > shafik

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

jhuber6 updated this revision to Diff 516167. jhuber6 added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149019/new/ https://reviews.llvm.org/D149019 Files: clang/include/clang/Driver/Options.td

[PATCH] D148767: Restore CodeGen/LowLevelType

chapuni updated this revision to Diff 516177. chapuni retitled this revision from "Restore MVT and LLT into llvm/CodeGen" to "Restore CodeGen/LowLevelType". chapuni edited the summary of this revision. chapuni added a comment. - Split out Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D148769: Split out `CodeGenTypes` from `CodeGen` for LLT/MVT/VT

chapuni updated this revision to Diff 516182. chapuni added a comment. Herald added a subscriber: ThomasRaoux. Herald added a reviewer: zuban32. Herald added a reviewer: mpaszkowski. - Rebase and fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149019/new/ https://reviews.llvm.org/D149019

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

jhuber6 added a comment. In D149019#4290573 , @JonChesterfield wrote: > Can't reasonably see the semantic change between all the whitespace reformat, > please split those two. E.g. use git-clang-format to only fix formatting in > the part you're

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

JonChesterfield added a comment. Can't reasonably see the semantic change between all the whitespace reformat, please split those two. E.g. use git-clang-format to only fix formatting in the part you're changing, or commit a clang-format only change first and then rebase this. Repository:

[PATCH] D125224: [CodeComplete] prototype of contextual postfix completions

SR_team added a comment. Iterator checks may crash in current state. Also, `pointeeType` may return invalid type of iterator store (`T*` instead of `T`) Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5589 + const auto = + static_cast(RD->getDeclContext()) +

[clang-tools-extra] 76469d5 - [clang-tidy] Modernize FileState (NFC)

Author: Kazu Hirata Date: 2023-04-23T09:07:23-07:00 New Revision: 76469d5aff1e0967adfe23d275075610585eef72 URL: https://github.com/llvm/llvm-project/commit/76469d5aff1e0967adfe23d275075610585eef72 DIFF: https://github.com/llvm/llvm-project/commit/76469d5aff1e0967adfe23d275075610585eef72.diff

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:730 +res.getLangOpts().OMPHostIRFile = arg->getValue(); +if (!llvm::sys::fs::exists(res.getLangOpts().OMPHostIRFile)) +

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL updated this revision to Diff 516140. PiotrZSL added a comment. Undo change for cppcoreguidelines-use-default-member-init Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149015/new/ https://reviews.llvm.org/D149015 Files:

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

carlosgalvezp added a comment. The commit message doesn't really tell me "what" this commit is fixing, it only points to a section of the Standard. It talks about "a false positive" but it doesn't tell what this FP is about. Could you write a little bit more about what the problem is?

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferIsaOrDynCastInConditionalsCheck.h:61 +private: + mutable std::optional HasIsPresent; }; njames93 wrote: > PiotrZSL wrote: > > no need for mutable, its used only form

[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

PiotrZSL added a comment. Thank you for your feedback regarding the code review. I understand that the review includes the removal of 35 lines and the addition of 42 lines. However, I would like to point out that the areStatementsIdentical function and the other function in question are only

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 516152. HerrCai0907 added a comment. fix assert failed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

argentite added inline comments. Comment at: clang/lib/Interpreter/Offload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// v.g.vassilev wrote: > argentite wrote: > > Hahnfeld wrote: > > > v.g.vassilev wrote: > > > >

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 516151. HerrCai0907 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D148767: Restore MVT and LLT into llvm/CodeGen

chapuni updated this revision to Diff 516158. chapuni edited the summary of this revision. chapuni added a comment. Herald added a subscriber: ThomasRaoux. Herald added a reviewer: zuban32. Herald added a reviewer: mpaszkowski. - Update CMake deps - s/LowLevelType/LowLevelTypeUtils/ - modmap:

[PATCH] D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check

thakis added a comment. > ASTMatchers have been baked into clang binary for at least a few years > already, actively used by the static analyzer (some backstory in D25429 > ). This warning is, however, probably the > first use in clang proper, so they'll be

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

ChuanqiXu added a comment. @rsmith gentle ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148506/new/ https://reviews.llvm.org/D148506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

PiotrZSL added a comment. Tests in lines 1195, 1201 actually tests InitListExpr. Test in line 1207 test negative scenario of CXXConstructExpr (list), but I didn't found any positive test for CXXConstructExpr with list expr, please add such test to show that warnings are still produced for such

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Manna added a comment. In D148639#4284085 , @tahonermann wrote: > This set of changes looks good to me. Thank you @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rGff4d2207db00: [NFC][clang] Fix static analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ff4d220 - [NFC][clang] Fix static analyzer concerns

Author: Manna, Soumi Date: 2023-04-23T18:19:55-04:00 New Revision: ff4d2207db00032b8c1fff7093b0407564518855 URL: https://github.com/llvm/llvm-project/commit/ff4d2207db00032b8c1fff7093b0407564518855 DIFF: https://github.com/llvm/llvm-project/commit/ff4d2207db00032b8c1fff7093b0407564518855.diff

[libunwind] bda5f77 - [test] Simplify libunwind REQUIRES

Author: Fangrui Song Date: 2023-04-23T14:58:46-07:00 New Revision: bda5f77f9664dc1b7f43bef854d66af161a9a5f0 URL: https://github.com/llvm/llvm-project/commit/bda5f77f9664dc1b7f43bef854d66af161a9a5f0 DIFF: https://github.com/llvm/llvm-project/commit/bda5f77f9664dc1b7f43bef854d66af161a9a5f0.diff

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb updated this revision to Diff 516211. jaredgrubb marked 6 inline comments as done. jaredgrubb added a comment. Address review comments from @owenpan CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 Files:

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

jaredgrubb added a comment. I have uploaded patch for all the points you called out. (Sorry for delay; I missed the suggestions earlier!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145262/new/ https://reviews.llvm.org/D145262 ___

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

glaubitz added a comment. @myhsu Can you fix the typo in the commit message? s/supports/support/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147481/new/ https://reviews.llvm.org/D147481 ___ cfe-commits mailing list

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D149000: Update with warning message for comparison to NULL pointer

tbaeder added a comment. Both test failures look like you just need to add the additional new diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 ___

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

carlosgalvezp added a comment. I would agree that the fact that a function throws or not can only be found out when analyzing the function definition (it's impossible to know from the declaration). There's also a duplicate diagnostic that I don't see much value on, so I would agree with this

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. Generally, looks good to me. I'd like to wait for @Hahnfeld and @tra's feedback at least for another week before merging. @dblaikie, I know that generally we do not want to run tests on the bots and that makes testing quite hard for this patch. Do you have a

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects when a

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-throw.cpp:4 +void throwing_throw_nothing() throw() { +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: an exception may be thrown in function

[PATCH] D148066: [RISCV] Add Smaia and Ssaia extensions support

4vtomat updated this revision to Diff 516137. 4vtomat added a comment. Resolved Alex's comment. Moved both of extensions to experimental. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148066/new/ https://reviews.llvm.org/D148066 Files:

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 516139. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Formating fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files:

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-throw.cpp:4 +void throwing_throw_nothing() throw() { +// CHECK-MESSAGES: :[[@LINE-1]]:6: warning: an exception may be thrown in function 'throwing_throw_nothing'

[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

carlosgalvezp added a comment. Thanks for the refactoring, great to remove some code duplication! As a reviewer it's not possible for me to confidently review the functional changes to `areStatementsIdentical`, since they don't show side by side as they are in different files. Please perform

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. Gentle ping .. @kamaub Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D143467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149017: [RISCV] Rewrite RVV-related class-based subroutines to functions

pcwang-thead updated this revision to Diff 516224. pcwang-thead added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rewrite all found subroutines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149017/new/

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

jhuber6 updated this revision to Diff 516188. jhuber6 added a comment. Remove cc1 negative option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149019/new/ https://reviews.llvm.org/D149019 Files: clang/include/clang/Driver/Options.td

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL added a comment. First, re-base code, looks like there were some changes in this check, and now there are conflicts with this path. Second I don't any more comments, for me this code looks fine, BUT I'm not familiar too much with this check. Check history for this check, and maybe

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:972 + LangOpts<"ConvergentFunctions">, DefaultFalse, + NegFlag, + PosFlag>; Only one of the positive and negative options need to be a cc1 option. Comment at:

[clang] 0d333bf - Remove ExplicitEmulatedTLS and simplify -femulated-tls handling

Author: Fangrui Song Date: 2023-04-23T11:55:12-07:00 New Revision: 0d333bf0e3aa37e2e6ae211e3aa80631c3e01b85 URL: https://github.com/llvm/llvm-project/commit/0d333bf0e3aa37e2e6ae211e3aa80631c3e01b85 DIFF: https://github.com/llvm/llvm-project/commit/0d333bf0e3aa37e2e6ae211e3aa80631c3e01b85.diff

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992, tra, yaxunl. Herald added a subscriber: kosarev. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GPU

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

jhuber6 updated this revision to Diff 516198. jhuber6 added a comment. Herald added subscribers: mattd, asavonic. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149028/new/ https://reviews.llvm.org/D149028 Files:

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

JonChesterfield added a comment. I think this is sensible. Passing fno-convergent-functions presumably changes the default? I wonder if we should adopt this and then remove the checks for each of the GPU programming models Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516201. Krishna-13-cyber added a comment. - Update with diagnostic addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149000/new/ https://reviews.llvm.org/D149000 Files:

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

jhuber6 added a comment. In D149028#4290831 , @JonChesterfield wrote: > I think this is sensible. Passing fno-convergent-functions presumably changes > the default? > > I wonder if we should adopt this and then remove the checks for each of the > GPU