[PATCH] D148211: [clang][tests] Fix Flang driver tests for Windows

kaadam added a comment. Bryan, thanks for the review. Is another acceptance required for merging? May I ask you to commit the change? I do not have commit access. Thanks, Adam CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148211/new/ https://reviews.llvm.org/D148211

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy marked an inline comment as done. donat.nagy added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:173 + const MemSpaceRegion *SR = rawOffset.getRegion()->getMemorySpace(); + if (SR->getKind() !=

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme marked 4 inline comments as done. mboehme added a comment. @MarcoFalke Would you be willing to review? (Thanks for your recent fix in D146288 !) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/

[clang] 946b326 - [InstSimplify] sdiv a (1 srem b) --> a

Author: Siyuan Zhu Date: 2023-04-24T14:37:07+02:00 New Revision: 946b32680311f43a349d0199f9e286f385cd9847 URL: https://github.com/llvm/llvm-project/commit/946b32680311f43a349d0199f9e286f385cd9847 DIFF: https://github.com/llvm/llvm-project/commit/946b32680311f43a349d0199f9e286f385cd9847.diff

[clang] 4475dd6 - Fix file info comment; NFC

Author: Aaron Ballman Date: 2023-04-24T08:36:27-04:00 New Revision: 4475dd62d0fcf59713791f608f8ade29bbca94ee URL: https://github.com/llvm/llvm-project/commit/4475dd62d0fcf59713791f608f8ade29bbca94ee DIFF: https://github.com/llvm/llvm-project/commit/4475dd62d0fcf59713791f608f8ade29bbca94ee.diff

[clang] 5e10cd7 - Remove known-stale projects from the open projects page

Author: Aaron Ballman Date: 2023-04-24T08:58:56-04:00 New Revision: 5e10cd78780891ee6777ff6268cd727f1785d373 URL: https://github.com/llvm/llvm-project/commit/5e10cd78780891ee6777ff6268cd727f1785d373 DIFF: https://github.com/llvm/llvm-project/commit/5e10cd78780891ee6777ff6268cd727f1785d373.diff

[PATCH] D144651: [Serialization] Place command line defines in the correct file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG524ed4b1ba51: [Serialization] Place command line defines in the correct file (authored by john.brawn). Changed prior to commit:

[clang-tools-extra] 524ed4b - [Serialization] Place command line defines in the correct file

Author: John Brawn Date: 2023-04-24T14:07:41+01:00 New Revision: 524ed4b1ba518d5dd5d67fb9593e0864b0e664a4 URL: https://github.com/llvm/llvm-project/commit/524ed4b1ba518d5dd5d67fb9593e0864b0e664a4 DIFF: https://github.com/llvm/llvm-project/commit/524ed4b1ba518d5dd5d67fb9593e0864b0e664a4.diff

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 516382. hokein marked 6 inline comments as done. hokein added a comment. - address review comments - add LSP's ChangeAnnotations support and use it in the include-cleaner batch fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 516294. eopXD marked an inline comment as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files:

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1486 + QualType getScalableVectorTupleType(QualType EltTy, unsigned NumElts, + unsigned Tuple) const; + craig.topper wrote: > Use `NF` or

[PATCH] D148263: [clang] Mark CWG2009 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a113c4c50f6: [clang] Mark CWG2009 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148263/new/ https://reviews.llvm.org/D148263

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

barannikov88 added inline comments. Comment at: clang/include/clang/Basic/Module.h:744-747 - submodule_iterator submodule_begin() { return SubModules.begin(); } - submodule_const_iterator submodule_begin() const {return SubModules.begin();} - submodule_iterator

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 516338. eopXD added a comment. Herald added a subscriber: arphaman. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files:

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD marked 2 inline comments as done. eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2723 + unsigned MaxIndex = cast(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); +

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/use-after-move.cpp:1439 // CHECK-NOTES: [[@LINE-1]]:9: note: move occurred here - // CHECK-NOTES: [[@LINE-4]]:11: note: the use happens in a later loop iteration than the move

[clang] 2bb7e00 - [Clang][Sema] Fix invalid cast when validating SVE types within CheckVariableDeclarationType.

Author: Paul Walker Date: 2023-04-24T12:45:19Z New Revision: 2bb7e00b098cdbf87b9e2e2f5ec85b661664b709 URL: https://github.com/llvm/llvm-project/commit/2bb7e00b098cdbf87b9e2e2f5ec85b661664b709 DIFF: https://github.com/llvm/llvm-project/commit/2bb7e00b098cdbf87b9e2e2f5ec85b661664b709.diff LOG:

[PATCH] D148919: [Clang][Sema] Fix invalid cast when validating SVE types within CheckVariableDeclarationType.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb7e00b098c: [Clang][Sema] Fix invalid cast when validating SVE types within… (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 516379. TIFitis marked an inline comment as done. TIFitis added a comment. Cleaned up how IsBegin argument is passed for createTargetData call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/

[PATCH] D148919: [Clang][Sema] Fix invalid cast when validating SVE types within CheckVariableDeclarationType.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. This LGTM, but I don't remember why it was written this way. (I am not an expert in this area either). It seems to still give correct error messages with/without

[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

nikic added a comment. Herald added subscribers: wlei, pcwang-thead, ormris, wenlei. Herald added a project: All. Would it be possible to cut down the Clang side tests to only check parts that Clang controls in some way, e.g. that SLPVectorizer is enabled? This test is something of a PITA

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. What's the difference between fcvt.bf16.s and fcvt.h.s? In your implementation, it seems that you just replace fcvt.h.s with fcvt.bf16.s in Zfbfmin extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. To conclude the review, please respond to the "Not Done" inline comments, and mark them "Done" if you think they are resolved. Thank you for your patience. Comment at: clang/lib/StaticAnalyzer/Checkers/DivZeroChecker.cpp:108-109 + if ((stateNotZero

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

kito-cheng added inline comments. Comment at: llvm/test/CodeGen/RISCV/O0-pipeline.ll:66-67 ; CHECK-NEXT: Stack Frame Layout Analysis +; CHECK-NEXT: RISC-V Zce move merging pass +; CHECK-NEXT: RISC-V Zce Push/Pop optimization pass ; CHECK-NEXT: RISC-V

[clang] e7e4c76 - [Pipelines] Don't run ForceFunctionAttrs post-link

Author: Nikita Popov Date: 2023-04-24T09:58:06+02:00 New Revision: e7e4c7632075fef21bc8f90ad76dc68680e3bac8 URL: https://github.com/llvm/llvm-project/commit/e7e4c7632075fef21bc8f90ad76dc68680e3bac8 DIFF: https://github.com/llvm/llvm-project/commit/e7e4c7632075fef21bc8f90ad76dc68680e3bac8.diff

[PATCH] D148904: [Pipelines] Don't run ForceFunctionAttrs post-link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7e4c7632075: [Pipelines] Dont run ForceFunctionAttrs post-link (authored by nikic). Herald added a project: clang. Herald added a subscriber:

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

eopXD updated this revision to Diff 516301. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147912/new/ https://reviews.llvm.org/D147912 Files: clang/include/clang/Basic/riscv_vector.td

[clang] 0a113c4 - [clang] Mark CWG2009 as N/A

Author: Vlad Serebrennikov Date: 2023-04-24T11:53:04+03:00 New Revision: 0a113c4c50f65a7d26d20be84bfb56562154753f URL: https://github.com/llvm/llvm-project/commit/0a113c4c50f65a7d26d20be84bfb56562154753f DIFF:

[clang] 40136ec - [clang] Make access to submodules via `iterator_range`

Author: Stoorx Date: 2023-04-24T12:05:59+03:00 New Revision: 40136ecefc0a542da7d0f1736c51325edc5539b4 URL: https://github.com/llvm/llvm-project/commit/40136ecefc0a542da7d0f1736c51325edc5539b4 DIFF: https://github.com/llvm/llvm-project/commit/40136ecefc0a542da7d0f1736c51325edc5539b4.diff LOG:

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

This revision was automatically updated to reflect the committed changes. Closed by commit rG40136ecefc0a: [clang] Make access to submodules via `iterator_range` (authored by Stoorx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148954/new/

[clang] 42d758b - [clang] Return `std::string_view` from `TargetInfo::getClobbers()`

Author: Stoorx Date: 2023-04-24T12:16:54+03:00 New Revision: 42d758bfa690d898918816509490a55bc50779df URL: https://github.com/llvm/llvm-project/commit/42d758bfa690d898918816509490a55bc50779df DIFF: https://github.com/llvm/llvm-project/commit/42d758bfa690d898918816509490a55bc50779df.diff LOG:

[PATCH] D148799: [clang] Return `std::string_view` from `TargetInfo::getClobbers()`

This revision was automatically updated to reflect the committed changes. Closed by commit rG42d758bfa690: [clang] Return `std::string_view` from `TargetInfo::getClobbers()` (authored by Stoorx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133863: [RISCV] Add MC support of RISCV zcmt Extension

kito-cheng added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:903 +return createStringError(errc::invalid_argument, + "zcmt is not allowed when c is specified"); + craig.topper wrote: > Extension names should be

[PATCH] D148355: [analyzer] Fix comparison logic in ArrayBoundCheckerV2

donat.nagy updated this revision to Diff 516365. donat.nagy marked 11 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148355/new/ https://reviews.llvm.org/D148355 Files:

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon updated this revision to Diff 516374. agozillon added a comment. - Resolve some of the reviewer comments - [Flang][OpenMP][Driver][MLIR] Add diagnostic error test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148038/new/

[PATCH] D149059: [clang][Interp] Fix zero-init of float and pointer arrays

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our Zero opcode only exists for integer types.

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 516380. dkrupp marked 10 inline comments as done. dkrupp added a comment. -append_range(..) used instead of std::vector.insert(...) to improve readability -minor updates based on @steakhal comments CHANGES SINCE LAST ACTION

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD updated this revision to Diff 516306. eopXD marked an inline comment as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 Files:

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.h:231 /// Used e.g. to break like: + /// ``` /// functionCall(Parameter, otherCall( If you want this to look like code you need to use \code \endcode CHANGES SINCE

[clang] 039c356 - Minor cleanup of the Open Projects page

Author: Aaron Ballman Date: 2023-04-24T08:27:09-04:00 New Revision: 039c356cda674530b8e16b55a83f092b2d8c35ff URL: https://github.com/llvm/llvm-project/commit/039c356cda674530b8e16b55a83f092b2d8c35ff DIFF: https://github.com/llvm/llvm-project/commit/039c356cda674530b8e16b55a83f092b2d8c35ff.diff

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon marked an inline comment as done. agozillon added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:730 +res.getLangOpts().OMPHostIRFile = arg->getValue(); +if (!llvm::sys::fs::exists(res.getLangOpts().OMPHostIRFile)) +

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:816 +/// \code +///original: +///int someFunction(int arg1, int arg2); Can you format this as we do the other documentation? Repository: rG LLVM Github

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

eopXD updated this revision to Diff 516296. eopXD added a comment. Rebase upon update of parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); + IIUC, this places properties on the current HTML

[clang] cd5c4cb - [RISCV] Add SiFive extension support

Author: Kito Cheng Date: 2023-04-24T03:12:49-07:00 New Revision: cd5c4cb7e0aea8beffe9642c9202f677fff59ca0 URL: https://github.com/llvm/llvm-project/commit/cd5c4cb7e0aea8beffe9642c9202f677fff59ca0 DIFF: https://github.com/llvm/llvm-project/commit/cd5c4cb7e0aea8beffe9642c9202f677fff59ca0.diff

[PATCH] D147935: [RISCV] Add SiFive extension support

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd5c4cb7e0ae: [RISCV] Add SiFive extension support (authored by kito-cheng, committed by 4vtomat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147935/new/

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 3 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1491 +mapTypes = exitDataOp.getMapTypes(); +mapperFunc = false; +return success();

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme updated this revision to Diff 516359. mboehme marked 2 inline comments as done. mboehme added a comment. Changes in response to review comments, and rebased to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/

[PATCH] D149001: [InstSimplify] sdiv a (1 srem b) --> a

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG946b32680311: [InstSimplify] sdiv a (1 srem b) -- a (authored by floatshadow, committed by nikic). Herald added a project: clang. Herald added a

[clang] 61fee67 - [Clang][Driver] Handle LoongArch multiarch tuples

Author: WANG Xuerui Date: 2023-04-24T15:18:59+08:00 New Revision: 61fee67cd77aedcb6f172ee0cfb0a0e5fa3c9c0d URL: https://github.com/llvm/llvm-project/commit/61fee67cd77aedcb6f172ee0cfb0a0e5fa3c9c0d DIFF: https://github.com/llvm/llvm-project/commit/61fee67cd77aedcb6f172ee0cfb0a0e5fa3c9c0d.diff

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

This revision was automatically updated to reflect the committed changes. Closed by commit rG61fee67cd77a: [Clang][Driver] Handle LoongArch multiarch tuples (authored by WANG Xuerui g...@xen0n.name, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

eopXD updated this revision to Diff 516298. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147911/new/ https://reviews.llvm.org/D147911 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

eopXD updated this revision to Diff 516302. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD updated this revision to Diff 516313. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D145262: [clang-format] Treat AttributeMacros more like attribute macros

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.h:231 /// Used e.g. to break like: + /// ``` /// functionCall(Parameter, otherCall( MyDeveloperDay wrote: > If you want this to look like code you need to use \code

[PATCH] D148961: [clang] Remove unnecessary virtual inheritance in `TargetInfo`

This revision was automatically updated to reflect the committed changes. Closed by commit rG368112e2024a: [clang] Remove unnecessary virtual inheritance in `TargetInfo` (authored by Stoorx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148961/new/

[clang] 368112e - [clang] Remove unnecessary virtual inheritance in `TargetInfo`

Author: Stoorx Date: 2023-04-24T12:14:30+03:00 New Revision: 368112e2024aabc91592cd21347968787919f044 URL: https://github.com/llvm/llvm-project/commit/368112e2024aabc91592cd21347968787919f044 DIFF: https://github.com/llvm/llvm-project/commit/368112e2024aabc91592cd21347968787919f044.diff LOG:

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 516341. eopXD added a comment. Herald added a subscriber: arphaman. Add test case for out-of-range access and guard vset correctly under SemaChecking.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme marked 4 inline comments as done. mboehme added a comment. In D145581#4290839 , @PiotrZSL wrote: > First, re-base code, looks like there were some changes in this check, and > now there are conflicts with this path. Done. (Not sure what the

[PATCH] D148612: [clang][dataflow] Use existing accessors to check for copy and move assignment ops.

mboehme updated this revision to Diff 516378. mboehme added a comment. Rebased to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148612/new/ https://reviews.llvm.org/D148612 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp Index:

[PATCH] D148110: [clang-tidy] Ctor arguments are sequenced if ctor call is written as list-initialization.

mboehme updated this revision to Diff 516390. mboehme marked 2 inline comments as done. mboehme added a comment. Changes in response to review comments, and rebased to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148110/new/

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. @steakhal thanks for the review. I fixed all outstanding remarks. I left the test taint-diagnostic-visitor.c formatting as is to remain consistent with the rest of the file. I think we should keep it as is, or reformat the whole file. Comment at:

[clang] 271a73d - [dataflow] HTMLLogger: fix off-by-one in the BB listing

Author: Sam McCall Date: 2023-04-24T15:55:21+02:00 New Revision: 271a73dae32f5eac2011a2f85351975484496262 URL: https://github.com/llvm/llvm-project/commit/271a73dae32f5eac2011a2f85351975484496262 DIFF: https://github.com/llvm/llvm-project/commit/271a73dae32f5eac2011a2f85351975484496262.diff

[PATCH] D148951: [dataflow] HTMLLogger: fix off-by-one in the BB listing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG271a73dae32f: [dataflow] HTMLLogger: fix off-by-one in the BB listing (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D149019: [Clang] Accept and forward `-fconvergent-functions` in the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGf66576016290: [Clang] Accept and forward `-fconvergent-functions` in the driver (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D149019?vs=516188=516400#toc Repository: rG

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane added a comment. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3597 + if (FD->getFriendObjectKind() == Decl::FriendObjectKind::FOK_None && + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) {

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein updated this revision to Diff 516384. hokein added a comment. some cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147684/new/ https://reviews.llvm.org/D147684 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

hokein added a comment. I have extended this patch a bit more (including the LSP `ChangeAnnotation` support part), it is based on https://reviews.llvm.org/D148783), and it implements a full workflow of batch fixes (verified it with VSCode). I hope it is not too big to review, happy to split it

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148712/new/ https://reviews.llvm.org/D148712

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin updated this revision to Diff 516388. cor3ntin added a comment. Remove duplicated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142401/new/ https://reviews.llvm.org/D142401 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak added a comment. I have been able to track down the failed `lld.wasm::stub_library.s` unit test to be due to the buildbot picking up line endings for the `lld/test/wasm/Inputs/libstub.so` to be Windows ones ("\r\n"), so the condition `if (mbref.getBuffer().starts_with("#STUB\n"))` in

[PATCH] D148612: [clang][dataflow] Use existing accessors to check for copy and move assignment ops.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b85cc18eb7b: [clang][dataflow] Use existing accessors to check for copy and move assignment… (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6b85cc1 - [clang][dataflow] Use existing accessors to check for copy and move assignment ops.

Author: Martin Braenne Date: 2023-04-24T14:32:09Z New Revision: 6b85cc18eb7be0fdc01b8586347750e65e56a4c3 URL: https://github.com/llvm/llvm-project/commit/6b85cc18eb7be0fdc01b8586347750e65e56a4c3 DIFF: https://github.com/llvm/llvm-project/commit/6b85cc18eb7be0fdc01b8586347750e65e56a4c3.diff

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

awarzynski added a comment. In D148038#4292549 , @agozillon wrote: > In D148038#4292262 , @awarzynski > wrote: > >> LGTM, thanks for addressing my comments! > > Thank you for your time and the great review

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 516452. jrmolin added a comment. pulled upstream/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

tra added a comment. lib/CodeGen changes look OK to me. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6257 + // Device code should not be at top level. + if (LangOpts.CUDA && LangOpts.CUDAIsDevice) +return; Could you give me an example of what exactly

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

ekieri abandoned this revision. ekieri added a comment. Herald added a subscriber: sunshaoce. Sorry to drop out on this. I got interrupted by other duties in life, and now I am no longer able to continue this work. If anybody wants to pick up the ball from here, please feel free to commandeer

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin updated this revision to Diff 516387. cor3ntin added a comment. Address comments, implement Aaron's clever solution, Rebase and add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142401/new/ https://reviews.llvm.org/D142401

[clang] 78086af - [Serialization] Correctly handle special files when deserializing

Author: John Brawn Date: 2023-04-24T15:35:37+01:00 New Revision: 78086af43ade0c91546a2688bb6e97906eee6c2a URL: https://github.com/llvm/llvm-project/commit/78086af43ade0c91546a2688bb6e97906eee6c2a DIFF: https://github.com/llvm/llvm-project/commit/78086af43ade0c91546a2688bb6e97906eee6c2a.diff

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

agozillon added a comment. In D148038#4292262 , @awarzynski wrote: > LGTM, thanks for addressing my comments! Thank you for your time and the great review comments as always! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] d64811f - Remove the "implement better version of existing tools" open project

Author: Aaron Ballman Date: 2023-04-24T11:56:25-04:00 New Revision: d64811f976b4305b54a5cbe0427002f5460c2d89 URL: https://github.com/llvm/llvm-project/commit/d64811f976b4305b54a5cbe0427002f5460c2d89 DIFF: https://github.com/llvm/llvm-project/commit/d64811f976b4305b54a5cbe0427002f5460c2d89.diff

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 516450. jrmolin marked an inline comment as done. jrmolin added a comment. change formatting of enum options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files:

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks for addressing my comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148038/new/ https://reviews.llvm.org/D148038

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall updated this revision to Diff 516392. sammccall marked an inline comment as done. sammccall added a comment. fix bad cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148949/new/ https://reviews.llvm.org/D148949 Files:

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.cpp:96 +for (const auto& Prop : V.properties()) + JOS.attributeObject(Prop.first(), [&] { dump(*Prop.second); }); +

[clang] f0630a3 - Add some open projects for people to consider

Author: Aaron Ballman Date: 2023-04-24T10:54:32-04:00 New Revision: f0630a37b616ec81bf65f5e36e0586a396bfb6d6 URL: https://github.com/llvm/llvm-project/commit/f0630a37b616ec81bf65f5e36e0586a396bfb6d6 DIFF: https://github.com/llvm/llvm-project/commit/f0630a37b616ec81bf65f5e36e0586a396bfb6d6.diff

[PATCH] D132819: [RISCV] Add MC support of RISCV zcmp Extension

VincentWu updated this revision to Diff 516435. VincentWu marked 2 inline comments as done. VincentWu added a comment. remove testcse of Codegen & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132819/new/ https://reviews.llvm.org/D132819

[PATCH] D145416: [clang] model 'p' inline asm constraint as reading memory

jyknight requested changes to this revision. jyknight added a comment. This revision now requires changes to proceed. I believe this is abandoned, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145416/new/ https://reviews.llvm.org/D145416

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp updated this revision to Diff 516389. dkrupp marked an inline comment as done. dkrupp added a comment. -using llvm::ArrayRef in the reportTaintBug(..) function in the DivZero Checker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144269/new/ https://reviews.llvm.org/D144269

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

mboehme added a comment. In D148110#4290400 , @carlosgalvezp wrote: > The commit message doesn't really tell me "what" this commit is fixing, it > only points to a section of the Standard. It talks about "a false positive" > but it doesn't tell what

[PATCH] D148783: [clangd] Add support TextDocumentEdit.

kadircet added a comment. In D148783#4286652 , @hokein wrote: >> can you also have a version of the >> clang-tools-extra/clangd/test/fixits-command.test with documentChanges >> support? it's unlikely to have clients in that configuration but i believe

[PATCH] D148110: [clang-tidy] bugprone-use-after-move: Ctor arguments should be sequenced if ctor call is written as list-initialization.

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:216-219 - Improved :doc:`bugprone-use-after-move - ` check to also cover constructor - initializers. + ` check: Also cover constructor + initializers. Fix check to understand that

[clang] 6e696b1 - Add some more open project for Clang

Author: Aaron Ballman Date: 2023-04-24T11:44:27-04:00 New Revision: 6e696b12b7f536400a1bac2d9cd5717b8813c94c URL: https://github.com/llvm/llvm-project/commit/6e696b12b7f536400a1bac2d9cd5717b8813c94c DIFF: https://github.com/llvm/llvm-project/commit/6e696b12b7f536400a1bac2d9cd5717b8813c94c.diff

[PATCH] D147684: [clangd] Add batch fixes for include-cleaner diagnostics

kadircet added a comment. can you also add test coverage for the new LSP fields? Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:439 + for (auto : RemoveAll.Edits) { +E.annotationId.emplace(); +*E.annotationId = RemoveAllUnusedID; nit:

[clang] 5259ff7 - Reword the open project for generating documentation

Author: Aaron Ballman Date: 2023-04-24T11:55:11-04:00 New Revision: 5259ff7f0aef9aa1871e623608d5c00d3284adb0 URL: https://github.com/llvm/llvm-project/commit/5259ff7f0aef9aa1871e623608d5c00d3284adb0 DIFF: https://github.com/llvm/llvm-project/commit/5259ff7f0aef9aa1871e623608d5c00d3284adb0.diff

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

gregrodgers abandoned this revision. gregrodgers added a comment. Its ugly, but to avoid requirement to set LD_LIBRARY_PATH for end-users who may need LD_LIBRARY_PATH for their own application, we will modify the compiler installation with these bash commands where _INSTALL_DIR is the

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5364-5368 if (const ConstantArrayType *CAT = S.getASTContext().getAsConstantArrayType(Entity.getType())) ArrayLength = CAT->getSize().getZExtValue(); else ArrayLength =

[PATCH] D148949: [dataflow] HTMLLogger - show the value of the current expr

sammccall updated this revision to Diff 516395. sammccall added a comment. use p: and f: prefixes for properties/fields respectively (we can remove these again if too annoying) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148949/new/

[PATCH] D149000: Update with warning message for comparison to NULL pointer

Krishna-13-cyber updated this revision to Diff 516397. Krishna-13-cyber added a comment. - Update with addition of testcase - There is an issue for which the build fails,actually when I replace the diagnostic by `comparison of address of 'x' not equal to a null pointer is always true` in

[PATCH] D148038: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR module attribute to proliferate to OpenMP IR lowering

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. agozillon marked an inline comment as done. Closed by commit rG2e634367be6a: [Flang][OpenMP][Driver][MLIR] Port fopenmp-host-ir-file-path flag and add MLIR… (authored

  1   2   >