[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7986 + +if (!firstArgType->isAnyPointerType()) { + QualType expectedType = Context.getPointerType(firstArgType); barannikov88 wrote: > Instead of directly checking for the

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 518285. junaire marked 3 inline comments as done. junaire added a comment. Only enable __clang_Interpreter_SetValueCopyArr support in C++ mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 518287. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D148209: Add baseline tests for D148210

junaire updated this revision to Diff 518288. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148209/new/ https://reviews.llvm.org/D148209 Files: llvm/test/Transforms/InstCombine/icmp.ll Index:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 518290. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518293. Ris-Bali added a comment. Requested changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp:55 void ignoredBuiltinsTest() { - (void)__builtin_assume_aligned(0, 8); (void)__builtin_constant_p(0); The test should not be

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3901 +case 1: + EXPECT_TRUE(HI->Type); + EXPECT_FALSE(HI->Value); Oops, this should be FALSE I think. Repository: rG LLVM

[PATCH] D148697: [clang-tidy] Handle more cases of functions which should always be noexcept

AMS21 updated this revision to Diff 518278. AMS21 marked an inline comment as done. AMS21 added a comment. Split the changes into 2 new checks and added cppcoreguidelines aliases for all of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added a comment. Thanks again for your efforts pushing this patch. It has gone a long way and I believe we are getting there. Comment at: clang/include/clang/Interpreter/Value.h:46 + +#define REPL_BUILTIN_TYPES

[PATCH] D148209: Add baseline tests for D148210

junaire updated this revision to Diff 518286. junaire added a comment. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148209/new/ https://reviews.llvm.org/D148209

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 518289. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added inline comments. Comment at: clang/test/Interpreter/pretty-print.cpp:107 +p2 +// CHECK-NEXT: (std::_MakeUniq::__single_object &) std::unique_ptr -> [[Addr:@0x.*]] + Hi @mizvekov, do you have a clue about why it doesn't print the correct type? So

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:121 +static T cast(const Value ) { + if (V.isPointerOrObjectType()) +return (T)(uintptr_t)V.getAs(); aaron.ballman wrote: > v.g.vassilev wrote: > > aaron.ballman

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518300. Ris-Bali marked 4 inline comments as done. Ris-Bali added a comment. Array test added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518277. zyounan added a comment. Do not evaluate on partial selection with children. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Thank you very much for the ideas. > (generalization) allow partial selection as long as it's of a single node - > the common ancestor is partially selected and no children are This strategy looks reasonable to me and it passes my test cases. I've updated my patch

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 518280. zyounan added a comment. Exclude the macro expands to single punctulator token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 518292. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

PiotrZSL updated this revision to Diff 518353. PiotrZSL added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148458/new/ https://reviews.llvm.org/D148458 Files:

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 518357. PiotrZSL added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148461/new/ https://reviews.llvm.org/D148461 Files:

[PATCH] D148461: [clang-tidy] Support C++17/20 in bugprone-exception-escape

PiotrZSL updated this revision to Diff 518356. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Update, added support for comparing function pointers without exception specification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

isuckatcs added a comment. Do we really want to split these two functions apart to different test files? Is this really NFC? The way `ExceptionEscapeCheck` works is that it creates an `ExceptionAnalyzer` upon instantiation. //By the way upon looking at the constructor of the check I see that

[PATCH] D148458: [clang-tidy][NFC] Split bugprone-exception-escape tests

isuckatcs added a comment. Do we really want to split these two functions apart to different test files? Is this really NFC? The way `ExceptionEscapeCheck` works is that it creates an `ExceptionAnalyzer` upon instantiation. //By the way upon looking at the constructor of the check I see that

[clang] 0a57d4d - Remove bug fix release note for a bug that was never released.

Author: Richard Smith Date: 2023-04-30T15:13:22-07:00 New Revision: 0a57d4d490a4090631e13bab17cee015fc91d4dd URL: https://github.com/llvm/llvm-project/commit/0a57d4d490a4090631e13bab17cee015fc91d4dd DIFF: https://github.com/llvm/llvm-project/commit/0a57d4d490a4090631e13bab17cee015fc91d4dd.diff

[clang] 4134f83 - [clang-format] Recognize Verilog type dimension in module header

Author: sstwcw Date: 2023-04-30T22:26:53Z New Revision: 4134f836103ebc70cc23a80c7a966d1d5f3a6353 URL: https://github.com/llvm/llvm-project/commit/4134f836103ebc70cc23a80c7a966d1d5f3a6353 DIFF: https://github.com/llvm/llvm-project/commit/4134f836103ebc70cc23a80c7a966d1d5f3a6353.diff LOG:

[clang] 82a90ca - [clang-format] Correctly format goto labels followed by blocks

Author: sstwcw Date: 2023-04-30T22:25:48Z New Revision: 82a90caa88fdc632ea2c8495ea3237065272a3a0 URL: https://github.com/llvm/llvm-project/commit/82a90caa88fdc632ea2c8495ea3237065272a3a0 DIFF: https://github.com/llvm/llvm-project/commit/82a90caa88fdc632ea2c8495ea3237065272a3a0.diff LOG:

[PATCH] D149352: [clang-format] Recognize Verilog type dimension in module header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4134f836103e: [clang-format] Recognize Verilog type dimension in module header (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D148484: [clang-format] Correctly format goto labels followed by blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82a90caa88fd: [clang-format] Correctly format goto labels followed by blocks (authored by sstwcw). Changed prior to commit:

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

rsmith added a comment. I wonder if there are any cases where the "deduction guide" is so broken that we shouldn't be creating a `CXXDeductionGuideDecl` at all. For example, if there's no trailing return type, then the declaration is syntactically invalid (and looks more like a constructor

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7982 DefaultFunctionArrayLvalueConversion(FirstArg); if (FirstArgResult.isInvalid()) return true; This check is likely also done by `checkBuiltinArgument`.

[PATCH] D149550: [clang][Interp] Fix compound assign operator evaluation order

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We need to evaluated the RHS before the LHS.

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe marked an inline comment as done. mikecrowe added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/printf-to-std-print-convert.cpp:289 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: Replace 'printf' with 'std::print'

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe updated this revision to Diff 518315. mikecrowe added a comment. I've addressed most of the review comments. The work that remains outstanding is: - Emit warnings when conversion is not possible explaining why. - Only add signed/unsigned casts when in StrictMode. - Automatically

[PATCH] D149456: Basic documentation of -mrecip=... option

tim.schmielau added a comment. Thank you Craig. Can someone with commit access please land the patch for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149456/new/ https://reviews.llvm.org/D149456

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

akyrtzi added a comment. `CodeGen` has the same issue: $ ninja tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/TargetInfo.cpp.o In file included from /llvm-project/clang/lib/CodeGen/TargetInfo.cpp:36: /llvm-project/llvm/include/llvm/TargetParser/RISCVTargetParser.h:32:10: fatal

[PATCH] D144135: [clang-tidy] Add performance-enum-size check

PiotrZSL updated this revision to Diff 518339. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144135/new/ https://reviews.llvm.org/D144135 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[clang-tools-extra] fc5f14c - [clang-tidy] Ignore declarations in bugprone-exception-escape

Author: Piotr Zegar Date: 2023-04-30T18:22:44Z New Revision: fc5f14c5fe78997fb01f9e921b0225f643171fe2 URL: https://github.com/llvm/llvm-project/commit/fc5f14c5fe78997fb01f9e921b0225f643171fe2 DIFF: https://github.com/llvm/llvm-project/commit/fc5f14c5fe78997fb01f9e921b0225f643171fe2.diff LOG:

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5f14c5fe78: [clang-tidy] Ignore declarations in bugprone-exception-escape (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144429: [clang-tidy] Add bugprone-chained-comparison check

PiotrZSL updated this revision to Diff 518342. PiotrZSL added a comment. Ping, Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144429/new/ https://reviews.llvm.org/D144429 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

Mordante added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:46 - if (lang_opts.CPlusPlus2b) { attributes.emplace_back("assume"); philnik wrote: > You probably want to `#ifdef` this based on Clang 16/17. Yeah I

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 518341. koops added a comment. 1. Taken care of some of the comments by Alexey. 2. Added extra tests of loop_bind_messages.cpp However, generic_loop_messages.cpp & generic_loop_ast_print.cpp are present and provide a good coverage. CHANGES SINCE LAST ACTION

[clang] 5a9abe8 - [clang-repl] Correctly disambiguate dtor declarations from statements.

Author: Vassil Vassilev Date: 2023-04-30T19:44:52Z New Revision: 5a9abe846617efea4a128134db0915a044d7dd73 URL: https://github.com/llvm/llvm-project/commit/5a9abe846617efea4a128134db0915a044d7dd73 DIFF: https://github.com/llvm/llvm-project/commit/5a9abe846617efea4a128134db0915a044d7dd73.diff

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9abe846617: [clang-repl] Correctly disambiguate dtor declarations from statements. (authored by v.g.vassilev). Herald

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev added a comment. Let's rely on a post-commit review here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148425/new/ https://reviews.llvm.org/D148425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 518347. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali updated this revision to Diff 518348. Ris-Bali added a comment. Removed redundant code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaChecking.cpp

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > bolshakov-a wrote: > > bolshakov-a wrote: > > > efriedma

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/printf-to-std-print-convert.cpp:289 + // CHECK-MESSAGES: [[@LINE-1]]:3: warning: Replace 'printf' with 'std::print' [modernize-printf-to-std-print] + // CHECK-FIXES:

[PATCH] D93031: Enable fexec-charset option

barannikov88 added a comment. @abhina.sreeskantharajan What is the status of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D93031 ___ cfe-commits mailing

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

philnik added inline comments. Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:46 - if (lang_opts.CPlusPlus2b) { attributes.emplace_back("assume"); You probably want to `#ifdef` this based on Clang 16/17. Repository: rG LLVM

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

v.g.vassilev added a comment. This looks reasonable to me. Is there a way we could check when `+relax` start working to remember to re-add this feature? Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:46 auto JTMB = JITTargetMachineBuilder(TI.getTriple()); -

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe marked 4 inline comments as done. mikecrowe added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize/printf-to-std-print.rst:61 +- any arguments where the format string and the parameter differ in + signedness will be wrapped in an

[PATCH] D149551: [Interpreter] Filter out RISC-V +relax feature

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, sgraenitz, lhames, StephenFan. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardson. Herald added a project: All. Hahnfeld

[PATCH] D149561: [clang-format] Recognize Verilog edge identifiers

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Previously the event expression would be misidentified as a

[PATCH] D149562: [clang-format] Stop comment disrupting indentation of Verilog ports

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Before: module x #( // parameter x)

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 518373. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index:

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 518375. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index:

[PATCH] D149456: Basic documentation of -mrecip=... option

This revision was automatically updated to reflect the committed changes. Closed by commit rG85ed0fb5037b: Basic documentation of -mrecip=... option (authored by tim.schmielau, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 85ed0fb - Basic documentation of -mrecip=... option

Author: Tim Schmielau Date: 2023-05-01T07:43:00+05:30 New Revision: 85ed0fb5037b7b261b9e5dd8c35fc71830f46b55 URL: https://github.com/llvm/llvm-project/commit/85ed0fb5037b7b261b9e5dd8c35fc71830f46b55 DIFF: https://github.com/llvm/llvm-project/commit/85ed0fb5037b7b261b9e5dd8c35fc71830f46b55.diff

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl updated this revision to Diff 518391. yaxunl retitled this revision from "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE_OPTION`" to "[AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers:

[PATCH] D149165: [clangd] Deduplicate missing-include findings

ArturGainullin added a comment. Hello! After this change IncludeCleaner.GenerateMissingHeaderDiags unit test from ClangdTests.exe is failing on Windows for Debug build. Could you please take a look. It looks like error appears because comparator doesn't satisfy strict weak ordering. I.e. it

[PATCH] D145343: [AMDGPU] Emit predefined macro `__AMDGCN_CUMODE`

yaxunl added a comment. In D145343#4172643 , @tra wrote: > Can `__has_feature` be used to accomplish what you need? There are a few issues using `__has_feature` or similar builtin macros to check target feature, which has been discussed in

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 updated this revision to Diff 518403. HerrCai0907 marked an inline comment as done. HerrCai0907 added a comment. refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 Files:

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 marked 2 inline comments as done. HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11196 if (D.isFunctionDefinition()) Diag(D.getIdentifierLoc(), diag::err_deduction_guide_defines_function); + return IsValid;